)]}'
{"tempest_lib/cli/base.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3a4eadca1d4e6bf08e1b8989e2384b68882e2d98","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.tenant_name \u003d tenant_name"},{"line_number":100,"context_line":"        self.password \u003d password"},{"line_number":101,"context_line":"        self.uri \u003d uri"},{"line_number":102,"context_line":"        self.insecure \u003d insecure"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def nova(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, fail_ok\u003dFalse,"},{"line_number":105,"context_line":"             endpoint_type\u003d\u0027publicURL\u0027, merge_stderr\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_23a4cb55","line":102,"updated":"2015-11-24 18:06:13.000000000","message":"I wonder, why we add this? I thought we could pass this flag via \"flags\" parameter. Each method for a certain service client has such parameter. For example, take a look at L104. Maybe I am missing something?","commit_id":"2fef45e3019e9770684d4b2880084096577353e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3921b0095e5cef291eb3f30da0ce1578dfe74e8d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.tenant_name \u003d tenant_name"},{"line_number":100,"context_line":"        self.password \u003d password"},{"line_number":101,"context_line":"        self.uri \u003d uri"},{"line_number":102,"context_line":"        self.insecure \u003d insecure"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def nova(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, fail_ok\u003dFalse,"},{"line_number":105,"context_line":"             endpoint_type\u003d\u0027publicURL\u0027, merge_stderr\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_847d26e9","line":102,"in_reply_to":"9a8ffd7b_23a4cb55","updated":"2015-11-26 05:24:27.000000000","message":"Yea, I also feel the same.\n\nThis way it enforce this flag for all CLI methods like nova, cinder etc.\n\ninsecure flag can be passed as other flags are passed like --api version, --debug etc\nexample-  https://github.com/openstack/python-novaclient/blob/62b1379cf856f1931aaa7195669f0222186d3a16/novaclient/tests/functional/base.py#L178-L179","commit_id":"2fef45e3019e9770684d4b2880084096577353e5"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"020f05aa27774b6e80f723aaf14f9acfb10d6957","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.tenant_name \u003d tenant_name"},{"line_number":100,"context_line":"        self.password \u003d password"},{"line_number":101,"context_line":"        self.uri \u003d uri"},{"line_number":102,"context_line":"        self.insecure \u003d insecure"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def nova(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, fail_ok\u003dFalse,"},{"line_number":105,"context_line":"             endpoint_type\u003d\u0027publicURL\u0027, merge_stderr\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_ef7deb1c","line":102,"in_reply_to":"9a8ffd7b_847d26e9","updated":"2015-11-26 05:56:10.000000000","message":"I would argue that the insecure flag is a basic and common flag, like the auth bits. The example above is showing a flag specific to one client.","commit_id":"2fef45e3019e9770684d4b2880084096577353e5"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"86e31d1e322e1d11567c46a51d4203bcf37a789a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.tenant_name \u003d tenant_name"},{"line_number":100,"context_line":"        self.password \u003d password"},{"line_number":101,"context_line":"        self.uri \u003d uri"},{"line_number":102,"context_line":"        self.insecure \u003d insecure"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def nova(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, fail_ok\u003dFalse,"},{"line_number":105,"context_line":"             endpoint_type\u003d\u0027publicURL\u0027, merge_stderr\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_2f8453d2","line":102,"in_reply_to":"9a8ffd7b_ef7deb1c","updated":"2015-11-26 06:01:34.000000000","message":"Also, this requires changing all calls to get a client. While doable, I\u0027m pretty sure people will forget to add the flag from time to time when writing new code.\n\nFor an example of how this would be used in novaclient: https://github.com/vuntz/python-novaclient/commit/8dec572fd615577798de2e5774c053f01c6c2e77","commit_id":"2fef45e3019e9770684d4b2880084096577353e5"}]}
