)]}'
{"tempest_lib/common/api_version_utils.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e98fa3bb723db001ac66ac60bd3859f3f623f355","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    # for all microversions. We need to define microversion range"},{"line_number":28,"context_line":"    # (min_microversion, max_microversion) on each test class if necessary."},{"line_number":29,"context_line":"    min_microversion \u003d None"},{"line_number":30,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def check_skip_with_microversion(test_min_version, test_max_version,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_20e85f7c","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":31},"updated":"2016-02-14 15:03:55.000000000","message":"How about defining this as LATEST_MICROVERSION and using it at the other places?","commit_id":"273a7b75ee75f018014eec576b6f703cade5353a"}],"tempest_lib/services/compute/base_compute_client.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"39ec3b162740d37d0f286cb46b11fd3bb7f66747","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class BaseComputeClient(base_microversion_client.BaseMicroversionClient):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":24,"context_line":"                 api_microversion_header_name\u003d\u0027X-OpenStack-Nova-API-Version\u0027,"},{"line_number":25,"context_line":"                 **kwargs):"},{"line_number":26,"context_line":"        super(BaseComputeClient, self).__init__("},{"line_number":27,"context_line":"            auth_provider, service, region,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_2823f506","line":24,"updated":"2016-02-11 13:14:58.000000000","message":"there is no reason for this to be configurable, this should be a constant.","commit_id":"273a7b75ee75f018014eec576b6f703cade5353a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e98fa3bb723db001ac66ac60bd3859f3f623f355","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class BaseComputeClient(base_microversion_client.BaseMicroversionClient):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":24,"context_line":"                 api_microversion_header_name\u003d\u0027X-OpenStack-Nova-API-Version\u0027,"},{"line_number":25,"context_line":"                 **kwargs):"},{"line_number":26,"context_line":"        super(BaseComputeClient, self).__init__("},{"line_number":27,"context_line":"            auth_provider, service, region,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_80e20b9e","line":24,"in_reply_to":"3a57f1b5_2823f506","updated":"2016-02-14 15:03:55.000000000","message":"nice point, I agree with that.","commit_id":"273a7b75ee75f018014eec576b6f703cade5353a"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"39ec3b162740d37d0f286cb46b11fd3bb7f66747","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                body\u003dNone):"},{"line_number":32,"context_line":"        resp, resp_body \u003d super(BaseComputeClient, self).request("},{"line_number":33,"context_line":"            method, url, extra_headers, headers, body)"},{"line_number":34,"context_line":"        if self.api_microversion and self.api_microversion !\u003d \u0027latest\u0027:"},{"line_number":35,"context_line":"            api_version_utils.assert_version_header_matches_request("},{"line_number":36,"context_line":"                self.api_microversion_header_name,"},{"line_number":37,"context_line":"                self.api_microversion,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_c84fc1bb","line":34,"updated":"2016-02-11 13:14:58.000000000","message":"I really really don\u0027t like this as instance variables, because it shouldn\u0027t be. That\u0027s something that has to be passed around for not really good reason.","commit_id":"273a7b75ee75f018014eec576b6f703cade5353a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e98fa3bb723db001ac66ac60bd3859f3f623f355","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                body\u003dNone):"},{"line_number":32,"context_line":"        resp, resp_body \u003d super(BaseComputeClient, self).request("},{"line_number":33,"context_line":"            method, url, extra_headers, headers, body)"},{"line_number":34,"context_line":"        if self.api_microversion and self.api_microversion !\u003d \u0027latest\u0027:"},{"line_number":35,"context_line":"            api_version_utils.assert_version_header_matches_request("},{"line_number":36,"context_line":"                self.api_microversion_header_name,"},{"line_number":37,"context_line":"                self.api_microversion,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_00ed5b8b","line":34,"in_reply_to":"3a57f1b5_c84fc1bb","updated":"2016-02-14 15:03:55.000000000","message":"How about using the definition instead of \"latest\" as I said at the other place?","commit_id":"273a7b75ee75f018014eec576b6f703cade5353a"}]}