)]}'
{"tempest/api/volume/test_volumes_list.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c50c861f0edabfc11bd90d3d00e8aef0e75d7090","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # In v1, list view and list detail view are same. So the"},{"line_number":96,"context_line":"        # following check should be run when \u0027with_detail\u0027 is True"},{"line_number":97,"context_line":"        # or v1 tests."},{"line_number":98,"context_line":"        if with_detail or self.name \u003d\u003d \u0027display_name\u0027:"},{"line_number":99,"context_line":"            for volume in fetched_vol_list:"},{"line_number":100,"context_line":"                for key in params:"},{"line_number":101,"context_line":"                    msg \u003d \"Failed to list volumes %s by %s\" % \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_fc969c3d","line":98,"updated":"2014-06-24 04:26:54.000000000","message":"One suggestion- instead checking the self.name, it would be better to check for _api_version. which gives more readability for test.","commit_id":"2314cadbd3a8d2ced1c203acfa2e96a75f6b4310"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e6b124d33c5ad90d70580f37a021afad0ecda3fe","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # In v1, list view and list detail view are same. So the"},{"line_number":96,"context_line":"        # following check should be run when \u0027with_detail\u0027 is True"},{"line_number":97,"context_line":"        # or v1 tests."},{"line_number":98,"context_line":"        if with_detail or self.name \u003d\u003d \u0027display_name\u0027:"},{"line_number":99,"context_line":"            for volume in fetched_vol_list:"},{"line_number":100,"context_line":"                for key in params:"},{"line_number":101,"context_line":"                    msg \u003d \"Failed to list volumes %s by %s\" % \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_7755471d","line":98,"in_reply_to":"1ae5cdf2_fc969c3d","updated":"2014-06-24 05:55:56.000000000","message":"good suggestion! Thanks!","commit_id":"2314cadbd3a8d2ced1c203acfa2e96a75f6b4310"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"aad887262ee7f5f1137352215b0fe47666b08973","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class VolumesListTestJSON(base.BaseVolumeTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    This test creates a number of 1G volumes. To run successfully,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_7438e03d","line":27,"updated":"2014-06-24 08:00:30.000000000","message":"I think this test class is for v2 now, and the class name should represent v2 test clearly.\n\nso how about rename this to VolumesV2ListTestJSON?","commit_id":"c18726f085ff6394dcb966fee29f3caed565ce9a"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"944fe43d57463ec083a66c98e1befcf243c9d358","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class VolumesListTestJSON(base.BaseVolumeTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    This test creates a number of 1G volumes. To run successfully,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_657f4c67","line":27,"in_reply_to":"1ae5cdf2_7438e03d","updated":"2014-06-24 09:02:07.000000000","message":"yep,  VolumesV2ListTestJSON is better. Thanks!","commit_id":"c18726f085ff6394dcb966fee29f3caed565ce9a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"aad887262ee7f5f1137352215b0fe47666b08973","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        self._list_by_param_value_and_assert(params, with_detail\u003dTrue)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class VolumesListTestXML(VolumesListTestJSON):"},{"line_number":218,"context_line":"    _interface \u003d \u0027xml\u0027"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_347c98eb","line":217,"updated":"2014-06-24 08:00:30.000000000","message":"ditto: how about renaming here also to  VolumesV2ListTestXML","commit_id":"c18726f085ff6394dcb966fee29f3caed565ce9a"}]}