)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1b3423fa5bcfdc17c187998f94f2e2f132785d1e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"It also implements following optional argument -"},{"line_number":13,"context_line":"1. --verbose"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Addtionally it also adds output verification of some tests."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements: blueprint missing-cli-tests-in-tempest"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_be491f90","line":15,"updated":"2014-06-18 07:54:34.000000000","message":"Addtionally it also adds output verification to test_heat_stack_list and test_heat_version","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"82b3b1553002473a4e5f07c30e1a3392401cc4cd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"It also implements following optional argument -"},{"line_number":13,"context_line":"1. --verbose"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Addtionally it also adds output verification of some tests."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements: blueprint missing-cli-tests-in-tempest"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_d5eb2910","line":15,"in_reply_to":"1ae5cdf2_be491f90","updated":"2014-06-18 08:37:00.000000000","message":"Will be done in next patch","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"}],"tempest/cli/__init__.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1b3423fa5bcfdc17c187998f94f2e2f132785d1e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            \u0027ceilometer\u0027, action, flags, params, admin, fail_ok)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def heat(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, admin\u003dTrue,"},{"line_number":74,"context_line":"             fail_ok\u003dFalse, merge_stderr\u003dTrue):"},{"line_number":75,"context_line":"        \"\"\"Executes heat command for the given action.\"\"\""},{"line_number":76,"context_line":"        flags +\u003d \u0027 --os-endpoint-type %s\u0027 % CONF.orchestration.endpoint_type"},{"line_number":77,"context_line":"        return self.cmd_with_auth("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_1ed4d3bb","line":74,"updated":"2014-06-18 07:54:34.000000000","message":"Why do you add  the argument \u0027merge_stderr\u0027 in the method ?The value is always True. Nobody else calls this method with a different value for merge_stderr","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"82b3b1553002473a4e5f07c30e1a3392401cc4cd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            \u0027ceilometer\u0027, action, flags, params, admin, fail_ok)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def heat(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, admin\u003dTrue,"},{"line_number":74,"context_line":"             fail_ok\u003dFalse, merge_stderr\u003dTrue):"},{"line_number":75,"context_line":"        \"\"\"Executes heat command for the given action.\"\"\""},{"line_number":76,"context_line":"        flags +\u003d \u0027 --os-endpoint-type %s\u0027 % CONF.orchestration.endpoint_type"},{"line_number":77,"context_line":"        return self.cmd_with_auth("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9599a17b","line":74,"in_reply_to":"1ae5cdf2_1ed4d3bb","updated":"2014-06-18 08:37:00.000000000","message":"if someone want to call heat with diffrent value of merge_error, then he/she can can call it in testcase file with merge_stderr\u003dFalse\n\nlike self.heat(\u0027stack-list\u0027, merge_error\u003dFalse)","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1b3423fa5bcfdc17c187998f94f2e2f132785d1e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \"\"\"Executes heat command for the given action.\"\"\""},{"line_number":76,"context_line":"        flags +\u003d \u0027 --os-endpoint-type %s\u0027 % CONF.orchestration.endpoint_type"},{"line_number":77,"context_line":"        return self.cmd_with_auth("},{"line_number":78,"context_line":"            \u0027heat\u0027, action, flags, params, admin, fail_ok, merge_stderr)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def cinder(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, admin\u003dTrue, fail_ok\u003dFalse):"},{"line_number":81,"context_line":"        \"\"\"Executes cinder command for the given action.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9edf03d6","line":78,"updated":"2014-06-18 07:54:34.000000000","message":"You may want to do :\n\"\u0027heat\u0027, action, flags, params, admin, fail_ok, merge_stderr\u003dTrue)\"","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"82b3b1553002473a4e5f07c30e1a3392401cc4cd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \"\"\"Executes heat command for the given action.\"\"\""},{"line_number":76,"context_line":"        flags +\u003d \u0027 --os-endpoint-type %s\u0027 % CONF.orchestration.endpoint_type"},{"line_number":77,"context_line":"        return self.cmd_with_auth("},{"line_number":78,"context_line":"            \u0027heat\u0027, action, flags, params, admin, fail_ok, merge_stderr)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def cinder(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, admin\u003dTrue, fail_ok\u003dFalse):"},{"line_number":81,"context_line":"        \"\"\"Executes cinder command for the given action.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f5c905ad","line":78,"in_reply_to":"1ae5cdf2_9edf03d6","updated":"2014-06-18 08:37:00.000000000","message":"No it seems no good to me.\n\nIf def heat(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, admin\u003dTrue, fail_ok) is being used and as you say in previous comment,\n\nthen return self.cmd_with_auth(\u0027heat\u0027, action, flags, params, admin, fail_ok, merge_stderr\u003dTrue) will no more remaining testcase dependent.\n\nand for all tests it will set to True. In future if you want to put some test cases with merge_error value as False, then it cannot be done.","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"bc24a5cb275873584d21c24af3923425ff0e9ae1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            \u0027ceilometer\u0027, action, flags, params, admin, fail_ok)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def heat(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, admin\u003dTrue,"},{"line_number":74,"context_line":"             fail_ok\u003dFalse, merge_stderr\u003dTrue):"},{"line_number":75,"context_line":"        \"\"\"Executes heat command for the given action.\"\"\""},{"line_number":76,"context_line":"        flags +\u003d \u0027 --os-endpoint-type %s\u0027 % CONF.orchestration.endpoint_type"},{"line_number":77,"context_line":"        return self.cmd_with_auth("}],"source_content_type":"text/x-python","patch_set":3,"id":"dab895d6_454a6d84","line":74,"range":{"start_line":74,"start_character":28,"end_line":74,"end_character":41},"updated":"2014-06-29 19:58:33.000000000","message":"Why do you need this to be true by default for heat?\nThis is required only required by the --version test I believe.","commit_id":"7b822b15397851ffa0cf7984e77e8188c2960eb0"}],"tempest/cli/simple_read_only/test_heat.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"db48c4bdd381961c41ae402fb288fa711c8a90cd","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_heat_build_info(self):"},{"line_number":101,"context_line":"        result \u003d self.heat(\u0027build-info\u0027)"},{"line_number":102,"context_line":"        build_info \u003d self.parser.listing(result)"},{"line_number":103,"context_line":"        self.assertTableStruct(build_info, [\u0027Property\u0027, \u0027Value\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b4f244e1","line":102,"updated":"2014-06-17 16:57:45.000000000","message":"Can you move this above the heat_version.  In other CLI tests we separate the flags from the commands.","commit_id":"04b4b1730dacaa152c3bcd2a62be73f43e1c4ef4"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"7f060da5bfe46eb4de18119695914d9db23597da","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_heat_build_info(self):"},{"line_number":101,"context_line":"        result \u003d self.heat(\u0027build-info\u0027)"},{"line_number":102,"context_line":"        build_info \u003d self.parser.listing(result)"},{"line_number":103,"context_line":"        self.assertTableStruct(build_info, [\u0027Property\u0027, \u0027Value\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5212d458","line":102,"in_reply_to":"1ae5cdf2_b4f244e1","updated":"2014-06-18 04:57:43.000000000","message":"Done","commit_id":"04b4b1730dacaa152c3bcd2a62be73f43e1c4ef4"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1b3423fa5bcfdc17c187998f94f2e2f132785d1e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        version \u003d self.heat(\u0027\u0027, flags\u003d\u0027--version\u0027)"},{"line_number":105,"context_line":"        self.assertTrue(re.search(\u0027^[0-9.]+\u0027, version))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_heat_debug(self):"},{"line_number":108,"context_line":"        self.heat(\u0027stack-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_heat_verbose(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_1e01336a","line":107,"updated":"2014-06-18 07:54:34.000000000","message":"I\u0027d rather you don\u0027t change the test name. Originaly, it was test_heat_stack_list_debug","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"82b3b1553002473a4e5f07c30e1a3392401cc4cd","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        version \u003d self.heat(\u0027\u0027, flags\u003d\u0027--version\u0027)"},{"line_number":105,"context_line":"        self.assertTrue(re.search(\u0027^[0-9.]+\u0027, version))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_heat_debug(self):"},{"line_number":108,"context_line":"        self.heat(\u0027stack-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_heat_verbose(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_1501116a","line":107,"in_reply_to":"1ae5cdf2_1e01336a","updated":"2014-06-18 08:37:00.000000000","message":"Will be done in next patch","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1b3423fa5bcfdc17c187998f94f2e2f132785d1e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test_heat_debug(self):"},{"line_number":108,"context_line":"        self.heat(\u0027stack-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_heat_verbose(self):"},{"line_number":111,"context_line":"        result \u003d self.parser.listing(self.heat(\u0027stack-list\u0027,"},{"line_number":112,"context_line":"                                               flags\u003d\u0027--verbose\u0027))"},{"line_number":113,"context_line":"        self.assertTableStruct(result, [\u0027id\u0027, \u0027stack_name\u0027, \u0027stack_status\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_5e39fb3d","line":110,"updated":"2014-06-18 07:54:34.000000000","message":"I think this test should be named test_heat_stack_list_verbose","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"82b3b1553002473a4e5f07c30e1a3392401cc4cd","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test_heat_debug(self):"},{"line_number":108,"context_line":"        self.heat(\u0027stack-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_heat_verbose(self):"},{"line_number":111,"context_line":"        result \u003d self.parser.listing(self.heat(\u0027stack-list\u0027,"},{"line_number":112,"context_line":"                                               flags\u003d\u0027--verbose\u0027))"},{"line_number":113,"context_line":"        self.assertTableStruct(result, [\u0027id\u0027, \u0027stack_name\u0027, \u0027stack_status\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_35f7ed8d","line":110,"in_reply_to":"1ae5cdf2_5e39fb3d","updated":"2014-06-18 08:37:00.000000000","message":"ditto","commit_id":"7e9b8be5f1a58c970cbec9da40f73f78bd3fa386"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b13d29e635d39646dc5cf5b568bd03170571619f","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_heat_build_info(self):"},{"line_number":86,"context_line":"        result \u003d self.heat(\u0027build-info\u0027)"},{"line_number":87,"context_line":"        build_info \u003d self.parser.listing(result)"},{"line_number":88,"context_line":"        self.assertTableStruct(build_info, [\u0027Property\u0027, \u0027Value\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_heat_help(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab895d6_fb05e214","line":87,"updated":"2014-06-30 01:46:48.000000000","message":"Above two line can be merged in one as done in other test.","commit_id":"7b822b15397851ffa0cf7984e77e8188c2960eb0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b13d29e635d39646dc5cf5b568bd03170571619f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.assertTrue(re.search(\u0027^[0-9.]+\u0027, version))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_heat_stack_list_debug(self):"},{"line_number":108,"context_line":"        self.heat(\u0027stack-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_heat_stack_list_verbose(self):"},{"line_number":111,"context_line":"        result \u003d self.parser.listing(self.heat(\u0027stack-list\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab895d6_9b178651","line":108,"updated":"2014-06-30 01:46:48.000000000","message":"Do not we need output verification here?","commit_id":"7b822b15397851ffa0cf7984e77e8188c2960eb0"}]}