)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"f264e97a6deaec97f4f2d8e7f7a13889228abaf1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     raiesmh08 \u003cmh.raies@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-16 15:30:46 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Missing Ceilometer CLI tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds following missing Ceilometer CLI tests -"},{"line_number":10,"context_line":"1. help"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_b91ebd72","line":7,"updated":"2014-06-17 16:54:47.000000000","message":"At this point this isn\u0027t an accurate summary of what this patch does.\n\nIt is more of \"improve ceilometer CLI tests\"","commit_id":"46bb20e3c929caad111cd1f6c1a276a180b8b98f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"af081ee61ecf7b7fcf8f3edcd7a058e65d00e49d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     raiesmh08 \u003cmh.raies@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-16 15:30:46 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Missing Ceilometer CLI tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds following missing Ceilometer CLI tests -"},{"line_number":10,"context_line":"1. help"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_3d951988","line":7,"in_reply_to":"1ae5cdf2_72d7d04f","updated":"2014-06-18 05:47:49.000000000","message":"Also \u0027Missing Ceilometer CLI tests\u0027 doesn\u0027t really explain what the patch is doing, perhaps \u0027add missing ...\u0027 etc.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages\n\nIn GIT commits the first line of the commit message has special significance. It is used as email subject line, git annotate messages, gitk viewer annotations, merge commit messages and many more places where space is at a premium. As well as summarizing the change itself, it should take care to detail what part of the code is affected. eg if it affects the libvirt driver, mention \u0027libvirt\u0027 somewhere in the first line.","commit_id":"46bb20e3c929caad111cd1f6c1a276a180b8b98f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"8b0e63e1973dad7ccce361b79ce76d27b1ad5703","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     raiesmh08 \u003cmh.raies@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-16 15:30:46 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Missing Ceilometer CLI tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds following missing Ceilometer CLI tests -"},{"line_number":10,"context_line":"1. help"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_72d7d04f","line":7,"in_reply_to":"1ae5cdf2_b91ebd72","updated":"2014-06-18 05:03:51.000000000","message":"In this case, I have added 3 missing tests as mentioned in commit message.\nAs this patch is also for improvement of some tests - \"It also modifies existing code to check outputs of different tests.\"\n\nI think commit message should not be modified more as it covers both addition as well as modification of some tests.","commit_id":"46bb20e3c929caad111cd1f6c1a276a180b8b98f"}],"tempest/cli/simple_read_only/test_ceilometer.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"f264e97a6deaec97f4f2d8e7f7a13889228abaf1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        commands \u003d set(commands)"},{"line_number":77,"context_line":"        wanted_commands \u003d set((\u0027alarm-combination-create\u0027, \u0027alarm-create\u0027,"},{"line_number":78,"context_line":"                               \u0027help\u0027, \u0027alarm-delete\u0027, \u0027event-list\u0027))"},{"line_number":79,"context_line":"        self.assertFalse(wanted_commands - commands)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_ceilometer_bash_completion(self):"},{"line_number":82,"context_line":"        self.ceilometer(\u0027bash-completion\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_943f08b5","line":79,"updated":"2014-06-17 16:54:47.000000000","message":"assertFalse seems like a strange choice here. What are you trying to check?","commit_id":"46bb20e3c929caad111cd1f6c1a276a180b8b98f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"8b0e63e1973dad7ccce361b79ce76d27b1ad5703","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        commands \u003d set(commands)"},{"line_number":77,"context_line":"        wanted_commands \u003d set((\u0027alarm-combination-create\u0027, \u0027alarm-create\u0027,"},{"line_number":78,"context_line":"                               \u0027help\u0027, \u0027alarm-delete\u0027, \u0027event-list\u0027))"},{"line_number":79,"context_line":"        self.assertFalse(wanted_commands - commands)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_ceilometer_bash_completion(self):"},{"line_number":82,"context_line":"        self.ceilometer(\u0027bash-completion\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_b2b3184c","line":79,"in_reply_to":"1ae5cdf2_943f08b5","updated":"2014-06-18 05:03:51.000000000","message":"I didn\u0027t get why you ask it strange ??\nAll other test with help test are also using same method.","commit_id":"46bb20e3c929caad111cd1f6c1a276a180b8b98f"}]}
