)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4699e1bd8051e6ee19bb33ca589c5d9ef11f860a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        super(BaseVolumeTest, cls).tearDownClass()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @classmethod"},{"line_number":83,"context_line":"    def create_volume(cls, size\u003d1, vol_name\u003dNone, vol_describ\u003dNone, **kwargs):"},{"line_number":84,"context_line":"        \"\"\"Wrapper utility that returns a test volume.\"\"\""},{"line_number":85,"context_line":"        if vol_name is None:"},{"line_number":86,"context_line":"            vol_name \u003d data_utils.rand_name(\u0027Volume\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_b8944e45","line":83,"updated":"2014-06-30 19:44:43.000000000","message":"It\u0027s ok to add new parameters to clarify that this method will take care of the name conversion in case of API.\nOr you could keep them in kwargs, and translate them when necessary. In any case a docstring would be helpful.\n\nHowever if go for the additional parameters, you may want to check that they are not passed in kwargs as well.\n\nI would add two helper methods so you can use them also in the tests:\n    name_field(api_version)\n    display_field(api_version)\n\nSo your code becomes:\n\nkwargs[name_field(cls._api_version)] \u003d vol_name or rand(...\nkwargs[display_field(cls._api_version)] \u003d vol_description or rand(...\nresp, volume \u003d cls.volumes_client.create_volume(size, **kwargs)\n\nif cls._api_version \u003d\u003d 1:\n    assert ...\nelif cls._api_version \u003d\u003d 2:\n    assert ...\n\nCould you call the extra params \"name\" and \"description\" instead, or vol_name and vol_description.","commit_id":"e1fb3e3a66522b4b800c821e7e7433f8fe487cd9"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e606f0af3021ad2cfa39da8070348036da76a3ae","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        super(BaseVolumeTest, cls).tearDownClass()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @classmethod"},{"line_number":83,"context_line":"    def create_volume(cls, size\u003d1, vol_name\u003dNone, vol_describ\u003dNone, **kwargs):"},{"line_number":84,"context_line":"        \"\"\"Wrapper utility that returns a test volume.\"\"\""},{"line_number":85,"context_line":"        if vol_name is None:"},{"line_number":86,"context_line":"            vol_name \u003d data_utils.rand_name(\u0027Volume\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_f5d132fc","line":83,"in_reply_to":"baada198_b8944e45","updated":"2014-07-02 06:21:21.000000000","message":"@Andrea, nice idea. I\u0027ll implement your suggestion in next patch. \n\nThanks!","commit_id":"e1fb3e3a66522b4b800c821e7e7433f8fe487cd9"}],"tempest/api/volume/test_volume_metadata.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fd8065b1aeae4823a5f74464c167f64ce24171eb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest import test"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumeMetadataTest(base.BaseVolumeTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    @test.safe_setup"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_f771520d","line":22,"updated":"2014-06-24 08:31:46.000000000","message":"Could you consider changing the class name to VolumeV2MetadataTest?\n\nWhen we face the problem at the gate, the class name will help us to understand which API is problem.","commit_id":"003eaa018ce85b1e4cc884c533eae2253f4a8790"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"2af3bd6e10b1702612d2ab9ead6fc5f68fe6220b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest import test"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumeMetadataTest(base.BaseVolumeTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    @test.safe_setup"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_85c1b883","line":22,"in_reply_to":"1ae5cdf2_f771520d","updated":"2014-06-24 09:46:48.000000000","message":"It\u0027s reasonable to use \u0027V2\u0027 in the name. I\u0027ll fix it in next patch. Thanks!","commit_id":"003eaa018ce85b1e4cc884c533eae2253f4a8790"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fd8065b1aeae4823a5f74464c167f64ce24171eb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.assertThat(body.items(), matchers.ContainsAll(expect.items()))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class VolumeMetadataTestXML(VolumeMetadataTest):"},{"line_number":120,"context_line":"    _interface \u003d \"xml\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_175ebe79","line":119,"updated":"2014-06-24 08:31:46.000000000","message":"ditto","commit_id":"003eaa018ce85b1e4cc884c533eae2253f4a8790"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4699e1bd8051e6ee19bb33ca589c5d9ef11f860a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumesV2MetadataTest(base.BaseVolumeTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    @test.safe_setup"},{"line_number":26,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_b8f7ee8b","line":23,"updated":"2014-06-30 19:44:43.000000000","message":"I find everything _interface and api_version set more readable, even when it\u0027s not strictly required to set them.","commit_id":"e1fb3e3a66522b4b800c821e7e7433f8fe487cd9"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e606f0af3021ad2cfa39da8070348036da76a3ae","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumesV2MetadataTest(base.BaseVolumeTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    @test.safe_setup"},{"line_number":26,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_752c4203","line":23,"in_reply_to":"baada198_b8f7ee8b","updated":"2014-07-02 06:21:21.000000000","message":"_interface and _api_version has default value in base.BaseVolumeTest.  I think it\u0027s fine to ignore the default values here to avoid redundant code.","commit_id":"e1fb3e3a66522b4b800c821e7e7433f8fe487cd9"}],"tempest/api/volume/test_volumes_get.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4699e1bd8051e6ee19bb33ca589c5d9ef11f860a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumesV2GetTest(base.BaseVolumeTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _name \u003d \u0027name\u0027"},{"line_number":29,"context_line":"    _description \u003d \u0027description\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_d873c2e5","line":28,"updated":"2014-06-30 19:44:43.000000000","message":"This is confusing. Could you call the variables something more specific e.g. _name_field and _description_field.\n\nMy preferred approach would be to drop the variables, and in the test call volumes_client.name_field(api_version) - see L34","commit_id":"e1fb3e3a66522b4b800c821e7e7433f8fe487cd9"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e606f0af3021ad2cfa39da8070348036da76a3ae","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumesV2GetTest(base.BaseVolumeTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _name \u003d \u0027name\u0027"},{"line_number":29,"context_line":"    _description \u003d \u0027description\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_f5269215","line":28,"in_reply_to":"baada198_d873c2e5","updated":"2014-07-02 06:21:21.000000000","message":"nice idea! I\u0027ll fix it in next patch.","commit_id":"e1fb3e3a66522b4b800c821e7e7433f8fe487cd9"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4699e1bd8051e6ee19bb33ca589c5d9ef11f860a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setUpClass(cls):"},{"line_number":33,"context_line":"        super(VolumesV2GetTest, cls).setUpClass()"},{"line_number":34,"context_line":"        cls.client \u003d cls.volumes_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _delete_volume(self, volume_id):"},{"line_number":37,"context_line":"        resp, _ \u003d self.client.delete_volume(volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_93b04bdf","line":34,"updated":"2014-06-30 19:44:43.000000000","message":"I would add the field names here:\n\ncls.name_field \u003d cls.volumes_client.name_field(cls._api_version)\n...","commit_id":"e1fb3e3a66522b4b800c821e7e7433f8fe487cd9"}]}