)]}'
{"tempest/api/compute/admin/test_flavors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return flavor[\u0027id\u0027]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":86,"context_line":"    def test_create_flavor_with_int_id(self):"},{"line_number":87,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":88,"context_line":"        flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"},{"line_number":89,"context_line":"        new_flavor_id \u003d self._create_flavor(flavor_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d8c29a34","line":86,"updated":"2014-06-25 07:17:32.000000000","message":"we can avoid locking as per my comment in next file","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"}],"tempest/api/compute/flavors/test_flavors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":33,"context_line":"    def test_list_flavors(self):"},{"line_number":34,"context_line":"        # List of all flavors should contain the expected flavor"},{"line_number":35,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":36,"context_line":"        resp, flavors \u003d self.client.list_flavors()"},{"line_number":37,"context_line":"        resp, flavor \u003d self.client.get_flavor_details(self.flavor_ref)"},{"line_number":38,"context_line":"        flavor_min_detail \u003d {\u0027id\u0027: flavor[\u0027id\u0027], \u0027links\u0027: flavor[\u0027links\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d8f0da94","line":35,"updated":"2014-06-25 07:17:32.000000000","message":"No need to change here as race condition cannot be happen here. It refer the list of flavor and self.flavor_ref. If admin test delete any of the its created flavor that does not harm this test.","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def test_list_flavors_with_detail(self):"},{"line_number":44,"context_line":"        # Detailed list of all flavors should contain the expected flavor"},{"line_number":45,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":46,"context_line":"        resp, flavors \u003d self.client.list_flavors_with_detail()"},{"line_number":47,"context_line":"        resp, flavor \u003d self.client.get_flavor_details(self.flavor_ref)"},{"line_number":48,"context_line":"        self.assertIn(flavor, flavors)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f874b6ff","line":46,"updated":"2014-06-25 07:17:32.000000000","message":"ditto. No race condition.","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_list_flavors_using_marker(self):"},{"line_number":72,"context_line":"        # The list of flavors should start from the provided marker"},{"line_number":73,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":74,"context_line":"        resp, flavor \u003d self.client.get_flavor_details(self.flavor_ref)"},{"line_number":75,"context_line":"        flavor_id \u003d flavor[\u0027id\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        params \u003d {\u0027marker\u0027: flavor_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_18708207","line":74,"updated":"2014-06-25 07:17:32.000000000","message":"ditto. No race condition.","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"586c35766059c7e0feaff44d0a1e94300b6e410d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_list_flavors_using_marker(self):"},{"line_number":72,"context_line":"        # The list of flavors should start from the provided marker"},{"line_number":73,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":74,"context_line":"        resp, flavor \u003d self.client.get_flavor_details(self.flavor_ref)"},{"line_number":75,"context_line":"        flavor_id \u003d flavor[\u0027id\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        params \u003d {\u0027marker\u0027: flavor_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_2a2111b4","line":74,"in_reply_to":"1ae5cdf2_18708207","updated":"2014-06-27 03:56:16.000000000","message":"But this test fails due to race condition as per bug report","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff494c46c68c392e20aeb8bc3c77d62db909a5cd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_list_flavors_using_marker(self):"},{"line_number":72,"context_line":"        # The list of flavors should start from the provided marker"},{"line_number":73,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":74,"context_line":"        resp, flavor \u003d self.client.get_flavor_details(self.flavor_ref)"},{"line_number":75,"context_line":"        flavor_id \u003d flavor[\u0027id\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        params \u003d {\u0027marker\u0027: flavor_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7573fab3","line":74,"in_reply_to":"1ae5cdf2_2a2111b4","updated":"2014-06-27 04:04:20.000000000","message":"yes, that was before fix - https://review.openstack.org/#/c/100433/\nI do not think after this fix this test should fail.","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"d325df43faacdaeb2f514b956818f677fbd01b9f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_list_flavors_using_marker(self):"},{"line_number":72,"context_line":"        # The list of flavors should start from the provided marker"},{"line_number":73,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":74,"context_line":"        resp, flavor \u003d self.client.get_flavor_details(self.flavor_ref)"},{"line_number":75,"context_line":"        flavor_id \u003d flavor[\u0027id\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        params \u003d {\u0027marker\u0027: flavor_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9593264e","line":74,"in_reply_to":"1ae5cdf2_7573fab3","updated":"2014-06-27 04:22:20.000000000","message":"Correct. Understood","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def test_list_flavors_detailed_using_marker(self):"},{"line_number":84,"context_line":"        # The list of flavors should start from the provided marker"},{"line_number":85,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":86,"context_line":"        resp, flavor \u003d self.client.get_flavor_details(self.flavor_ref)"},{"line_number":87,"context_line":"        flavor_id \u003d flavor[\u0027id\u0027]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        params \u003d {\u0027marker\u0027: flavor_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_38c53e0a","line":86,"updated":"2014-06-25 07:17:32.000000000","message":"ditto. No race condition.","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":98,"context_line":"        resp, flavors \u003d self.client.list_flavors_with_detail()"},{"line_number":99,"context_line":"        flavors \u003d sorted(flavors, key\u003dlambda k: k[\u0027disk\u0027])"},{"line_number":100,"context_line":"        flavor_id \u003d flavors[0][\u0027id\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        params \u003d {self._min_disk: flavors[0][\u0027disk\u0027] + 1}"},{"line_number":103,"context_line":"        resp, flavors \u003d self.client.list_flavors_with_detail(params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d881baa1","line":100,"updated":"2014-06-25 07:17:32.000000000","message":"Locking is little expensive here, race condition can be avoided by getting the flavor for self.flavor instead of taking first element from list.","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027flavor\u0027))"},{"line_number":110,"context_line":"        resp, flavors \u003d self.client.list_flavors_with_detail()"},{"line_number":111,"context_line":"        flavors \u003d sorted(flavors, key\u003dlambda k: k[\u0027ram\u0027])"},{"line_number":112,"context_line":"        flavor_id \u003d flavors[0][\u0027id\u0027]"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        params \u003d {self._min_ram: flavors[0][\u0027ram\u0027] + 1}"},{"line_number":115,"context_line":"        resp, flavors \u003d self.client.list_flavors_with_detail(params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_188c02d7","line":112,"updated":"2014-06-25 07:17:32.000000000","message":"ditto.\nuse flavor of self.flavor","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        # The list of flavors should be filtered by disk space"},{"line_number":121,"context_line":"        resp, flavors \u003d self.client.list_flavors_with_detail()"},{"line_number":122,"context_line":"        flavors \u003d sorted(flavors, key\u003dlambda k: k[\u0027disk\u0027])"},{"line_number":123,"context_line":"        flavor_id \u003d flavors[0][\u0027id\u0027]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        params \u003d {self._min_disk: flavors[0][\u0027disk\u0027] + 1}"},{"line_number":126,"context_line":"        resp, flavors \u003d self.client.list_flavors(params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f8a7564e","line":123,"updated":"2014-06-25 07:17:32.000000000","message":"ditto.\nuse flavor of self.flavor","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6de27600280ad89a8852299f051ee728a5c66f0f","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        resp, flavors \u003d self.client.list_flavors_with_detail()"},{"line_number":134,"context_line":"        flavors \u003d sorted(flavors, key\u003dlambda k: k[\u0027ram\u0027])"},{"line_number":135,"context_line":"        flavor_id \u003d flavors[0][\u0027id\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        params \u003d {self._min_ram: flavors[0][\u0027ram\u0027] + 1}"},{"line_number":138,"context_line":"        resp, flavors \u003d self.client.list_flavors(params)"},{"line_number":139,"context_line":"        self.assertFalse(any([i for i in flavors if i[\u0027id\u0027] \u003d\u003d flavor_id]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_58bdaa66","line":136,"updated":"2014-06-25 07:17:32.000000000","message":"ditto.\nuse flavor of self.flavor","commit_id":"5b7b8076bb4b8fc0dfb918061fe023cf1b38c8b1"}]}