)]}'
{"tempest/api/network/test_fwaas_extensions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":236,"context_line":"    def test_insert_remove_firewall_rule_policy(self):"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        # Create firewall rule"},{"line_number":239,"context_line":"        resp, body \u003d self.client.create_firewall_rule("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cd0a8d25","line":236,"updated":"2014-07-04 04:22:21.000000000","message":"test name does not much clarity about test. Looks like this test is for inserting and removing the policy.\n\nit should be something like -\ntest_insert_remove_firewall_rule_from_policy(self)","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":236,"context_line":"    def test_insert_remove_firewall_rule_policy(self):"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        # Create firewall rule"},{"line_number":239,"context_line":"        resp, body \u003d self.client.create_firewall_rule("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d01db5bf","line":236,"in_reply_to":"baada198_cd0a8d25","updated":"2014-07-04 12:11:44.000000000","message":"Thanks for reviewing the code .\n\nI have updated the name of the test to test_insert_remove_firewall_rule_from_policy(self)","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def test_insert_remove_firewall_rule_policy(self):"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        # Create firewall rule"},{"line_number":239,"context_line":"        resp, body \u003d self.client.create_firewall_rule("},{"line_number":240,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":241,"context_line":"            action\u003d\"allow\","},{"line_number":242,"context_line":"            protocol\u003d\"tcp\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0d01e505","line":239,"updated":"2014-07-04 04:22:21.000000000","message":"unused variable.","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def test_insert_remove_firewall_rule_policy(self):"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        # Create firewall rule"},{"line_number":239,"context_line":"        resp, body \u003d self.client.create_firewall_rule("},{"line_number":240,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":241,"context_line":"            action\u003d\"allow\","},{"line_number":242,"context_line":"            protocol\u003d\"tcp\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f029d99b","line":239,"in_reply_to":"baada198_0d01e505","updated":"2014-07-04 12:11:44.000000000","message":"Use the variable to check the response after the creation of firewall rule \nself.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        resp, body \u003d self.client.create_firewall_rule("},{"line_number":240,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":241,"context_line":"            action\u003d\"allow\","},{"line_number":242,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":243,"context_line":"        fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":244,"context_line":"        # Create firewall policy"},{"line_number":245,"context_line":"        resp, body \u003d self.client.create_firewall_policy("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3884255d","line":242,"updated":"2014-07-04 04:22:21.000000000","message":"addCleanup is needed here to avoid resource leakage.","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        resp, body \u003d self.client.create_firewall_rule("},{"line_number":240,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":241,"context_line":"            action\u003d\"allow\","},{"line_number":242,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":243,"context_line":"        fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":244,"context_line":"        # Create firewall policy"},{"line_number":245,"context_line":"        resp, body \u003d self.client.create_firewall_policy("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f6147245","line":242,"in_reply_to":"baada198_3884255d","updated":"2014-07-04 12:11:44.000000000","message":"Updated the test by adding \nself.addCleanup(self._try_delete_rule, fw_rule_id) call \n to cleanup the resources .\n\nAdded the _try_delete_rule method to incorporate the cleanup of rules","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            fw_policy_id, fw_rule_id, \u0027\u0027, \u0027\u0027)"},{"line_number":253,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        # Verify insertion of rule in policy"},{"line_number":256,"context_line":"        resp, fw_policy \u003d self.client.show_firewall_policy("},{"line_number":257,"context_line":"            fw_policy_id)"},{"line_number":258,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_786cddd0","line":255,"updated":"2014-07-04 04:22:21.000000000","message":"Code L255 to L262 and L269 to L276 can be merged.\nHave 1 helper method and return boolean based on whether rule is in list or not.\nthen have assertTrue and assertFalse for insert and remove verification respectively.","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            fw_policy_id, fw_rule_id, \u0027\u0027, \u0027\u0027)"},{"line_number":253,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        # Verify insertion of rule in policy"},{"line_number":256,"context_line":"        resp, fw_policy \u003d self.client.show_firewall_policy("},{"line_number":257,"context_line":"            fw_policy_id)"},{"line_number":258,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d623eea4","line":255,"in_reply_to":"baada198_786cddd0","updated":"2014-07-04 12:11:44.000000000","message":"Added a method _rule_exists_in_policy that return boolean variable based on whether the rule is in list or not. \nUsed assertTrue and assertFalse for insert and remove verification respectively","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        for ruleid in fw_policy[\u0027firewall_policy\u0027][\u0027firewall_rules\u0027]:"},{"line_number":275,"context_line":"                rule_id_list.append(ruleid)"},{"line_number":276,"context_line":"        self.assertNotIn(fw_rule_id, rule_id_list)"},{"line_number":277,"context_line":"        self.addCleanup(self._try_delete_policy, fw_policy_id)"},{"line_number":278,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(fw_rule_id)"},{"line_number":279,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_389d05bd","line":277,"updated":"2014-07-04 04:22:21.000000000","message":"This should be just after L247","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        for ruleid in fw_policy[\u0027firewall_policy\u0027][\u0027firewall_rules\u0027]:"},{"line_number":275,"context_line":"                rule_id_list.append(ruleid)"},{"line_number":276,"context_line":"        self.assertNotIn(fw_rule_id, rule_id_list)"},{"line_number":277,"context_line":"        self.addCleanup(self._try_delete_policy, fw_policy_id)"},{"line_number":278,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(fw_rule_id)"},{"line_number":279,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_36326af2","line":277,"in_reply_to":"baada198_389d05bd","updated":"2014-07-04 12:11:44.000000000","message":"Updated the test by adding this call just after L247","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8e5b53900cac5a742b59400ce7843f7a9ae5f894","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # Verify insertion of rule in policy"},{"line_number":267,"context_line":"        self.assertTrue(self._rule_exists_in_policy("},{"line_number":268,"context_line":"            fw_policy_id, fw_rule_id))"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        # Remove rule from the firewall policy"},{"line_number":271,"context_line":"        resp, removerule \u003d self.client.remove_firewall_rule_from_policy("}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_173d3cc4","line":268,"updated":"2014-07-07 11:52:34.000000000","message":"this can be replaced with \n\n    self.assertIn(fw_rule_id, _get_list_fw_rule_ids(fw_policy_id))","commit_id":"6bc77e5406abfd97ff6de8dcd196ce0611911c79"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"25114df6c837dcdac246ebaeb89b1cc35c4af1d3","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # Verify insertion of rule in policy"},{"line_number":267,"context_line":"        self.assertTrue(self._rule_exists_in_policy("},{"line_number":268,"context_line":"            fw_policy_id, fw_rule_id))"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        # Remove rule from the firewall policy"},{"line_number":271,"context_line":"        resp, removerule \u003d self.client.remove_firewall_rule_from_policy("}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cc07ba80","line":268,"in_reply_to":"baada198_173d3cc4","updated":"2014-07-07 12:54:57.000000000","message":"Thanks for reviewing the code .\nI have updated the test with  self.assertIn(fw_rule_id, self._get_list_fw_rule_ids(fw_policy_id)).","commit_id":"6bc77e5406abfd97ff6de8dcd196ce0611911c79"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8e5b53900cac5a742b59400ce7843f7a9ae5f894","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        # Verify removal of rule from firewall policy"},{"line_number":276,"context_line":"        self.assertFalse(self._rule_exists_in_policy("},{"line_number":277,"context_line":"            fw_policy_id, fw_rule_id))"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _rule_exists_in_policy(self, fw_policy_id, fw_rule_id):"},{"line_number":280,"context_line":"        resp, fw_policy \u003d self.client.show_firewall_policy("}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f759a835","line":277,"updated":"2014-07-07 11:52:34.000000000","message":"this can be replaced with \n\n    self.assertNotIn(fw_rule_id, _get_list_fw_rule_ids(fw_policy_id))","commit_id":"6bc77e5406abfd97ff6de8dcd196ce0611911c79"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"25114df6c837dcdac246ebaeb89b1cc35c4af1d3","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        # Verify removal of rule from firewall policy"},{"line_number":276,"context_line":"        self.assertFalse(self._rule_exists_in_policy("},{"line_number":277,"context_line":"            fw_policy_id, fw_rule_id))"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _rule_exists_in_policy(self, fw_policy_id, fw_rule_id):"},{"line_number":280,"context_line":"        resp, fw_policy \u003d self.client.show_firewall_policy("}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_acec46bc","line":277,"in_reply_to":"baada198_f759a835","updated":"2014-07-07 12:54:57.000000000","message":"I have updated the test with \nself.assertNotIn(fw_rule_id, self._get_list_fw_rule_ids(fw_policy_id))","commit_id":"6bc77e5406abfd97ff6de8dcd196ce0611911c79"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8e5b53900cac5a742b59400ce7843f7a9ae5f894","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        if fw_rule_id in rule_id_list:"},{"line_number":287,"context_line":"                return True"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"                return False"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class FWaaSExtensionTestXML(FWaaSExtensionTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_77459841","line":289,"updated":"2014-07-07 11:52:34.000000000","message":"replace 283-290 into\n\n     return [ruleid for ruleid in fw_policy[\u0027firewall_policy\u0027][\u0027firewall_rules\u0027]]","commit_id":"6bc77e5406abfd97ff6de8dcd196ce0611911c79"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"25114df6c837dcdac246ebaeb89b1cc35c4af1d3","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        if fw_rule_id in rule_id_list:"},{"line_number":287,"context_line":"                return True"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"                return False"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class FWaaSExtensionTestXML(FWaaSExtensionTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2c5d9679","line":289,"in_reply_to":"baada198_77459841","updated":"2014-07-07 12:54:57.000000000","message":"Updated the test with \nreturn [ruleid for ruleid in fw_policy[\u0027firewall_policy\u0027]\n               [\u0027firewall_rules\u0027]]\n\nChanged the function name with \ndef _get_list_fw_rule_ids(self, fw_policy_id)","commit_id":"6bc77e5406abfd97ff6de8dcd196ce0611911c79"},{"author":{"_account_id":6553,"name":"Abhijeet Jain","username":"abhijeetjpjain","inactive":true},"change_message_id":"e297b52d2467c9cd1cc280a85f9c48906b67dd93","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        self.addCleanup(self._try_delete_policy, fw_policy_id)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Insert rule to firewall policy"},{"line_number":262,"context_line":"        resp, insertrule \u003d self.client.insert_firewall_rule_in_policy("},{"line_number":263,"context_line":"            fw_policy_id, fw_rule_id, \u0027\u0027, \u0027\u0027)"},{"line_number":264,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_3ed73fef","line":262,"updated":"2014-07-08 19:02:53.000000000","message":"Unused \u0027insertrule\u0027 variable.","commit_id":"9169b435b4bbc9038a0c46c2e7e11824cdf7e09b"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"268b169ac202581bd7345b205b3c4652e6f67d8d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        self.addCleanup(self._try_delete_policy, fw_policy_id)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Insert rule to firewall policy"},{"line_number":262,"context_line":"        resp, insertrule \u003d self.client.insert_firewall_rule_in_policy("},{"line_number":263,"context_line":"            fw_policy_id, fw_rule_id, \u0027\u0027, \u0027\u0027)"},{"line_number":264,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d9701d76","line":262,"in_reply_to":"baada198_3ed73fef","updated":"2014-07-08 19:24:14.000000000","message":"Thanks for reviewing the code. \nI have updated the unused variable  resp, _ \u003d self.client.insert_firewall_rule_in_policy(","commit_id":"9169b435b4bbc9038a0c46c2e7e11824cdf7e09b"},{"author":{"_account_id":6553,"name":"Abhijeet Jain","username":"abhijeetjpjain","inactive":true},"change_message_id":"e297b52d2467c9cd1cc280a85f9c48906b67dd93","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        # Verify insertion of rule in policy"},{"line_number":267,"context_line":"        self.assertIn(fw_rule_id, self._get_list_fw_rule_ids(fw_policy_id))"},{"line_number":268,"context_line":"        # Remove rule from the firewall policy"},{"line_number":269,"context_line":"        resp, removerule \u003d self.client.remove_firewall_rule_from_policy("},{"line_number":270,"context_line":"            fw_policy_id, fw_rule_id)"},{"line_number":271,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7e93774f","line":269,"updated":"2014-07-08 19:02:53.000000000","message":"Unused Variable \u0027 removerule\u0027,\nRather Use :\n\nresp, _ \u003d self.client.remove_firewall_rule_from_policy(","commit_id":"9169b435b4bbc9038a0c46c2e7e11824cdf7e09b"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"268b169ac202581bd7345b205b3c4652e6f67d8d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        # Verify insertion of rule in policy"},{"line_number":267,"context_line":"        self.assertIn(fw_rule_id, self._get_list_fw_rule_ids(fw_policy_id))"},{"line_number":268,"context_line":"        # Remove rule from the firewall policy"},{"line_number":269,"context_line":"        resp, removerule \u003d self.client.remove_firewall_rule_from_policy("},{"line_number":270,"context_line":"            fw_policy_id, fw_rule_id)"},{"line_number":271,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7909d1dc","line":269,"in_reply_to":"baada198_7e93774f","updated":"2014-07-08 19:24:14.000000000","message":"I have updated the unused variable resp, _ \u003dself.client.remove_firewall_rule_from_policy","commit_id":"9169b435b4bbc9038a0c46c2e7e11824cdf7e09b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f6c6a12b9f7457af8af3d2aae4379b47592db2af","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Insert rule to firewall policy"},{"line_number":262,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("},{"line_number":263,"context_line":"            fw_policy_id, fw_rule_id, \u0027\u0027, \u0027\u0027)"},{"line_number":264,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # Verify insertion of rule in policy"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_05aa11d4","line":263,"updated":"2014-07-09 12:36:57.000000000","message":"It seems nice to remove the specified values of arguments insert_after and insert_before because these values are the same as default values of the method and the above values seem a little difficult.\n\nBTW, will you add the tests for some patterns for insert_after and insert_before? In this patch, these values are not passed to Neutron. This is just a question, and it is OK if this patch does not cover these patterns because of the scope.","commit_id":"b773127479b112b8a50662b91a8239d7712265a5"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"7bd8b5ca0111096ef79eff9eac64fa79ec763bbe","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Insert rule to firewall policy"},{"line_number":262,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("},{"line_number":263,"context_line":"            fw_policy_id, fw_rule_id, \u0027\u0027, \u0027\u0027)"},{"line_number":264,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # Verify insertion of rule in policy"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2cd8dd52","line":263,"in_reply_to":"baada198_05aa11d4","updated":"2014-07-09 14:28:56.000000000","message":"Thanks for the review.\nThis test covers only insertion and removal of rule in the firewall policy.","commit_id":"b773127479b112b8a50662b91a8239d7712265a5"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"2e3442ec29d3a3cd88376ddeb3c2e7c772000fbe","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":244,"context_line":"    def test_insert_remove_firewall_rule_from_policy(self):"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Create firewall rule"},{"line_number":247,"context_line":"        resp, body \u003d self.client.create_firewall_rule("}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_4201836c","line":244,"updated":"2014-07-22 10:47:44.000000000","message":"nit: blank line is not necessary here","commit_id":"340c888d1fd21ac725dc034aa6adfb06b146354c"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"a47b876904c059d20863b5ad8eef47cbf9383a60","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":244,"context_line":"    def test_insert_remove_firewall_rule_from_policy(self):"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Create firewall rule"},{"line_number":247,"context_line":"        resp, body \u003d self.client.create_firewall_rule("}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_06ffdb01","line":244,"in_reply_to":"baada198_4201836c","updated":"2014-08-04 05:56:05.000000000","message":"thanks for the review\nRemoved the blank line","commit_id":"340c888d1fd21ac725dc034aa6adfb06b146354c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8876e77dd17c3013a29a7081181702d268af0ab3","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":244,"context_line":"    def test_insert_remove_firewall_rule_from_policy(self):"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Create firewall rule"},{"line_number":247,"context_line":"        resp, body \u003d self.client.create_firewall_rule("},{"line_number":248,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":249,"context_line":"            action\u003d\"allow\","}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_8c7ddee8","line":246,"updated":"2014-08-02 22:37:53.000000000","message":"You don\u0027t need to create a new firewall rule. You can use the one created in setUpClass()\n\nCreating a new firewall rule is not strictly the purpose of this test.","commit_id":"340c888d1fd21ac725dc034aa6adfb06b146354c"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"a47b876904c059d20863b5ad8eef47cbf9383a60","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":244,"context_line":"    def test_insert_remove_firewall_rule_from_policy(self):"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Create firewall rule"},{"line_number":247,"context_line":"        resp, body \u003d self.client.create_firewall_rule("},{"line_number":248,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":249,"context_line":"            action\u003d\"allow\","}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_4605530e","line":246,"in_reply_to":"baada198_8c7ddee8","updated":"2014-08-04 05:56:05.000000000","message":"Thanks for the review\nUsed the existing firewall rule that is created in setUpClass()","commit_id":"340c888d1fd21ac725dc034aa6adfb06b146354c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8876e77dd17c3013a29a7081181702d268af0ab3","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":252,"context_line":"        fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":253,"context_line":"        self.addCleanup(self._try_delete_rule, fw_rule_id)"},{"line_number":254,"context_line":"        # Create firewall policy"},{"line_number":255,"context_line":"        resp, body \u003d self.client.create_firewall_policy("},{"line_number":256,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":257,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_ec673a4f","line":254,"updated":"2014-08-02 22:37:53.000000000","message":"You don\u0027t need to create a new firewall policy. You can use the one created in setUpClass()","commit_id":"340c888d1fd21ac725dc034aa6adfb06b146354c"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"a47b876904c059d20863b5ad8eef47cbf9383a60","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":252,"context_line":"        fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":253,"context_line":"        self.addCleanup(self._try_delete_rule, fw_rule_id)"},{"line_number":254,"context_line":"        # Create firewall policy"},{"line_number":255,"context_line":"        resp, body \u003d self.client.create_firewall_policy("},{"line_number":256,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":257,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_e613c756","line":254,"in_reply_to":"baada198_ec673a4f","updated":"2014-08-04 05:56:05.000000000","message":"Used the existing firewall policy that is created in setUpClass()","commit_id":"340c888d1fd21ac725dc034aa6adfb06b146354c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e0268b8af50e911f4b88e0b9f484f2064ba8e539","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # List firewall rules"},{"line_number":246,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":247,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":248,"context_line":"        fw_rule_id \u003d fw_rules[\u0027firewall_rules\u0027][0][\u0027id\u0027]"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # List firewall Policies"},{"line_number":251,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_45670651","line":248,"updated":"2014-08-04 08:42:47.000000000","message":"Great you took my comment into consideration. I am sorry I wasn\u0027t clear in my last comment :\n\nI think you should just replace L246 to L248 with the one following line :\nfw_rule_id \u003d self.fw_rule[\u0027firewall_rule\u0027][\u0027id\u0027]\n\nBecause, here, with your approach, it might be that the firewall rule \u00270\u0027 (fw_rules[\u0027firewall_rules\u0027][0]) is not related at all to our test. it might have been created way before this Tempest test.","commit_id":"e680751a0fb6230c01a64d5ae84b5f1baa18c266"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"5e238b0383d4e804568f382d1e177acafeac7691","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # List firewall rules"},{"line_number":246,"context_line":"        resp, fw_rules \u003d self.client.list_firewall_rules()"},{"line_number":247,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":248,"context_line":"        fw_rule_id \u003d fw_rules[\u0027firewall_rules\u0027][0][\u0027id\u0027]"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # List firewall Policies"},{"line_number":251,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_2b710377","line":248,"in_reply_to":"baada198_45670651","updated":"2014-08-04 09:20:15.000000000","message":"Thanks Jordan for the review again .\nEdit the test :Replace the lines with\nfw_rule_id \u003d self.fw_rule[\u0027id\u0027]\n\nAgreed with your points.","commit_id":"e680751a0fb6230c01a64d5ae84b5f1baa18c266"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e0268b8af50e911f4b88e0b9f484f2064ba8e539","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        # List firewall Policies"},{"line_number":251,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"},{"line_number":252,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":253,"context_line":"        fw_policy_id \u003d fw_policies[\u0027firewall_policies\u0027][0][\u0027id\u0027]"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        # Insert rule to firewall policy"},{"line_number":256,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_652a4a92","line":253,"updated":"2014-08-04 08:42:47.000000000","message":"Same.\n\nIt might be :\nfw_policy_id \u003d self.fw_policy[\u0027firewall_policy\u0027][\u0027id\u0027]","commit_id":"e680751a0fb6230c01a64d5ae84b5f1baa18c266"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"5e238b0383d4e804568f382d1e177acafeac7691","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        # List firewall Policies"},{"line_number":251,"context_line":"        resp, fw_policies \u003d self.client.list_firewall_policies()"},{"line_number":252,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":253,"context_line":"        fw_policy_id \u003d fw_policies[\u0027firewall_policies\u0027][0][\u0027id\u0027]"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        # Insert rule to firewall policy"},{"line_number":256,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_cb07a7c7","line":253,"in_reply_to":"baada198_652a4a92","updated":"2014-08-04 09:20:15.000000000","message":"Edit the test :Replace the lines with\nfw_policy_id \u003d self.fw_policy[\u0027id\u0027]","commit_id":"e680751a0fb6230c01a64d5ae84b5f1baa18c266"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0dca6b66d3d9b404f849a0a71ab21bd3f3d6dcfb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except exceptions.NotFound:"},{"line_number":65,"context_line":"            pass"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _try_delete_rule(self, rule_id):"},{"line_number":68,"context_line":"        # delete rule, if it exists"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            self.client.delete_firewall_rule(rule_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_08ba5eb9","line":67,"updated":"2014-08-05 05:13:07.000000000","message":"This method is not used in this patch, it is better to remove it from this patch for keeping clean code.","commit_id":"50c79bbfa52531ec1fceab4c2bfb7a551035405c"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"fa5e244e362976aae94ac8b7ed10a769da1d7530","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except exceptions.NotFound:"},{"line_number":65,"context_line":"            pass"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _try_delete_rule(self, rule_id):"},{"line_number":68,"context_line":"        # delete rule, if it exists"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            self.client.delete_firewall_rule(rule_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_9e1ea40b","line":67,"in_reply_to":"baada198_08ba5eb9","updated":"2014-08-05 06:25:00.000000000","message":"Thanks for the review:\ni have updated the test by removing this method","commit_id":"50c79bbfa52531ec1fceab4c2bfb7a551035405c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1395b05196bc5969c2a5903101925adf96d63984","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":236,"context_line":"    def test_insert_remove_firewall_rule_from_policy(self):"},{"line_number":237,"context_line":"        fw_rule_id \u003d self.fw_rule[\u0027id\u0027]"},{"line_number":238,"context_line":"        fw_policy_id \u003d self.fw_policy[\u0027id\u0027]"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        # Insert rule to firewall policy"},{"line_number":241,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_aa1fa2b6","line":238,"updated":"2014-08-05 08:45:04.000000000","message":"Sorry for missing this in my previous review.\n\nThis test changes the shared resources(fw_rule, fw_policy).\nThat means this test fails at the middle of the test, that would affect the other tests and it would be difficult to debug the problem.\n\nTo avoid this situation, it is better to create this test own resources like:\n\n fw_rule \u003d self.create_firewall_rule(\"allow\", \"tcp\")\n fw_policy \u003d self.create_firewall_policy()","commit_id":"f86c90adf2b035b9c5c00bb790473a3e35ed8636"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"218b59f2ada886654d09d400dbfc8a6b9bbcd2e7","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":236,"context_line":"    def test_insert_remove_firewall_rule_from_policy(self):"},{"line_number":237,"context_line":"        fw_rule_id \u003d self.fw_rule[\u0027id\u0027]"},{"line_number":238,"context_line":"        fw_policy_id \u003d self.fw_policy[\u0027id\u0027]"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        # Insert rule to firewall policy"},{"line_number":241,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_d8d58de7","line":238,"in_reply_to":"baada198_aa1fa2b6","updated":"2014-08-05 09:09:33.000000000","message":"I\u0027ve recommended against doing so in patchset 6. \n\nI am sorry Ashish, I made a mistake, I now think that Ken is right...","commit_id":"f86c90adf2b035b9c5c00bb790473a3e35ed8636"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"4591e40810ca2f60803744d98b31515dc1388748","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":236,"context_line":"    def test_insert_remove_firewall_rule_from_policy(self):"},{"line_number":237,"context_line":"        fw_rule_id \u003d self.fw_rule[\u0027id\u0027]"},{"line_number":238,"context_line":"        fw_policy_id \u003d self.fw_policy[\u0027id\u0027]"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        # Insert rule to firewall policy"},{"line_number":241,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_fbbb2bbc","line":238,"in_reply_to":"baada198_aa1fa2b6","updated":"2014-08-05 09:36:01.000000000","message":"Thanks for the review again :\nUpdated the test by creating a firewall_rule and firewall_policy in my test .\nHave added the method _try_delete_rule(self, rule_id) since its used in the test.","commit_id":"f86c90adf2b035b9c5c00bb790473a3e35ed8636"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"4591e40810ca2f60803744d98b31515dc1388748","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":236,"context_line":"    def test_insert_remove_firewall_rule_from_policy(self):"},{"line_number":237,"context_line":"        fw_rule_id \u003d self.fw_rule[\u0027id\u0027]"},{"line_number":238,"context_line":"        fw_policy_id \u003d self.fw_policy[\u0027id\u0027]"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        # Insert rule to firewall policy"},{"line_number":241,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_1bffff6a","line":238,"in_reply_to":"baada198_d8d58de7","updated":"2014-08-05 09:36:01.000000000","message":"Thanks for the review  jordan.\nNot a problem, I have undo to patchset 6.","commit_id":"f86c90adf2b035b9c5c00bb790473a3e35ed8636"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"90ffafad2e269b485d1ba11ca31ac1e33dcae1d9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # delete policy, if it exists"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            self.client.delete_firewall_policy(policy_id)"},{"line_number":63,"context_line":"        # if policy is not found, this means it was deleted in the test"},{"line_number":64,"context_line":"        except exceptions.NotFound:"},{"line_number":65,"context_line":"            pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_93f2fd6d","line":63,"updated":"2014-08-25 17:32:07.000000000","message":"out of curiosity, why is this except clause needed? are there a lot of cases where we try to delete something that has been indirectly deleted?","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"7e1e35c93985493fff16a18ab90f0e7205384cc8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # delete policy, if it exists"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            self.client.delete_firewall_policy(policy_id)"},{"line_number":63,"context_line":"        # if policy is not found, this means it was deleted in the test"},{"line_number":64,"context_line":"        except exceptions.NotFound:"},{"line_number":65,"context_line":"            pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_cb30390a","line":63,"in_reply_to":"1abeadc6_93f2fd6d","updated":"2014-08-25 20:10:30.000000000","message":"No, but we don\u0027t want to bomb out if some code did an addCleanUp. I\u0027m not sure when addCleanUp runs relative to the class cleanup.  And some times a test might need to free things as they are used to avoid a quota issue.","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"89f733a3a028a8ee604343ad9374dc54a694c17c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # delete policy, if it exists"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            self.client.delete_firewall_policy(policy_id)"},{"line_number":63,"context_line":"        # if policy is not found, this means it was deleted in the test"},{"line_number":64,"context_line":"        except exceptions.NotFound:"},{"line_number":65,"context_line":"            pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa98f980_39579727","line":63,"in_reply_to":"1abeadc6_93f2fd6d","updated":"2014-09-05 08:53:55.000000000","message":"Thanks for the review .","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"89f733a3a028a8ee604343ad9374dc54a694c17c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # delete policy, if it exists"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            self.client.delete_firewall_policy(policy_id)"},{"line_number":63,"context_line":"        # if policy is not found, this means it was deleted in the test"},{"line_number":64,"context_line":"        except exceptions.NotFound:"},{"line_number":65,"context_line":"            pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa98f980_59529b35","line":63,"in_reply_to":"1abeadc6_cb30390a","updated":"2014-09-05 08:53:55.000000000","message":"Thanks for the review","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23404374820d7e7494ed06acfa489ddc1b50f01c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":248,"context_line":"            action\u003d\"allow\","},{"line_number":249,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":250,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":251,"context_line":"        fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":252,"context_line":"        self.addCleanup(self._try_delete_rule, fw_rule_id)"},{"line_number":253,"context_line":"        # Create firewall policy"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_942ff4a0","line":250,"updated":"2014-08-27 11:39:40.000000000","message":"It is not needed anymore to check status here. Remove this check.","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"89f733a3a028a8ee604343ad9374dc54a694c17c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":248,"context_line":"            action\u003d\"allow\","},{"line_number":249,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":250,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":251,"context_line":"        fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":252,"context_line":"        self.addCleanup(self._try_delete_rule, fw_rule_id)"},{"line_number":253,"context_line":"        # Create firewall policy"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa98f980_d93dabde","line":250,"in_reply_to":"1abeadc6_942ff4a0","updated":"2014-09-05 08:53:55.000000000","message":"Thanks for the review\n i have updated the test .","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23404374820d7e7494ed06acfa489ddc1b50f01c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # Create firewall policy"},{"line_number":254,"context_line":"        resp, body \u003d self.client.create_firewall_policy("},{"line_number":255,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":256,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":257,"context_line":"        fw_policy_id \u003d body[\u0027firewall_policy\u0027][\u0027id\u0027]"},{"line_number":258,"context_line":"        self.addCleanup(self._try_delete_policy, fw_policy_id)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_b42a308e","line":256,"updated":"2014-08-27 11:39:40.000000000","message":"The same.","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"89f733a3a028a8ee604343ad9374dc54a694c17c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # Create firewall policy"},{"line_number":254,"context_line":"        resp, body \u003d self.client.create_firewall_policy("},{"line_number":255,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":256,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":257,"context_line":"        fw_policy_id \u003d body[\u0027firewall_policy\u0027][\u0027id\u0027]"},{"line_number":258,"context_line":"        self.addCleanup(self._try_delete_policy, fw_policy_id)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa98f980_392eb7a5","line":256,"in_reply_to":"1abeadc6_b42a308e","updated":"2014-09-05 08:53:55.000000000","message":"Done","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23404374820d7e7494ed06acfa489ddc1b50f01c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        # Insert rule to firewall policy"},{"line_number":261,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("},{"line_number":262,"context_line":"            fw_policy_id, fw_rule_id, \u0027\u0027, \u0027\u0027)"},{"line_number":263,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Verify insertion of rule in policy"},{"line_number":266,"context_line":"        self.assertIn(fw_rule_id, self._get_list_fw_rule_ids(fw_policy_id))"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_f41bc87d","line":263,"updated":"2014-08-27 11:39:40.000000000","message":"The same","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"89f733a3a028a8ee604343ad9374dc54a694c17c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        # Insert rule to firewall policy"},{"line_number":261,"context_line":"        resp, _ \u003d self.client.insert_firewall_rule_in_policy("},{"line_number":262,"context_line":"            fw_policy_id, fw_rule_id, \u0027\u0027, \u0027\u0027)"},{"line_number":263,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Verify insertion of rule in policy"},{"line_number":266,"context_line":"        self.assertIn(fw_rule_id, self._get_list_fw_rule_ids(fw_policy_id))"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa98f980_5929bb99","line":263,"in_reply_to":"1abeadc6_f41bc87d","updated":"2014-09-05 08:53:55.000000000","message":"Done","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23404374820d7e7494ed06acfa489ddc1b50f01c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        # Remove rule from the firewall policy"},{"line_number":268,"context_line":"        resp, _ \u003d self.client.remove_firewall_rule_from_policy("},{"line_number":269,"context_line":"            fw_policy_id, fw_rule_id)"},{"line_number":270,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        # Verify removal of rule from firewall policy"},{"line_number":273,"context_line":"        self.assertNotIn(fw_rule_id, self._get_list_fw_rule_ids(fw_policy_id))"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_540c7c42","line":270,"updated":"2014-08-27 11:39:40.000000000","message":"The same","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"89f733a3a028a8ee604343ad9374dc54a694c17c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        # Remove rule from the firewall policy"},{"line_number":268,"context_line":"        resp, _ \u003d self.client.remove_firewall_rule_from_policy("},{"line_number":269,"context_line":"            fw_policy_id, fw_rule_id)"},{"line_number":270,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        # Verify removal of rule from firewall policy"},{"line_number":273,"context_line":"        self.assertNotIn(fw_rule_id, self._get_list_fw_rule_ids(fw_policy_id))"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa98f980_791bdf80","line":270,"in_reply_to":"1abeadc6_540c7c42","updated":"2014-09-05 08:53:55.000000000","message":"Done","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"23404374820d7e7494ed06acfa489ddc1b50f01c","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    def _get_list_fw_rule_ids(self, fw_policy_id):"},{"line_number":276,"context_line":"        resp, fw_policy \u003d self.client.show_firewall_policy("},{"line_number":277,"context_line":"            fw_policy_id)"},{"line_number":278,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":279,"context_line":"        return [ruleid for ruleid in fw_policy[\u0027firewall_policy\u0027]"},{"line_number":280,"context_line":"                [\u0027firewall_rules\u0027]]"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_7407b81d","line":278,"updated":"2014-08-27 11:39:40.000000000","message":"The same.","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"89f733a3a028a8ee604343ad9374dc54a694c17c","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    def _get_list_fw_rule_ids(self, fw_policy_id):"},{"line_number":276,"context_line":"        resp, fw_policy \u003d self.client.show_firewall_policy("},{"line_number":277,"context_line":"            fw_policy_id)"},{"line_number":278,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":279,"context_line":"        return [ruleid for ruleid in fw_policy[\u0027firewall_policy\u0027]"},{"line_number":280,"context_line":"                [\u0027firewall_rules\u0027]]"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa98f980_991ec36e","line":278,"in_reply_to":"1abeadc6_7407b81d","updated":"2014-09-05 08:53:55.000000000","message":"Done","commit_id":"2a909fd61d797a85b2d538d902ce622676133018"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f426d93c56779ad174ebeef179c5a7e14ed8b520","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":232,"context_line":"            action\u003d\"allow\","},{"line_number":233,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":234,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":235,"context_line":"        fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":236,"context_line":"        self.addCleanup(self._try_delete_rule, fw_rule_id)"},{"line_number":237,"context_line":"        # Create firewall policy"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_3e8e6e28","line":234,"updated":"2014-09-08 00:56:51.000000000","message":"Why don\u0027t you remove this\n\n self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])\n\nhere?","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"eefa7e643b2ada053681ecbe5b49884843304ce9","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"),"},{"line_number":232,"context_line":"            action\u003d\"allow\","},{"line_number":233,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":234,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":235,"context_line":"        fw_rule_id \u003d body[\u0027firewall_rule\u0027][\u0027id\u0027]"},{"line_number":236,"context_line":"        self.addCleanup(self._try_delete_rule, fw_rule_id)"},{"line_number":237,"context_line":"        # Create firewall policy"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_a0678d24","line":234,"in_reply_to":"fa98f980_3e8e6e28","updated":"2014-09-08 11:07:48.000000000","message":"Thanks for the review.\nRemoved the line","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        body \u003d json.loads(body)"},{"line_number":295,"context_line":"        return resp, body"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def insert_firewall_rule_policy(self, firewall_policy_id,"},{"line_number":298,"context_line":"                                    firewall_rule_id, insert_after\u003d\"\","},{"line_number":299,"context_line":"                                    insert_before\u003d\"\"):"},{"line_number":300,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/insert_rule\u0027 % (self.uri_prefix,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_5889d973","line":297,"updated":"2014-07-04 04:22:21.000000000","message":"name of this fun should be insert_firewall_rule_in_policy","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        body \u003d json.loads(body)"},{"line_number":295,"context_line":"        return resp, body"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def insert_firewall_rule_policy(self, firewall_policy_id,"},{"line_number":298,"context_line":"                                    firewall_rule_id, insert_after\u003d\"\","},{"line_number":299,"context_line":"                                    insert_before\u003d\"\"):"},{"line_number":300,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/insert_rule\u0027 % (self.uri_prefix,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f669d2be","line":297,"in_reply_to":"baada198_5889d973","updated":"2014-07-04 12:11:44.000000000","message":"Updated the name as insert_firewall_rule_in_policy","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        body \u003d json.loads(body)"},{"line_number":310,"context_line":"        return resp, body"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def remove_firewall_rule_policy(self, firewall_policy_id,"},{"line_number":313,"context_line":"                                    firewall_rule_id):"},{"line_number":314,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/remove_rule\u0027 % (self.uri_prefix,"},{"line_number":315,"context_line":"                                                firewall_policy_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b897558f","line":312,"updated":"2014-07-04 04:22:21.000000000","message":"ditto name- remove_firewall_rule_from_policy","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        body \u003d json.loads(body)"},{"line_number":310,"context_line":"        return resp, body"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def remove_firewall_rule_policy(self, firewall_policy_id,"},{"line_number":313,"context_line":"                                    firewall_rule_id):"},{"line_number":314,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/remove_rule\u0027 % (self.uri_prefix,"},{"line_number":315,"context_line":"                                                firewall_policy_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_96a256fb","line":312,"in_reply_to":"baada198_b897558f","updated":"2014-07-04 12:11:44.000000000","message":"Updated the method name as remove_firewall_rule_from_policy","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f426d93c56779ad174ebeef179c5a7e14ed8b520","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            \"insert_before\": insert_before"},{"line_number":333,"context_line":"        }"},{"line_number":334,"context_line":"        body \u003d json.dumps(body)"},{"line_number":335,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":336,"context_line":"        body \u003d json.loads(body)"},{"line_number":337,"context_line":"        return resp, body"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_7e98f66a","line":335,"updated":"2014-09-08 00:56:51.000000000","message":"The status code check is necessary like\n\n self.rest_client.expected_success(2XX, resp.status)","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"eefa7e643b2ada053681ecbe5b49884843304ce9","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            \"insert_before\": insert_before"},{"line_number":333,"context_line":"        }"},{"line_number":334,"context_line":"        body \u003d json.dumps(body)"},{"line_number":335,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":336,"context_line":"        body \u003d json.loads(body)"},{"line_number":337,"context_line":"        return resp, body"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_c09e5107","line":335,"in_reply_to":"fa98f980_7e98f66a","updated":"2014-09-08 11:07:48.000000000","message":"Added the check","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f426d93c56779ad174ebeef179c5a7e14ed8b520","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                                                          firewall_policy_id)"},{"line_number":343,"context_line":"        update_body \u003d {\"firewall_rule_id\": firewall_rule_id}"},{"line_number":344,"context_line":"        update_body \u003d json.dumps(update_body)"},{"line_number":345,"context_line":"        resp, body \u003d self.put(uri, update_body)"},{"line_number":346,"context_line":"        body \u003d json.loads(body)"},{"line_number":347,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_9e9d9a5c","line":345,"updated":"2014-09-08 00:56:51.000000000","message":"ditto","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"eefa7e643b2ada053681ecbe5b49884843304ce9","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                                                          firewall_policy_id)"},{"line_number":343,"context_line":"        update_body \u003d {\"firewall_rule_id\": firewall_rule_id}"},{"line_number":344,"context_line":"        update_body \u003d json.dumps(update_body)"},{"line_number":345,"context_line":"        resp, body \u003d self.put(uri, update_body)"},{"line_number":346,"context_line":"        body \u003d json.loads(body)"},{"line_number":347,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_e0a3554d","line":345,"in_reply_to":"fa98f980_9e9d9a5c","updated":"2014-09-08 11:07:48.000000000","message":"Added the check","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"}],"tempest/services/network/xml/network_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":259,"context_line":"        return resp, body"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def insert_firewall_rule_policy(self, firewall_policy_id,"},{"line_number":262,"context_line":"                                    firewall_rule_id, insert_after\u003d\"\","},{"line_number":263,"context_line":"                                    insert_before\u003d\"\"):"},{"line_number":264,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/insert_rule\u0027 % (self.uri_prefix,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d894098d","line":261,"updated":"2014-07-04 04:22:21.000000000","message":"ditto","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":259,"context_line":"        return resp, body"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def insert_firewall_rule_policy(self, firewall_policy_id,"},{"line_number":262,"context_line":"                                    firewall_rule_id, insert_after\u003d\"\","},{"line_number":263,"context_line":"                                    insert_before\u003d\"\"):"},{"line_number":264,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/insert_rule\u0027 % (self.uri_prefix,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f6b0f244","line":261,"in_reply_to":"baada198_d894098d","updated":"2014-07-04 12:11:44.000000000","message":"Updated the name as insert_firewall_rule_in_policy","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"889a154143f6e7298e57026dd0f919b71ab7c88d","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":269,"context_line":"        return resp, body"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def remove_firewall_rule_policy(self, firewall_policy_id,"},{"line_number":272,"context_line":"                                    firewall_rule_id):"},{"line_number":273,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/remove_rule\u0027 % (self.uri_prefix,"},{"line_number":274,"context_line":"                                                 firewall_policy_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f88d4d7d","line":271,"updated":"2014-07-04 04:22:21.000000000","message":"ditto","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3f36de71d77de1b8988583cda3e6fa322549bca8","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":269,"context_line":"        return resp, body"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def remove_firewall_rule_policy(self, firewall_policy_id,"},{"line_number":272,"context_line":"                                    firewall_rule_id):"},{"line_number":273,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/remove_rule\u0027 % (self.uri_prefix,"},{"line_number":274,"context_line":"                                                 firewall_policy_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_16ae46e6","line":271,"in_reply_to":"baada198_f88d4d7d","updated":"2014-07-04 12:11:44.000000000","message":"Updated the method name as remove_firewall_rule_from_policy","commit_id":"70789a58eba00e16a5740fc92c9d82515c7ed53d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ee956b677494b21afccec216ac95237a76c018c7","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                    firewall_rule_id, insert_after\u003d\"\","},{"line_number":263,"context_line":"                                    insert_before\u003d\"\"):"},{"line_number":264,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/insert_rule\u0027 % (self.uri_prefix,"},{"line_number":265,"context_line":"                                                       firewall_policy_id)"},{"line_number":266,"context_line":"        rule \u003d common.Element(\"firewall_rule_id\", firewall_rule_id)"},{"line_number":267,"context_line":"        resp, body \u003d self.put(uri, str(common.Document(rule)))"},{"line_number":268,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_b4252cad","line":265,"updated":"2014-08-18 09:53:03.000000000","message":"There is a lot of pep8 errors in this patch now because of the commit Iaff25fc9e2ecfad0c0574b39ddce0c5188d6c31f . so we need to update this patch.\n\n2014-08-18 08:29:19.190 | ./tempest/services/network/json/network_client.py:298:37: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.190 |                                     firewall_rule_id, insert_after\u003d\"\",\n2014-08-18 08:29:19.190 |                                     ^\n2014-08-18 08:29:19.190 | ./tempest/services/network/json/network_client.py:299:37: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.191 |                                     insert_before\u003d\"\"):\n2014-08-18 08:29:19.191 |                                     ^\n2014-08-18 08:29:19.191 | ./tempest/services/network/json/network_client.py:301:49: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.191 |                                                 firewall_policy_id)\n2014-08-18 08:29:19.191 |                                                 ^\n2014-08-18 08:29:19.191 | ./tempest/services/network/json/network_client.py:313:37: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.191 |                                     firewall_rule_id):\n2014-08-18 08:29:19.192 |                                     ^\n2014-08-18 08:29:19.192 | ./tempest/services/network/json/network_client.py:315:49: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.192 |                                                 firewall_policy_id)\n2014-08-18 08:29:19.192 |                                                 ^\n2014-08-18 08:29:19.192 | ./tempest/services/network/xml/network_client.py:263:37: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.192 |                                     firewall_rule_id, insert_after\u003d\"\",\n2014-08-18 08:29:19.192 |                                     ^\n2014-08-18 08:29:19.193 | ./tempest/services/network/xml/network_client.py:264:37: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.193 |                                     insert_before\u003d\"\"):\n2014-08-18 08:29:19.193 |                                     ^\n2014-08-18 08:29:19.193 | ./tempest/services/network/xml/network_client.py:266:56: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.193 |                                                        firewall_policy_id)\n2014-08-18 08:29:19.193 |                                                        ^\n2014-08-18 08:29:19.194 | ./tempest/services/network/xml/network_client.py:273:37: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.194 |                                     firewall_rule_id):\n2014-08-18 08:29:19.194 |                                     ^\n2014-08-18 08:29:19.194 | ./tempest/services/network/xml/network_client.py:275:50: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.194 |                                                  firewall_policy_id)\n2014-08-18 08:29:19.194 |                                                  ^\n2014-08-18 08:29:19.194 | ./tempest/api/network/test_fwaas_extensions.py:280:16: E128 continuation line under-indented for visual indent\n2014-08-18 08:29:19.195 |                [\u0027firewall_rules\u0027]]\n2014-08-18 08:29:19.195 |                ^","commit_id":"12d8d832993ad2b91e005051b8ea792df3b9924c"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"0abcf5749afbde7e52da80fa88215f0004aef994","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                    firewall_rule_id, insert_after\u003d\"\","},{"line_number":263,"context_line":"                                    insert_before\u003d\"\"):"},{"line_number":264,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/insert_rule\u0027 % (self.uri_prefix,"},{"line_number":265,"context_line":"                                                       firewall_policy_id)"},{"line_number":266,"context_line":"        rule \u003d common.Element(\"firewall_rule_id\", firewall_rule_id)"},{"line_number":267,"context_line":"        resp, body \u003d self.put(uri, str(common.Document(rule)))"},{"line_number":268,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_9fb049df","line":265,"in_reply_to":"1abeadc6_b4252cad","updated":"2014-08-18 10:35:02.000000000","message":"Thanks for the review.\nUpdated the patch resolving the pep8 issue .","commit_id":"12d8d832993ad2b91e005051b8ea792df3b9924c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f426d93c56779ad174ebeef179c5a7e14ed8b520","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                                                          firewall_policy_id)"},{"line_number":290,"context_line":"        rule \u003d common.Element(\"firewall_rule_id\", firewall_rule_id)"},{"line_number":291,"context_line":"        resp, body \u003d self.put(uri, str(common.Document(rule)))"},{"line_number":292,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":293,"context_line":"        return resp, body"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def remove_firewall_rule_from_policy(self, firewall_policy_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_bea17e97","line":292,"updated":"2014-09-08 00:56:51.000000000","message":"ditto","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"eefa7e643b2ada053681ecbe5b49884843304ce9","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                                                          firewall_policy_id)"},{"line_number":290,"context_line":"        rule \u003d common.Element(\"firewall_rule_id\", firewall_rule_id)"},{"line_number":291,"context_line":"        resp, body \u003d self.put(uri, str(common.Document(rule)))"},{"line_number":292,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":293,"context_line":"        return resp, body"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def remove_firewall_rule_from_policy(self, firewall_policy_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_40e421ac","line":292,"in_reply_to":"fa98f980_bea17e97","updated":"2014-09-08 11:07:48.000000000","message":"Added the check.","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f426d93c56779ad174ebeef179c5a7e14ed8b520","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/remove_rule\u0027 % (self.uri_prefix,"},{"line_number":298,"context_line":"                                                          firewall_policy_id)"},{"line_number":299,"context_line":"        rule \u003d common.Element(\"firewall_rule_id\", firewall_rule_id)"},{"line_number":300,"context_line":"        resp, body \u003d self.put(uri, str(common.Document(rule)))"},{"line_number":301,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":302,"context_line":"        return resp, body"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_de9e4254","line":300,"updated":"2014-09-08 00:56:51.000000000","message":"ditto","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"eefa7e643b2ada053681ecbe5b49884843304ce9","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        uri \u003d \u0027%s/fw/firewall_policies/%s/remove_rule\u0027 % (self.uri_prefix,"},{"line_number":298,"context_line":"                                                          firewall_policy_id)"},{"line_number":299,"context_line":"        rule \u003d common.Element(\"firewall_rule_id\", firewall_rule_id)"},{"line_number":300,"context_line":"        resp, body \u003d self.put(uri, str(common.Document(rule)))"},{"line_number":301,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":302,"context_line":"        return resp, body"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_a0994d21","line":300,"in_reply_to":"fa98f980_de9e4254","updated":"2014-09-08 11:07:48.000000000","message":"Added the check","commit_id":"97071cdc080fc45792f29f6bf81638c12ad2c19f"}]}