)]}'
{"tempest/clients.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a4b194de236a53fa56f18d12896c113d1dfc9b55","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # enable test user to operate swift by adding operator role to him."},{"line_number":566,"context_line":"        roles \u003d keystone_admin.roles.list()"},{"line_number":567,"context_line":"        operator_role \u003d CONF.object_storage.operator_role"},{"line_number":568,"context_line":"        region \u003d CONF.identity.region"},{"line_number":569,"context_line":"        member_role \u003d [role for role in roles if role.name \u003d\u003d operator_role][0]"},{"line_number":570,"context_line":"        # NOTE(maurosr): This is surrounded in the try-except block cause"},{"line_number":571,"context_line":"        # neutron tests doesn\u0027t have tenant isolation."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_14f8857b","line":568,"updated":"2014-07-01 13:41:03.000000000","message":"Shouldn\u0027t this be CONF.object_storage.region ?","commit_id":"4effa8d83ea822338ccea0934bd39b01b708bbca"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"35c7643813669024b840d45f11579e2bdd87bbcc","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # enable test user to operate swift by adding operator role to him."},{"line_number":566,"context_line":"        roles \u003d keystone_admin.roles.list()"},{"line_number":567,"context_line":"        operator_role \u003d CONF.object_storage.operator_role"},{"line_number":568,"context_line":"        region \u003d CONF.identity.region"},{"line_number":569,"context_line":"        member_role \u003d [role for role in roles if role.name \u003d\u003d operator_role][0]"},{"line_number":570,"context_line":"        # NOTE(maurosr): This is surrounded in the try-except block cause"},{"line_number":571,"context_line":"        # neutron tests doesn\u0027t have tenant isolation."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_80e44f3c","line":568,"in_reply_to":"baada198_14f8857b","updated":"2014-07-01 15:07:08.000000000","message":"For other services like compute, glance etc we are using conf.identity.region. Wouldn\u0027t it be better to maintain the same ?","commit_id":"4effa8d83ea822338ccea0934bd39b01b708bbca"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e9edb89a955714fed0ca480429af8a127ba0e6f7","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # enable test user to operate swift by adding operator role to him."},{"line_number":566,"context_line":"        roles \u003d keystone_admin.roles.list()"},{"line_number":567,"context_line":"        operator_role \u003d CONF.object_storage.operator_role"},{"line_number":568,"context_line":"        region \u003d CONF.identity.region"},{"line_number":569,"context_line":"        member_role \u003d [role for role in roles if role.name \u003d\u003d operator_role][0]"},{"line_number":570,"context_line":"        # NOTE(maurosr): This is surrounded in the try-except block cause"},{"line_number":571,"context_line":"        # neutron tests doesn\u0027t have tenant isolation."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_4c8431d4","line":568,"in_reply_to":"baada198_26663c52","updated":"2014-07-01 16:14:48.000000000","message":"This is in fact wrong for all clients in the scenario manager.\nThe rest client is doing:\n\n    def _get_region(self, service):\n        \"\"\"\n        Returns the region for a specific service\n        \"\"\"\n        service_region \u003d None\n        for cfgname in dir(CONF._config):\n            # Find all config.FOO.catalog_type and assume FOO is a service.\n            cfg \u003d getattr(CONF, cfgname)\n            catalog_type \u003d getattr(cfg, \u0027catalog_type\u0027, None)\n            if catalog_type \u003d\u003d service:\n                service_region \u003d getattr(cfg, \u0027region\u0027, None)\n        if not service_region:\n            service_region \u003d CONF.identity.region\n        return service_region\n\nYou may want to replicate this function in clients.py or even move it to some common module to be consumed by both rest_client and official clients.","commit_id":"4effa8d83ea822338ccea0934bd39b01b708bbca"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"aa205fc94c0037a567f61c5040d7e8893fbc260c","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # enable test user to operate swift by adding operator role to him."},{"line_number":566,"context_line":"        roles \u003d keystone_admin.roles.list()"},{"line_number":567,"context_line":"        operator_role \u003d CONF.object_storage.operator_role"},{"line_number":568,"context_line":"        region \u003d CONF.identity.region"},{"line_number":569,"context_line":"        member_role \u003d [role for role in roles if role.name \u003d\u003d operator_role][0]"},{"line_number":570,"context_line":"        # NOTE(maurosr): This is surrounded in the try-except block cause"},{"line_number":571,"context_line":"        # neutron tests doesn\u0027t have tenant isolation."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_4f27c364","line":568,"in_reply_to":"baada198_4c8431d4","updated":"2014-07-03 11:54:13.000000000","message":"Thanks ! I tested for all scenario services and local region configs are not getting effective and broken. So should I be opening another bug or proceed fixing it in this ?","commit_id":"4effa8d83ea822338ccea0934bd39b01b708bbca"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"362e8445dfb179e5ebf224a336d70517ac249070","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # enable test user to operate swift by adding operator role to him."},{"line_number":566,"context_line":"        roles \u003d keystone_admin.roles.list()"},{"line_number":567,"context_line":"        operator_role \u003d CONF.object_storage.operator_role"},{"line_number":568,"context_line":"        region \u003d CONF.identity.region"},{"line_number":569,"context_line":"        member_role \u003d [role for role in roles if role.name \u003d\u003d operator_role][0]"},{"line_number":570,"context_line":"        # NOTE(maurosr): This is surrounded in the try-except block cause"},{"line_number":571,"context_line":"        # neutron tests doesn\u0027t have tenant isolation."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_721c5f14","line":568,"in_reply_to":"baada198_4f27c364","updated":"2014-07-09 19:49:56.000000000","message":"Dependency  for getting region info. Added \"_get_region\" in clients.py - https://review.openstack.org/#/c/105782/\n\nNeed review","commit_id":"4effa8d83ea822338ccea0934bd39b01b708bbca"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7237bac116e9f03b30e967556777b80eb827c94e","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # enable test user to operate swift by adding operator role to him."},{"line_number":566,"context_line":"        roles \u003d keystone_admin.roles.list()"},{"line_number":567,"context_line":"        operator_role \u003d CONF.object_storage.operator_role"},{"line_number":568,"context_line":"        region \u003d CONF.identity.region"},{"line_number":569,"context_line":"        member_role \u003d [role for role in roles if role.name \u003d\u003d operator_role][0]"},{"line_number":570,"context_line":"        # NOTE(maurosr): This is surrounded in the try-except block cause"},{"line_number":571,"context_line":"        # neutron tests doesn\u0027t have tenant isolation."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c662e0d7","line":568,"in_reply_to":"baada198_80e44f3c","updated":"2014-07-01 15:17:17.000000000","message":"I am not sure. According to the code comment in config.py \n\"The object-storage region name to use. If empty, the value of identity.region is used instead\", the right think to do might be to try to read the region from CONF.object_storage.region and if empty read CONF.identity.region\n\nWhat do you think ?","commit_id":"4effa8d83ea822338ccea0934bd39b01b708bbca"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"0b5dd25e571a3c5539a639446940662fd820b2ac","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # enable test user to operate swift by adding operator role to him."},{"line_number":566,"context_line":"        roles \u003d keystone_admin.roles.list()"},{"line_number":567,"context_line":"        operator_role \u003d CONF.object_storage.operator_role"},{"line_number":568,"context_line":"        region \u003d CONF.identity.region"},{"line_number":569,"context_line":"        member_role \u003d [role for role in roles if role.name \u003d\u003d operator_role][0]"},{"line_number":570,"context_line":"        # NOTE(maurosr): This is surrounded in the try-except block cause"},{"line_number":571,"context_line":"        # neutron tests doesn\u0027t have tenant isolation."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_26663c52","line":568,"in_reply_to":"baada198_c662e0d7","updated":"2014-07-01 15:28:49.000000000","message":"Make sense,\nif not CONF.object_storage.region:\n          region \u003d CONF.identity.region\n        else:\n          region \u003d CONF.object_storage.region","commit_id":"4effa8d83ea822338ccea0934bd39b01b708bbca"}]}