)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f2883e6838818a3f92999d48939b6732c30dbdd7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid errors in log when neutron tests are skipped"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The BaseNetworkTest class setUp() method will initialize"},{"line_number":10,"context_line":"various class attributes which the tearDown() method"},{"line_number":11,"context_line":"expects to exist. Unfortunately when Neutron is not"},{"line_number":12,"context_line":"available, the entire of the setUp() method is skipped,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_2e6c0335","line":9,"updated":"2014-07-03 11:33:45.000000000","message":"s/setUp/setUpClass/g\n\ns/tearDown/tearDownClass/g","commit_id":"042ab36632d25ada8cf3933f7811aaa642c06d4a"}],"tempest/api/network/base.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ea2a730f5e43a2289c927f8003810a26fff7fdd0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        cls.set_network_resources()"},{"line_number":61,"context_line":"        super(BaseNetworkTest, cls).setUpClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        os \u003d cls.get_client_manager()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        cls.network_cfg \u003d CONF.network"},{"line_number":66,"context_line":"        cls.client \u003d os.network_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_e80af877","line":63,"updated":"2014-07-03 14:50:17.000000000","message":"Can you move the get_client_manger and the os.client \u003d os.network_client after the skip ?\nIt is expected to cause even less log.","commit_id":"3c0e85bf39e83f7c480feaccfbe505566a7065a4"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5b6a1bcb95fb27e71f48ec2fabd1272e86a94432","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        cls.fw_policies \u003d []"},{"line_number":82,"context_line":"        cls.ipsecpolicies \u003d []"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not CONF.service_available.neutron:"},{"line_number":85,"context_line":"            raise cls.skipException(\"Neutron support is required\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4ffbdfc0","line":84,"updated":"2014-07-03 19:25:22.000000000","message":"Why do we want to execute all this setup/teardown if we are skipping the test? Why not move the skip to the very top of setUpClass?\n\nMatt told me we used to not be able to skip before the call to super due to some way we were handling config but that it is ok now.","commit_id":"3c0e85bf39e83f7c480feaccfbe505566a7065a4"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"9f78552004104f364e4b7da18ca57b1a1bee96a9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        cls.fw_policies \u003d []"},{"line_number":82,"context_line":"        cls.ipsecpolicies \u003d []"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not CONF.service_available.neutron:"},{"line_number":85,"context_line":"            raise cls.skipException(\"Neutron support is required\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_aac7ed96","line":84,"in_reply_to":"baada198_41a9e18e","updated":"2014-07-13 22:57:07.000000000","message":"Well I think it would be better to make the tearDown smarter, and push the skip even more up in the setUpClass.","commit_id":"3c0e85bf39e83f7c480feaccfbe505566a7065a4"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"84a7fa7e3c7af2763f16db0c9174634788c4cf2d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        cls.fw_policies \u003d []"},{"line_number":82,"context_line":"        cls.ipsecpolicies \u003d []"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not CONF.service_available.neutron:"},{"line_number":85,"context_line":"            raise cls.skipException(\"Neutron support is required\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_41a9e18e","line":84,"in_reply_to":"baada198_4ffbdfc0","updated":"2014-07-04 08:27:41.000000000","message":"The whole point of this bug fix is that we need to initialize these variables because the tearDownClass() method is getting called despite the fact we\u0027re skipping the test.","commit_id":"3c0e85bf39e83f7c480feaccfbe505566a7065a4"}]}