)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ea11c94d127875586139139524fe62efb226090d","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        for flavor in cls.flavors:"},{"line_number":159,"context_line":"            try:"},{"line_number":160,"context_line":"                cls.flavor_client.wait_for_server_termination(flavor[\u0027id\u0027])"},{"line_number":161,"context_line":"            except Exception:"},{"line_number":162,"context_line":"                pass"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_04f805e4","line":160,"updated":"2014-07-03 09:13:53.000000000","message":"cls.flavor_client doesn\u0027t have wait_for_server_termination. \n\nit should be:\n\ncls.flavor_client.wait_for_resource_deletion(flavor[\u0027id\u0027])","commit_id":"2b0c1bdeb7118a8b4c66958f09a3739565b94596"}],"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ea11c94d127875586139139524fe62efb226090d","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        def _create_flavor(name, **kw):"},{"line_number":145,"context_line":"            # creates a flavor based on configured flavor_ref"},{"line_number":146,"context_line":"            resp, orig \u003d self.flavor_client.get_flavor_details("},{"line_number":147,"context_line":"                CONF.compute.flavor_ref)"},{"line_number":148,"context_line":"            ram \u003d orig[\u0027ram\u0027]"},{"line_number":149,"context_line":"            vcpus \u003d orig[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_295fa442","line":146,"updated":"2014-07-03 09:13:53.000000000","message":"same comments in v3/servers/test_create_server.py","commit_id":"2b0c1bdeb7118a8b4c66958f09a3739565b94596"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ea11c94d127875586139139524fe62efb226090d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            else:"},{"line_number":157,"context_line":"                disk \u003d orig[\u0027disk\u0027]"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"            flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":160,"context_line":"            resp, extra \u003d self.flavor_client.get_flavor_extra_spec(flavor_ref)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_e913ec63","line":159,"updated":"2014-07-03 09:13:53.000000000","message":"ditto","commit_id":"2b0c1bdeb7118a8b4c66958f09a3739565b94596"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ea11c94d127875586139139524fe62efb226090d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                disk \u003d orig[\u0027disk\u0027]"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"            flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":160,"context_line":"            resp, extra \u003d self.flavor_client.get_flavor_extra_spec(flavor_ref)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"},{"line_number":163,"context_line":"            resp, flavor \u003d self.create_flavor(name, ram, vcpus, disk,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_89543022","line":160,"updated":"2014-07-03 09:13:53.000000000","message":"ditto","commit_id":"2b0c1bdeb7118a8b4c66958f09a3739565b94596"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ee0a9109dfd43dbad6eb882deb6ee86b6cddb720","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        def _create_flavor(name, **kw):"},{"line_number":145,"context_line":"            # creates a flavor based on configured flavor_ref"},{"line_number":146,"context_line":"            resp, orig \u003d self.flavor_client.get_flavor_details("},{"line_number":147,"context_line":"                self.flavor_ref)"},{"line_number":148,"context_line":"            ram \u003d orig[\u0027ram\u0027]"},{"line_number":149,"context_line":"            vcpus \u003d orig[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_e4c12e30","line":146,"updated":"2014-07-04 01:09:32.000000000","message":"resp is not used.","commit_id":"f888b1f681d1019d9f9b3d141528eb3406fc1ce2"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"b7d6cca27654f5e9ca076a3b2283f6cadf68d9e1","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            resp, extra \u003d self.flavor_client.get_flavor_extra_spec("},{"line_number":162,"context_line":"                self.flavor_ref)"},{"line_number":163,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"},{"line_number":166,"context_line":"            resp, flavor \u003d self.create_flavor(name, ram, vcpus, disk,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_bafcbf0e","line":163,"updated":"2014-08-08 15:55:32.000000000","message":"can we use method \u0027expected_success\u0027 instead of assertEqual here?\n\nFor example:\nhttps://github.com/openstack/tempest/blob/master/tempest/services/identity/xml/identity_client.py#L32","commit_id":"972d32df96289362c704858561d63f4c58142f56"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"b7d6cca27654f5e9ca076a3b2283f6cadf68d9e1","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"},{"line_number":166,"context_line":"            resp, flavor \u003d self.create_flavor(name, ram, vcpus, disk,"},{"line_number":167,"context_line":"                                              flavor_id, **kw)"},{"line_number":168,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"            if extra:"},{"line_number":171,"context_line":"                self.flavor_client.set_flavor_extra_spec(flavor_id, extra)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_5a09e330","line":168,"updated":"2014-08-08 15:55:32.000000000","message":"can we use method \u0027expected_success\u0027 instead of assertEqual here?\n\nFor example:\nhttps://github.com/openstack/tempest/blob/master/tempest/services/identity/xml/identity_client.py#L32","commit_id":"972d32df96289362c704858561d63f4c58142f56"}],"tempest/api/compute/v3/servers/test_create_server.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ea11c94d127875586139139524fe62efb226090d","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def _create_flavor(name, **kw):"},{"line_number":124,"context_line":"            # creates a flavor based off configured flavor_ref"},{"line_number":125,"context_line":"            resp, orig \u003d self.flavor_client.get_flavor_details("},{"line_number":126,"context_line":"                CONF.compute.flavor_ref)"},{"line_number":127,"context_line":"            ram \u003d orig[\u0027ram\u0027]"},{"line_number":128,"context_line":"            vcpus \u003d orig[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c91628a7","line":125,"updated":"2014-07-03 09:13:53.000000000","message":"resp is not used.","commit_id":"2b0c1bdeb7118a8b4c66958f09a3739565b94596"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ea11c94d127875586139139524fe62efb226090d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            else:"},{"line_number":136,"context_line":"                disk \u003d orig[\u0027disk\u0027]"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":139,"context_line":"            resp, extra \u003d self.flavor_client.get_flavor_extra_spec(flavor_ref)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"            flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4985b8ab","line":138,"updated":"2014-07-03 09:13:53.000000000","message":"line 126 can also use flavor_ref if move this line to the top","commit_id":"2b0c1bdeb7118a8b4c66958f09a3739565b94596"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ea11c94d127875586139139524fe62efb226090d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                disk \u003d orig[\u0027disk\u0027]"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":139,"context_line":"            resp, extra \u003d self.flavor_client.get_flavor_extra_spec(flavor_ref)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"            flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"},{"line_number":142,"context_line":"            resp, flavor \u003d self.create_flavor(name, ram, vcpus, disk,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c9670824","line":139,"updated":"2014-07-03 09:13:53.000000000","message":"resp is not used","commit_id":"2b0c1bdeb7118a8b4c66958f09a3739565b94596"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ee0a9109dfd43dbad6eb882deb6ee86b6cddb720","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def _create_flavor(name, **kw):"},{"line_number":124,"context_line":"            # creates a flavor based off configured flavor_ref"},{"line_number":125,"context_line":"            resp, orig \u003d self.flavor_client.get_flavor_details("},{"line_number":126,"context_line":"                self.flavor_ref)"},{"line_number":127,"context_line":"            ram \u003d orig[\u0027ram\u0027]"},{"line_number":128,"context_line":"            vcpus \u003d orig[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_24dfa60e","line":125,"updated":"2014-07-04 01:09:32.000000000","message":"resp is not used.","commit_id":"f888b1f681d1019d9f9b3d141528eb3406fc1ce2"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"b7d6cca27654f5e9ca076a3b2283f6cadf68d9e1","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            # creates a flavor based off configured flavor_ref"},{"line_number":125,"context_line":"            resp, orig \u003d self.flavor_client.get_flavor_details("},{"line_number":126,"context_line":"                self.flavor_ref)"},{"line_number":127,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            ram \u003d orig[\u0027ram\u0027]"},{"line_number":130,"context_line":"            vcpus \u003d orig[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_1d03e50c","line":127,"updated":"2014-08-08 15:55:32.000000000","message":"can we use method \u0027expected_success\u0027 instead of assertEqual here?\n\nFor example:\nhttps://github.com/openstack/tempest/blob/master/tempest/services/identity/xml/identity_client.py#L32","commit_id":"972d32df96289362c704858561d63f4c58142f56"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"b7d6cca27654f5e9ca076a3b2283f6cadf68d9e1","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            resp, extra \u003d self.flavor_client.get_flavor_extra_spec("},{"line_number":141,"context_line":"                self.flavor_ref)"},{"line_number":142,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"            flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"},{"line_number":145,"context_line":"            resp, flavor \u003d self.create_flavor(name, ram, vcpus, disk,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_5d10fd4e","line":142,"updated":"2014-08-08 15:55:32.000000000","message":"can we use method \u0027expected_success\u0027 instead of assertEqual here?\n\nFor example:\nhttps://github.com/openstack/tempest/blob/master/tempest/services/identity/xml/identity_client.py#L32","commit_id":"972d32df96289362c704858561d63f4c58142f56"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"b7d6cca27654f5e9ca076a3b2283f6cadf68d9e1","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            flavor_id \u003d data_utils.rand_int_id(start\u003d1000)"},{"line_number":145,"context_line":"            resp, flavor \u003d self.create_flavor(name, ram, vcpus, disk,"},{"line_number":146,"context_line":"                                              flavor_id, **kw)"},{"line_number":147,"context_line":"            self.assertEqual(201, resp.status)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            if extra:"},{"line_number":150,"context_line":"                self.flavor_client.set_flavor_extra_spec(flavor_id, extra)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_bd13d957","line":147,"updated":"2014-08-08 15:55:32.000000000","message":"can we use method \u0027expected_success\u0027 instead of assertEqual here?\n\nFor example:\nhttps://github.com/openstack/tempest/blob/master/tempest/services/identity/xml/identity_client.py#L32","commit_id":"972d32df96289362c704858561d63f4c58142f56"}]}