)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1153b771c362c47307b75db4490973ef4e1d948b","unresolved":false,"context_lines":[{"line_number":1378,"context_line":"        except heat_exceptions.HTTPNotFound:"},{"line_number":1379,"context_line":"            pass"},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"    def assign_keypair(self):"},{"line_number":1382,"context_line":"        if CONF.orchestration.keypair_name:"},{"line_number":1383,"context_line":"            self.keypair \u003d None"},{"line_number":1384,"context_line":"            self.keypair_name \u003d CONF.orchestration.keypair_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_053f15d7","line":1381,"updated":"2014-07-03 14:38:24.000000000","message":"Could you add docstring to explain how to use this function?","commit_id":"6b94e0395fdfc4ca098448ad9c2115d7469d172e"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1153b771c362c47307b75db4490973ef4e1d948b","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"            self.keypair_name \u003d self.keypair.id"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":"    def create_stack(self, stack_name, template, parameters\u003d{},"},{"line_number":1390,"context_line":"                     adopt_stack_data\u003dNone):"},{"line_number":1391,"context_line":"        self.client.stacks.create(stack_name\u003dstack_name,"},{"line_number":1392,"context_line":"                                  template\u003dtemplate,"},{"line_number":1393,"context_line":"                                  parameters\u003dself.parameters,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_250ed93b","line":1390,"updated":"2014-07-03 14:38:24.000000000","message":"Could you add docstring to explain how to use this function?\n\nIt works only for one stack at the time, which is fine, but it would be good to clarify that.","commit_id":"6b94e0395fdfc4ca098448ad9c2115d7469d172e"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0f7fcf0d7ce8902b2e5b988c4c1d43bf5d0de417","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"        exist then create a new keypair."},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        :returns: keypair object and keypair name"},{"line_number":1420,"context_line":"        \"\"\""},{"line_number":1421,"context_line":"        if CONF.orchestration.keypair_name:"},{"line_number":1422,"context_line":"            keypair \u003d None"},{"line_number":1423,"context_line":"            keypair_name \u003d CONF.orchestration.keypair_name"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4f3b4a38","line":1420,"updated":"2014-07-09 12:29:36.000000000","message":"Love the docstring. keep up the good docs","commit_id":"ce05012da2a5103c6ac3963657df5ddfd19799d3"}],"tempest/scenario/orchestration/test_autoscaling.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a7a73301dcacfb2f9290c23eb991fcb999c462a6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"CONF \u003d config.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AutoScalingTest(manager.OrchestrationScenarioTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(AutoScalingTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_21c1d780","line":23,"updated":"2014-08-14 10:59:27.000000000","message":"see comments on test_server_cfn_init scenario","commit_id":"b4cd333ea00fb974a1df74ce0871661a13018d9e"}],"tempest/scenario/orchestration/test_server_cfn_init.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0f7fcf0d7ce8902b2e5b988c4c1d43bf5d0de417","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class CfnInitScenarioTest(manager.OrchestrationScenarioTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(CfnInitScenarioTest, self).setUp()"},{"line_number":29,"context_line":"        if not CONF.orchestration.image_ref:"},{"line_number":30,"context_line":"            raise self.skipException(\"No image available to test\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6a4d5cc4","line":27,"updated":"2014-07-09 12:29:36.000000000","message":"looks like some of these lines could move upwards as well","commit_id":"ce05012da2a5103c6ac3963657df5ddfd19799d3"},{"author":{"_account_id":11956,"name":"Ishant Tyagi","email":"ityagi@infoblox.com","username":"ishant"},"change_message_id":"279e54480175d69aae5b3e55f4d5c2e697e2100b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class CfnInitScenarioTest(manager.OrchestrationScenarioTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(CfnInitScenarioTest, self).setUp()"},{"line_number":29,"context_line":"        if not CONF.orchestration.image_ref:"},{"line_number":30,"context_line":"            raise self.skipException(\"No image available to test\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_65daed18","line":27,"in_reply_to":"baada198_6a4d5cc4","updated":"2014-07-09 12:48:45.000000000","message":"didn\u0027t get you? which lines?","commit_id":"ce05012da2a5103c6ac3963657df5ddfd19799d3"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0f7fcf0d7ce8902b2e5b988c4c1d43bf5d0de417","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.stack_name \u003d self._stack_rand_name()"},{"line_number":33,"context_line":"        self.keypair, self.keypair_name \u003d self.assign_keypair()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def launch_stack(self):"},{"line_number":36,"context_line":"        net \u003d self._get_default_network()"},{"line_number":37,"context_line":"        self.parameters \u003d {"},{"line_number":38,"context_line":"            \u0027key_name\u0027: self.keypair_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ca7d88e9","line":35,"updated":"2014-07-09 12:29:36.000000000","message":"can\u0027t this be moved to manager as well?","commit_id":"ce05012da2a5103c6ac3963657df5ddfd19799d3"},{"author":{"_account_id":11956,"name":"Ishant Tyagi","email":"ityagi@infoblox.com","username":"ishant"},"change_message_id":"279e54480175d69aae5b3e55f4d5c2e697e2100b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.stack_name \u003d self._stack_rand_name()"},{"line_number":33,"context_line":"        self.keypair, self.keypair_name \u003d self.assign_keypair()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def launch_stack(self):"},{"line_number":36,"context_line":"        net \u003d self._get_default_network()"},{"line_number":37,"context_line":"        self.parameters \u003d {"},{"line_number":38,"context_line":"            \u0027key_name\u0027: self.keypair_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c5a579b6","line":35,"in_reply_to":"baada198_ca7d88e9","updated":"2014-07-09 12:48:45.000000000","message":"No, these are the parameters which are test case specific.","commit_id":"ce05012da2a5103c6ac3963657df5ddfd19799d3"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a7a73301dcacfb2f9290c23eb991fcb999c462a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(CfnInitScenarioTest, self).setUp()"},{"line_number":29,"context_line":"        if not CONF.orchestration.image_ref:"},{"line_number":30,"context_line":"            raise self.skipException(\"No image available to test\")"},{"line_number":31,"context_line":"        self.template_name \u003d \u0027cfn_init_signal.yaml\u0027"},{"line_number":32,"context_line":"        self.stack_name \u003d self._stack_rand_name()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_ce9f7202","line":29,"updated":"2014-08-14 10:59:27.000000000","message":"this should go in setUpClass - skip should be decided as soon as possible","commit_id":"b4cd333ea00fb974a1df74ce0871661a13018d9e"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a7a73301dcacfb2f9290c23eb991fcb999c462a6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(CfnInitScenarioTest, self).setUp()"},{"line_number":29,"context_line":"        if not CONF.orchestration.image_ref:"},{"line_number":30,"context_line":"            raise self.skipException(\"No image available to test\")"},{"line_number":31,"context_line":"        self.template_name \u003d \u0027cfn_init_signal.yaml\u0027"},{"line_number":32,"context_line":"        self.stack_name \u003d self._stack_rand_name()"},{"line_number":33,"context_line":"        self.keypair, self.keypair_name \u003d self.assign_keypair()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_4e9362fa","line":31,"updated":"2014-08-14 10:59:27.000000000","message":"this could go in setUpClass\n\nor even better - decide on a template to match between scenario module and scenario yaml and have manger load it at runtime based on the scenario module/test running","commit_id":"b4cd333ea00fb974a1df74ce0871661a13018d9e"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a7a73301dcacfb2f9290c23eb991fcb999c462a6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        if not CONF.orchestration.image_ref:"},{"line_number":30,"context_line":"            raise self.skipException(\"No image available to test\")"},{"line_number":31,"context_line":"        self.template_name \u003d \u0027cfn_init_signal.yaml\u0027"},{"line_number":32,"context_line":"        self.stack_name \u003d self._stack_rand_name()"},{"line_number":33,"context_line":"        self.keypair, self.keypair_name \u003d self.assign_keypair()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def launch_stack(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_c1574301","line":32,"updated":"2014-08-14 10:59:27.000000000","message":"this could go in super.setUp","commit_id":"b4cd333ea00fb974a1df74ce0871661a13018d9e"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a7a73301dcacfb2f9290c23eb991fcb999c462a6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            raise self.skipException(\"No image available to test\")"},{"line_number":31,"context_line":"        self.template_name \u003d \u0027cfn_init_signal.yaml\u0027"},{"line_number":32,"context_line":"        self.stack_name \u003d self._stack_rand_name()"},{"line_number":33,"context_line":"        self.keypair, self.keypair_name \u003d self.assign_keypair()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def launch_stack(self):"},{"line_number":36,"context_line":"        net \u003d self._get_default_network()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_ee40ae58","line":33,"updated":"2014-08-14 10:59:27.000000000","message":"this could go in super.setUp()","commit_id":"b4cd333ea00fb974a1df74ce0871661a13018d9e"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a7a73301dcacfb2f9290c23eb991fcb999c462a6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.stack_name \u003d self._stack_rand_name()"},{"line_number":33,"context_line":"        self.keypair, self.keypair_name \u003d self.assign_keypair()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def launch_stack(self):"},{"line_number":36,"context_line":"        net \u003d self._get_default_network()"},{"line_number":37,"context_line":"        self.parameters \u003d {"},{"line_number":38,"context_line":"            \u0027key_name\u0027: self.keypair_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_2bc7f846","line":35,"updated":"2014-08-14 10:59:27.000000000","message":"Couldn\u0027t you set the \"test case specific\" values as arguments to this method and call it with different args/dict for each test?","commit_id":"b4cd333ea00fb974a1df74ce0871661a13018d9e"}]}