)]}'
{"tempest/api/network/admin/test_partial_specs_extension.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0f616578bb76ea7832bccb4a8107cc6ce41c04b7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                observed_network_types \u003d [x[\u0027provider:network_type\u0027]"},{"line_number":165,"context_line":"                                          for x in observed[\u0027segments\u0027]]"},{"line_number":166,"context_line":"                self.assertEqual(sorted(network_types),"},{"line_number":167,"context_line":"                                 sorted(observed_network_types))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"class PartialSpecsMultiProviderExtensionTestXML("}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_cf511a10","line":167,"updated":"2014-07-09 11:37:27.000000000","message":"Lines\n\n    self.assertNotIn(\u0027provider:network_type\u0027, observed)\n    self.assertNotIn(\u0027provider:physical_network\u0027, observed)\n    self.assertNotIn(\u0027provider:segmentation_id\u0027, observed\n    observed_network_types \u003d [x[\u0027provider:network_type\u0027]\n                              for x in observed[\u0027segments\u0027]]\n    self.assertEqual(sorted(network_types),\n\t\t\t    sorted(observed_network_types))\n\nduplicates 3 times. I suggest to move them in a separate help function.","commit_id":"c58d145b2a6dc34a0d29ef1119731d9a93fc3fb7"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"bebe9698a33715e2e9238d43a945fb2b71ae5005","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                observed_network_types \u003d [x[\u0027provider:network_type\u0027]"},{"line_number":165,"context_line":"                                          for x in observed[\u0027segments\u0027]]"},{"line_number":166,"context_line":"                self.assertEqual(sorted(network_types),"},{"line_number":167,"context_line":"                                 sorted(observed_network_types))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"class PartialSpecsMultiProviderExtensionTestXML("}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_6f2e4ea7","line":167,"in_reply_to":"baada198_cf511a10","updated":"2014-07-09 12:06:40.000000000","message":"Done","commit_id":"c58d145b2a6dc34a0d29ef1119731d9a93fc3fb7"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"90f53ac0c077378ecc0dd229f7ddef173a4913df","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def setUpClass(cls):"},{"line_number":31,"context_line":"        super(PartialSpecsProviderExtensionTestMixin, cls).setUpClass()"},{"line_number":32,"context_line":"        if not test.is_extension_enabled(\u0027provider\u0027, \u0027network\u0027):"},{"line_number":33,"context_line":"            msg \u003d \"provider extension not enabled.\""},{"line_number":34,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_fcdb4f4b","line":31,"updated":"2014-08-04 10:49:22.000000000","message":"duplication. see comments on previous patches in branch","commit_id":"0fd211b69454f35da1778f6d9d96c01027899404"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"90f53ac0c077378ecc0dd229f7ddef173a4913df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            msg \u003d \"provider extension not enabled.\""},{"line_number":34,"context_line":"            raise cls.skipException(msg)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        scenario \u003d CONF.network.partial_specs_network_scenario"},{"line_number":37,"context_line":"        if cls.NETWORK_TYPE not in scenario:"},{"line_number":38,"context_line":"            msg \u003d \"%s partial specs provider network support not enabled.\""},{"line_number":39,"context_line":"            raise cls.skipException(msg % cls.NETWORK_TYPE)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_7cbe5fcf","line":36,"updated":"2014-08-04 10:49:22.000000000","message":"please avoid the word \"scenario\" it could create confusion since it\u0027s a frequently used word in other context in Tempest tree","commit_id":"0fd211b69454f35da1778f6d9d96c01027899404"}],"tempest/config.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"90f53ac0c077378ecc0dd229f7ddef173a4913df","unresolved":false,"context_lines":[{"line_number":446,"context_line":"             \"0 segment (no test), \""},{"line_number":447,"context_line":"             \"1 segment (test mono-segment network), \""},{"line_number":448,"context_line":"             \"2+ segments (test mono/multi-segment network).\"),"},{"line_number":449,"context_line":"    cfg.ListOpt("},{"line_number":450,"context_line":"        \u0027partial_specs_network_scenario\u0027,"},{"line_number":451,"context_line":"        default\u003d[],"},{"line_number":452,"context_line":"        help\u003d\"List segments to use in partial_specs (multi-)provider network \""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_5c719b43","line":449,"updated":"2014-08-04 10:49:22.000000000","message":"Same concerns with documentation and complication of conf.\nthis is too vague","commit_id":"0fd211b69454f35da1778f6d9d96c01027899404"}]}