)]}'
{"tempest/api/compute/admin/test_hypervisor.py":[{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"fc193047eb720f6f71b1c7d4d733ed6b951fc813","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertTrue(len(stats) \u003e 0)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @testtools.skipIf(CONF.baremetal.driver_enabled,"},{"line_number":90,"context_line":"                      \"Baremetal does not support hypervisor uptime\")"},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":92,"context_line":"    def test_get_hypervisor_uptime(self):"},{"line_number":93,"context_line":"        # Verify that GET shows the specified hypervisor uptime"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d8682224","line":90,"updated":"2014-07-08 15:16:45.000000000","message":"maybe remove this decorator and add decorator:\n\n@test.services(\u0027baremetal\u0027)","commit_id":"96ad42ef1ac0d1abc3a542e19f102355afe53897"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"83d8fbaefd66718224a43186c02008ab9571db2b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertTrue(len(stats) \u003e 0)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @testtools.skipIf(CONF.baremetal.driver_enabled,"},{"line_number":90,"context_line":"                      \"Baremetal does not support hypervisor uptime\")"},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":92,"context_line":"    def test_get_hypervisor_uptime(self):"},{"line_number":93,"context_line":"        # Verify that GET shows the specified hypervisor uptime"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cf62faac","line":90,"in_reply_to":"baada198_291c72c1","updated":"2014-07-09 11:45:14.000000000","message":"Decorator @test.services() implemented in:\nhttps://github.com/openstack/tempest/blob/master/tempest/test.py#L92\n\nThis decorator with argument \"baremetal\" is to skip test, if config CONF.service_available.ironic\u003dFalse.","commit_id":"96ad42ef1ac0d1abc3a542e19f102355afe53897"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"a25e4bb862da1925c8afd5fcd990aed9554d48b6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertTrue(len(stats) \u003e 0)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @testtools.skipIf(CONF.baremetal.driver_enabled,"},{"line_number":90,"context_line":"                      \"Baremetal does not support hypervisor uptime\")"},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":92,"context_line":"    def test_get_hypervisor_uptime(self):"},{"line_number":93,"context_line":"        # Verify that GET shows the specified hypervisor uptime"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e008ab2a","line":90,"in_reply_to":"baada198_6592edf7","updated":"2014-07-09 12:57:59.000000000","message":"alright","commit_id":"96ad42ef1ac0d1abc3a542e19f102355afe53897"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b52375a81975c9eebfffb6696590b5fb4906afe9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertTrue(len(stats) \u003e 0)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @testtools.skipIf(CONF.baremetal.driver_enabled,"},{"line_number":90,"context_line":"                      \"Baremetal does not support hypervisor uptime\")"},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":92,"context_line":"    def test_get_hypervisor_uptime(self):"},{"line_number":93,"context_line":"        # Verify that GET shows the specified hypervisor uptime"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6592edf7","line":90,"in_reply_to":"baada198_cf62faac","updated":"2014-07-09 12:53:31.000000000","message":"Vadim, that\u0027s the opposite of what we want. This test should be skipped only when baremetal/ironic is enabled.","commit_id":"96ad42ef1ac0d1abc3a542e19f102355afe53897"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"ea3c26a55b88aff819d8d4cefe40c25f477dbb9d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertTrue(len(stats) \u003e 0)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @testtools.skipIf(CONF.baremetal.driver_enabled,"},{"line_number":90,"context_line":"                      \"Baremetal does not support hypervisor uptime\")"},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":92,"context_line":"    def test_get_hypervisor_uptime(self):"},{"line_number":93,"context_line":"        # Verify that GET shows the specified hypervisor uptime"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_291c72c1","line":90,"in_reply_to":"baada198_d8682224","updated":"2014-07-08 16:26:00.000000000","message":"I don\u0027t understand your suggestion. I don\u0027t see how using the @services decorator skips the test, it just marks which services are being tested, right?","commit_id":"96ad42ef1ac0d1abc3a542e19f102355afe53897"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8eff21b953b040657d1493d113ec8470bc0d4b6e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertTrue(len(stats) \u003e 0)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @testtools.skipIf(CONF.baremetal.driver_enabled,"},{"line_number":90,"context_line":"                      \"Baremetal does not support hypervisor uptime\")"},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":92,"context_line":"    def test_get_hypervisor_uptime(self):"},{"line_number":93,"context_line":"        # Verify that GET shows the specified hypervisor uptime"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cb92a04a","line":90,"updated":"2014-07-11 02:39:50.000000000","message":"If the target environment consists of multiple type hypervisors(qemu/kvm, ironic, etc), we need to check get_hypervisor_uptime for qemu/kvm.\n\nSo how about adding \"hypervisor_type\" check before line 101 for skipping ironic?","commit_id":"a8882db37b69b7cba2cfa06a34b8cfebe98a2749"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"d0099f30a1a1c4d14dc0998c882bd6f863f16c15","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertTrue(len(stats) \u003e 0)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @testtools.skipIf(CONF.baremetal.driver_enabled,"},{"line_number":90,"context_line":"                      \"Baremetal does not support hypervisor uptime\")"},{"line_number":91,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":92,"context_line":"    def test_get_hypervisor_uptime(self):"},{"line_number":93,"context_line":"        # Verify that GET shows the specified hypervisor uptime"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_93392bf5","line":90,"in_reply_to":"baada198_cb92a04a","updated":"2014-07-15 21:51:34.000000000","message":"Done","commit_id":"a8882db37b69b7cba2cfa06a34b8cfebe98a2749"}]}
