)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"8195ce3c5fe22eb224a93a1628dfae7205aa4c48","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added a common get_region in auth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Consumers glance and swift object store"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I07df17d03aaac24a101282bd2eba884e490eb495"},{"line_number":12,"context_line":"Closes-Bug: #1339733"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_e1a2d195","line":9,"updated":"2014-08-11 16:48:01.000000000","message":"We should put more information about this change. Mention why glance and swift use this function. I know it\u0027s in the bug report but the commit message should still have some information.","commit_id":"ad7b60fe23dc61c5381f02329e7ebd8b0ea2a769"}],"tempest/auth.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"72d118c1fd6ed110ac4bc6e730b3c22166e1476e","unresolved":false,"context_lines":[{"line_number":714,"context_line":""},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"def get_region(service):"},{"line_number":717,"context_line":"    \"\"\""},{"line_number":718,"context_line":"    Returns the region for a specific service"},{"line_number":719,"context_line":"    \"\"\""},{"line_number":720,"context_line":"    service_region \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_401797ef","line":717,"updated":"2014-08-13 14:08:53.000000000","message":"maybe i misunderstand how tempest code works but it seems that you have the exact same function already availble in rest_client :\n\nhttps://github.com/openstack/tempest/blob/master/tempest/common/rest_client.py#L105\n\nwhy not using that? \n\nand I don\u0027t think I like having to do introspection to find the region configuration but I guess it\u0027s done like this for a reason","commit_id":"9fbe61efc23d1f47f5842ef23608fbb4e82eeb29"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"150f44d4e4d35825c2f12c7ba269a2e577a00ce8","unresolved":false,"context_lines":[{"line_number":714,"context_line":""},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"def get_region(service):"},{"line_number":717,"context_line":"    \"\"\""},{"line_number":718,"context_line":"    Returns the region for a specific service"},{"line_number":719,"context_line":"    \"\"\""},{"line_number":720,"context_line":"    service_region \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_8f9d5b5b","line":717,"in_reply_to":"baada198_401797ef","updated":"2014-08-13 15:20:57.000000000","message":"So used the same function from rest_client.py. The recommendation from previous reviewers was to move this to a common location so that both rest_clients and scenarios clients can consume it.\n\nSee https://review.openstack.org/#/c/102827/3/tempest/clients.py\n\nThe current fix added the same function in auth namespace and patched the scenario client to use this.","commit_id":"9fbe61efc23d1f47f5842ef23608fbb4e82eeb29"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"507e1781f0a28510ccc5fd3a5e2710f00c73fde0","unresolved":false,"context_lines":[{"line_number":714,"context_line":""},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"def get_region(service):"},{"line_number":717,"context_line":"    \"\"\""},{"line_number":718,"context_line":"    Returns the region for a specific service"},{"line_number":719,"context_line":"    \"\"\""},{"line_number":720,"context_line":"    service_region \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_00b5b0ed","line":717,"in_reply_to":"baada198_8f9d5b5b","updated":"2014-08-18 15:09:27.000000000","message":"Prashanth, I see you tried to implement Andrea Frittoli\u0027s comment and that\u0027s good. \n\nWe want to avoid code duplication, so you also have to change tempest/common/rest_client.py to remove \"def get_region\" there and use the get_region() you introduced in tempest/auth.py.\n\nAlso, I am not sure tempest/auth.py is the best place to put the common get_region() but I have no better option :)","commit_id":"9fbe61efc23d1f47f5842ef23608fbb4e82eeb29"}]}