)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"ca730209f141bac1a2c995c28f390811e42d7df0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Shnaidman \u003csshnaidm@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-10 09:43:41 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_450db48f","line":7,"updated":"2014-07-10 15:52:48.000000000","message":"Could you please provide a more detailed commit message [1] and link a bug?\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"a5b3a06b23c57815c2f8bcff7d6a3ecf624417df"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"46f30a23b9bb1e066841c783a0369be65175edbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Shnaidman \u003csshnaidm@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-10 09:43:41 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_06165fa7","line":7,"in_reply_to":"baada198_450db48f","updated":"2014-07-10 20:07:51.000000000","message":"Done","commit_id":"a5b3a06b23c57815c2f8bcff7d6a3ecf624417df"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"852f6f034bdd42b0dd68049b6c666edbb30874d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Shnaidman \u003csshnaidm@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-10 09:43:41 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_506f30c5","line":7,"in_reply_to":"baada198_450db48f","updated":"2014-07-10 15:59:09.000000000","message":"I agree the commit message could be more detailed.\n\nBut there\u0027s no bug here, i am not sure a bug report is required. It would just fill launchpad more.","commit_id":"a5b3a06b23c57815c2f8bcff7d6a3ecf624417df"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"46f30a23b9bb1e066841c783a0369be65175edbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Shnaidman \u003csshnaidm@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-10 09:43:41 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_e6124bb3","line":7,"in_reply_to":"baada198_506f30c5","updated":"2014-07-10 20:07:51.000000000","message":"Done","commit_id":"a5b3a06b23c57815c2f8bcff7d6a3ecf624417df"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"acb5cf4a3c42e70c9ecf860cdfe76e02dadc9572","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Shnaidman \u003csshnaidm@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-10 09:43:41 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_d0f180ce","line":7,"in_reply_to":"baada198_506f30c5","updated":"2014-07-10 16:04:21.000000000","message":"The latter may be not obligatory in this case IMO, but it is a common practice to provide a link either to a bp or a bug for a change as a proof that it was made for a reason.","commit_id":"a5b3a06b23c57815c2f8bcff7d6a3ecf624417df"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"46f30a23b9bb1e066841c783a0369be65175edbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Shnaidman \u003csshnaidm@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-10 09:43:41 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_c64467b9","line":7,"in_reply_to":"baada198_d0f180ce","updated":"2014-07-10 20:07:51.000000000","message":"It\u0027s too much obvious to fill a bug. I expanded a little the commit message.","commit_id":"a5b3a06b23c57815c2f8bcff7d6a3ecf624417df"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c5fb7936ccf2236e2793613433e820c9b0d02d0d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If openstack doesn\u0027t have Swift installation this role assign is unnecessary and cause bugs and fails for other tests."},{"line_number":10,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_f87c9874","line":9,"updated":"2014-07-11 01:43:32.000000000","message":"better to put a new line after \"unnecessary\" for the commit log readability.","commit_id":"9a621e4027931adbf0d79d3e919b8e6366cd9786"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4b236628c6918480eb23218d45a0d2e7d5cd58a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If openstack doesn\u0027t have Swift installation this role assign is unnecessary and cause bugs and fails for other tests."},{"line_number":10,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_5a62d4d8","line":9,"updated":"2014-07-11 06:15:51.000000000","message":"Same comment as given by Ken\u0027ichi.\n\nCommit msg subsequent line should be wrapped in 72 char.\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ad0e6e2cd3a802abbd283a9fa3f761cbd970e159"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"fd853374268dc6eaee40460a0f07cc258f001eea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t use swift roles when no swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If openstack doesn\u0027t have Swift installation this role assign is unnecessary and cause bugs and fails for other tests."},{"line_number":10,"context_line":"Change-Id: If3bbc49cde6144e883daaf77b8f551a0562c84c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_7ab4f834","line":9,"in_reply_to":"baada198_5a62d4d8","updated":"2014-07-11 06:21:21.000000000","message":"Done","commit_id":"ad0e6e2cd3a802abbd283a9fa3f761cbd970e159"}],"tempest/common/isolated_creds.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c5fb7936ccf2236e2793613433e820c9b0d02d0d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        email \u003d data_utils.rand_name(root) + suffix + \"@example.com\""},{"line_number":161,"context_line":"        user \u003d self._create_user(username, self.password,"},{"line_number":162,"context_line":"                                 tenant, email)"},{"line_number":163,"context_line":"        # NOTE(andrey-mp): user needs this role to create containers in swift"},{"line_number":164,"context_line":"        if CONF.service_available.swift:"},{"line_number":165,"context_line":"            swift_operator_role \u003d CONF.object_storage.operator_role"},{"line_number":166,"context_line":"            self._assign_user_role(tenant, user, swift_operator_role)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d89ef4b7","line":163,"updated":"2014-07-11 01:43:32.000000000","message":"This NOTE message is necessary to be moved to line 165.","commit_id":"9a621e4027931adbf0d79d3e919b8e6366cd9786"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0bd066bd41cef7c1af117fa46e50fa84839a08e2","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        email \u003d data_utils.rand_name(root) + suffix + \"@example.com\""},{"line_number":161,"context_line":"        user \u003d self._create_user(username, self.password,"},{"line_number":162,"context_line":"                                 tenant, email)"},{"line_number":163,"context_line":"        # NOTE(andrey-mp): user needs this role to create containers in swift"},{"line_number":164,"context_line":"        if CONF.service_available.swift:"},{"line_number":165,"context_line":"            swift_operator_role \u003d CONF.object_storage.operator_role"},{"line_number":166,"context_line":"            self._assign_user_role(tenant, user, swift_operator_role)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_5f2006f7","line":163,"in_reply_to":"baada198_d89ef4b7","updated":"2014-07-11 05:59:36.000000000","message":"Done","commit_id":"9a621e4027931adbf0d79d3e919b8e6366cd9786"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4b797f798b7a27af36c64588dbc94b53133c7f19","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        user \u003d self._create_user(username, self.password,"},{"line_number":162,"context_line":"                                 tenant, email)"},{"line_number":163,"context_line":"        if CONF.service_available.swift:"},{"line_number":164,"context_line":"        # NOTE(andrey-mp): user needs this role to create containers in swift"},{"line_number":165,"context_line":"            swift_operator_role \u003d CONF.object_storage.operator_role"},{"line_number":166,"context_line":"            self._assign_user_role(tenant, user, swift_operator_role)"},{"line_number":167,"context_line":"        if admin:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_7a6798b7","line":164,"updated":"2014-07-11 06:27:28.000000000","message":"4 spaces are necessary at line 164.\nCurrent code is against E112 rule like:\n\n./tempest/common/isolated_creds.py:164:9: E112 expected an indented block\n        # NOTE(andrey-mp): user needs this role to create containers in swift","commit_id":"46c9f7ff7ebbfa1829a64bebacf670a5b2ab236c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"49105abede1e76c584fd8e00016dfa8527a404bd","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        user \u003d self._create_user(username, self.password,"},{"line_number":162,"context_line":"                                 tenant, email)"},{"line_number":163,"context_line":"        if CONF.service_available.swift:"},{"line_number":164,"context_line":"        # NOTE(andrey-mp): user needs this role to create containers in swift"},{"line_number":165,"context_line":"            swift_operator_role \u003d CONF.object_storage.operator_role"},{"line_number":166,"context_line":"            self._assign_user_role(tenant, user, swift_operator_role)"},{"line_number":167,"context_line":"        if admin:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_7a44f8b6","line":164,"in_reply_to":"baada198_7a6798b7","updated":"2014-07-11 06:40:32.000000000","message":"Done","commit_id":"46c9f7ff7ebbfa1829a64bebacf670a5b2ab236c"}]}