)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"b3dd7fed1e85590c2a7328a751a662d5e8477125","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Basic networks Scenario Test Enhancements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to update router admin_state_up attribute of the router"},{"line_number":10,"context_line":"-Update admin_state_up attribute of router to False  and the check public connectivity"},{"line_number":11,"context_line":"-Update admin_state_up attribute of router back to True  and check public connectivity again"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fd56c44411ff6919e15dd1033f6c13e58271f4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_be6e132d","line":10,"updated":"2014-07-15 10:42:58.000000000","message":"I\u0027m sorry that I did not look here in first time. Agree with Jordan, move please \u0027the check\u0027 to \u0027check\u0027 and remove double space \u0027False  and\u0027.","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3f734b6a65623dbcb9a6cc2aba1cb61e7eef6f78","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Basic networks Scenario Test Enhancements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to update router admin_state_up attribute of the router"},{"line_number":10,"context_line":"-Update admin_state_up attribute of router to False  and the check public connectivity"},{"line_number":11,"context_line":"-Update admin_state_up attribute of router back to True  and check public connectivity again"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fd56c44411ff6919e15dd1033f6c13e58271f4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_f8ab42d3","line":10,"updated":"2014-07-15 10:02:21.000000000","message":"s/the//","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"3cb2bcb9ad854b8016ecc609b1ab2bff64a2acc6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Basic networks Scenario Test Enhancements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to update router admin_state_up attribute of the router"},{"line_number":10,"context_line":"-Update admin_state_up attribute of router to False  and the check public connectivity"},{"line_number":11,"context_line":"-Update admin_state_up attribute of router back to True  and check public connectivity again"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fd56c44411ff6919e15dd1033f6c13e58271f4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_18138f01","line":10,"in_reply_to":"baada198_be6e132d","updated":"2014-07-15 12:59:23.000000000","message":"Done","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"3cb2bcb9ad854b8016ecc609b1ab2bff64a2acc6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Basic networks Scenario Test Enhancements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to update router admin_state_up attribute of the router"},{"line_number":10,"context_line":"-Update admin_state_up attribute of router to False  and the check public connectivity"},{"line_number":11,"context_line":"-Update admin_state_up attribute of router back to True  and check public connectivity again"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fd56c44411ff6919e15dd1033f6c13e58271f4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_f817bbeb","line":10,"in_reply_to":"baada198_f8ab42d3","updated":"2014-07-15 12:59:23.000000000","message":"Done","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"b3dd7fed1e85590c2a7328a751a662d5e8477125","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to update router admin_state_up attribute of the router"},{"line_number":10,"context_line":"-Update admin_state_up attribute of router to False  and the check public connectivity"},{"line_number":11,"context_line":"-Update admin_state_up attribute of router back to True  and check public connectivity again"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fd56c44411ff6919e15dd1033f6c13e58271f4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_dec66748","line":11,"updated":"2014-07-15 10:42:58.000000000","message":"ditto(double space)","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"3cb2bcb9ad854b8016ecc609b1ab2bff64a2acc6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to update router admin_state_up attribute of the router"},{"line_number":10,"context_line":"-Update admin_state_up attribute of router to False  and the check public connectivity"},{"line_number":11,"context_line":"-Update admin_state_up attribute of router back to True  and check public connectivity again"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fd56c44411ff6919e15dd1033f6c13e58271f4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_38d5b31b","line":11,"in_reply_to":"baada198_dec66748","updated":"2014-07-15 12:59:23.000000000","message":"Done","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0bc19162ef9eb58a144dbb5ff11acb3bd6f9b38f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to update router admin_state_up attribute of the router"},{"line_number":10,"context_line":"-Update admin_state_up attribute of router to False and check public connectivity"},{"line_number":11,"context_line":"-Update admin_state_up attribute of router back to True and check public connectivity again"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fd56c44411ff6919e15dd1033f6c13e58271f4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a890539_33c91ead","line":11,"updated":"2014-11-28 11:21:42.000000000","message":"Line too long should be under 72 chars. https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"51c937493fda85f728b921b98de763467dc0b5de"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"30b2b417c389e4af2f929d260ebde45b07a63b6d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to update router admin_state_up attribute of the router"},{"line_number":10,"context_line":"-Update admin_state_up attribute of router to False and check public connectivity"},{"line_number":11,"context_line":"-Update admin_state_up attribute of router back to True and check public connectivity again"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fd56c44411ff6919e15dd1033f6c13e58271f4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a890539_94b993ee","line":11,"in_reply_to":"5a890539_33c91ead","updated":"2014-12-02 11:24:30.000000000","message":"Done","commit_id":"51c937493fda85f728b921b98de763467dc0b5de"}],"tempest/scenario/manager.py":[{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"8312d1a32a8887f6a063c50d8b3f3435baa47d38","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        return router"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    def _update_router_admin_state(self, router_id, admin_state_up):"},{"line_number":1269,"context_line":"        body \u003d dict("},{"line_number":1270,"context_line":"            router\u003ddict("},{"line_number":1271,"context_line":"                admin_state_up\u003dadmin_state_up,"},{"line_number":1272,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_70220d53","line":1269,"updated":"2014-07-14 14:16:55.000000000","message":"Why are you doing this using \u0027dict\u0027?\n\nThis design can be simpler:\n\nbody \u003d {\u0027router\u0027:{\u0027admin_state_up\u0027:admin_state_up}}","commit_id":"33fe1e9540085d17f12296a98f5558aeb6d8d015"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"da625d7c2a38a4d6e613373561b080dcd82923ae","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        return router"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    def _update_router_admin_state(self, router_id, admin_state_up):"},{"line_number":1269,"context_line":"        body \u003d dict("},{"line_number":1270,"context_line":"            router\u003ddict("},{"line_number":1271,"context_line":"                admin_state_up\u003dadmin_state_up,"},{"line_number":1272,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_abac3aee","line":1269,"in_reply_to":"baada198_70220d53","updated":"2014-07-14 14:35:05.000000000","message":"Even though both ways are quite redable, I\u0027d agree with Vadim that the literal syntax ({}) is preferable to using the name of the class (dict), because the the former is faster [1].\n\nhttp://doughellmann.com/2012/11/12/the-performance-impact-of-using-dict-instead-of-in-cpython-2-7-2.html","commit_id":"33fe1e9540085d17f12296a98f5558aeb6d8d015"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"99632326408650f56cd05983a72c2b3ccf2a0ed2","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        return router"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    def _update_router_admin_state(self, router_id, admin_state_up):"},{"line_number":1269,"context_line":"        body \u003d dict("},{"line_number":1270,"context_line":"            router\u003ddict("},{"line_number":1271,"context_line":"                admin_state_up\u003dadmin_state_up,"},{"line_number":1272,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3c9307a4","line":1269,"in_reply_to":"baada198_70220d53","updated":"2014-07-14 18:46:13.000000000","message":"Thanks Vadim  for  review comment ,  I have  updated the the  code as per your comment.","commit_id":"33fe1e9540085d17f12296a98f5558aeb6d8d015"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"99632326408650f56cd05983a72c2b3ccf2a0ed2","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        return router"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    def _update_router_admin_state(self, router_id, admin_state_up):"},{"line_number":1269,"context_line":"        body \u003d dict("},{"line_number":1270,"context_line":"            router\u003ddict("},{"line_number":1271,"context_line":"                admin_state_up\u003dadmin_state_up,"},{"line_number":1272,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_5ce51b36","line":1269,"in_reply_to":"baada198_abac3aee","updated":"2014-07-14 18:46:13.000000000","message":"Done","commit_id":"33fe1e9540085d17f12296a98f5558aeb6d8d015"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"72888fbe8249c0de995ab3a85305e0197f8cfe7a","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"        self.addCleanup(self.delete_wrapper, router)"},{"line_number":1266,"context_line":"        return router"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    def _update_router_admin_state(self, router_id, admin_state_up):"},{"line_number":1269,"context_line":"        body \u003d {\u0027router\u0027: {\u0027admin_state_up\u0027: admin_state_up}}"},{"line_number":1270,"context_line":"        router \u003d self.network_client.update_router(router_id, body)"},{"line_number":1271,"context_line":"        self.assertEqual(admin_state_up, router[\u0027router\u0027][\u0027admin_state_up\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_93abe888","line":1268,"updated":"2014-08-14 09:19:36.000000000","message":"could this be added to DeleteableRouter instead?","commit_id":"a52e81fc49d7b9b40a92b8d3464bf73110b1f9db"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"cf14804ed0f564c4eef0551eabe8a800c88c733f","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"        self.addCleanup(self.delete_wrapper, router)"},{"line_number":1266,"context_line":"        return router"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    def _update_router_admin_state(self, router_id, admin_state_up):"},{"line_number":1269,"context_line":"        body \u003d {\u0027router\u0027: {\u0027admin_state_up\u0027: admin_state_up}}"},{"line_number":1270,"context_line":"        router \u003d self.network_client.update_router(router_id, body)"},{"line_number":1271,"context_line":"        self.assertEqual(admin_state_up, router[\u0027router\u0027][\u0027admin_state_up\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_d676ec05","line":1268,"in_reply_to":"7ac7a964_93abe888","updated":"2014-11-20 15:16:40.000000000","message":"I have updated update_router_admin_state(self, router_id, admin_state_up) to make  use of DeletableRouter.","commit_id":"a52e81fc49d7b9b40a92b8d3464bf73110b1f9db"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"1ee4cd3a4567af3d07dbb9dd13a051e29ead23a0","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"        self.addCleanup(self.delete_wrapper, router)"},{"line_number":1266,"context_line":"        return router"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    def _update_router_admin_state(self, router_id, admin_state_up):"},{"line_number":1269,"context_line":"        body \u003d {\u0027router\u0027: {\u0027admin_state_up\u0027: admin_state_up}}"},{"line_number":1270,"context_line":"        router \u003d self.network_client.update_router(router_id, body)"},{"line_number":1271,"context_line":"        self.assertEqual(admin_state_up, router[\u0027router\u0027][\u0027admin_state_up\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_a72b2781","line":1268,"in_reply_to":"7ac7a964_93abe888","updated":"2014-09-01 06:48:50.000000000","message":"Thanks  Yair Fried\t, for  reviewing the   test.\nI\u0027ll  rebase my test   with  https://review.openstack.org/#/c/111719/  \n\nand  submit a new patch.","commit_id":"a52e81fc49d7b9b40a92b8d3464bf73110b1f9db"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"c1b56ff67b8006298ad56d73d04c58170b713cca","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        return router"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    def _update_router_admin_state(self, router, admin_state_up):"},{"line_number":973,"context_line":"        router.update(admin_state_up\u003dadmin_state_up)"},{"line_number":974,"context_line":"        self.assertEqual(admin_state_up, router.admin_state_up)"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    def create_networks(self, client\u003dNone, tenant_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_a1b9fd2f","line":973,"updated":"2014-11-21 05:39:21.000000000","message":"this assumes that the status change is immediate.\nI think you should add a waiter for the change to go through","commit_id":"7243761f944c1f61c356080d0d2624fca55f46b5"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"fef72f4b45be799e8e3741ff8ccd98528117ab67","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        return router"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    def _update_router_admin_state(self, router, admin_state_up):"},{"line_number":973,"context_line":"        router.update(admin_state_up\u003dadmin_state_up)"},{"line_number":974,"context_line":"        self.assertEqual(admin_state_up, router.admin_state_up)"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    def create_networks(self, client\u003dNone, tenant_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_01d73124","line":973,"in_reply_to":"5a890539_a1b9fd2f","updated":"2014-11-21 05:56:31.000000000","message":"Since  this  method  is  expecting REST update  to be successful . \namin_state_up attribute should be updated immediately  and REST response should  have updated attribute , so  i think  waiter is not  required  in this method. \n\nHowever _check_public_network_connectivity method internally  has waiter.\n\nPlease let me  know  your thoughts  on it.","commit_id":"7243761f944c1f61c356080d0d2624fca55f46b5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"85111f819efeeeec4ba776ee31e63b7023c88904","unresolved":false,"context_lines":[{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    def _update_router_admin_state(self, router, admin_state_up):"},{"line_number":993,"context_line":"        router.update(admin_state_up\u003dadmin_state_up)"},{"line_number":994,"context_line":"        self.assertEqual(admin_state_up, router.admin_state_up)"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    def create_networks(self, client\u003dNone, tenant_id\u003dNone):"},{"line_number":997,"context_line":"        \"\"\"Create a network with a subnet connected to a router."}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_02289ce0","line":994,"updated":"2014-11-25 21:15:11.000000000","message":"this check is rather pedant but I guess is consistent with the other methods in this class","commit_id":"003c4d9a40390121e17b683ed8d0b82017eadf22"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e84d96cd57c83ff70e49a77288d4809194c5da6f","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        return router"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    def _update_router_admin_state(self, router, admin_state_up):"},{"line_number":993,"context_line":"        router.update(admin_state_up\u003dadmin_state_up)"},{"line_number":994,"context_line":"        self.assertEqual(admin_state_up, router.admin_state_up)"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    def create_networks(self, client\u003dNone, tenant_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_6764b449","line":993,"updated":"2014-12-09 11:23:05.000000000","message":"would like to see some doc string for this method. But m ok to update those later.","commit_id":"6384bbba9cc01827cc0c5ac4bc57078d38ef6d49"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"d14054ef5496d682c4db309298e09d13adea7a65","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        return router"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    def _update_router_admin_state(self, router, admin_state_up):"},{"line_number":993,"context_line":"        router.update(admin_state_up\u003dadmin_state_up)"},{"line_number":994,"context_line":"        self.assertEqual(admin_state_up, router.admin_state_up)"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    def create_networks(self, client\u003dNone, tenant_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_0aba1723","line":993,"in_reply_to":"3a961159_6764b449","updated":"2014-12-09 11:37:56.000000000","message":"Thanks Ghanshyam  for  reviewing  and approving the test, i\u0027ll submit a new review  for this.","commit_id":"6384bbba9cc01827cc0c5ac4bc57078d38ef6d49"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"40c74204689813236e2d69efbb6b9a00c1abad08","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        self._update_router_admin_state(self.router.id, False)"},{"line_number":384,"context_line":"        self._check_public_network_connectivity(should_connect\u003dFalse,"},{"line_number":385,"context_line":"                                  msg\u003d\"after updating \""},{"line_number":386,"context_line":"                                  \"admin_state_state of router to False \")"},{"line_number":387,"context_line":"        self._update_router_admin_state(self.router.id, True)"},{"line_number":388,"context_line":"        self._check_public_network_connectivity(should_connect\u003dTrue,"},{"line_number":389,"context_line":"                                   msg\u003d\"after updating \""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ac28e233","line":386,"updated":"2014-07-14 08:10:41.000000000","message":"It seems that vmware job fails here because the ip is still reachable even after updating router_admin_state to False.","commit_id":"33fe1e9540085d17f12296a98f5558aeb6d8d015"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"2637e19569a2818789cde526ce6f4033ac9f7693","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        self._update_router_admin_state(self.router.id, False)"},{"line_number":384,"context_line":"        self._check_public_network_connectivity(should_connect\u003dFalse,"},{"line_number":385,"context_line":"                                  msg\u003d\"after updating \""},{"line_number":386,"context_line":"                                  \"admin_state_state of router to False \")"},{"line_number":387,"context_line":"        self._update_router_admin_state(self.router.id, True)"},{"line_number":388,"context_line":"        self._check_public_network_connectivity(should_connect\u003dTrue,"},{"line_number":389,"context_line":"                                   msg\u003d\"after updating \""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_76a05090","line":386,"in_reply_to":"baada198_ac28e233","updated":"2014-07-14 10:30:35.000000000","message":"Thanks Elena for  reviewing  the test , I have looked into VMware job  failure log , in  VMware   Floating  IP  remains  reachable  even after  admin_state_up  of  router is  set to False .\nIt works  in ML2  and OVS  plugin .\n\nI have raised  defect  in NSX for this issue\n\nhttps://bugs.launchpad.net/neutron/+bug/1341332","commit_id":"33fe1e9540085d17f12296a98f5558aeb6d8d015"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3f734b6a65623dbcb9a6cc2aba1cb61e7eef6f78","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    def test_update_router_admin_state(self):"},{"line_number":370,"context_line":"        \"\"\""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        1. Check public coneectivity before updating"},{"line_number":373,"context_line":"                router_admin_state to False"},{"line_number":374,"context_line":"        2. Check public connectivity after updating"},{"line_number":375,"context_line":"                router_admin_state  of router to False"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_589d0ebb","line":372,"updated":"2014-07-15 10:02:21.000000000","message":"connectivity","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"3cb2bcb9ad854b8016ecc609b1ab2bff64a2acc6","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    def test_update_router_admin_state(self):"},{"line_number":370,"context_line":"        \"\"\""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        1. Check public coneectivity before updating"},{"line_number":373,"context_line":"                router_admin_state to False"},{"line_number":374,"context_line":"        2. Check public connectivity after updating"},{"line_number":375,"context_line":"                router_admin_state  of router to False"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_98831f02","line":372,"in_reply_to":"baada198_589d0ebb","updated":"2014-07-15 12:59:23.000000000","message":"Done","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"b3dd7fed1e85590c2a7328a751a662d5e8477125","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        2. Check public connectivity after updating"},{"line_number":375,"context_line":"                router_admin_state  of router to False"},{"line_number":376,"context_line":"        3. Check public connectivity after updating"},{"line_number":377,"context_line":"                router_admin_state  of router to  True"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        \"\"\""},{"line_number":380,"context_line":"        self._check_public_network_connectivity(should_connect\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_3ef04366","line":377,"updated":"2014-07-15 10:42:58.000000000","message":"ditto(double spaces)","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"3cb2bcb9ad854b8016ecc609b1ab2bff64a2acc6","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        2. Check public connectivity after updating"},{"line_number":375,"context_line":"                router_admin_state  of router to False"},{"line_number":376,"context_line":"        3. Check public connectivity after updating"},{"line_number":377,"context_line":"                router_admin_state  of router to  True"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        \"\"\""},{"line_number":380,"context_line":"        self._check_public_network_connectivity(should_connect\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b87d431e","line":377,"in_reply_to":"baada198_3ef04366","updated":"2014-07-15 12:59:23.000000000","message":"Done","commit_id":"b4b01c843314f6ab9bf5076ab33b0aab2de918f1"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e8ecc1e757aa503a181278867785bcc4dfe64d27","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":369,"context_line":"    def test_update_router_admin_state(self):"},{"line_number":370,"context_line":"        \"\"\""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        1. Check public connectivity before updating"},{"line_number":373,"context_line":"                admin_state_up attribute of router to False"},{"line_number":374,"context_line":"        2. Check public connectivity after updating"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_5d923358","line":371,"updated":"2014-08-14 13:30:50.000000000","message":"Just a nit, but is a newline really needed here?","commit_id":"a52e81fc49d7b9b40a92b8d3464bf73110b1f9db"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"cf14804ed0f564c4eef0551eabe8a800c88c733f","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":369,"context_line":"    def test_update_router_admin_state(self):"},{"line_number":370,"context_line":"        \"\"\""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        1. Check public connectivity before updating"},{"line_number":373,"context_line":"                admin_state_up attribute of router to False"},{"line_number":374,"context_line":"        2. Check public connectivity after updating"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_765d3879","line":371,"in_reply_to":"7ac7a964_5d923358","updated":"2014-11-20 15:16:40.000000000","message":"Done","commit_id":"a52e81fc49d7b9b40a92b8d3464bf73110b1f9db"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"c1b56ff67b8006298ad56d73d04c58170b713cca","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(TestNetworkBasicOps, self)._check_public_network_connectivity("},{"line_number":201,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":202,"context_line":"            self.servers)"},{"line_number":203,"context_line":"        if should_check_floating_ip_status:"},{"line_number":204,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_01865165","line":203,"updated":"2014-11-21 05:39:21.000000000","message":"why disable it?","commit_id":"7243761f944c1f61c356080d0d2624fca55f46b5"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"fef72f4b45be799e8e3741ff8ccd98528117ab67","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(TestNetworkBasicOps, self)._check_public_network_connectivity("},{"line_number":201,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":202,"context_line":"            self.servers)"},{"line_number":203,"context_line":"        if should_check_floating_ip_status:"},{"line_number":204,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_8190814f","line":203,"in_reply_to":"5a890539_01865165","updated":"2014-11-21 05:56:31.000000000","message":"Since in my test I am not   dissociating floating IP from VM port , so  I  don\u0027t expect status of  floating IP  to  go  down.\nIn this  test only router_admin_state is updated , which  i think  should not  cause status of floating_ip  to go  in down state","commit_id":"7243761f944c1f61c356080d0d2624fca55f46b5"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"5b6ed939ad94a5815a46623cb13cb4718cea8d2e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(TestNetworkBasicOps, self)._check_public_network_connectivity("},{"line_number":201,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":202,"context_line":"            self.servers)"},{"line_number":203,"context_line":"        if should_check_floating_ip_status:"},{"line_number":204,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_24755bcc","line":203,"in_reply_to":"5a890539_38ff8403","updated":"2014-11-28 06:41:42.000000000","message":"If   decision is  that  Status  attribute of  \"Floating IP\"  does  not depend  on\n\nadmin_state_up  attribute  of  router ,  then  should  I  remove  reference of 1396310  ?","commit_id":"7243761f944c1f61c356080d0d2624fca55f46b5"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ef82d3d6e94cb60c89518f1213fc4ae4669d80ea","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(TestNetworkBasicOps, self)._check_public_network_connectivity("},{"line_number":201,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":202,"context_line":"            self.servers)"},{"line_number":203,"context_line":"        if should_check_floating_ip_status:"},{"line_number":204,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_c5298c9c","line":203,"in_reply_to":"5a890539_8190814f","updated":"2014-11-23 09:47:23.000000000","message":"I\u0027ve checked and it really doesn\u0027t go down. However, I\u0027m not sure if it should or shouldn\u0027t go down.\nIMO, if the router is down, the floating_ip (which constantly monitors the router) needs to go down as well.\n\n\nThis should be checked with the Neutron devs in-charge of the feature https://blueprints.launchpad.net/neutron/+spec/fip-op-status","commit_id":"7243761f944c1f61c356080d0d2624fca55f46b5"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"48d46dd8770bf2c9a5eb9b20f00482dda362c8dd","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(TestNetworkBasicOps, self)._check_public_network_connectivity("},{"line_number":201,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":202,"context_line":"            self.servers)"},{"line_number":203,"context_line":"        if should_check_floating_ip_status:"},{"line_number":204,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_57227fa3","line":203,"in_reply_to":"5a890539_c5298c9c","updated":"2014-11-25 11:23:09.000000000","message":"Added Mark McClain as a reviewer of the test ,  who  implemented \n\nhttps://blueprints.launchpad.net/neutron/+spec/fip-op-status","commit_id":"7243761f944c1f61c356080d0d2624fca55f46b5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"49be5affac2fe987c21705c958135fa8bd78b517","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        super(TestNetworkBasicOps, self)._check_public_network_connectivity("},{"line_number":201,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":202,"context_line":"            self.servers)"},{"line_number":203,"context_line":"        if should_check_floating_ip_status:"},{"line_number":204,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_38ff8403","line":203,"in_reply_to":"5a890539_c5298c9c","updated":"2014-11-26 03:03:45.000000000","message":"No! A management plane downtime should not bring down the data plane!! So there\u0027s no relationship between the two statuses, and there must not be one.\n\nHTH","commit_id":"7243761f944c1f61c356080d0d2624fca55f46b5"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"f0db8c633b5c9823f39f3d43b763bc443db5699e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        super(TestNetworkBasicOps, self).check_public_network_connectivity("},{"line_number":197,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":198,"context_line":"            self.servers)"},{"line_number":199,"context_line":"        if should_check_floating_ip_status:"},{"line_number":200,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_b96c63d1","line":199,"updated":"2014-11-25 19:26:52.000000000","message":"So it\u0027s a bug in Neutron (confirmed by :\nhttps://bugs.launchpad.net/neutron/+bug/1396310","commit_id":"60b658ad0f7c466ed3dc41c771d39628cac86ad0"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"f0db8c633b5c9823f39f3d43b763bc443db5699e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        super(TestNetworkBasicOps, self).check_public_network_connectivity("},{"line_number":197,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":198,"context_line":"            self.servers)"},{"line_number":199,"context_line":"        if should_check_floating_ip_status:"},{"line_number":200,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_39b7933b","line":199,"updated":"2014-11-25 19:26:52.000000000","message":"So, Mark confirms this is a bug in Neutron to be fixed in Kilo.\nhttps://bugs.launchpad.net/neutron/+bug/1396310\n\nI assume you wouldn\u0027t want to wait until the bug is fixed, so please add a \"todo\" comment so we know to remove this workaround once it\u0027s no longer needed.","commit_id":"60b658ad0f7c466ed3dc41c771d39628cac86ad0"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"b7ce470a0435f2cade74533f4910562481c7b11f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        super(TestNetworkBasicOps, self).check_public_network_connectivity("},{"line_number":197,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":198,"context_line":"            self.servers)"},{"line_number":199,"context_line":"        if should_check_floating_ip_status:"},{"line_number":200,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_5c98cd74","line":199,"in_reply_to":"5a890539_39b7933b","updated":"2014-11-25 19:59:57.000000000","message":"Done","commit_id":"60b658ad0f7c466ed3dc41c771d39628cac86ad0"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"b7ce470a0435f2cade74533f4910562481c7b11f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        super(TestNetworkBasicOps, self).check_public_network_connectivity("},{"line_number":197,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":198,"context_line":"            self.servers)"},{"line_number":199,"context_line":"        if should_check_floating_ip_status:"},{"line_number":200,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_5cc1ad4c","line":199,"in_reply_to":"5a890539_b96c63d1","updated":"2014-11-25 19:59:57.000000000","message":"Done","commit_id":"60b658ad0f7c466ed3dc41c771d39628cac86ad0"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"aca9170a5c0ed747ede49c36905c8b0843d66a54","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        super(TestNetworkBasicOps, self).check_public_network_connectivity("},{"line_number":197,"context_line":"            ip_address, ssh_login, private_key, should_connect, msg,"},{"line_number":198,"context_line":"            self.servers)"},{"line_number":199,"context_line":"        if should_check_floating_ip_status:"},{"line_number":200,"context_line":"            self.check_floating_ip_status(floating_ip, floatingip_status)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _disassociate_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_9ceeb520","line":199,"in_reply_to":"5a890539_b96c63d1","updated":"2014-11-25 19:53:10.000000000","message":"I\u0027ll add below comments in line no 411\n\n # TODO: Remove should_check_floating_ip_status\u003dFalse check\n # once bug 1396310 is fixed","commit_id":"60b658ad0f7c466ed3dc41c771d39628cac86ad0"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"85111f819efeeeec4ba776ee31e63b7023c88904","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        self._hotplug_server()"},{"line_number":398,"context_line":"        self._check_network_internal_connectivity(network\u003dself.new_net)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":401,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":402,"context_line":"    def test_update_router_admin_state(self):"},{"line_number":403,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_226af819","line":400,"updated":"2014-11-25 21:15:11.000000000","message":"now that the full job is enabled and voting, do we still have this \u0027smoke\u0027 requirement? I don\u0027t think so, but I know nothing about tempest","commit_id":"003c4d9a40390121e17b683ed8d0b82017eadf22"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"152040742974595207363ea5fbe27d4a676850ab","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        self._hotplug_server()"},{"line_number":398,"context_line":"        self._check_network_internal_connectivity(network\u003dself.new_net)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":401,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":402,"context_line":"    def test_update_router_admin_state(self):"},{"line_number":403,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_3b477ea4","line":400,"in_reply_to":"5a890539_226af819","updated":"2014-11-26 03:51:48.000000000","message":"Thanks Salvatore  for  reviewing the test.\n\nI am really sure ,  if  we can remove smoke  requirement.\nIf we smoke requirement is not  there anymore , probably a new review can be posted  after removing smoke requirement from all tempest  tests.","commit_id":"003c4d9a40390121e17b683ed8d0b82017eadf22"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"85111f819efeeeec4ba776ee31e63b7023c88904","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                admin_state_up attribute of router to True"},{"line_number":410,"context_line":"        \"\"\""},{"line_number":411,"context_line":"        # TODO: Remove should_check_floating_ip_status\u003dFalse check"},{"line_number":412,"context_line":"        # once bug 1396310 is fixed"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        self._setup_network_and_servers()"},{"line_number":415,"context_line":"        self.check_public_network_connectivity("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_a2cc2836","line":412,"updated":"2014-11-25 21:15:11.000000000","message":"perhaps if you move this comment to the appropriate line (418) it would be easier for reviewers and everybody else looking at your code","commit_id":"003c4d9a40390121e17b683ed8d0b82017eadf22"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"152040742974595207363ea5fbe27d4a676850ab","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                admin_state_up attribute of router to True"},{"line_number":410,"context_line":"        \"\"\""},{"line_number":411,"context_line":"        # TODO: Remove should_check_floating_ip_status\u003dFalse check"},{"line_number":412,"context_line":"        # once bug 1396310 is fixed"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        self._setup_network_and_servers()"},{"line_number":415,"context_line":"        self.check_public_network_connectivity("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_db6e7a2e","line":412,"in_reply_to":"5a890539_a2cc2836","updated":"2014-11-26 03:51:48.000000000","message":"Done","commit_id":"003c4d9a40390121e17b683ed8d0b82017eadf22"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"82d9dff750944a588a289c51abf332a420e4b029","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        2. connect VM to new network"},{"line_number":387,"context_line":"        3. set static ip and bring new nic up"},{"line_number":388,"context_line":"        4. check VM can ping new network dhcp port"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        \"\"\""},{"line_number":391,"context_line":"        self._setup_network_and_servers()"},{"line_number":392,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_66aebd82","side":"PARENT","line":389,"updated":"2014-11-26 13:16:31.000000000","message":"unrelated change","commit_id":"3653cb889a1bd0762c9b1a33b0d6d98bc493d8c4"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"30b2b417c389e4af2f929d260ebde45b07a63b6d","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        2. connect VM to new network"},{"line_number":387,"context_line":"        3. set static ip and bring new nic up"},{"line_number":388,"context_line":"        4. check VM can ping new network dhcp port"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        \"\"\""},{"line_number":391,"context_line":"        self._setup_network_and_servers()"},{"line_number":392,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_f4b657f8","side":"PARENT","line":389,"in_reply_to":"5a890539_66aebd82","updated":"2014-12-02 11:24:30.000000000","message":"Done","commit_id":"3653cb889a1bd0762c9b1a33b0d6d98bc493d8c4"}]}