)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11877,"name":"Kim Jensen","email":"kimberly.jensen@charter.com","username":"KimJ"},"change_message_id":"33a0e9cf8d34b55cd3a7af9cb97f6819d6e75644","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add base class for all credential providers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Defines the base interface of all credential providers. User of this"},{"line_number":10,"context_line":"will be the existing isoloated_cread provider and the a new user_list"},{"line_number":11,"context_line":"provider."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If382b549428c15ebb2ed850be9e0405e84226f6c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_ec46c87a","line":10,"updated":"2014-07-17 09:46:53.000000000","message":"isoloated_cread spelling?","commit_id":"2c9540b89429a3635c093c10a7dd1e06cfc1c3a2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6fc3daed5b71ed2fd420623312737c929fecddb9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add base class for all credential providers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Defines the base interface of all credential providers. User of this"},{"line_number":10,"context_line":"will be the existing isolated_cread provider and the a new user_list"},{"line_number":11,"context_line":"provider."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If382b549428c15ebb2ed850be9e0405e84226f6c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"baada198_28441e46","line":10,"updated":"2014-07-23 17:55:35.000000000","message":"I don\u0027t think you\u0027ll ever be rid of the typos in this commit msg:\n\ns/cread/cred","commit_id":"d2690fe1c32476d8dbf123fabef6d6f81482a4d5"}],"tempest/common/cred_provider.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"291fb834b73b9d8ed4637ae1534ea3a330e47f30","unresolved":false,"context_lines":[{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CredentialProvider(object):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, name, tempest_client\u003dTrue, interface\u003d\u0027json\u0027,"},{"line_number":24,"context_line":"                 password\u003d\u0027pass\u0027, network_resources\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8991e5f3","line":21,"updated":"2014-07-16 12:31:58.000000000","message":"You should use ABC for this type of class.","commit_id":"bb66437b09da7bbdfa934097131fec72ce83e306"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"291fb834b73b9d8ed4637ae1534ea3a330e47f30","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def __init__(self, name, tempest_client\u003dTrue, interface\u003d\u0027json\u0027,"},{"line_number":24,"context_line":"                 password\u003d\u0027pass\u0027, network_resources\u003dNone):"},{"line_number":25,"context_line":"        self.network_resources \u003d network_resources"},{"line_number":26,"context_line":"        self.isolated_creds \u003d {}"},{"line_number":27,"context_line":"        self.isolated_net_resources \u003d {}"},{"line_number":28,"context_line":"        self.ports \u003d []"},{"line_number":29,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c9611d13","line":26,"updated":"2014-07-16 12:31:58.000000000","message":"I think we\u0027ll need to refactor these attrs. Some of them aren\u0027t going to be used in the general cred provider case. Like the dict of isolated creds.","commit_id":"bb66437b09da7bbdfa934097131fec72ce83e306"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"d2898d7a1c288ea298ef562884d96d2f1ab0a2f7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @abc.abstractmethod"},{"line_number":43,"context_line":"    def clear_isolated_creds(self):"},{"line_number":44,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_dfdef3d9","line":43,"updated":"2014-07-23 20:00:43.000000000","message":"This class has nothing to do with isolation now. Perhaps this should be delete_creds.","commit_id":"d2690fe1c32476d8dbf123fabef6d6f81482a4d5"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a4a2a743e23fe2f21213eaa0a4e87ee5b2e2a87a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @abc.abstractmethod"},{"line_number":43,"context_line":"    def clear_isolated_creds(self):"},{"line_number":44,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_625aaef3","line":43,"in_reply_to":"baada198_dfdef3d9","updated":"2014-07-23 20:25:50.000000000","message":"The issue is backwards compatibility. clear_isolated_creds is used in all the base test classes. We thought that it was easier to just reuse the method name then rename all the uses.","commit_id":"d2690fe1c32476d8dbf123fabef6d6f81482a4d5"}]}