)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"71cada575e63b23383f279d858107053a38fcf0d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    -Create a security group rule with protocol attribute as integer value"},{"line_number":11,"context_line":"    -Validate the security rule protocol value"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"related-bug https://bugs.launchpad.net/neutron/+bug/1381379"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Icd967f8d25a55c3e0db57af8e764bfb0a3dab6f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_b40fa687","line":13,"updated":"2014-11-20 09:49:48.000000000","message":"As bug has been resolved I think this line could be removed from commit message.","commit_id":"c5106a5734c0e17750e947e7e5ef847c05b66887"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"b4655b5837ee3d6061bb6a5267db5345e0f702cc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    -Create a security group rule with protocol attribute as integer value"},{"line_number":11,"context_line":"    -Validate the security rule protocol value"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"related-bug https://bugs.launchpad.net/neutron/+bug/1381379"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Icd967f8d25a55c3e0db57af8e764bfb0a3dab6f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_7f02770a","line":13,"in_reply_to":"5a890539_b40fa687","updated":"2014-11-20 10:00:58.000000000","message":"Done","commit_id":"c5106a5734c0e17750e947e7e5ef847c05b66887"}],"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2d5e188c26990087166621a663b791adbc8b1f20","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self.assertEqual(int(sec_group_rule[\u0027port_range_max\u0027]), port_range_max)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":137,"context_line":"    def test_create_security_group_rule_with_protocol_interger_value(self):"},{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as interger value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": \"17\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b1eeb220","line":137,"updated":"2014-07-18 10:34:45.000000000","message":"s/interger/integer/","commit_id":"725aada0595f2b1437cf05f4c1921846c9213557"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3a2034efe94a88aa1ff49912965f99300abe8b36","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self.assertEqual(int(sec_group_rule[\u0027port_range_max\u0027]), port_range_max)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":137,"context_line":"    def test_create_security_group_rule_with_protocol_interger_value(self):"},{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as interger value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": \"17\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2202523e","line":137,"in_reply_to":"baada198_b1eeb220","updated":"2014-07-18 10:52:04.000000000","message":"Thanks for the review:\nEdited the text \ntest_create_security_group_rule_with_protocol_integer_value","commit_id":"725aada0595f2b1437cf05f4c1921846c9213557"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2d5e188c26990087166621a663b791adbc8b1f20","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":137,"context_line":"    def test_create_security_group_rule_with_protocol_interger_value(self):"},{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as interger value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": \"17\""},{"line_number":141,"context_line":"        group_create_body, _ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f1f4aaf2","line":139,"updated":"2014-07-18 10:34:45.000000000","message":"s/interger/integer/","commit_id":"725aada0595f2b1437cf05f4c1921846c9213557"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3a2034efe94a88aa1ff49912965f99300abe8b36","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":137,"context_line":"    def test_create_security_group_rule_with_protocol_interger_value(self):"},{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as interger value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": \"17\""},{"line_number":141,"context_line":"        group_create_body, _ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_a29582e5","line":139,"in_reply_to":"baada198_f1f4aaf2","updated":"2014-07-18 10:52:04.000000000","message":"Edited the text \nprotocol as integer value","commit_id":"725aada0595f2b1437cf05f4c1921846c9213557"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2d5e188c26990087166621a663b791adbc8b1f20","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def test_create_security_group_rule_with_protocol_interger_value(self):"},{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as interger value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": \"17\""},{"line_number":141,"context_line":"        group_create_body, _ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f1b58aed","line":140,"updated":"2014-07-18 10:34:45.000000000","message":"Comments shows us, that value for \u0027protocol\u0027 is a string value.","commit_id":"725aada0595f2b1437cf05f4c1921846c9213557"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3a2034efe94a88aa1ff49912965f99300abe8b36","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def test_create_security_group_rule_with_protocol_interger_value(self):"},{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as interger value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": \"17\""},{"line_number":141,"context_line":"        group_create_body, _ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_428666ba","line":140,"in_reply_to":"baada198_f1b58aed","updated":"2014-07-18 10:52:04.000000000","message":"Edited the text :\narguments : \"protocol\": 17","commit_id":"725aada0595f2b1437cf05f4c1921846c9213557"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2d5e188c26990087166621a663b791adbc8b1f20","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as interger value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": \"17\""},{"line_number":141,"context_line":"        group_create_body, _ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"},{"line_number":144,"context_line":"        security_group_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b1d5d244","line":141,"updated":"2014-07-18 10:34:45.000000000","message":"Please, use \"__\" instead of \"_\", because last one is used for translation function.","commit_id":"725aada0595f2b1437cf05f4c1921846c9213557"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"3a2034efe94a88aa1ff49912965f99300abe8b36","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as interger value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": \"17\""},{"line_number":141,"context_line":"        group_create_body, _ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"},{"line_number":144,"context_line":"        security_group_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_828cfed8","line":141,"in_reply_to":"baada198_b1d5d244","updated":"2014-07-18 10:52:04.000000000","message":"Used :\ngroup_create_body, __ \u003d self._create_security_group()","commit_id":"725aada0595f2b1437cf05f4c1921846c9213557"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c62d9049bbbdcbac9b0e64ab14f244c5fe5331f4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as integer value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": 17"},{"line_number":141,"context_line":"        group_create_body, __ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"},{"line_number":144,"context_line":"        security_group_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_772e2ca7","line":141,"updated":"2014-08-25 18:06:49.000000000","message":"from what i\u0027ve been told, use single underscore in tempest for throwaway variables","commit_id":"201ee2006df53870633c5a7899d639aa452cff43"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"cc250c6592b14bfd641bf19cc4e9c22024f9a5b0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # Verify creating security group rule with the"},{"line_number":139,"context_line":"        # protocol as integer value"},{"line_number":140,"context_line":"        # arguments : \"protocol\": 17"},{"line_number":141,"context_line":"        group_create_body, __ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"},{"line_number":144,"context_line":"        security_group_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_5c48c9b2","line":141,"in_reply_to":"1abeadc6_772e2ca7","updated":"2014-09-05 09:19:07.000000000","message":"Thanks for the review .\nLast time i got the comment on that. .Edited with single underscore.","commit_id":"201ee2006df53870633c5a7899d639aa452cff43"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"7a0c69c32aba1e55ea86b3eeaa4141538020d9ec","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # arguments : \"protocol\": 17"},{"line_number":141,"context_line":"        group_create_body, __ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"},{"line_number":144,"context_line":"        security_group_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":145,"context_line":"        resp, rule_create_body \u003d self.client.create_security_group_rule("},{"line_number":146,"context_line":"            security_group_id\u003dsecurity_group_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_bd6843f6","line":143,"updated":"2014-07-18 11:24:27.000000000","message":"I think this is not a valid protocol value.\n\nI used {icmp | tcp | udp | null} these only.","commit_id":"201ee2006df53870633c5a7899d639aa452cff43"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"772b3b3b4747406bb5b7f59a6df9f39854b896b9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # arguments : \"protocol\": 17"},{"line_number":141,"context_line":"        group_create_body, __ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"},{"line_number":144,"context_line":"        security_group_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":145,"context_line":"        resp, rule_create_body \u003d self.client.create_security_group_rule("},{"line_number":146,"context_line":"            security_group_id\u003dsecurity_group_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_23f5f1ec","line":143,"in_reply_to":"baada198_a8ff2000","updated":"2014-07-18 13:12:59.000000000","message":"Attaching the rest call output:\n\nREQ: curl -i http://\u003cipaddress\u003e:9696/v2.0/security-group-rules.json -X POST -H \"X-Auth-Token: 6af46c55e32b45a2b26f8da74d5854de\" -H \"Content-Type: application/json\" -H \"Accept: application/json\" -H \"User-Agent: python-neutronclient\" -d \u0027{\"security_group_rule\": {\"ethertype\": \"IPv4\", \"direction\": \"ingress\", \"protocol\": \"17\", \"security_group_id\": \"7dddf809-72e7-4fff-9a6a-373f0acc06dc\"}}\u0027\n\nDEBUG: urllib3.connectionpool \"POST /v2.0/security-group-rules.json HTTP/1.1\" 201 343\nDEBUG: neutronclient.client RESP:201 CaseInsensitiveDict({\u0027date\u0027: \u0027Fri, 18 Jul 2014 12:42:41 GMT\u0027, \u0027content-length\u0027: \u0027343\u0027, \u0027content-type\u0027: \u0027application/json; charset\u003dUTF-8\u0027, \u0027x-openstack-request-id\u0027: \u0027req-27c04669-338b-489a-88df-aa02f457caf9\u0027}) {\"security_group_rule\": {\"remote_group_id\": null, \"direction\": \"ingress\", \"remote_ip_prefix\": null, \"protocol\": \"17\", \"ethertype\": \"IPv4\", \"tenant_id\": \"fbcad83c63e84f4cace5e43f2cb3409d\", \"port_range_max\": null, \"port_range_min\": null, \"id\": \"0ff3f2ac-4fd8-4de7-93e7-5b79a1e3019b\", \"security_group_id\": \"7dddf809-72e7-4fff-9a6a-373f0acc06dc\"}}","commit_id":"201ee2006df53870633c5a7899d639aa452cff43"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"264457f69fc078317e15dd9f34612da5dff8ff6b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # arguments : \"protocol\": 17"},{"line_number":141,"context_line":"        group_create_body, __ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"},{"line_number":144,"context_line":"        security_group_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":145,"context_line":"        resp, rule_create_body \u003d self.client.create_security_group_rule("},{"line_number":146,"context_line":"            security_group_id\u003dsecurity_group_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c5c19de5","line":143,"in_reply_to":"baada198_bd6843f6","updated":"2014-07-18 12:34:21.000000000","message":"Thanks for the review :\n\nprotocol values [None, \u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027] and their integer representation (0 to 255) are supported.\n\nneutron security-group-rule-create 7dddf809-72e7-4fff-9a6a-373f0acc06dc --protocol 17 \n\nCreated a new security_group_rule:\n+-------------------+--------------------------------------+\n| Field             | Value                                |\n+-------------------+--------------------------------------+\n| direction         | ingress                              |\n| ethertype         | IPv4                                 |\n| id                | 2d0b534b-b113-444a-88bb-c7ee724080f3 |\n| port_range_max    |                                      |\n| port_range_min    |                                      |\n| protocol          | 255                                  |\n| remote_group_id   |                                      |\n| remote_ip_prefix  |                                      |\n| security_group_id | 7dddf809-72e7-4fff-9a6a-373f0acc06dc |\n| tenant_id         | fbcad83c63e84f4cace5e43f2cb3409d     |\n+-------------------+--------------------------------------+","commit_id":"201ee2006df53870633c5a7899d639aa452cff43"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a56f67d1789b3ef69957c5d42d7c115cf43e6202","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # arguments : \"protocol\": 17"},{"line_number":141,"context_line":"        group_create_body, __ \u003d self._create_security_group()"},{"line_number":142,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":143,"context_line":"        protocol \u003d 17"},{"line_number":144,"context_line":"        security_group_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":145,"context_line":"        resp, rule_create_body \u003d self.client.create_security_group_rule("},{"line_number":146,"context_line":"            security_group_id\u003dsecurity_group_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a8ff2000","line":143,"in_reply_to":"baada198_c5c19de5","updated":"2014-07-18 12:41:56.000000000","message":"This is different. Tempest tests API directly without neutronclient and neutronclient can make any changes to provided values via cli. To be sure, test API directly or see what exactly is sent by neutronclient with \u0027--debug\u0027 flag.","commit_id":"201ee2006df53870633c5a7899d639aa452cff43"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"523f59425884609409ac871362643962ed1f8ab0","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            direction\u003ddirection,"},{"line_number":148,"context_line":"            protocol\u003dprotocol"},{"line_number":149,"context_line":"        )"},{"line_number":150,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":151,"context_line":"        sec_group_rule \u003d rule_create_body[\u0027security_group_rule\u0027]"},{"line_number":152,"context_line":"        self.assertEqual(sec_group_rule[\u0027direction\u0027], direction)"},{"line_number":153,"context_line":"        self.assertEqual(int(sec_group_rule[\u0027protocol\u0027]), protocol)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_d7d08e55","line":150,"updated":"2014-08-27 11:43:09.000000000","message":"This check is not needed anymore","commit_id":"201ee2006df53870633c5a7899d639aa452cff43"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"cc250c6592b14bfd641bf19cc4e9c22024f9a5b0","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            direction\u003ddirection,"},{"line_number":148,"context_line":"            protocol\u003dprotocol"},{"line_number":149,"context_line":"        )"},{"line_number":150,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":151,"context_line":"        sec_group_rule \u003d rule_create_body[\u0027security_group_rule\u0027]"},{"line_number":152,"context_line":"        self.assertEqual(sec_group_rule[\u0027direction\u0027], direction)"},{"line_number":153,"context_line":"        self.assertEqual(int(sec_group_rule[\u0027protocol\u0027]), protocol)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_9ccdd133","line":150,"in_reply_to":"1abeadc6_d7d08e55","updated":"2014-09-05 09:19:07.000000000","message":"Thanks for the review. \nRemoved the check.","commit_id":"201ee2006df53870633c5a7899d639aa452cff43"}]}