)]}'
{"tempest/cmd/javelin.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ca5c898dd7144e4c10afbb0206c0a645a0d202d5","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        create_resources()"},{"line_number":560,"context_line":"        # Make sure the resources we just created actually work"},{"line_number":561,"context_line":"        checker \u003d JavelinCheck(USERS, RES)"},{"line_number":562,"context_line":"        checker.check()"},{"line_number":563,"context_line":"    elif OPTS.mode \u003d\u003d \u0027check\u0027:"},{"line_number":564,"context_line":"        collect_users(RES[\u0027users\u0027])"},{"line_number":565,"context_line":"        checker \u003d JavelinCheck(USERS, RES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_80512510","line":562,"updated":"2014-07-25 19:34:33.000000000","message":"If there\u0027s no wait between create and check, check is almost guaranteed to fail as the compute resources will not be ready and will not pass their pings.","commit_id":"1a09700abcf4d4b7bbfc6d33c554dce8477f788f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"206012969cbe3e5796e029b9856d8b5833253b39","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        create_resources()"},{"line_number":560,"context_line":"        # Make sure the resources we just created actually work"},{"line_number":561,"context_line":"        checker \u003d JavelinCheck(USERS, RES)"},{"line_number":562,"context_line":"        checker.check()"},{"line_number":563,"context_line":"    elif OPTS.mode \u003d\u003d \u0027check\u0027:"},{"line_number":564,"context_line":"        collect_users(RES[\u0027users\u0027])"},{"line_number":565,"context_line":"        checker \u003d JavelinCheck(USERS, RES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_c0a5dd03","line":562,"in_reply_to":"baada198_80512510","updated":"2014-07-25 19:37:03.000000000","message":"see the other patches in this series for how this is addressed.\n\ncreate_servers waits for them to go to \u0027ACTIVE\u0027 state, and the ping phase is more forgiving.\n\nI ran this code on trunk tempest with no issues.","commit_id":"1a09700abcf4d4b7bbfc6d33c554dce8477f788f"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"dae66db3bdb0fc1f3c9d98c915998fb2328f6fc5","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        create_resources()"},{"line_number":560,"context_line":"        # Make sure the resources we just created actually work"},{"line_number":561,"context_line":"        checker \u003d JavelinCheck(USERS, RES)"},{"line_number":562,"context_line":"        checker.check()"},{"line_number":563,"context_line":"    elif OPTS.mode \u003d\u003d \u0027check\u0027:"},{"line_number":564,"context_line":"        collect_users(RES[\u0027users\u0027])"},{"line_number":565,"context_line":"        checker \u003d JavelinCheck(USERS, RES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_c0e79de1","line":562,"in_reply_to":"baada198_c00f9dde","updated":"2014-07-25 19:50:51.000000000","message":"Chris, you can see the full series at: https://review.openstack.org/#/q/status:open+project:openstack/tempest+branch:master+topic:javelin,n,z\n\nthe patches are broken up into discrete logical changes, and all build on each other.\n\nAs for the ceilometer test case, I am not sure how to handle that.  IMHO javelin2  should work on devstack environment that hasn\u0027t gone through an upgrade, this makes testing much easier among other things.","commit_id":"1a09700abcf4d4b7bbfc6d33c554dce8477f788f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"cd082dde414d4c8e19fc8126a3039c610e229715","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        create_resources()"},{"line_number":560,"context_line":"        # Make sure the resources we just created actually work"},{"line_number":561,"context_line":"        checker \u003d JavelinCheck(USERS, RES)"},{"line_number":562,"context_line":"        checker.check()"},{"line_number":563,"context_line":"    elif OPTS.mode \u003d\u003d \u0027check\u0027:"},{"line_number":564,"context_line":"        collect_users(RES[\u0027users\u0027])"},{"line_number":565,"context_line":"        checker \u003d JavelinCheck(USERS, RES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_c00f9dde","line":562,"in_reply_to":"baada198_c0a5dd03","updated":"2014-07-25 19:42:36.000000000","message":"The way this is all being done in different patchsets is rather hard to keep track of. I\u0027ll take your word for it.\n\nGiven that check now is being done before and after the shutdown and upgrade, some advice will be needed on how to write a \"check\" that confirms survivability of data over the upgrade. For example in the ceilometer case we want the _second_ test to confirm that there are samples from before and after the upgrade.","commit_id":"1a09700abcf4d4b7bbfc6d33c554dce8477f788f"}]}