)]}'
{"tempest/api/network/test_routers_negative.py":[{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"5e2ece7b395ebfcb6579a33b917c93803b038a3f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                              \u0027network_id\u0027: alt_network[\u0027id\u0027]})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":62,"context_line":"    def test_router_remove_interface_in_use_returns_409(self):"},{"line_number":63,"context_line":"        self.client.add_router_interface_with_subnet_id("},{"line_number":64,"context_line":"            self.router[\u0027id\u0027], self.subnet[\u0027id\u0027])"},{"line_number":65,"context_line":"        self.assertRaises(exceptions.Conflict,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0e9b1b18","line":62,"updated":"2014-08-06 05:40:57.000000000","message":"Why did you change the location of this test?\nPlease tell me the reason.","commit_id":"83954e5b8009d34ce46a8b9e861399893a7b3417"},{"author":{"_account_id":12626,"name":"Rajkumar","email":"rajkumart@hp.com","username":"raj15"},"change_message_id":"3eaf2dd79435fcab608a0de8fc22f38a4fa3333d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                              \u0027network_id\u0027: alt_network[\u0027id\u0027]})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":62,"context_line":"    def test_router_remove_interface_in_use_returns_409(self):"},{"line_number":63,"context_line":"        self.client.add_router_interface_with_subnet_id("},{"line_number":64,"context_line":"            self.router[\u0027id\u0027], self.subnet[\u0027id\u0027])"},{"line_number":65,"context_line":"        self.assertRaises(exceptions.Conflict,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ae5f3a4c","line":62,"in_reply_to":"baada198_0e9b1b18","updated":"2014-08-08 07:31:40.000000000","message":"Thanks for the review:\nSorry for this change .By mistake i did it.First code commit in tempest.","commit_id":"83954e5b8009d34ce46a8b9e861399893a7b3417"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"5e2ece7b395ebfcb6579a33b917c93803b038a3f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_show_non_existent_router(self):"},{"line_number":86,"context_line":"        non_exist_id \u003d data_utils.rand_name(\u0027router\u0027)"},{"line_number":87,"context_line":"        self.assertRaises(exceptions.NotFound, self.client.show_router,"},{"line_number":88,"context_line":"                          non_exist_id)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":91,"context_line":"    def test_update_non_existent_router(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cee92384","line":88,"updated":"2014-08-06 05:40:57.000000000","message":"I think it is better that negative tests will be expressed by using not negative parameter name but negative parameter value.\n\nex:\nrouter \u003d data_utils.rand_name(\u0027non_exist_router\u0027)\nself.assertRaises(exceptions.NotFound, self.client.show_router,\n                  router)\n\nhow do you think?","commit_id":"83954e5b8009d34ce46a8b9e861399893a7b3417"},{"author":{"_account_id":12626,"name":"Rajkumar","email":"rajkumart@hp.com","username":"raj15"},"change_message_id":"3eaf2dd79435fcab608a0de8fc22f38a4fa3333d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_show_non_existent_router(self):"},{"line_number":86,"context_line":"        non_exist_id \u003d data_utils.rand_name(\u0027router\u0027)"},{"line_number":87,"context_line":"        self.assertRaises(exceptions.NotFound, self.client.show_router,"},{"line_number":88,"context_line":"                          non_exist_id)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":91,"context_line":"    def test_update_non_existent_router(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6e544222","line":88,"in_reply_to":"baada198_cee92384","updated":"2014-08-08 07:31:40.000000000","message":"Addressed the comments. I have edited the parameters name.","commit_id":"83954e5b8009d34ce46a8b9e861399893a7b3417"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1890c9bdeafb9198f4be07d68c078486debe489d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":85,"context_line":"    def test_show_non_existent_router(self):"},{"line_number":86,"context_line":"        router \u003d data_utils.rand_name(\u0027non_exist_router\u0027)"},{"line_number":87,"context_line":"        self.assertRaises(exceptions.NotFound, self.client.show_router,"},{"line_number":88,"context_line":"                          router)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_c972bd10","line":87,"updated":"2014-11-20 20:59:08.000000000","message":"Maybe it\u0027s better to add also messages checking, but it depends on you, I see there are no such checks in this file.","commit_id":"87cfd07d7be7a27a0893e55d4f672cec9d0a5a2d"}]}