)]}'
{"tempest/auth.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"9dd33f74154dc78a49b4c6b818ec3d697f083637","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            if noversion_path !\u003d \"\":"},{"line_number":322,"context_line":"                path +\u003d \"/\" + noversion_path"},{"line_number":323,"context_line":"            _base_url \u003d _base_url.replace(parts.path, path)"},{"line_number":324,"context_line":"        if filters.get(\u0027skip_path\u0027, None) is not None and parts.path !\u003d \u0027\u0027:"},{"line_number":325,"context_line":"            _base_url \u003d _base_url.replace(parts.path, \"/\")"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return _base_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_7aab63d7","line":324,"updated":"2014-07-30 05:10:22.000000000","message":"The original logic seems correct to me - if skip_path is anything but \"None\" skip path.\n\nCan you point me to the part of the code in the image client which is setting an empty skip_path and still expecting to get the path? I do not find it in the code base.\n\nRest client provide two helpers \"skip_path\" and \"reset_path\" that will do the right thing anyways - so it should not happen that a test is using this in the wrong way.\n\nThe docstring could be improved :)","commit_id":"5a2cb4586d99229f8496584094b7ab8102023c7a"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"ba4a9342334fdfb090876ef1ad6187b33e07dc1b","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            if noversion_path !\u003d \"\":"},{"line_number":322,"context_line":"                path +\u003d \"/\" + noversion_path"},{"line_number":323,"context_line":"            _base_url \u003d _base_url.replace(parts.path, path)"},{"line_number":324,"context_line":"        if filters.get(\u0027skip_path\u0027, None) is not None and parts.path !\u003d \u0027\u0027:"},{"line_number":325,"context_line":"            _base_url \u003d _base_url.replace(parts.path, \"/\")"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return _base_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_7aea38a1","line":324,"in_reply_to":"baada198_7aab63d7","updated":"2014-07-31 19:44:24.000000000","message":"It is not there now. I was mucking with the api discovery code in verify_tempest_config which does the discovery differently for image than the other services but did  not see why. But the current code in that case, where parts.path is null, it will return \u0027/h/t/t/p/://///h/o/s/t/./c/o/m/:/9/2/9/2/\u0027 which has to be a bug. \n\nThe only thing based on the if is to strip the path out recover the top-level url, right?","commit_id":"5a2cb4586d99229f8496584094b7ab8102023c7a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"ba2fa069c841002bc4e6fda6d121b840c8428992","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            if noversion_path !\u003d \"\":"},{"line_number":322,"context_line":"                path +\u003d \"/\" + noversion_path"},{"line_number":323,"context_line":"            _base_url \u003d _base_url.replace(parts.path, path)"},{"line_number":324,"context_line":"        if filters.get(\u0027skip_path\u0027, None) is not None and parts.path !\u003d \u0027\u0027:"},{"line_number":325,"context_line":"            _base_url \u003d _base_url.replace(parts.path, \"/\")"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return _base_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9dbe15ae","line":324,"in_reply_to":"baada198_7aea38a1","updated":"2014-08-01 08:08:41.000000000","message":"OK, I got it know; I misread your change.\nSo if asking to skip path and path is already empty do nothing. Makes sense to me.","commit_id":"5a2cb4586d99229f8496584094b7ab8102023c7a"}]}