)]}'
{"tempest/common/isolated_creds.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"96a1cb0de82ce22d7c1439b475f77996bb450b1a","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            LOG.info(\"Acquired isolated creds:\\n credentials: %s\""},{"line_number":332,"context_line":"                     % credentials)"},{"line_number":333,"context_line":"            if (CONF.service_available.neutron and"},{"line_number":334,"context_line":"                not CONF.baremetal.driver_enabled):"},{"line_number":335,"context_line":"                network, subnet, router \u003d self._create_network_resources("},{"line_number":336,"context_line":"                    credentials.tenant_id)"},{"line_number":337,"context_line":"                self.isolated_net_resources[credential_type] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c7ee7321","line":334,"updated":"2014-08-05 20:14:19.000000000","message":"_create_network_resources only creates resources which are requested by the test.\n\ntest.py exposes a function that shall be used to define which network resources are required:\n\nhttps://git.openstack.org/cgit/openstack/tempest/tree/tempest/test.py#n361","commit_id":"9ac65f11a2766ebdd28b10f1d1fd581e2fc3bedf"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"7c43171339e6e4ea17cf084e3362d8ccb8885ee7","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            LOG.info(\"Acquired isolated creds:\\n credentials: %s\""},{"line_number":332,"context_line":"                     % credentials)"},{"line_number":333,"context_line":"            if (CONF.service_available.neutron and"},{"line_number":334,"context_line":"                not CONF.baremetal.driver_enabled):"},{"line_number":335,"context_line":"                network, subnet, router \u003d self._create_network_resources("},{"line_number":336,"context_line":"                    credentials.tenant_id)"},{"line_number":337,"context_line":"                self.isolated_net_resources[credential_type] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_65f4bf55","line":334,"in_reply_to":"baada198_c7ee7321","updated":"2014-08-05 21:43:00.000000000","message":"Right, but rather than requiring every test to  special case for baremetal, this seems like the proper place to do it--in the same we do currently for the nova-net/non-Neutron case.  This allows tests to not care about the underlying topology and ensures new tests can be added without worrying about it.  Adding it to the baremetal check to the linked function in test.py looks non-optimal and puts similar logic in two separate places.","commit_id":"9ac65f11a2766ebdd28b10f1d1fd581e2fc3bedf"}]}