)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"bf9c8f50f678fbec7307a4beb820e9ff35f9755d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allows choosing ip_version for ScenarioTest based tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Eliminates hard-code which makes all ScenarioTest based tests creating default IPv4 subnet. Implements possibility to switch the test from ip_version\u003d4 (still the default) to ip_version\u003d6"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I728edf0165ba47b6f8930f2fb3d08bd29cfbb317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_caf3ca71","line":9,"updated":"2014-08-18 19:27:23.000000000","message":"\u0027Subsequent lines should be wrapped at 72 characters. \u0027\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"8ea3d7927170a47d03a8cdddf7584d2a9952eec7"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0da7cc87e4668d1fd2150cb05792fcda431fa878","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* Check the way how  IPv6 addresses assigned to vNIC"},{"line_number":10,"context_line":"* Eliminate hardcoded IPv4 subnet creation."},{"line_number":11,"context_line":"* Fix problem with creating FIP for port with few addresses."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially implements: blueprint ipv6-api-testing-parity"},{"line_number":14,"context_line":"Change-Id: I728edf0165ba47b6f8930f2fb3d08bd29cfbb317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"5a890539_193353f7","line":12,"updated":"2014-11-29 16:15:45.000000000","message":"nit: Adds ping6 to remote_client","commit_id":"3aaca22f689162abfba194e72aaed8c929d18f7c"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"93a277d2a36ced11908cd4f22d0ce504958421b0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* Check the way how  IPv6 addresses assigned to vNIC"},{"line_number":10,"context_line":"* Eliminate hardcoded IPv4 subnet creation."},{"line_number":11,"context_line":"* Fix problem with creating FIP for port with few addresses."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially implements: blueprint ipv6-api-testing-parity"},{"line_number":14,"context_line":"Change-Id: I728edf0165ba47b6f8930f2fb3d08bd29cfbb317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"5a890539_6800ed66","line":12,"in_reply_to":"5a890539_193353f7","updated":"2014-12-01 13:54:36.000000000","message":"Done","commit_id":"3aaca22f689162abfba194e72aaed8c929d18f7c"}],"tempest/common/isolated_creds.py":[{"author":{"_account_id":9194,"name":"Emily Hugenbruch","email":"ekhugenbruch@us.ibm.com","username":"ekhugen"},"change_message_id":"a21e66109fede3da185317c4b3cd5335715dc11e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baada198_a9e4cda8","updated":"2014-08-06 19:00:09.000000000","message":"Avoid the inline if/else expression and you won\u0027t run into the \"line too long\" PEP 8 errors.","commit_id":"33aae5633f8cfdf86ba51b8d29aa7774a1e884f5"}],"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1f13c0e3286f32c69321831b52a65cec0829e551","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        cmd \u003d \u0027ping6\u0027 if addr.version \u003d\u003d 6 else \u0027ping\u0027"},{"line_number":93,"context_line":"        cmd +\u003d \u0027 -c1 -w1 {0}\u0027.format(host)"},{"line_number":94,"context_line":"        if iface:"},{"line_number":95,"context_line":"            cmd +\u003d \u0027-I {0}\u0027.format(iface)"},{"line_number":96,"context_line":"        return self.exec_command(cmd)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_mac_address(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_c502de71","line":95,"updated":"2014-11-27 16:01:16.000000000","message":"It does not seem that iface argument is used anywhere.","commit_id":"c804a783b8e62761eb797c8b80b8811005f8090d"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"0f3fe9a7a82caf791f96224598c43bb36c684f0c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        cmd \u003d \u0027ping6\u0027 if addr.version \u003d\u003d 6 else \u0027ping\u0027"},{"line_number":93,"context_line":"        cmd +\u003d \u0027 -c1 -w1 {0}\u0027.format(host)"},{"line_number":94,"context_line":"        if iface:"},{"line_number":95,"context_line":"            cmd +\u003d \u0027-I {0}\u0027.format(iface)"},{"line_number":96,"context_line":"        return self.exec_command(cmd)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_mac_address(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_e5343afd","line":95,"in_reply_to":"5a890539_c502de71","updated":"2014-11-27 16:24:16.000000000","message":"no yet, but there\u0027re cases when it might be needed (remember that in some cases ping6 is not able to figure out correct if)","commit_id":"c804a783b8e62761eb797c8b80b8811005f8090d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"14fd04e24827bd6f2637ca45a55df13b248ab391","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        cmd \u003d \u0027ping6\u0027 if addr.version \u003d\u003d 6 else \u0027ping\u0027"},{"line_number":93,"context_line":"        cmd +\u003d \u0027 -c1 -w1 {0}\u0027.format(host)"},{"line_number":94,"context_line":"        if iface:"},{"line_number":95,"context_line":"            cmd +\u003d \u0027-I {0}\u0027.format(iface)"},{"line_number":96,"context_line":"        return self.exec_command(cmd)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_mac_address(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_c02acc2e","line":95,"in_reply_to":"5a890539_e5343afd","updated":"2014-11-27 16:33:06.000000000","message":"I would refrain from adding it as part of the patch since it\u0027s irrelevant here, though I agree it may be useful as a separate patch or a part of another test that actually uses the argument.","commit_id":"c804a783b8e62761eb797c8b80b8811005f8090d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e42657751b066343c28c179cf0c49faf65412ab6","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        addr \u003d netaddr.IPAddress(host)"},{"line_number":92,"context_line":"        cmd \u003d \u0027ping6\u0027 if addr.version \u003d\u003d 6 else \u0027ping\u0027"},{"line_number":93,"context_line":"        cmd +\u003d \u0027 -c1 -w1 {0}\u0027.format(host)"},{"line_number":94,"context_line":"        if iface:"},{"line_number":95,"context_line":"            cmd +\u003d \u0027-I {0}\u0027.format(iface)"},{"line_number":96,"context_line":"        return self.exec_command(cmd)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_401edc0e","line":94,"updated":"2014-11-27 16:33:38.000000000","message":"I still think -I change is not relevant here and should be removed.","commit_id":"ae840394df70ef6b2b3fe52d7fc2bd0117f5e497"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"21f4ee28a2d1c554e4307c0925360c4a972dc988","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        addr \u003d netaddr.IPAddress(host)"},{"line_number":92,"context_line":"        cmd \u003d \u0027ping6\u0027 if addr.version \u003d\u003d 6 else \u0027ping\u0027"},{"line_number":93,"context_line":"        cmd +\u003d \u0027 -c1 -w1 {0}\u0027.format(host)"},{"line_number":94,"context_line":"        if iface:"},{"line_number":95,"context_line":"            cmd +\u003d \u0027-I {0}\u0027.format(iface)"},{"line_number":96,"context_line":"        return self.exec_command(cmd)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_80ab6474","line":94,"in_reply_to":"5a890539_401edc0e","updated":"2014-11-27 16:38:59.000000000","message":"Done","commit_id":"ae840394df70ef6b2b3fe52d7fc2bd0117f5e497"}],"tempest/scenario/manager.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"be459e90938e67dc0d79ff4090a51603ecafbda8","unresolved":false,"context_lines":[{"line_number":769,"context_line":"    \"\"\""},{"line_number":770,"context_line":"    Base class for network scenario tests"},{"line_number":771,"context_line":"    \"\"\""},{"line_number":772,"context_line":"    _ip_version \u003d 4"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    @classmethod"},{"line_number":775,"context_line":"    def check_preconditions(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_cc4ccf79","line":772,"updated":"2014-08-25 21:07:05.000000000","message":"when would this get set?","commit_id":"c2b458334b0d1b78a06c48df2c19ddbe9ca10009"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"283f9440fe243676671d61ef653ef5bdc9f96959","unresolved":false,"context_lines":[{"line_number":769,"context_line":"    \"\"\""},{"line_number":770,"context_line":"    Base class for network scenario tests"},{"line_number":771,"context_line":"    \"\"\""},{"line_number":772,"context_line":"    _ip_version \u003d 4"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    @classmethod"},{"line_number":775,"context_line":"    def check_preconditions(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_7ec98f59","line":772,"in_reply_to":"1abeadc6_cc4ccf79","updated":"2014-08-28 14:19:24.000000000","message":"In class inherited from this one as a class level attribute","commit_id":"c2b458334b0d1b78a06c48df2c19ddbe9ca10009"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":535,"context_line":"            return len(cidr_in_use) !\u003d 0"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if \u0027ip_version\u0027 not in kwargs:"},{"line_number":538,"context_line":"            kwargs[\u0027ip_version\u0027] \u003d 4"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if kwargs[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":541,"context_line":"            tenant_cidr \u003d \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_db706ca6","line":538,"updated":"2014-11-24 22:12:48.000000000","message":"ip_version \u003d kwargs.get(\u0027ip_version\u0027, 4)\n\nand then if ip_version...\n\nI\u0027d suggest to do it like in API function create_subnet","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":535,"context_line":"            return len(cidr_in_use) !\u003d 0"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if \u0027ip_version\u0027 not in kwargs:"},{"line_number":538,"context_line":"            kwargs[\u0027ip_version\u0027] \u003d 4"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if kwargs[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":541,"context_line":"            tenant_cidr \u003d \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_018b551f","line":538,"in_reply_to":"5a890539_db706ca6","updated":"2014-11-25 12:59:59.000000000","message":"I do kwargs.pop(\u0027ip_version\u0027, 4), agree?","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            kwargs[\u0027ip_version\u0027] \u003d 4"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if kwargs[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":541,"context_line":"            tenant_cidr \u003d \\"},{"line_number":542,"context_line":"                netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":543,"context_line":"            num_bits \u003d CONF.network.tenant_network_v6_mask_bits"},{"line_number":544,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_fbafe8e0","line":541,"updated":"2014-11-24 22:12:48.000000000","message":"no slashes:\n\n  tenant_cidr \u003d netaddr.IPNetwork(\n    CONF.network.tenant_network_v6_cidr)","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            kwargs[\u0027ip_version\u0027] \u003d 4"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if kwargs[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":541,"context_line":"            tenant_cidr \u003d \\"},{"line_number":542,"context_line":"                netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":543,"context_line":"            num_bits \u003d CONF.network.tenant_network_v6_mask_bits"},{"line_number":544,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_a1f601d5","line":541,"in_reply_to":"5a890539_fbafe8e0","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            num_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        result \u003d None"},{"line_number":549,"context_line":"        str_cidr \u003d None"},{"line_number":550,"context_line":"        # Repeatedly attempt subnet creation with sequential cidr"},{"line_number":551,"context_line":"        # blocks until an unallocated block is found."},{"line_number":552,"context_line":"        for subnet_cidr in tenant_cidr.subnet(num_bits):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_7b83f855","line":549,"updated":"2014-11-24 22:12:48.000000000","message":"what is it for?","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            num_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        result \u003d None"},{"line_number":549,"context_line":"        str_cidr \u003d None"},{"line_number":550,"context_line":"        # Repeatedly attempt subnet creation with sequential cidr"},{"line_number":551,"context_line":"        # blocks until an unallocated block is found."},{"line_number":552,"context_line":"        for subnet_cidr in tenant_cidr.subnet(num_bits):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_617099a4","line":549,"in_reply_to":"5a890539_7b83f855","updated":"2014-11-25 12:59:59.000000000","message":"pep8 str_cidr might be used undefined","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                                 fixed_ip\u003dip_addr)"},{"line_number":595,"context_line":"        self.assertEqual(len(ports), 1,"},{"line_number":596,"context_line":"                         \"Unable to determine which port to target.\")"},{"line_number":597,"context_line":"        ip4 \u003d None"},{"line_number":598,"context_line":"        for ip46 in ports[0][\u0027fixed_ips\u0027]:"},{"line_number":599,"context_line":"            ip \u003d ip46[\u0027ip_address\u0027]"},{"line_number":600,"context_line":"            if netaddr.valid_ipv4(ip):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_1b94b489","line":597,"updated":"2014-11-24 22:12:48.000000000","message":"write a little comment about what are you doing, not all aware of the problem here","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                                 fixed_ip\u003dip_addr)"},{"line_number":595,"context_line":"        self.assertEqual(len(ports), 1,"},{"line_number":596,"context_line":"                         \"Unable to determine which port to target.\")"},{"line_number":597,"context_line":"        ip4 \u003d None"},{"line_number":598,"context_line":"        for ip46 in ports[0][\u0027fixed_ips\u0027]:"},{"line_number":599,"context_line":"            ip \u003d ip46[\u0027ip_address\u0027]"},{"line_number":600,"context_line":"            if netaddr.valid_ipv4(ip):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_81c66598","line":597,"in_reply_to":"5a890539_1b94b489","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"620d1e8552feffcead613ee5fd43674a6dffbe5f","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        return floating_ip"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def _associate_floating_ip(self, floating_ip, server):"},{"line_number":698,"context_line":"        port_id \u003d self._get_server_port_id_and_ip4(server)[0]"},{"line_number":699,"context_line":"        floating_ip.update(port_id\u003dport_id)"},{"line_number":700,"context_line":"        self.assertEqual(port_id, floating_ip.port_id)"},{"line_number":701,"context_line":"        return floating_ip"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_8a0ab177","line":698,"updated":"2014-11-27 08:07:01.000000000","message":"nit:\nI prefer this form, as it is more explicit\n port_id, _ \u003d self._get_server_port_id_and_ip4(server)","commit_id":"c64399cead6e2b088defea2f3ec581c1980cb7bf"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"0461631442a9fa6ecfb872e826ef3410f8c23e49","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        return floating_ip"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def _associate_floating_ip(self, floating_ip, server):"},{"line_number":698,"context_line":"        port_id \u003d self._get_server_port_id_and_ip4(server)[0]"},{"line_number":699,"context_line":"        floating_ip.update(port_id\u003dport_id)"},{"line_number":700,"context_line":"        self.assertEqual(port_id, floating_ip.port_id)"},{"line_number":701,"context_line":"        return floating_ip"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_e75d2b7b","line":698,"in_reply_to":"5a890539_8a0ab177","updated":"2014-11-27 10:28:05.000000000","message":"Done","commit_id":"c64399cead6e2b088defea2f3ec581c1980cb7bf"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"aff6b0cb0995ca47a11316b596dcf829e0dc297e","unresolved":false,"context_lines":[{"line_number":607,"context_line":"            num_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        result \u003d None"},{"line_number":610,"context_line":"        str_cidr \u003d None"},{"line_number":611,"context_line":"        # Repeatedly attempt subnet creation with sequential cidr"},{"line_number":612,"context_line":"        # blocks until an unallocated block is found."},{"line_number":613,"context_line":"        for subnet_cidr in tenant_cidr.subnet(num_bits):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_da380640","line":610,"updated":"2014-11-27 11:05:30.000000000","message":"You can probably remove this assignment, it is not required.","commit_id":"34383db866850da91e2ac4aea0e2cd9dfe8a1d0d"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"64be7584688c7cf86eacfd0b346e166a8cc8d0da","unresolved":false,"context_lines":[{"line_number":607,"context_line":"            num_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        result \u003d None"},{"line_number":610,"context_line":"        str_cidr \u003d None"},{"line_number":611,"context_line":"        # Repeatedly attempt subnet creation with sequential cidr"},{"line_number":612,"context_line":"        # blocks until an unallocated block is found."},{"line_number":613,"context_line":"        for subnet_cidr in tenant_cidr.subnet(num_bits):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_73249db2","line":610,"in_reply_to":"5a890539_da380640","updated":"2014-11-27 13:39:00.000000000","message":"well, actually it\u0027s due to pep8 check embedded into pycharm.\nstr_cidr is used in:\nself.assertEqual(subnet.cidr, str_cidr)","commit_id":"34383db866850da91e2ac4aea0e2cd9dfe8a1d0d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a5d0ff5d1f8b17850d19fd3aa88a397cbd1c6a7c","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        for ip46 in ports[0][\u0027fixed_ips\u0027]:"},{"line_number":663,"context_line":"            ip \u003d ip46[\u0027ip_address\u0027]"},{"line_number":664,"context_line":"            if netaddr.valid_ipv4(ip):"},{"line_number":665,"context_line":"                ip4 \u003d ip"},{"line_number":666,"context_line":"        return ports[0][\u0027id\u0027], ip4"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    def _get_network_by_name(self, network_name):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_9aa83579","line":665,"updated":"2014-11-27 15:58:47.000000000","message":"should we break here to avoid looping thru the whole list once we\u0027ve found a proper ip address? or better, just return right away.","commit_id":"6219be77b1a80180348c32889853a291931860de"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"0d087ab5143ee3acad41c2c49a23115a184c1850","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        for ip46 in ports[0][\u0027fixed_ips\u0027]:"},{"line_number":663,"context_line":"            ip \u003d ip46[\u0027ip_address\u0027]"},{"line_number":664,"context_line":"            if netaddr.valid_ipv4(ip):"},{"line_number":665,"context_line":"                ip4 \u003d ip"},{"line_number":666,"context_line":"        return ports[0][\u0027id\u0027], ip4"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    def _get_network_by_name(self, network_name):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_65204ab1","line":665,"in_reply_to":"5a890539_9aa83579","updated":"2014-11-27 16:24:25.000000000","message":"Done","commit_id":"6219be77b1a80180348c32889853a291931860de"}],"tempest/scenario/test_network_v6.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_7bd13856","line":22,"updated":"2014-11-24 22:12:48.000000000","message":"log and LOG seems unused here","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_1e1e5470","line":22,"in_reply_to":"5a890539_7bd13856","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"},{"line_number":26,"context_line":"    stateful \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":27,"context_line":"    stateless \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":28,"context_line":"    slaac \u003d \u0027slaac\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_1bc2f484","line":28,"updated":"2014-11-24 22:12:48.000000000","message":"class variables? hmmm...","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"},{"line_number":26,"context_line":"    stateful \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":27,"context_line":"    stateless \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":28,"context_line":"    slaac \u003d \u0027slaac\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_cfa33941","line":28,"in_reply_to":"5a890539_1bc2f484","updated":"2014-11-25 12:59:59.000000000","message":"they\u0027re just like enum- used to avoid mistakes in strings","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.sec_grp \u003d self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":50,"context_line":"        self.srv_kwargs \u003d {"},{"line_number":51,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":52,"context_line":"            \u0027security_groups\u0027: [self.sec_grp]}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def prepare_network(self, address6_mode):"},{"line_number":55,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_5b663cbc","line":52,"updated":"2014-11-24 22:12:48.000000000","message":"don\u0027t forget that your patch about ssh and icmp v6 in default security groups was lost :) you need to resurrect it","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.sec_grp \u003d self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":50,"context_line":"        self.srv_kwargs \u003d {"},{"line_number":51,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":52,"context_line":"            \u0027security_groups\u0027: [self.sec_grp]}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def prepare_network(self, address6_mode):"},{"line_number":55,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_6f608501","line":52,"in_reply_to":"5a890539_5b663cbc","updated":"2014-11-25 12:59:59.000000000","message":"not needed as for now, ssh4 is only in use","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"},{"line_number":56,"context_line":"        sub4 \u003d self._create_subnet(network\u003dnet,"},{"line_number":57,"context_line":"                                   namestart\u003d\u0027sub4\u0027,"},{"line_number":58,"context_line":"                                   ip_version\u003d4,)"},{"line_number":59,"context_line":"        sub6 \u003d self._create_subnet(network\u003dnet,"},{"line_number":60,"context_line":"                                   namestart\u003d\u0027sub6\u0027,"},{"line_number":61,"context_line":"                                   ip_version\u003d6,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_3b17b0ef","line":58,"updated":"2014-11-24 22:12:48.000000000","message":"it\u0027s by default 4","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"},{"line_number":56,"context_line":"        sub4 \u003d self._create_subnet(network\u003dnet,"},{"line_number":57,"context_line":"                                   namestart\u003d\u0027sub4\u0027,"},{"line_number":58,"context_line":"                                   ip_version\u003d4,)"},{"line_number":59,"context_line":"        sub6 \u003d self._create_subnet(network\u003dnet,"},{"line_number":60,"context_line":"                                   namestart\u003d\u0027sub6\u0027,"},{"line_number":61,"context_line":"                                   ip_version\u003d6,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_cf289999","line":58,"in_reply_to":"5a890539_3b17b0ef","updated":"2014-11-25 12:59:59.000000000","message":"I think it\u0027s better to have it explicit here","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        sub6 \u003d self._create_subnet(network\u003dnet,"},{"line_number":60,"context_line":"                                   namestart\u003d\u0027sub6\u0027,"},{"line_number":61,"context_line":"                                   ip_version\u003d6,"},{"line_number":62,"context_line":"                                   gateway_ip\u003d\u00272003::1\u0027,"},{"line_number":63,"context_line":"                                   ipv6_ra_mode\u003daddress6_mode,"},{"line_number":64,"context_line":"                                   ipv6_address_mode\u003daddress6_mode)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_7b2db845","line":62,"updated":"2014-11-24 22:12:48.000000000","message":"you have CONF.network.tenant... etc. why to use hardcoded gateway_ip? And if 2003:: subnet is allocated already?","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        sub6 \u003d self._create_subnet(network\u003dnet,"},{"line_number":60,"context_line":"                                   namestart\u003d\u0027sub6\u0027,"},{"line_number":61,"context_line":"                                   ip_version\u003d6,"},{"line_number":62,"context_line":"                                   gateway_ip\u003d\u00272003::1\u0027,"},{"line_number":63,"context_line":"                                   ipv6_ra_mode\u003daddress6_mode,"},{"line_number":64,"context_line":"                                   ipv6_address_mode\u003daddress6_mode)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_ed28f898","line":62,"in_reply_to":"5a890539_7b2db845","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        sub4.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":68,"context_line":"        sub6.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def define_server_ips(cls, srv):"},{"line_number":72,"context_line":"        for net_name, nics in srv[\u0027addresses\u0027].iteritems():"},{"line_number":73,"context_line":"            for nic in nics:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_3beed0ed","line":70,"updated":"2014-11-24 22:12:48.000000000","message":"should it be class method? I don\u0027t see cls used here","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        sub4.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":68,"context_line":"        sub6.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def define_server_ips(cls, srv):"},{"line_number":72,"context_line":"        for net_name, nics in srv[\u0027addresses\u0027].iteritems():"},{"line_number":73,"context_line":"            for nic in nics:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_ea4f0369","line":70,"in_reply_to":"5a890539_3beed0ed","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                else:"},{"line_number":77,"context_line":"                    srv[\u0027accessIPv4\u0027] \u003d nic[\u0027addr\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def prepare_server(self, is_use_alt_image\u003dFalse):"},{"line_number":80,"context_line":"        if is_use_alt_image:"},{"line_number":81,"context_line":"            image_id \u003d CONF.compute.image_ref_alt"},{"line_number":82,"context_line":"            username \u003d CONF.compute.image_alt_ssh_user"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_9b8ee42c","line":79,"updated":"2014-11-24 22:12:48.000000000","message":"I don\u0027t so understand the purpose of \"is use alt image\" if you don\u0027t use this in your test","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                else:"},{"line_number":77,"context_line":"                    srv[\u0027accessIPv4\u0027] \u003d nic[\u0027addr\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def prepare_server(self, is_use_alt_image\u003dFalse):"},{"line_number":80,"context_line":"        if is_use_alt_image:"},{"line_number":81,"context_line":"            image_id \u003d CONF.compute.image_ref_alt"},{"line_number":82,"context_line":"            username \u003d CONF.compute.image_alt_ssh_user"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_6a431342","line":79,"in_reply_to":"5a890539_9b8ee42c","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        self.prepare_network(address6_mode\u003daddress6_mode)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        ssh1, i1 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":106,"context_line":"        ssh2, i2 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        r \u003d ssh1.exec_command(\u0027ip addr show dev eth0\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_9ba7c4bc","line":105,"updated":"2014-11-24 22:12:48.000000000","message":"1) \"i1\" is nt gd vrbl nm\n\n2) is_use_alt_image by default is False anyway","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        self.prepare_network(address6_mode\u003daddress6_mode)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        ssh1, i1 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":106,"context_line":"        ssh2, i2 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        r \u003d ssh1.exec_command(\u0027ip addr show dev eth0\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_4aa7370b","line":105,"in_reply_to":"5a890539_9ba7c4bc","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.prepare_network(address6_mode\u003daddress6_mode)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        ssh1, i1 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":106,"context_line":"        ssh2, i2 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        r \u003d ssh1.exec_command(\u0027ip addr show dev eth0\u0027)"},{"line_number":109,"context_line":"        self.assertIn(i1[\u0027accessIPv4\u0027], r)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_9b950435","line":106,"updated":"2014-11-24 22:12:48.000000000","message":"nbd lks vrbls nms lk \"i2\"","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.prepare_network(address6_mode\u003daddress6_mode)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        ssh1, i1 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":106,"context_line":"        ssh2, i2 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        r \u003d ssh1.exec_command(\u0027ip addr show dev eth0\u0027)"},{"line_number":109,"context_line":"        self.assertIn(i1[\u0027accessIPv4\u0027], r)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_ca896770","line":106,"in_reply_to":"5a890539_9b950435","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        ssh1, i1 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":106,"context_line":"        ssh2, i2 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        r \u003d ssh1.exec_command(\u0027ip addr show dev eth0\u0027)"},{"line_number":109,"context_line":"        self.assertIn(i1[\u0027accessIPv4\u0027], r)"},{"line_number":110,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":111,"context_line":"        self.assertIn(i1[\u0027accessIPv6\u0027], r)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_9b0a6488","line":108,"updated":"2014-11-24 22:12:48.000000000","message":"wht s r?","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        ssh1, i1 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":106,"context_line":"        ssh2, i2 \u003d self.prepare_server(is_use_alt_image\u003dFalse)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        r \u003d ssh1.exec_command(\u0027ip addr show dev eth0\u0027)"},{"line_number":109,"context_line":"        self.assertIn(i1[\u0027accessIPv4\u0027], r)"},{"line_number":110,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":111,"context_line":"        self.assertIn(i1[\u0027accessIPv6\u0027], r)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_aabc1b07","line":108,"in_reply_to":"5a890539_9b0a6488","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertIn(i1[\u0027accessIPv4\u0027], r)"},{"line_number":110,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":111,"context_line":"        self.assertIn(i1[\u0027accessIPv6\u0027], r)"},{"line_number":112,"context_line":"        r \u003d ssh2.exec_command(\u0027ip addr show dev eth0\u0027)"},{"line_number":113,"context_line":"        self.assertIn(i2[\u0027accessIPv4\u0027], r)"},{"line_number":114,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":115,"context_line":"        self.assertIn(i2[\u0027accessIPv6\u0027], r)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_fbd1a8fb","line":112,"updated":"2014-11-24 22:12:48.000000000","message":"variable override, we have a lot of letters combinations! :) for example: interface1, interface2. server1, server2. etc","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertIn(i1[\u0027accessIPv4\u0027], r)"},{"line_number":110,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":111,"context_line":"        self.assertIn(i1[\u0027accessIPv6\u0027], r)"},{"line_number":112,"context_line":"        r \u003d ssh2.exec_command(\u0027ip addr show dev eth0\u0027)"},{"line_number":113,"context_line":"        self.assertIn(i2[\u0027accessIPv4\u0027], r)"},{"line_number":114,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":115,"context_line":"        self.assertIn(i2[\u0027accessIPv6\u0027], r)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_4a5ad7f2","line":112,"in_reply_to":"5a890539_fbd1a8fb","updated":"2014-11-25 12:59:59.000000000","message":"it this point r is already checked not needed any more, it\u0027s safe to redefine it","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.assertIn(i2[\u0027accessIPv4\u0027], r)"},{"line_number":114,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":115,"context_line":"        self.assertIn(i2[\u0027accessIPv6\u0027], r)"},{"line_number":116,"context_line":"        r \u003d ssh1.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i2[\u0027accessIPv4\u0027]))"},{"line_number":117,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":118,"context_line":"        r \u003d ssh2.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i1[\u0027accessIPv4\u0027]))"},{"line_number":119,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_bb09e085","line":116,"updated":"2014-11-24 22:12:48.000000000","message":"why do you check ping after SSH? what is it for?","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.assertIn(i2[\u0027accessIPv4\u0027], r)"},{"line_number":114,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":115,"context_line":"        self.assertIn(i2[\u0027accessIPv6\u0027], r)"},{"line_number":116,"context_line":"        r \u003d ssh1.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i2[\u0027accessIPv4\u0027]))"},{"line_number":117,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":118,"context_line":"        r \u003d ssh2.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i1[\u0027accessIPv4\u0027]))"},{"line_number":119,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_2a0e6be5","line":116,"in_reply_to":"5a890539_bb09e085","updated":"2014-11-25 12:59:59.000000000","message":"it\u0027s ping in between 2 VMs, not between tempest host and VM","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":115,"context_line":"        self.assertIn(i2[\u0027accessIPv6\u0027], r)"},{"line_number":116,"context_line":"        r \u003d ssh1.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i2[\u0027accessIPv4\u0027]))"},{"line_number":117,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":118,"context_line":"        r \u003d ssh2.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i1[\u0027accessIPv4\u0027]))"},{"line_number":119,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_7b2cd802","line":117,"updated":"2014-11-24 22:12:48.000000000","message":"I\u0027m not sure it\u0027s a good way to check, I think you can use success of ping function, there is such in Scenario test.","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":115,"context_line":"        self.assertIn(i2[\u0027accessIPv6\u0027], r)"},{"line_number":116,"context_line":"        r \u003d ssh1.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i2[\u0027accessIPv4\u0027]))"},{"line_number":117,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":118,"context_line":"        r \u003d ssh2.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i1[\u0027accessIPv4\u0027]))"},{"line_number":119,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_6a223353","line":117,"in_reply_to":"5a890539_7b2cd802","updated":"2014-11-25 12:59:59.000000000","message":"AFAIK this function pings VM from tempest host","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        r \u003d ssh2.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i1[\u0027accessIPv4\u0027]))"},{"line_number":119,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # uncomment when https://bugs.launchpad.net/tempest/+bug/1366326 solved"},{"line_number":122,"context_line":"        #r \u003d ssh1.exec_command(cmd\u003d\u0027ping6 -c1 {0}\u0027.format(i2[\u0027accessIPv6\u0027]))"},{"line_number":123,"context_line":"        #self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":124,"context_line":"        #r \u003d ssh2.exec_command(cmd\u003d\u0027ping6 -c1 {0}\u0027.format(i1[\u0027accessIPv6\u0027]))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_3b4b30b2","line":121,"updated":"2014-11-24 22:12:48.000000000","message":"this bug is about dhcpv6 statefull, not about ping6 support.\nI think it\u0027s worth to check here if image has such tool (\"ping 6\"). If so - let\u0027s run it, if not - pass it with log \"can not check ping6 now\"","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        r \u003d ssh2.exec_command(cmd\u003d\u0027ping -c1 {0}\u0027.format(i1[\u0027accessIPv4\u0027]))"},{"line_number":119,"context_line":"        self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # uncomment when https://bugs.launchpad.net/tempest/+bug/1366326 solved"},{"line_number":122,"context_line":"        #r \u003d ssh1.exec_command(cmd\u003d\u0027ping6 -c1 {0}\u0027.format(i2[\u0027accessIPv6\u0027]))"},{"line_number":123,"context_line":"        #self.assertIn(\u00270% packet loss\u0027, r)"},{"line_number":124,"context_line":"        #r \u003d ssh2.exec_command(cmd\u003d\u0027ping6 -c1 {0}\u0027.format(i1[\u0027accessIPv6\u0027]))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_1e31f459","line":121,"in_reply_to":"5a890539_3b4b30b2","updated":"2014-11-25 12:59:59.000000000","message":"this bug is about lack of support ipv6 in cirros image, in particular about absence of ping6 and dhcp6 client. My guess that there should be no need to check for ping6 when this bug is fixed","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def test_slaac_from_os(self):"},{"line_number":129,"context_line":"        self._prepare_and_test(address6_mode\u003dself.slaac)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @test.skip_because(bug\u003d\u00271366326\u0027)"},{"line_number":132,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":133,"context_line":"    def test_dhcp6_stateful_from_os(self):"},{"line_number":134,"context_line":"        self._prepare_and_test(address6_mode\u003dself.stateful)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_9b9b4417","line":131,"updated":"2014-11-24 22:12:48.000000000","message":"tempest doesn\u0027t accept skipped test, you have to remove it. Add it after bug will be resolved.","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def test_slaac_from_os(self):"},{"line_number":129,"context_line":"        self._prepare_and_test(address6_mode\u003dself.slaac)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @test.skip_because(bug\u003d\u00271366326\u0027)"},{"line_number":132,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":133,"context_line":"    def test_dhcp6_stateful_from_os(self):"},{"line_number":134,"context_line":"        self._prepare_and_test(address6_mode\u003dself.stateful)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_fe4c28a0","line":131,"in_reply_to":"5a890539_9b9b4417","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"588ed50757812708bdb1e33e5cd1bf01d3925560","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self._prepare_and_test(address6_mode\u003dself.stateful)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @test.skip_because(bug\u003d\u00271366326\u0027)"},{"line_number":137,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":138,"context_line":"    def test_dhcp6_stateless_from_os(self):"},{"line_number":139,"context_line":"        self._prepare_and_test(address6_mode\u003dself.stateless)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_3b9090ec","line":137,"updated":"2014-11-24 22:12:48.000000000","message":"tempest doesn\u0027t accept skipped test, you have to remove it.","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"fa7f1a2da28f954a1d4e4402e2052b2d7b85fbc8","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self._prepare_and_test(address6_mode\u003dself.stateful)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @test.skip_because(bug\u003d\u00271366326\u0027)"},{"line_number":137,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":138,"context_line":"    def test_dhcp6_stateless_from_os(self):"},{"line_number":139,"context_line":"        self._prepare_and_test(address6_mode\u003dself.stateless)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_5e461c7c","line":137,"in_reply_to":"5a890539_3b9090ec","updated":"2014-11-25 12:59:59.000000000","message":"Done","commit_id":"d1885855bf9361aa788b1557c21ba30badf57746"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"cfa0c317f0812fb2c62a403c977de7535ca25c5a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"},{"line_number":25,"context_line":"    stateful \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":26,"context_line":"    stateless \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":27,"context_line":"    slaac \u003d \u0027slaac\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_a8225eb6","line":25,"updated":"2014-11-25 13:11:59.000000000","message":"not used","commit_id":"8c69c13b6db5b724302ec2dc1042fe7adfa40216"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"971d059bb72836068fb361397afa8daec030c3fd","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"},{"line_number":25,"context_line":"    stateful \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":26,"context_line":"    stateless \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":27,"context_line":"    slaac \u003d \u0027slaac\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_836f452a","line":25,"in_reply_to":"5a890539_a8225eb6","updated":"2014-11-25 13:28:07.000000000","message":"Done","commit_id":"8c69c13b6db5b724302ec2dc1042fe7adfa40216"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"cfa0c317f0812fb2c62a403c977de7535ca25c5a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"},{"line_number":25,"context_line":"    stateful \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":26,"context_line":"    stateless \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":27,"context_line":"    slaac \u003d \u0027slaac\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_489e5a08","line":27,"updated":"2014-11-25 13:11:59.000000000","message":"Global variables.","commit_id":"8c69c13b6db5b724302ec2dc1042fe7adfa40216"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"971d059bb72836068fb361397afa8daec030c3fd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"},{"line_number":25,"context_line":"    stateful \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":26,"context_line":"    stateless \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":27,"context_line":"    slaac \u003d \u0027slaac\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_c375cdfa","line":27,"in_reply_to":"5a890539_489e5a08","updated":"2014-11-25 13:28:07.000000000","message":"Done","commit_id":"8c69c13b6db5b724302ec2dc1042fe7adfa40216"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"cfa0c317f0812fb2c62a403c977de7535ca25c5a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            cmd\u003d\u0027ping -c1 {0}\u0027.format(srv1[\u0027accessIPv4\u0027]))"},{"line_number":119,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # uncomment when https://bugs.launchpad.net/tempest/+bug/1366326 solved"},{"line_number":122,"context_line":"        # result \u003d ssh1.exec_command("},{"line_number":123,"context_line":"        #     cmd\u003d\u0027ping6 -c1 {0}\u0027.format(srv2[\u0027accessIPv6\u0027]))"},{"line_number":124,"context_line":"        # self.assertIn(\u00270% packet loss\u0027, result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_e8a38640","line":121,"updated":"2014-11-25 13:11:59.000000000","message":"it should be removed until bug is fixed","commit_id":"8c69c13b6db5b724302ec2dc1042fe7adfa40216"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"971d059bb72836068fb361397afa8daec030c3fd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            cmd\u003d\u0027ping -c1 {0}\u0027.format(srv1[\u0027accessIPv4\u0027]))"},{"line_number":119,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # uncomment when https://bugs.launchpad.net/tempest/+bug/1366326 solved"},{"line_number":122,"context_line":"        # result \u003d ssh1.exec_command("},{"line_number":123,"context_line":"        #     cmd\u003d\u0027ping6 -c1 {0}\u0027.format(srv2[\u0027accessIPv6\u0027]))"},{"line_number":124,"context_line":"        # self.assertIn(\u00270% packet loss\u0027, result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_e370090a","line":121,"in_reply_to":"5a890539_e8a38640","updated":"2014-11-25 13:28:07.000000000","message":"Done","commit_id":"8c69c13b6db5b724302ec2dc1042fe7adfa40216"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"cfa0c317f0812fb2c62a403c977de7535ca25c5a","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":130,"context_line":"    def test_slaac_from_os(self):"},{"line_number":131,"context_line":"        self._prepare_and_test(address6_mode\u003dself.slaac)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_083452fa","line":131,"updated":"2014-11-25 13:11:59.000000000","message":"add stateless","commit_id":"8c69c13b6db5b724302ec2dc1042fe7adfa40216"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"971d059bb72836068fb361397afa8daec030c3fd","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":130,"context_line":"    def test_slaac_from_os(self):"},{"line_number":131,"context_line":"        self._prepare_and_test(address6_mode\u003dself.slaac)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_635c197e","line":131,"in_reply_to":"5a890539_083452fa","updated":"2014-11-25 13:28:07.000000000","message":"Done","commit_id":"8c69c13b6db5b724302ec2dc1042fe7adfa40216"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"e60f00a98682865aa19a897ab37931fc360c97c3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def check_preconditions(cls):"},{"line_number":34,"context_line":"        super(TestGettingAddress, cls).check_preconditions()"},{"line_number":35,"context_line":"        if not (CONF.network.tenant_networks_reachable"},{"line_number":36,"context_line":"                or CONF.network.public_network_id):"},{"line_number":37,"context_line":"            msg \u003d (\u0027Either tenant_networks_reachable must be \"true\", or \u0027"},{"line_number":38,"context_line":"                   \u0027public_network_id must be defined.\u0027)"},{"line_number":39,"context_line":"            cls.enabled \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_1bad709b","line":36,"updated":"2014-11-25 18:33:42.000000000","message":"shouldn\u0027t this check for IPv6 enabled as well?","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"e6854c974f73870d19ed9d9daf47db34c3f33e06","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def check_preconditions(cls):"},{"line_number":34,"context_line":"        super(TestGettingAddress, cls).check_preconditions()"},{"line_number":35,"context_line":"        if not (CONF.network.tenant_networks_reachable"},{"line_number":36,"context_line":"                or CONF.network.public_network_id):"},{"line_number":37,"context_line":"            msg \u003d (\u0027Either tenant_networks_reachable must be \"true\", or \u0027"},{"line_number":38,"context_line":"                   \u0027public_network_id must be defined.\u0027)"},{"line_number":39,"context_line":"            cls.enabled \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_f069878c","line":36,"in_reply_to":"5a890539_1bad709b","updated":"2014-11-26 12:10:31.000000000","message":"Done","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"e60f00a98682865aa19a897ab37931fc360c97c3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.addCleanup(sub4.delete)"},{"line_number":70,"context_line":"        self.addCleanup(sub6.delete)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def define_server_ips(self, srv):"},{"line_number":73,"context_line":"        for net_name, nics in srv[\u0027addresses\u0027].iteritems():"},{"line_number":74,"context_line":"            for nic in nics:"},{"line_number":75,"context_line":"                if nic[\u0027version\u0027] \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_1b37304e","line":72,"updated":"2014-11-25 18:33:42.000000000","message":"this should be a static method","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"e6854c974f73870d19ed9d9daf47db34c3f33e06","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.addCleanup(sub4.delete)"},{"line_number":70,"context_line":"        self.addCleanup(sub6.delete)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def define_server_ips(self, srv):"},{"line_number":73,"context_line":"        for net_name, nics in srv[\u0027addresses\u0027].iteritems():"},{"line_number":74,"context_line":"            for nic in nics:"},{"line_number":75,"context_line":"                if nic[\u0027version\u0027] \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_3cbe8b65","line":72,"in_reply_to":"5a890539_1b37304e","updated":"2014-11-26 12:10:31.000000000","message":"Done","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"e60f00a98682865aa19a897ab37931fc360c97c3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return ssh, srv"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _prepare_and_test(self, address6_mode):"},{"line_number":94,"context_line":"        \"\"\"Create network with 2 subnets: IPv4 and IPv6in a given address mode"},{"line_number":95,"context_line":"        Boot 2 VMs on this network"},{"line_number":96,"context_line":"        Allocate and assign 2 FIP4"},{"line_number":97,"context_line":"        Check that vNIC of server get correct IPv4 and IPv6"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_7b74b435","line":94,"updated":"2014-11-25 18:33:42.000000000","message":"please add this to Class and/or test_methods docstring","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"e6854c974f73870d19ed9d9daf47db34c3f33e06","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return ssh, srv"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _prepare_and_test(self, address6_mode):"},{"line_number":94,"context_line":"        \"\"\"Create network with 2 subnets: IPv4 and IPv6in a given address mode"},{"line_number":95,"context_line":"        Boot 2 VMs on this network"},{"line_number":96,"context_line":"        Allocate and assign 2 FIP4"},{"line_number":97,"context_line":"        Check that vNIC of server get correct IPv4 and IPv6"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_30014f05","line":94,"in_reply_to":"5a890539_7b74b435","updated":"2014-11-26 12:10:31.000000000","message":"Done","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"e60f00a98682865aa19a897ab37931fc360c97c3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"\"\"Create network with 2 subnets: IPv4 and IPv6in a given address mode"},{"line_number":95,"context_line":"        Boot 2 VMs on this network"},{"line_number":96,"context_line":"        Allocate and assign 2 FIP4"},{"line_number":97,"context_line":"        Check that vNIC of server get correct IPv4 and IPv6"},{"line_number":98,"context_line":"        Ping4 tenant IPv4 of one VM from another one"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        self.prepare_network(address6_mode\u003daddress6_mode)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_db1da874","line":97,"updated":"2014-11-25 18:33:42.000000000","message":"should be \"Check that vNIC of server matches server/port data from nova/neutron DB\"","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"e6854c974f73870d19ed9d9daf47db34c3f33e06","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"\"\"Create network with 2 subnets: IPv4 and IPv6in a given address mode"},{"line_number":95,"context_line":"        Boot 2 VMs on this network"},{"line_number":96,"context_line":"        Allocate and assign 2 FIP4"},{"line_number":97,"context_line":"        Check that vNIC of server get correct IPv4 and IPv6"},{"line_number":98,"context_line":"        Ping4 tenant IPv4 of one VM from another one"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        self.prepare_network(address6_mode\u003daddress6_mode)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_fc03230d","line":97,"in_reply_to":"5a890539_db1da874","updated":"2014-11-26 12:10:31.000000000","message":"Done","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"e60f00a98682865aa19a897ab37931fc360c97c3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        ssh1, srv1 \u003d self.prepare_server()"},{"line_number":103,"context_line":"        ssh2, srv2 \u003d self.prepare_server()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        result \u003d ssh1.exec_command(\u0027ip addr show dev eth0\u0027)"},{"line_number":106,"context_line":"        self.assertIn(srv1[\u0027accessIPv4\u0027], result)"},{"line_number":107,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":108,"context_line":"        self.assertIn(srv1[\u0027accessIPv6\u0027], result)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_7be3d4a3","line":105,"updated":"2014-11-25 18:33:42.000000000","message":"what if image has different nic names than \"eth0\"?\n\nIMO, the \"ip a\" should be parsed for clearer result in remote_client.py","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"e6854c974f73870d19ed9d9daf47db34c3f33e06","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        ssh1, srv1 \u003d self.prepare_server()"},{"line_number":103,"context_line":"        ssh2, srv2 \u003d self.prepare_server()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        result \u003d ssh1.exec_command(\u0027ip addr show dev eth0\u0027)"},{"line_number":106,"context_line":"        self.assertIn(srv1[\u0027accessIPv4\u0027], result)"},{"line_number":107,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":108,"context_line":"        self.assertIn(srv1[\u0027accessIPv6\u0027], result)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_50941b36","line":105,"in_reply_to":"5a890539_7be3d4a3","updated":"2014-11-26 12:10:31.000000000","message":"Done","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"e60f00a98682865aa19a897ab37931fc360c97c3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.assertIn(srv2[\u0027accessIPv4\u0027], result)"},{"line_number":111,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":112,"context_line":"        self.assertIn(srv2[\u0027accessIPv6\u0027], result)"},{"line_number":113,"context_line":"        result \u003d ssh1.exec_command("},{"line_number":114,"context_line":"            cmd\u003d\u0027ping -c1 {0}\u0027.format(srv2[\u0027accessIPv4\u0027]))"},{"line_number":115,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":116,"context_line":"        result \u003d ssh2.exec_command("}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_9be08027","line":113,"updated":"2014-11-25 18:33:42.000000000","message":"why not use ssh1.ping_host?\nAlso, what if the network isn\u0027t immediately ready for traffic? we have check_connectivity with waiter to verify connectivity within time-limit\nsee network_basic_ops for example\n\nIf you have a valid reason not to use pre-existing connectivity check, please state this in comment/docstring","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"e6854c974f73870d19ed9d9daf47db34c3f33e06","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.assertIn(srv2[\u0027accessIPv4\u0027], result)"},{"line_number":111,"context_line":"        # v6 should be configured since the image supports it"},{"line_number":112,"context_line":"        self.assertIn(srv2[\u0027accessIPv6\u0027], result)"},{"line_number":113,"context_line":"        result \u003d ssh1.exec_command("},{"line_number":114,"context_line":"            cmd\u003d\u0027ping -c1 {0}\u0027.format(srv2[\u0027accessIPv4\u0027]))"},{"line_number":115,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":116,"context_line":"        result \u003d ssh2.exec_command("}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_d0780b2d","line":113,"in_reply_to":"5a890539_9be08027","updated":"2014-11-26 12:10:31.000000000","message":"partly agree, will use ping_host. concerning testing connectivity- it\u0027s done when getting remote client for the server. It goes through _get_ssh_connection with a number of re-tries. Although it goes through FIP4 path, it difficult to imagine the situation with significant dealy in between IPv4 and IPv6 addresses assignment","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"e60f00a98682865aa19a897ab37931fc360c97c3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        result \u003d ssh1.exec_command("},{"line_number":114,"context_line":"            cmd\u003d\u0027ping -c1 {0}\u0027.format(srv2[\u0027accessIPv4\u0027]))"},{"line_number":115,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":116,"context_line":"        result \u003d ssh2.exec_command("},{"line_number":117,"context_line":"            cmd\u003d\u0027ping -c1 {0}\u0027.format(srv1[\u0027accessIPv4\u0027]))"},{"line_number":118,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_3bfb0cc2","line":116,"updated":"2014-11-25 18:33:42.000000000","message":"same here","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"e6854c974f73870d19ed9d9daf47db34c3f33e06","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        result \u003d ssh1.exec_command("},{"line_number":114,"context_line":"            cmd\u003d\u0027ping -c1 {0}\u0027.format(srv2[\u0027accessIPv4\u0027]))"},{"line_number":115,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":116,"context_line":"        result \u003d ssh2.exec_command("},{"line_number":117,"context_line":"            cmd\u003d\u0027ping -c1 {0}\u0027.format(srv1[\u0027accessIPv4\u0027]))"},{"line_number":118,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_f073474b","line":116,"in_reply_to":"5a890539_3bfb0cc2","updated":"2014-11-26 12:10:31.000000000","message":"Done","commit_id":"ab9e97edeb71fc44b9bfbaebc53e783d8d5baeca"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"620d1e8552feffcead613ee5fd43674a6dffbe5f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    Boot 2 VMs on this network"},{"line_number":27,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":28,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":29,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_6a2e65fc","line":29,"updated":"2014-11-27 08:07:01.000000000","message":"pinging ipv4 is already covered in scenarios. why not ping IPv6 address? that\u0027s the special case here, isn\u0027t it?","commit_id":"c64399cead6e2b088defea2f3ec581c1980cb7bf"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"0461631442a9fa6ecfb872e826ef3410f8c23e49","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    Boot 2 VMs on this network"},{"line_number":27,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":28,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":29,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_c7390ff4","line":29,"in_reply_to":"5a890539_6a2e65fc","updated":"2014-11-27 10:28:05.000000000","message":"it\u0027s due to cirros image. It does not have ping6 utility. Check patchset1- it had ping6 commented out with a link to corresponding bug. Then I\u0027ve been asked to remove it since commented code is not accepted in upstream","commit_id":"c64399cead6e2b088defea2f3ec581c1980cb7bf"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"620d1e8552feffcead613ee5fd43674a6dffbe5f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":58,"context_line":"            \u0027security_groups\u0027: [self.sec_grp]}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def prepare_network(self, address6_mode):"},{"line_number":61,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"},{"line_number":62,"context_line":"        sub4 \u003d self._create_subnet(network\u003dnet,"},{"line_number":63,"context_line":"                                   namestart\u003d\u0027sub4\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_8a97113a","line":60,"updated":"2014-11-27 08:07:01.000000000","message":"I\u0027d still appreciate a docstring for this method","commit_id":"c64399cead6e2b088defea2f3ec581c1980cb7bf"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"0461631442a9fa6ecfb872e826ef3410f8c23e49","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":58,"context_line":"            \u0027security_groups\u0027: [self.sec_grp]}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def prepare_network(self, address6_mode):"},{"line_number":61,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"},{"line_number":62,"context_line":"        sub4 \u003d self._create_subnet(network\u003dnet,"},{"line_number":63,"context_line":"                                   namestart\u003d\u0027sub4\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_c7102f5c","line":60,"in_reply_to":"5a890539_8a97113a","updated":"2014-11-27 10:28:05.000000000","message":"Done","commit_id":"c64399cead6e2b088defea2f3ec581c1980cb7bf"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"aff6b0cb0995ca47a11316b596dcf829e0dc297e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":29,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":30,"context_line":"    Will do the same with ping6 when"},{"line_number":31,"context_line":"    https://bugs.launchpad.net/tempest/+bug/1366326 resolved"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_bd3fb486","line":31,"updated":"2014-11-27 11:05:30.000000000","message":"I agree with you that cirros currently does not include ping6 utility.\nHowever, since we can configure tempest to run on our local setup with a different image-id (which includes ping6 utility), it would be good to check the VM for the ping6 utility. We could run the test, if the VM includes the utility and skip it otherwise.\n\nPlease have a look at my old patch which includes this support.\nhttps://review.openstack.org/#/c/100143/6/tempest/scenario/test_provider_net_ops.py","commit_id":"34383db866850da91e2ac4aea0e2cd9dfe8a1d0d"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"64be7584688c7cf86eacfd0b346e166a8cc8d0da","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":29,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":30,"context_line":"    Will do the same with ping6 when"},{"line_number":31,"context_line":"    https://bugs.launchpad.net/tempest/+bug/1366326 resolved"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_f1fc0475","line":31,"in_reply_to":"5a890539_bd3fb486","updated":"2014-11-27 13:39:00.000000000","message":"Done","commit_id":"34383db866850da91e2ac4aea0e2cd9dfe8a1d0d"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"aff6b0cb0995ca47a11316b596dcf829e0dc297e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        sub4.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":85,"context_line":"        sub6.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.addCleanup(sub4.delete)"},{"line_number":87,"context_line":"        self.addCleanup(sub6.delete)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @staticmethod"},{"line_number":90,"context_line":"    def define_server_ips(srv):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_1aab6e1f","line":87,"updated":"2014-11-27 11:05:30.000000000","message":"Please check if we really need these statements. \nIMO they may not be required as its handled in _create_subnet() api.","commit_id":"34383db866850da91e2ac4aea0e2cd9dfe8a1d0d"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"64be7584688c7cf86eacfd0b346e166a8cc8d0da","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        sub4.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":85,"context_line":"        sub6.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.addCleanup(sub4.delete)"},{"line_number":87,"context_line":"        self.addCleanup(sub6.delete)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @staticmethod"},{"line_number":90,"context_line":"    def define_server_ips(srv):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_938bc91d","line":87,"in_reply_to":"5a890539_1aab6e1f","updated":"2014-11-27 13:39:00.000000000","message":"They are required. Without them cleanup will fail to delete the router since ports are not added for cleanup in add_to_router","commit_id":"34383db866850da91e2ac4aea0e2cd9dfe8a1d0d"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"aff6b0cb0995ca47a11316b596dcf829e0dc297e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    srv[\u0027accessIPv4\u0027] \u003d nic[\u0027addr\u0027]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def prepare_server(self):"},{"line_number":99,"context_line":"        image_id \u003d CONF.compute.image_ref"},{"line_number":100,"context_line":"        username \u003d CONF.compute.image_ssh_user"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        srv \u003d self.create_server(create_kwargs\u003dself.srv_kwargs, image\u003dimage_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_fa5b0253","line":99,"updated":"2014-11-27 11:05:30.000000000","message":"image_id can be removed as create_server uses the same value when image is None.","commit_id":"34383db866850da91e2ac4aea0e2cd9dfe8a1d0d"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"64be7584688c7cf86eacfd0b346e166a8cc8d0da","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    srv[\u0027accessIPv4\u0027] \u003d nic[\u0027addr\u0027]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def prepare_server(self):"},{"line_number":99,"context_line":"        image_id \u003d CONF.compute.image_ref"},{"line_number":100,"context_line":"        username \u003d CONF.compute.image_ssh_user"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        srv \u003d self.create_server(create_kwargs\u003dself.srv_kwargs, image\u003dimage_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_f3796d31","line":99,"in_reply_to":"5a890539_fa5b0253","updated":"2014-11-27 13:39:00.000000000","message":"Done","commit_id":"34383db866850da91e2ac4aea0e2cd9dfe8a1d0d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a5d0ff5d1f8b17850d19fd3aa88a397cbd1c6a7c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":29,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":30,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":31,"context_line":"    Will do the same with ping6 when if available in VM"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_da155d9c","line":31,"updated":"2014-11-27 15:58:47.000000000","message":"is it missing in cirros images? is the limitation tracked in any bug?","commit_id":"6219be77b1a80180348c32889853a291931860de"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"0d087ab5143ee3acad41c2c49a23115a184c1850","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":29,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":30,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":31,"context_line":"    Will do the same with ping6 when if available in VM"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_e050a80c","line":31,"in_reply_to":"5a890539_da155d9c","updated":"2014-11-27 16:24:25.000000000","message":"yes in https://bugs.launchpad.net/tempest/+bug/1366326","commit_id":"6219be77b1a80180348c32889853a291931860de"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a5d0ff5d1f8b17850d19fd3aa88a397cbd1c6a7c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            result \u003d ssh2.exec_command("},{"line_number":135,"context_line":"                cmd\u003d\u0027ping6 -c1 {0}\u0027.format(srv1[\u0027accessIPv6\u0027]))"},{"line_number":136,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":137,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":138,"context_line":"            pass"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_7ae389a4","line":137,"updated":"2014-11-27 15:58:47.000000000","message":"I don\u0027t think tests should be that liberal if ping6 is not present. Can\u0027t we make sure we use the proper image, and fail/warn if not?","commit_id":"6219be77b1a80180348c32889853a291931860de"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"0d087ab5143ee3acad41c2c49a23115a184c1850","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            result \u003d ssh2.exec_command("},{"line_number":135,"context_line":"                cmd\u003d\u0027ping6 -c1 {0}\u0027.format(srv1[\u0027accessIPv6\u0027]))"},{"line_number":136,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":137,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":138,"context_line":"            pass"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_a05dc017","line":137,"in_reply_to":"5a890539_7ae389a4","updated":"2014-11-27 16:24:25.000000000","message":"that what I do in my local testing. In upstream AFAIK there\u0027s feeling to not accept tests which fail. When new cirros image ready try-except block is to be removed","commit_id":"6219be77b1a80180348c32889853a291931860de"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"7c92bc5055b5fb95583476d0efc9ffb4b460b268","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"},{"line_number":26,"context_line":"    \"\"\"Create network with 2 subnets: IPv4 and IPv6in a given address mode"},{"line_number":27,"context_line":"    Boot 2 VMs on this network"},{"line_number":28,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":29,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_f0123508","line":26,"updated":"2014-11-27 22:33:13.000000000","message":"typo: IPv6 in","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestGettingAddress(manager.NetworkScenarioTest):"},{"line_number":26,"context_line":"    \"\"\"Create network with 2 subnets: IPv4 and IPv6in a given address mode"},{"line_number":27,"context_line":"    Boot 2 VMs on this network"},{"line_number":28,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":29,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_825c3e4e","line":26,"in_reply_to":"5a890539_f0123508","updated":"2014-11-28 10:06:16.000000000","message":"Done","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"7c92bc5055b5fb95583476d0efc9ffb4b460b268","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":29,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":30,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":31,"context_line":"    Will do the same with ping6 when if available in VM"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_10f7c1d5","line":31,"updated":"2014-11-27 22:33:13.000000000","message":"remove \u0027if\u0027","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    Allocate and assign 2 FIP4"},{"line_number":29,"context_line":"    Check that vNIC of server matches port data from OpenStack DB"},{"line_number":30,"context_line":"    Ping4 tenant IPv4 of one VM from another one"},{"line_number":31,"context_line":"    Will do the same with ping6 when if available in VM"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_a2593a5d","line":31,"in_reply_to":"5a890539_10f7c1d5","updated":"2014-11-28 10:06:16.000000000","message":"Done","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"7c92bc5055b5fb95583476d0efc9ffb4b460b268","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def prepare_network(self, address6_mode):"},{"line_number":63,"context_line":"        \"\"\"Creates network with"},{"line_number":64,"context_line":"         one IPv6 sub-network in the given mode and"},{"line_number":65,"context_line":"         one IPv4 sub-network."},{"line_number":66,"context_line":"         Creates router with ports on both sub-networks"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_903571aa","line":65,"updated":"2014-11-27 22:33:13.000000000","message":"s/sub-network/subnet","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def prepare_network(self, address6_mode):"},{"line_number":63,"context_line":"        \"\"\"Creates network with"},{"line_number":64,"context_line":"         one IPv6 sub-network in the given mode and"},{"line_number":65,"context_line":"         one IPv4 sub-network."},{"line_number":66,"context_line":"         Creates router with ports on both sub-networks"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_e2534237","line":65,"in_reply_to":"5a890539_903571aa","updated":"2014-11-28 10:06:16.000000000","message":"Done","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"7c92bc5055b5fb95583476d0efc9ffb4b460b268","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\"Creates network with"},{"line_number":64,"context_line":"         one IPv6 sub-network in the given mode and"},{"line_number":65,"context_line":"         one IPv4 sub-network."},{"line_number":66,"context_line":"         Creates router with ports on both sub-networks"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"},{"line_number":69,"context_line":"        sub4 \u003d self._create_subnet(network\u003dnet,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_b03a6d96","line":66,"updated":"2014-11-27 22:33:13.000000000","message":"s/sub-networks/subnets","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\"Creates network with"},{"line_number":64,"context_line":"         one IPv6 sub-network in the given mode and"},{"line_number":65,"context_line":"         one IPv4 sub-network."},{"line_number":66,"context_line":"         Creates router with ports on both sub-networks"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        net \u003d self._create_network(tenant_id\u003dself.tenant_id)"},{"line_number":69,"context_line":"        sub4 \u003d self._create_subnet(network\u003dnet,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_02304e06","line":66,"in_reply_to":"5a890539_b03a6d96","updated":"2014-11-28 10:06:16.000000000","message":"Done","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"7c92bc5055b5fb95583476d0efc9ffb4b460b268","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                   namestart\u003d\u0027sub4\u0027,"},{"line_number":71,"context_line":"                                   ip_version\u003d4,)"},{"line_number":72,"context_line":"        # since https://bugs.launchpad.net/neutron/+bug/1394112 we need"},{"line_number":73,"context_line":"        # to specify gateway_ip manually"},{"line_number":74,"context_line":"        net_range \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":75,"context_line":"        gateway_ip \u003d (netaddr.IPAddress(net_range) + 1).format()"},{"line_number":76,"context_line":"        sub6 \u003d self._create_subnet(network\u003dnet,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_705005d5","line":73,"updated":"2014-11-27 22:33:13.000000000","message":"do you plan to change after the bug is fixed? I think you can just provide a gateway here without referring to it since that bug will be fixed anyway.","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                   namestart\u003d\u0027sub4\u0027,"},{"line_number":71,"context_line":"                                   ip_version\u003d4,)"},{"line_number":72,"context_line":"        # since https://bugs.launchpad.net/neutron/+bug/1394112 we need"},{"line_number":73,"context_line":"        # to specify gateway_ip manually"},{"line_number":74,"context_line":"        net_range \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":75,"context_line":"        gateway_ip \u003d (netaddr.IPAddress(net_range) + 1).format()"},{"line_number":76,"context_line":"        sub6 \u003d self._create_subnet(network\u003dnet,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_e518ac77","line":73,"in_reply_to":"5a890539_705005d5","updated":"2014-11-28 10:06:16.000000000","message":"yes I think that it\u0027s better to allow neutron to do the job. This is scenario test, so it\u0027s better to test more things.","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"63f94d2e461be0696c4a2b738cc179f2268f227a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    srv[\u0027accessIPv4\u0027] \u003d nic[\u0027addr\u0027]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def prepare_server(self):"},{"line_number":99,"context_line":"        username \u003d CONF.compute.image_ssh_user"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        srv \u003d self.create_server(create_kwargs\u003dself.srv_kwargs)"},{"line_number":102,"context_line":"        ex_net \u003d CONF.network.public_network_id"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_2bd531b9","line":99,"updated":"2014-11-27 17:38:59.000000000","message":"I am sorry I didn\u0027t go through all the patchset but :\n * Why not use CONF.scenario.ssh_user ? or better yet let get_remote_client() choose the right username","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    srv[\u0027accessIPv4\u0027] \u003d nic[\u0027addr\u0027]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def prepare_server(self):"},{"line_number":99,"context_line":"        username \u003d CONF.compute.image_ssh_user"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        srv \u003d self.create_server(create_kwargs\u003dself.srv_kwargs)"},{"line_number":102,"context_line":"        ex_net \u003d CONF.network.public_network_id"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_253b949d","line":99,"in_reply_to":"5a890539_2bd531b9","updated":"2014-11-28 10:06:16.000000000","message":"Here I\u0027m not sure. Although CONF.scenario.ssh_user \u003d\u003d \u0027cirros\u0027 by default,\nthe way it\u0027s defined looks like its not a property of image itself","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"63f94d2e461be0696c4a2b738cc179f2268f227a","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        srv \u003d self.create_server(create_kwargs\u003dself.srv_kwargs)"},{"line_number":102,"context_line":"        ex_net \u003d CONF.network.public_network_id"},{"line_number":103,"context_line":"        fip \u003d self.create_floating_ip(thing\u003dsrv, external_network_id\u003dex_net)"},{"line_number":104,"context_line":"        self.define_server_ips(srv\u003dsrv)"},{"line_number":105,"context_line":"        ssh \u003d self.get_remote_client("},{"line_number":106,"context_line":"            server_or_ip\u003dfip.floating_ip_address,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_4bd99df3","line":103,"updated":"2014-11-27 17:38:59.000000000","message":"Same here. CONF.network.public_network_id is already the default in create_floating_ip().","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        srv \u003d self.create_server(create_kwargs\u003dself.srv_kwargs)"},{"line_number":102,"context_line":"        ex_net \u003d CONF.network.public_network_id"},{"line_number":103,"context_line":"        fip \u003d self.create_floating_ip(thing\u003dsrv, external_network_id\u003dex_net)"},{"line_number":104,"context_line":"        self.define_server_ips(srv\u003dsrv)"},{"line_number":105,"context_line":"        ssh \u003d self.get_remote_client("},{"line_number":106,"context_line":"            server_or_ip\u003dfip.floating_ip_address,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_45f26007","line":103,"in_reply_to":"5a890539_4bd99df3","updated":"2014-11-28 10:06:16.000000000","message":"Done","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"7c92bc5055b5fb95583476d0efc9ffb4b460b268","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.assertIn(srv2[\u0027accessIPv6\u0027], result)"},{"line_number":124,"context_line":"        result \u003d ssh1.ping_host(srv2[\u0027accessIPv4\u0027])"},{"line_number":125,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":126,"context_line":"        result \u003d ssh2.ping_host(srv1[\u0027accessIPv4\u0027])"},{"line_number":127,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Some VM (like cirros) may not have ping6 utility"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_b008adda","line":126,"updated":"2014-11-27 22:33:13.000000000","message":"Nit: Not sure why the order gets changed here: ping srv2 followed by srv1.","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"fb1f982b7bb8a4f3a81e751f8439473bc3d29d9e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.assertIn(srv2[\u0027accessIPv6\u0027], result)"},{"line_number":124,"context_line":"        result \u003d ssh1.ping_host(srv2[\u0027accessIPv4\u0027])"},{"line_number":125,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":126,"context_line":"        result \u003d ssh2.ping_host(srv1[\u0027accessIPv4\u0027])"},{"line_number":127,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Some VM (like cirros) may not have ping6 utility"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_eb9956d1","line":126,"in_reply_to":"5a890539_0573f8b4","updated":"2014-11-28 14:42:34.000000000","message":"got it. thanks.","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.assertIn(srv2[\u0027accessIPv6\u0027], result)"},{"line_number":124,"context_line":"        result \u003d ssh1.ping_host(srv2[\u0027accessIPv4\u0027])"},{"line_number":125,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":126,"context_line":"        result \u003d ssh2.ping_host(srv1[\u0027accessIPv4\u0027])"},{"line_number":127,"context_line":"        self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Some VM (like cirros) may not have ping6 utility"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_0573f8b4","line":126,"in_reply_to":"5a890539_b008adda","updated":"2014-11-28 10:06:16.000000000","message":"first we ping vm2 from vm1 then vice versa","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7dae3471eea5991f99e37b683666ba5bd67ad96e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":133,"context_line":"            result \u003d ssh2.ping_host(srv1[\u0027accessIPv6\u0027])"},{"line_number":134,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":135,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":136,"context_line":"            pass"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_bd3406fc","line":135,"updated":"2014-11-27 21:38:20.000000000","message":"What about logging here? \"Ping6 is not available, so skipped\"","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"04b2b93f71b59c7db330990fa758b5b55a4b22e2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":133,"context_line":"            result \u003d ssh2.ping_host(srv1[\u0027accessIPv6\u0027])"},{"line_number":134,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":135,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":136,"context_line":"            pass"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_c549f061","line":135,"in_reply_to":"5a890539_bd3406fc","updated":"2014-11-28 10:06:16.000000000","message":"Done","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"7c92bc5055b5fb95583476d0efc9ffb4b460b268","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":133,"context_line":"            result \u003d ssh2.ping_host(srv1[\u0027accessIPv6\u0027])"},{"line_number":134,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":135,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":136,"context_line":"            pass"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_f0e075fc","line":135,"in_reply_to":"5a890539_bd3406fc","updated":"2014-11-27 22:33:13.000000000","message":"Question: is the ping initiated from outside the VM? Does cirros have ipv6 stack running even through it doesn\u0027t have ping6 utility? \n\nAt least, the above comments may need to be corrected.","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"0a3f4b0676b125c21d722d8554fbb9778fb547ae","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":133,"context_line":"            result \u003d ssh2.ping_host(srv1[\u0027accessIPv6\u0027])"},{"line_number":134,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":135,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":136,"context_line":"            pass"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_3ff3a6a0","line":135,"in_reply_to":"5a890539_f0e075fc","updated":"2014-11-28 07:46:42.000000000","message":"Yes Robert, Cirros has the IPv6 stack running but it lacks the associated utilities (like ping6, IPv6 support in dhcp client etc). \n\nAs for the ping, it is actually initiated from within one VM to another.\n1. We spawn two VMs associated to a network that has both IPV4 subnet and IPv6 subnet.\n2. Create floating IPs for both the VM ports.\n3. Get an SSH client handle to each of the VMs.\n4. From VM1 (i.e., using SSH handle), ping VM2 and vice-versa.","commit_id":"2d6c2bd2f7545a08637f84832dd8f7472050b529"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0da7cc87e4668d1fd2150cb05792fcda431fa878","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":134,"context_line":"            result \u003d ssh2.ping_host(srv1[\u0027accessIPv6\u0027])"},{"line_number":135,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":136,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":137,"context_line":"            LOG.warning(\u0027Ping6 is not available, skipping\u0027)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a890539_b9595f37","line":136,"updated":"2014-11-29 16:15:45.000000000","message":"what if ping6 exists but the command fails for some other reason? this would mask the exception.\nwither verify that the exception is really \"command doesn\u0027t exist\" or check for command before (\"whereis\") and only run this block if exists","commit_id":"3aaca22f689162abfba194e72aaed8c929d18f7c"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"93a277d2a36ced11908cd4f22d0ce504958421b0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":134,"context_line":"            result \u003d ssh2.ping_host(srv1[\u0027accessIPv6\u0027])"},{"line_number":135,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"},{"line_number":136,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":137,"context_line":"            LOG.warning(\u0027Ping6 is not available, skipping\u0027)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a890539_88f6f98e","line":136,"in_reply_to":"5a890539_b9595f37","updated":"2014-12-01 13:54:36.000000000","message":"Done","commit_id":"3aaca22f689162abfba194e72aaed8c929d18f7c"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"7aa60849542d96bd37cf6381ed3817e4ea1f26f6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest import exceptions"},{"line_number":18,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":19,"context_line":"from tempest.scenario import manager"},{"line_number":20,"context_line":"from tempest import test"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a890539_9fa1d048","line":17,"updated":"2014-12-01 14:48:32.000000000","message":"This is unused, so pep8 fails.","commit_id":"46bf2d3419e1eea1f5135d5d867b9046e3a6bced"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"c93e9aad71fa224fae554d985eb264a8d3bc730c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest import exceptions"},{"line_number":18,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":19,"context_line":"from tempest.scenario import manager"},{"line_number":20,"context_line":"from tempest import test"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a890539_d257cf25","line":17,"in_reply_to":"5a890539_9fa1d048","updated":"2014-12-01 15:16:49.000000000","message":"Done","commit_id":"46bf2d3419e1eea1f5135d5d867b9046e3a6bced"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"6cfdc7b6652a78d3b8096501c52f1caa74fd6f6c","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Some VM (like cirros) may not have ping6 utility"},{"line_number":130,"context_line":"        result \u003d ssh1.exec_command(\u0027whereis ping6\u0027)"},{"line_number":131,"context_line":"        is_ping6 \u003d False if result \u003d\u003d \u0027ping6:\\n\u0027 else True"},{"line_number":132,"context_line":"        if is_ping6:"},{"line_number":133,"context_line":"            result \u003d ssh1.ping_host(srv2[\u0027accessIPv6\u0027])"},{"line_number":134,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a890539_d8d525e6","line":131,"updated":"2014-12-01 19:53:07.000000000","message":"nit: better do is_ping6 \u003d (\u0027ping6\u0027 in result.strip())","commit_id":"14113579e8d78a49cbe576959d25b49c199bafb6"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"4bf9ca7415469a588525f81845c18e11ea8cbe25","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Some VM (like cirros) may not have ping6 utility"},{"line_number":130,"context_line":"        result \u003d ssh1.exec_command(\u0027whereis ping6\u0027)"},{"line_number":131,"context_line":"        is_ping6 \u003d False if result \u003d\u003d \u0027ping6:\\n\u0027 else True"},{"line_number":132,"context_line":"        if is_ping6:"},{"line_number":133,"context_line":"            result \u003d ssh1.ping_host(srv2[\u0027accessIPv6\u0027])"},{"line_number":134,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a890539_bdc10fe6","line":131,"in_reply_to":"5a890539_b9284886","updated":"2014-12-02 13:45:32.000000000","message":"please ignore my comment. I was unaware of how \"whereis\" works","commit_id":"14113579e8d78a49cbe576959d25b49c199bafb6"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"1e5940c657da91ed7ac83c0a466aedeb5a075cc7","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Some VM (like cirros) may not have ping6 utility"},{"line_number":130,"context_line":"        result \u003d ssh1.exec_command(\u0027whereis ping6\u0027)"},{"line_number":131,"context_line":"        is_ping6 \u003d False if result \u003d\u003d \u0027ping6:\\n\u0027 else True"},{"line_number":132,"context_line":"        if is_ping6:"},{"line_number":133,"context_line":"            result \u003d ssh1.ping_host(srv2[\u0027accessIPv6\u0027])"},{"line_number":134,"context_line":"            self.assertIn(\u00270% packet loss\u0027, result)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a890539_b9284886","line":131,"in_reply_to":"5a890539_d8d525e6","updated":"2014-12-02 10:34:05.000000000","message":"I believe it\u0027s not  correct. if ping6 is there you expect to get something like\nping6: /bin/ping6 /usr/share/man/man8/ping6.8.gz , Probably you meant:\n\nis_ping6 \u003d (\u0027ping6:\\n\u0027 !\u003d result)","commit_id":"14113579e8d78a49cbe576959d25b49c199bafb6"}]}