)]}'
{"tempest/scenario/test_network_advanced_server_ops.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"757fb68d3cb425c51baf8503d3be2bad1a51ec68","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def setUpClass(cls):"},{"line_number":54,"context_line":"        # Create no network resources for these tests."},{"line_number":55,"context_line":"        cls.set_network_resources()"},{"line_number":56,"context_line":"        super(TestNetworkAdvancedServerOps, cls).setUpClass()"},{"line_number":57,"context_line":"        for ext in [\u0027security-group\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_d6450918","line":54,"updated":"2014-09-02 02:43:34.000000000","message":"I don\u0027t understand the reason why do we need this change.\nWhat is the problem of original code?","commit_id":"e1e5236dfd2ebf5ffb71ba21277f08788a422bea"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"f32d6726de6feb805a276ffb024e4685dad83596","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def setUpClass(cls):"},{"line_number":54,"context_line":"        # Create no network resources for these tests."},{"line_number":55,"context_line":"        cls.set_network_resources()"},{"line_number":56,"context_line":"        super(TestNetworkAdvancedServerOps, cls).setUpClass()"},{"line_number":57,"context_line":"        for ext in [\u0027security-group\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_f28bf265","line":54,"in_reply_to":"fa98f980_d6450918","updated":"2014-09-07 10:20:47.000000000","message":"well, this was wrongly in setup instead of check_preconditions it might be out of scope a little but I don\u0027t want to leave it this way.\nHowever, don\u0027t know how the \u0027security_group\u0027 extension check got in. will remove it","commit_id":"e1e5236dfd2ebf5ffb71ba21277f08788a422bea"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0a46ecbc42e0df95f04bf51e6c1e0cf09cfd3d09","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def _setup_network_and_servers(self):"},{"line_number":59,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":60,"context_line":"        security_group \u003d self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":61,"context_line":"        network, router, subnet \u003d self.create_networks()"},{"line_number":62,"context_line":"        public_network_id \u003d CONF.network.public_network_id"},{"line_number":63,"context_line":"        create_kwargs \u003d {"},{"line_number":64,"context_line":"            \u0027nics\u0027: ["}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_84d419be","line":61,"updated":"2014-09-10 05:46:56.000000000","message":"I think NeutronScenarioTest.create_networks() returns (network, subnet, router)\nhttps://review.openstack.org/#/c/112199/13/tempest/scenario/manager.py\n\nI think this may cause confusion or a bug though it\u0027s harmless here for now.","commit_id":"a3606fb738236c71040b784ba274be882e728bbb"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"78ba0b938b86542ebc83afe275e255acfa903805","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def _setup_network_and_servers(self):"},{"line_number":59,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":60,"context_line":"        security_group \u003d self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":61,"context_line":"        network, router, subnet \u003d self.create_networks()"},{"line_number":62,"context_line":"        public_network_id \u003d CONF.network.public_network_id"},{"line_number":63,"context_line":"        create_kwargs \u003d {"},{"line_number":64,"context_line":"            \u0027nics\u0027: ["}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_005f2ee6","line":61,"in_reply_to":"fa98f980_84d419be","updated":"2014-09-10 10:22:25.000000000","message":"Done\nNice catch. tnx","commit_id":"a3606fb738236c71040b784ba274be882e728bbb"}]}