)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"345da42ebe22f3cf9729ce75ad16936cbac2dbd6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Ironic set/get boot device scenario test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds an Ironic scenario test that validates the managament interface"},{"line_number":10,"context_line":"for set/get boot device and get the supported boot devices."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint new-management-interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ac7a964_9e584ffc","line":9,"updated":"2014-08-14 09:34:12.000000000","message":"I think its functional/API tests.","commit_id":"29586a6065aef3bc41192d19d0a4667f15dcaae9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"015cd6a513e889acf63d08c3acf2434342eb5eed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Ironic set/get boot device scenario test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds an Ironic scenario test that validates the managament interface"},{"line_number":10,"context_line":"for set/get boot device and get the supported boot devices."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint new-management-interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ac7a964_d96741e9","line":9,"in_reply_to":"7ac7a964_9e584ffc","updated":"2014-08-14 10:13:28.000000000","message":"Done","commit_id":"29586a6065aef3bc41192d19d0a4667f15dcaae9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"807f1e40504ddb439dd0432826c64df2f1d876df","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Ironic set/get boot device API test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds Ironic API tests to validates the management interface for set/get"},{"line_number":10,"context_line":"boot device and get the supported boot devices."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint new-management-interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1abeadc6_d3fd103c","line":9,"updated":"2014-08-19 20:24:54.000000000","message":"nit: validates -\u003e validate","commit_id":"9038e9f1e575c29801c70fc84018a57aa9f5ec48"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"808894a96bc235c80d18c34c6b8616fe0ca0ae6a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Ironic set/get boot device API test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds Ironic API tests to validates the management interface for set/get"},{"line_number":10,"context_line":"boot device and get the supported boot devices."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint new-management-interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1abeadc6_bd068ccc","line":9,"in_reply_to":"1abeadc6_d3fd103c","updated":"2014-08-20 09:39:52.000000000","message":"Done","commit_id":"9038e9f1e575c29801c70fc84018a57aa9f5ec48"}],"tempest/api/baremetal/admin/test_nodes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"345da42ebe22f3cf9729ce75ad16936cbac2dbd6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":100,"context_line":"    def test_set_node_boot_device(self):"},{"line_number":101,"context_line":"        resp, body \u003d self.client.set_node_boot_device(self.node[\u0027uuid\u0027], \u0027pxe\u0027)"},{"line_number":102,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_get_node_boot_device(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac7a964_7e3c5394","line":102,"updated":"2014-08-14 09:34:12.000000000","message":"We need to move status code check on client side (at least for new tests in same patch)-https://blueprints.launchpad.net/tempest/+spec/client-checks-success","commit_id":"29586a6065aef3bc41192d19d0a4667f15dcaae9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"015cd6a513e889acf63d08c3acf2434342eb5eed","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":100,"context_line":"    def test_set_node_boot_device(self):"},{"line_number":101,"context_line":"        resp, body \u003d self.client.set_node_boot_device(self.node[\u0027uuid\u0027], \u0027pxe\u0027)"},{"line_number":102,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":105,"context_line":"    def test_get_node_boot_device(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac7a964_8b82cc50","line":102,"in_reply_to":"7ac7a964_7e3c5394","updated":"2014-08-14 10:13:28.000000000","message":"Done","commit_id":"29586a6065aef3bc41192d19d0a4667f15dcaae9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b82f32328dec2bf3b8bb217016bf3a94175c70e9","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":100,"context_line":"    def test_set_node_boot_device(self):"},{"line_number":101,"context_line":"        resp, body \u003d self.client.set_node_boot_device(self.node[\u0027uuid\u0027], \u0027pxe\u0027)"},{"line_number":102,"context_line":"        # No content"},{"line_number":103,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_9c8560af","line":101,"updated":"2014-08-20 00:37:07.000000000","message":"unused var resp.\n\nsame in below places.","commit_id":"9038e9f1e575c29801c70fc84018a57aa9f5ec48"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"808894a96bc235c80d18c34c6b8616fe0ca0ae6a","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":100,"context_line":"    def test_set_node_boot_device(self):"},{"line_number":101,"context_line":"        resp, body \u003d self.client.set_node_boot_device(self.node[\u0027uuid\u0027], \u0027pxe\u0027)"},{"line_number":102,"context_line":"        # No content"},{"line_number":103,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_5df578c9","line":101,"in_reply_to":"1abeadc6_9c8560af","updated":"2014-08-20 09:39:52.000000000","message":"Done","commit_id":"9038e9f1e575c29801c70fc84018a57aa9f5ec48"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"aa30e957e3e3d85e3e24db79eb9785ee985fc911","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":106,"context_line":"    def test_get_node_boot_device(self):"},{"line_number":107,"context_line":"        body \u003d self.client.get_node_boot_device(self.node[\u0027uuid\u0027])"},{"line_number":108,"context_line":"        expected_resp \u003d {\u0027boot_device\u0027: \u0027pxe\u0027, \u0027persistent\u0027: False}"},{"line_number":109,"context_line":"        self.assertEqual(expected_resp, body)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_7a04287e","line":108,"updated":"2014-08-26 15:52:36.000000000","message":"Correct me if I\u0027m wrong but doesn\u0027t checking for pxe here depend on the set_node_boot_device call being run in test_set_node_boot_device()? You can\u0027t have a dependency like this between tests because run order isn\u0027t guaranteed.\n\nYou either need to make this one big test, or explicitly call set_node_boot in each test before the the get calls that depend on it.","commit_id":"5173ed64aebe23a21ea2880966b5c06523ee9be9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a2a25eb484b18eca29e91d0d30d0a5e3bb2ee3e3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":106,"context_line":"    def test_get_node_boot_device(self):"},{"line_number":107,"context_line":"        body \u003d self.client.get_node_boot_device(self.node[\u0027uuid\u0027])"},{"line_number":108,"context_line":"        expected_resp \u003d {\u0027boot_device\u0027: \u0027pxe\u0027, \u0027persistent\u0027: False}"},{"line_number":109,"context_line":"        self.assertEqual(expected_resp, body)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_7dc7c212","line":108,"in_reply_to":"1abeadc6_7a04287e","updated":"2014-08-26 16:14:53.000000000","message":"That\u0027s correct and is a very good point...\n\nI was thinking whether I should be testing the \u0027pxe\u0027 value there and instead just test the format of the response (check if it\u0027s a dict and if has the keys \u0027boot_device\u0027 and \u0027persistent\u0027)\n\nWhat you think?","commit_id":"5173ed64aebe23a21ea2880966b5c06523ee9be9"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"aa30e957e3e3d85e3e24db79eb9785ee985fc911","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":112,"context_line":"    def test_get_node_supported_boot_devices(self):"},{"line_number":113,"context_line":"        body \u003d self.client.get_node_supported_boot_devices(self.node[\u0027uuid\u0027])"},{"line_number":114,"context_line":"        expected_resp \u003d {\u0027supported_boot_devices\u0027: [\u0027pxe\u0027]}"},{"line_number":115,"context_line":"        self.assertEqual(expected_resp, body)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_faf7588a","line":114,"updated":"2014-08-26 15:52:36.000000000","message":"Same here","commit_id":"5173ed64aebe23a21ea2880966b5c06523ee9be9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a2a25eb484b18eca29e91d0d30d0a5e3bb2ee3e3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":112,"context_line":"    def test_get_node_supported_boot_devices(self):"},{"line_number":113,"context_line":"        body \u003d self.client.get_node_supported_boot_devices(self.node[\u0027uuid\u0027])"},{"line_number":114,"context_line":"        expected_resp \u003d {\u0027supported_boot_devices\u0027: [\u0027pxe\u0027]}"},{"line_number":115,"context_line":"        self.assertEqual(expected_resp, body)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_9dcade18","line":114,"in_reply_to":"1abeadc6_faf7588a","updated":"2014-08-26 16:14:53.000000000","message":"same here","commit_id":"5173ed64aebe23a21ea2880966b5c06523ee9be9"}],"tempest/services/baremetal/v1/base_v1.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"807f1e40504ddb439dd0432826c64df2f1d876df","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        Set the boot device of the specified node."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        :param node_uuid: The unique identifier of the node."},{"line_number":274,"context_line":"        :param boot_device: The boot device name."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        \"\"\""},{"line_number":277,"context_line":"        request \u003d {\u0027boot_device\u0027: boot_device, \u0027persistent\u0027: persistent}"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_132dc8fe","line":274,"updated":"2014-08-19 20:24:54.000000000","message":"nit. Maybe add :param persistent:?","commit_id":"9038e9f1e575c29801c70fc84018a57aa9f5ec48"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"808894a96bc235c80d18c34c6b8616fe0ca0ae6a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        Set the boot device of the specified node."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        :param node_uuid: The unique identifier of the node."},{"line_number":274,"context_line":"        :param boot_device: The boot device name."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        \"\"\""},{"line_number":277,"context_line":"        request \u003d {\u0027boot_device\u0027: boot_device, \u0027persistent\u0027: persistent}"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_1d14e0f3","line":274,"in_reply_to":"1abeadc6_132dc8fe","updated":"2014-08-20 09:39:52.000000000","message":"Done","commit_id":"9038e9f1e575c29801c70fc84018a57aa9f5ec48"}]}