)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9349,"name":"Jon Grimm","email":"jon.grimm@gmail.com","username":"jgrimm"},"change_message_id":"a1c5779d269bb021f16bab16e30a73521bfc3ae8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test case to update allowed address pair port with CIDR value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"creating a port , updating a port with CIDR value"},{"line_number":10,"context_line":"verifying the port creation with CIDR value"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I22a041df97f9f630b66c48f92f4c0da12db75b0a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_dd853608","line":9,"updated":"2014-08-29 16:11:40.000000000","message":"nit. extra space if you are cleaning up yet.","commit_id":"f867a3d7c0198926140cb5f4c160cda11e5a3ec6"}],"tempest/api/network/test_allowed_address_pair.py":[{"author":{"_account_id":9349,"name":"Jon Grimm","email":"jon.grimm@gmail.com","username":"jgrimm"},"change_message_id":"a1c5779d269bb021f16bab16e30a73521bfc3ae8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        port_id \u003d body[\u0027port\u0027][\u0027id\u0027]"},{"line_number":100,"context_line":"        self.addCleanup(self.client.delete_port, port_id)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # Confirm  port is created"},{"line_number":103,"context_line":"        resp, body \u003d self.client.show_port(port_id)"},{"line_number":104,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_3d554ac6","line":102,"updated":"2014-08-29 16:11:40.000000000","message":"nit extra space to remove if yet cleaning up.","commit_id":"f867a3d7c0198926140cb5f4c160cda11e5a3ec6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a199a717e16b526d0c0566d4cc65c7156560c144","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def test_update_port_with_cidr_address_pair(self):"},{"line_number":96,"context_line":"        # Create a port without allowed address pair"},{"line_number":97,"context_line":"        resp, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":99,"context_line":"        port_id \u003d body[\u0027port\u0027][\u0027id\u0027]"},{"line_number":100,"context_line":"        self.addCleanup(self.client.delete_port, port_id)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_a956fccb","line":98,"updated":"2014-09-04 08:53:02.000000000","message":"All checks of status are moved in client. Remove this.","commit_id":"7837c5c27bffe19d1a12cce4e2e7544edbb4175e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a199a717e16b526d0c0566d4cc65c7156560c144","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # Confirm port is created"},{"line_number":103,"context_line":"        resp, body \u003d self.client.show_port(port_id)"},{"line_number":104,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # Update allowed address pair with CIDR"},{"line_number":107,"context_line":"        allowed_address_pairs \u003d [{\u0027ip_address\u0027: \u002720.20.20.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_296a0c81","line":104,"updated":"2014-09-04 08:53:02.000000000","message":"The same","commit_id":"7837c5c27bffe19d1a12cce4e2e7544edbb4175e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a199a717e16b526d0c0566d4cc65c7156560c144","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                  \u0027mac_address\u0027: self.mac_address}]"},{"line_number":109,"context_line":"        resp, body \u003d self.client.update_port(port_id,"},{"line_number":110,"context_line":"                          allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":111,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":112,"context_line":"        portnew \u003d body[\u0027port\u0027]"},{"line_number":113,"context_line":"        self._confirm_allowed_address_pair(portnew, \u002720.20.20.0/24\u0027)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_6907b4ca","line":111,"updated":"2014-09-04 08:53:02.000000000","message":"The same","commit_id":"7837c5c27bffe19d1a12cce4e2e7544edbb4175e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"c7db156508571be60539d5cb1b4fb3acb96531c7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def test_update_port_with_cidr_address_pair(self):"},{"line_number":96,"context_line":"        # Create a port without allowed address pair"},{"line_number":97,"context_line":"        resp, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":99,"context_line":"        port_id \u003d body[\u0027port\u0027][\u0027id\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Confirm port is created"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_8ffd5f71","line":98,"updated":"2014-09-08 07:36:08.000000000","message":"Comment for previous patch set is not resolved. Remove this check.","commit_id":"828a37dd8801221a8dc8e4dd53243f0b19423280"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d6e521888098e0cb31e9c1deda340a4337454539","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self._confirm_allowed_address_pair(newport, self.ip_address)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":95,"context_line":"    def test_update_port_with_cidr_address_pair(self):"},{"line_number":96,"context_line":"        # Create a port without allowed address pair"},{"line_number":97,"context_line":"        cidr \u003d netaddr.IPNetwork(CONF.network.tenant_network_cidr)"},{"line_number":98,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9df570_8c4164ab","line":95,"updated":"2014-09-26 02:54:29.000000000","message":"Most part is duplicated with test_update_port_with_address_pair().\nTo avoid duplicated code, how about adding internal method like\n\n def _update_port_with_address(self, address, mac_address\u003dNone):\n    if mac_address is None:\n        mac_address \u003d self.mac_address\n    ...\n\nand calling it from test_update_port_with_address_pair and test_update_port_with_cidr_address_pair like:\n\n def test_update_port_with_address_pair(self):\n     self._update_port_with_address(self.ip_address)\n\n def test_update_port_with_cidr_address_pair(self):\n     cidr \u003d str(netaddr.IPNetwork(CONF.network.tenant_network_cidr))\n     self._update_port_with_address(cidr)\n\n?","commit_id":"4a9c257f2be754536634a6614e4a614751d3de21"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d6e521888098e0cb31e9c1deda340a4337454539","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self._confirm_allowed_address_pair(portnew, str(cidr))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":114,"context_line":"    def test_update_port_with_multiple_ip_mac_address_pair(self):"},{"line_number":115,"context_line":"        # Create a port without allowed address pair"},{"line_number":116,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dself.network[\u0027id\u0027])"},{"line_number":117,"context_line":"        port_id \u003d body[\u0027port\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9df570_8c6fa42a","line":114,"updated":"2014-09-26 02:54:29.000000000","message":"ditto","commit_id":"4a9c257f2be754536634a6614e4a614751d3de21"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"17ebe38aabaf0845e559d448d87d1f48fad103db","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.ip_address, self.mac_address,"},{"line_number":123,"context_line":"            allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _confirm_allowed_pair_multiple_ip_mac(self, port, **kwargs):"},{"line_number":126,"context_line":"        msg \u003d \u0027Port allowed address pairs should not be empty\u0027"},{"line_number":127,"context_line":"        self.assertTrue(port[\u0027allowed_address_pairs\u0027], msg)"},{"line_number":128,"context_line":"        address \u003d port[\u0027allowed_address_pairs\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_4d87b50f","line":125,"updated":"2014-10-02 12:41:04.000000000","message":"This method is used in _update_port_with_address() only and kwargs seems unreadable.\n\nSo how about moving this code(line 126-130) into _update_port_with_address() ?","commit_id":"fde5ae034c93ea1e71a23c7a20c5cfb0c36f7b54"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e0eeb12eab529c1e7aa279f71a829757824ca5fd","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        port_id \u003d body[\u0027port\u0027][\u0027id\u0027]"},{"line_number":81,"context_line":"        self.addCleanup(self.client.delete_port, port_id)"},{"line_number":82,"context_line":"        # Confirm port is created"},{"line_number":83,"context_line":"        _, body \u003d self.client.show_port(port_id)"},{"line_number":84,"context_line":"        if mac_address is None:"},{"line_number":85,"context_line":"            mac_address \u003d self.mac_address"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_30a52447","line":83,"updated":"2014-10-06 13:43:20.000000000","message":"This \u0027body\u0027 (L83) is never read.","commit_id":"055d8e848972ee6b97f52303b0182d540ba6f574"}]}