)]}'
{"tempest/common/accounts.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"273644da22f40915c9959cab82e961f0a2b70e34","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        raise exceptions.InvalidConfiguration(msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _get_creds(self):"},{"line_number":76,"context_line":"        free_hash \u003d self._get_free_hash(self.hashes.keys())"},{"line_number":77,"context_line":"        return self.hash_dict[free_hash]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @lockutils.synchronized(\u0027test_accounts_io\u0027, external\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_45005867","line":76,"updated":"2014-08-15 21:26:44.000000000","message":"self.hash_dict.keys() ?","commit_id":"70e68c05fd8c94b844ef1a4542478d57876e0302"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"d0bfcc6ba0c98eeb1a1374aa1791403ae53b618c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        raise exceptions.InvalidConfiguration(msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _get_creds(self):"},{"line_number":76,"context_line":"        free_hash \u003d self._get_free_hash(self.hashes.keys())"},{"line_number":77,"context_line":"        return self.hash_dict[free_hash]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @lockutils.synchronized(\u0027test_accounts_io\u0027, external\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_17a3f2b2","line":76,"in_reply_to":"7ac7a964_45005867","updated":"2014-08-16 01:50:18.000000000","message":"Done","commit_id":"70e68c05fd8c94b844ef1a4542478d57876e0302"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"5ffcad6d68825123e8266cb5652944338a3b97f6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.remove_hash(hash, self.accounts_dir)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_primary_creds(self):"},{"line_number":108,"context_line":"        if self.isolated_creds.get(\u0027primary\u0027):"},{"line_number":109,"context_line":"            return self.isolated_creds.get(\u0027primary\u0027)"},{"line_number":110,"context_line":"        creds \u003d self._get_creds()"},{"line_number":111,"context_line":"        primary_credential \u003d auth.get_credentials(**creds)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_c51b8819","line":108,"updated":"2014-08-15 21:21:20.000000000","message":"I liked credentials better, but we would need to change things around then.","commit_id":"70e68c05fd8c94b844ef1a4542478d57876e0302"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"8a0842ed5d0263376252b0d14b3c5ebd5f1af136","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            hash_dict[temp_hash.hexdigest()] \u003d account"},{"line_number":53,"context_line":"        return hash_dict"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def is_multi_user(self):"},{"line_number":56,"context_line":"        return len(self.hash_dict) \u003e 1"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _create_hash_file(self, hash_string):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_7b014c69","line":55,"updated":"2014-09-03 20:50:32.000000000","message":"This is not used anywhere.","commit_id":"797fca7fac97eddebd0e2dfe820450412046483a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b37fa8a610f1e3c459e2d00308430421160d0694","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            hash_dict[temp_hash.hexdigest()] \u003d account"},{"line_number":53,"context_line":"        return hash_dict"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def is_multi_user(self):"},{"line_number":56,"context_line":"        return len(self.hash_dict) \u003e 1"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _create_hash_file(self, hash_string):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_f3e8f5e3","line":55,"in_reply_to":"fa98f980_7b014c69","updated":"2014-09-04 07:49:38.000000000","message":"This will be needed for multi user check in BaseComputeTest (currently).\n\nShould be part of https://review.openstack.org/#/c/107685/ for clear view but i think it should be fine as all are in same BP.","commit_id":"797fca7fac97eddebd0e2dfe820450412046483a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"70523781bfdbc626730efef85121ac43cb61df7c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            hash_dict[temp_hash.hexdigest()] \u003d account"},{"line_number":53,"context_line":"        return hash_dict"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def is_multi_user(self):"},{"line_number":56,"context_line":"        return len(self.hash_dict) \u003e 1"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _create_hash_file(self, hash_string):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_0ca2b698","line":55,"in_reply_to":"fa98f980_f3e8f5e3","updated":"2014-09-04 09:33:01.000000000","message":"Right, is_multi_user is part of the abstract class implemented by Accounts, so it should be implemented - it\u0027s only used in the next patch though. I can move it there if you prefer so. All this code is not used anywhere anyways except for unit tests - so what I think I\u0027ll do here is add a unit test for is_multi_user.","commit_id":"797fca7fac97eddebd0e2dfe820450412046483a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"201fce5d44a80d1e58d2c79f87594b461da65bd7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            res \u003d self._create_hash_file(_hash)"},{"line_number":74,"context_line":"            if res:"},{"line_number":75,"context_line":"                return _hash"},{"line_number":76,"context_line":"        msg \u003d \u0027Insufficient number of users provided\u0027"},{"line_number":77,"context_line":"        raise exceptions.InvalidConfiguration(msg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _get_creds(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_f678e3c5","line":76,"updated":"2014-09-04 08:42:01.000000000","message":"I am wondering, how user will get to know how many accounts (number of tests case in parallel) should be pre-created?\n\nIt will be good if we can somehow tell the number in error message. But how to count the number of parallel tests running? May be we need some mechanism somewhere.","commit_id":"797fca7fac97eddebd0e2dfe820450412046483a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"984ba606739370c0628246b66d32852cea3c309d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            res \u003d self._create_hash_file(_hash)"},{"line_number":74,"context_line":"            if res:"},{"line_number":75,"context_line":"                return _hash"},{"line_number":76,"context_line":"        msg \u003d \u0027Insufficient number of users provided\u0027"},{"line_number":77,"context_line":"        raise exceptions.InvalidConfiguration(msg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _get_creds(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_806bc21c","line":76,"in_reply_to":"fa98f980_2cc69a68","updated":"2014-09-04 13:06:03.000000000","message":"Got it. Thanks Andrea for clarification.","commit_id":"797fca7fac97eddebd0e2dfe820450412046483a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"70523781bfdbc626730efef85121ac43cb61df7c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            res \u003d self._create_hash_file(_hash)"},{"line_number":74,"context_line":"            if res:"},{"line_number":75,"context_line":"                return _hash"},{"line_number":76,"context_line":"        msg \u003d \u0027Insufficient number of users provided\u0027"},{"line_number":77,"context_line":"        raise exceptions.InvalidConfiguration(msg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _get_creds(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_2cc69a68","line":76,"in_reply_to":"fa98f980_f678e3c5","updated":"2014-09-04 09:33:01.000000000","message":"The number of users that are needed is for now CONCURRENCY x 2, as tests expect user and alt_user.\nI agree it should be documented somewhere, the help of the config option or a comment in the sample YAML file could be valid options as well.","commit_id":"797fca7fac97eddebd0e2dfe820450412046483a"}]}