)]}'
{"tempest/cli/simple_read_only/identity/test_keystone.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3503cc75f6da16226543a04f562aaad642f49866","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \u0027id\u0027, \u0027region\u0027, \u0027publicurl\u0027, \u0027internalurl\u0027,"},{"line_number":62,"context_line":"            \u0027adminurl\u0027, \u0027service_id\u0027])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @testtools.skipIf(not CONF.service_available.neutron,"},{"line_number":65,"context_line":"                      \"Neutron service is not available\")"},{"line_number":66,"context_line":"    def test_admin_endpoint_get(self):"},{"line_number":67,"context_line":"        output \u003d self.parser.listing(self.keystone"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_790ae979","line":64,"updated":"2014-09-16 01:23:05.000000000","message":"Sorry I just realized why neutron is needed for keystone tests. This is just endpoint-get test and that can be checked with \"identity\" service.\n\n output \u003d self.parser.listing(self.keystone\t67\n                                     (\u0027endpoint-get --service\u0027,\t68\n                                      params\u003d\"identity\"))","commit_id":"0117bb003457201b1d0dd3d4a781965bf047e789"}],"tempest/cli/simple_read_only/test_keystone.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e54f63180081b1cb4df3e1def40a46ac88c8cc6e","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_admin_endpoint_get(self):"},{"line_number":64,"context_line":"        service_enabled \u003d CONF.service_available.neutron"},{"line_number":65,"context_line":"        if service_enabled:"},{"line_number":66,"context_line":"            output \u003d self.parser.listing(self.keystone"},{"line_number":67,"context_line":"                                         (\u0027endpoint-get --service\u0027,"},{"line_number":68,"context_line":"                                          params\u003d\"network\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_849b3971","line":65,"updated":"2014-08-20 12:11:36.000000000","message":"Please use something like:\n  @testtools.skipIf(CONF.service_available.neutron\n   ...\nif this test needs to get skipped.","commit_id":"e93fae71749713e49884a8d75511902bd59e9032"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"56d269e9aac544ece30dc8a5ed5228e3afcedbb6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            \u0027adminurl\u0027, \u0027service_id\u0027])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @testtools.skipIf(not CONF.service_available.neutron,"},{"line_number":65,"context_line":"                      \"Neutron service is not available\")"},{"line_number":66,"context_line":"    def test_admin_endpoint_get(self):"},{"line_number":67,"context_line":"        output \u003d self.parser.listing(self.keystone"},{"line_number":68,"context_line":"                                     (\u0027endpoint-get --service\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_6cc01b7d","line":65,"updated":"2014-08-25 21:18:35.000000000","message":"i think you can just use services decorator (https://github.com/openstack/tempest/blob/master/tempest/test.py#L92-L130)\n\nie. @tempest.test.services(\u0027network\u0027)","commit_id":"69f76293319690684ee3adaa6f7bb918a013b2e9"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"56d269e9aac544ece30dc8a5ed5228e3afcedbb6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        roles \u003d self.parser.listing(self.keystone(\u0027role-list\u0027))"},{"line_number":83,"context_line":"        self.assertTableStruct(roles, [\u0027id\u0027, \u0027name\u0027])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @testtools.skipIf(not CONF.identity.admin_role,"},{"line_number":86,"context_line":"                      \"admin role is not available\")"},{"line_number":87,"context_line":"    def test_admin_role_get(self):"},{"line_number":88,"context_line":"        roles \u003d CONF.identity.admin_role"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_ec30aba0","line":85,"updated":"2014-08-25 21:18:35.000000000","message":"curious but why would admin role not but available in CONF?","commit_id":"69f76293319690684ee3adaa6f7bb918a013b2e9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"16a6bf92a35deff1857e9e1bf16d199d058bd3b7","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @testtools.skipIf(not CONF.service_available.neutron,"},{"line_number":66,"context_line":"                      \"Neutron service is not available\")"},{"line_number":67,"context_line":"    @test.services(\u0027identity\u0027)"},{"line_number":68,"context_line":"    def test_admin_endpoint_get(self):"},{"line_number":69,"context_line":"        output \u003d self.parser.listing(self.keystone"},{"line_number":70,"context_line":"                                     (\u0027endpoint-get --service\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_04959f3f","line":67,"updated":"2014-08-26 15:05:28.000000000","message":"Gordon suggested to use tempest.test.services(\u0027network\u0027) for tests that depends on Neutron. This is now the recommended way of specifying dependencies.\n\nI will still +1 because Marc in a comment suggested you to use the skipIf decorator. Both solutions work.","commit_id":"e7bef821a626243087d3c9bbddeafdcde60a4398"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a54153a7bcad5795184b565ed17bdcc121dacf25","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @testtools.skipIf(not CONF.service_available.neutron,"},{"line_number":66,"context_line":"                      \"Neutron service is not available\")"},{"line_number":67,"context_line":"    @test.services(\u0027identity\u0027)"},{"line_number":68,"context_line":"    def test_admin_endpoint_get(self):"},{"line_number":69,"context_line":"        output \u003d self.parser.listing(self.keystone"},{"line_number":70,"context_line":"                                     (\u0027endpoint-get --service\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_a1380bd4","line":67,"in_reply_to":"1abeadc6_04959f3f","updated":"2014-08-28 09:33:56.000000000","message":"Actually tempest.test.services(\u0027network\u0027) can be added where network service is required either from neutron or nova-network. But where tests must require network service from neutron only (not nova-netwrok) then explicit skip is needed.","commit_id":"e7bef821a626243087d3c9bbddeafdcde60a4398"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a54153a7bcad5795184b565ed17bdcc121dacf25","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        roles \u003d self.parser.listing(self.keystone(\u0027role-list\u0027))"},{"line_number":85,"context_line":"        self.assertTableStruct(roles, [\u0027id\u0027, \u0027name\u0027])"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @test.services(\u0027identity\u0027)"},{"line_number":88,"context_line":"    def test_admin_role_get(self):"},{"line_number":89,"context_line":"        roles \u003d CONF.identity.admin_role"},{"line_number":90,"context_line":"        output \u003d self.parser.listing(self.keystone(\u0027role-get\u0027, params\u003droles))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_1ec3daed","line":87,"updated":"2014-08-28 09:33:56.000000000","message":"You can remove this service check.","commit_id":"e7bef821a626243087d3c9bbddeafdcde60a4398"}]}