)]}'
{"tempest/services/identity/v3/json/identity_client.py":[{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"04447f3c5bf12a330f1cbd23d32cb0049c48410c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        email \u003d kwargs.get(\u0027email\u0027, body[\u0027email\u0027])"},{"line_number":63,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, body[\u0027enabled\u0027])"},{"line_number":64,"context_line":"        project_id \u003d kwargs.get(\u0027project_id\u0027, body[\u0027project_id\u0027])"},{"line_number":65,"context_line":"        if \u0027default_project_id\u0027 in body.keys():"},{"line_number":66,"context_line":"            default_project_id \u003d kwargs.get(\u0027default_project_id\u0027, body[\u0027default_project_id\u0027])"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            default_project_id \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_7bdbf34e","line":65,"updated":"2014-08-21 09:06:00.000000000","message":"default_project_id \u003d kwargs.get(\u0027default_project_id\u0027, body[\u0027default_project_id\u0027])\n\nshould not this line be enough? without the if statement","commit_id":"77c71674886d84fe6304e4d115707f2f7193369f"},{"author":{"_account_id":6683,"name":"Pavel Sedlák","email":"psedlak@redhat.com","username":"psedlak"},"change_message_id":"26e18abf67fb057c0c090231f0bac8d0d99cdc04","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        email \u003d kwargs.get(\u0027email\u0027, body[\u0027email\u0027])"},{"line_number":63,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, body[\u0027enabled\u0027])"},{"line_number":64,"context_line":"        project_id \u003d kwargs.get(\u0027project_id\u0027, body[\u0027project_id\u0027])"},{"line_number":65,"context_line":"        if \u0027default_project_id\u0027 in body.keys():"},{"line_number":66,"context_line":"            default_project_id \u003d kwargs.get(\u0027default_project_id\u0027, body[\u0027default_project_id\u0027])"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            default_project_id \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_9c29a539","line":65,"in_reply_to":"1abeadc6_61f50656","updated":"2014-08-21 10:37:14.000000000","message":"Still, maybe it could be done like\n\n  def_proj_id \u003d kwargs.get(\u0027def...\u0027,\n                           body.get(\u0027def..\u0027, None))\n\nas this way, when there is no default_project_id set already,\nit will not be possible to \u0027update\u0027 it, as line 68 imho should be\n\n  default_project_id \u003d kwargs.get(\u0027default_project_id\u0027, None)\n\n(if it\u0027s possible to set default_project_id for user which does not have any yet, of course)","commit_id":"77c71674886d84fe6304e4d115707f2f7193369f"},{"author":{"_account_id":12946,"name":"Udi Kalifon","email":"ukalifon@redhat.com","username":"ukalifon"},"change_message_id":"5306c5475cffa17544cd051a59e98490315d6af1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        email \u003d kwargs.get(\u0027email\u0027, body[\u0027email\u0027])"},{"line_number":63,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, body[\u0027enabled\u0027])"},{"line_number":64,"context_line":"        project_id \u003d kwargs.get(\u0027project_id\u0027, body[\u0027project_id\u0027])"},{"line_number":65,"context_line":"        if \u0027default_project_id\u0027 in body.keys():"},{"line_number":66,"context_line":"            default_project_id \u003d kwargs.get(\u0027default_project_id\u0027, body[\u0027default_project_id\u0027])"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            default_project_id \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_c1fa5abc","line":65,"in_reply_to":"1abeadc6_7bdbf34e","updated":"2014-08-21 10:16:48.000000000","message":"Hi Tomáš.\n\nWithout the if I had a problem: the GET call doesn\u0027t list the default_project_id at all if it isn\u0027t defined for the user. This is exceptional compared to the other user attributes, which are always listed no matter what. So, in this case, it requires us to check for this attribute every time.","commit_id":"77c71674886d84fe6304e4d115707f2f7193369f"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"083b178336fb936a485959d7d90db2a4a87a8c14","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        email \u003d kwargs.get(\u0027email\u0027, body[\u0027email\u0027])"},{"line_number":63,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, body[\u0027enabled\u0027])"},{"line_number":64,"context_line":"        project_id \u003d kwargs.get(\u0027project_id\u0027, body[\u0027project_id\u0027])"},{"line_number":65,"context_line":"        if \u0027default_project_id\u0027 in body.keys():"},{"line_number":66,"context_line":"            default_project_id \u003d kwargs.get(\u0027default_project_id\u0027, body[\u0027default_project_id\u0027])"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            default_project_id \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_61f50656","line":65,"in_reply_to":"1abeadc6_c1fa5abc","updated":"2014-08-21 10:21:50.000000000","message":"Thanks for the explanation.","commit_id":"77c71674886d84fe6304e4d115707f2f7193369f"}]}