)]}'
{"tempest/api/baremetal/admin/base.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ce76ac5c059d7d69500d6c6d3d9df8b5b624f36c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            for resource, uuids in cls.created_objects.iteritems():"},{"line_number":83,"context_line":"                if cls.client is None:"},{"line_number":84,"context_line":"                    break"},{"line_number":85,"context_line":"                delete_method \u003d getattr(cls.client, \u0027delete_%s\u0027 % resource)"},{"line_number":86,"context_line":"                for u in uuids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_f91146ad","line":83,"updated":"2014-08-18 18:13:58.000000000","message":"Why is it inside the loop, not outside ?","commit_id":"1f5889deffe8839b7e003e088a2ed155177d51db"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"565e96b6e2b463aad64dbe25b4305f32ba7432a5","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            for resource, uuids in cls.created_objects.iteritems():"},{"line_number":83,"context_line":"                if cls.client is None:"},{"line_number":84,"context_line":"                    break"},{"line_number":85,"context_line":"                delete_method \u003d getattr(cls.client, \u0027delete_%s\u0027 % resource)"},{"line_number":86,"context_line":"                for u in uuids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_949c996b","line":83,"in_reply_to":"1abeadc6_f91146ad","updated":"2014-08-18 18:31:21.000000000","message":"Done","commit_id":"1f5889deffe8839b7e003e088a2ed155177d51db"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"0de0447c0ed61be64580da272b738e7b9ad4ec83","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class BaseBaremetalTest(test.BaseTestCase):"},{"line_number":49,"context_line":"    \"\"\"Base class for Baremetal API tests.\"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def __init__(self):"},{"line_number":52,"context_line":"        self.client \u003d None"},{"line_number":53,"context_line":"        self.created_objects \u003d {}"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_af4dc074","line":51,"updated":"2014-08-18 18:41:43.000000000","message":"AFAIK __init__ Is never used in tempest test classes elsewhere, consider declaring them as class variable, or use the hasattr in the tearDwonClass.","commit_id":"d3e73510419e10ac3fea1b70331c7d6f50a4bf0e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"1f032dcdfb7787e5e3d0eabb1caf2dd33e20cb0e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class BaseBaremetalTest(test.BaseTestCase):"},{"line_number":49,"context_line":"    \"\"\"Base class for Baremetal API tests.\"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def __init__(self):"},{"line_number":52,"context_line":"        self.client \u003d None"},{"line_number":53,"context_line":"        self.created_objects \u003d {}"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_2bc10e54","line":51,"in_reply_to":"1abeadc6_908b7767","updated":"2014-09-04 18:52:48.000000000","message":"The attributes defined here will be instance variables, which cannot be seen by a classmethod, the class even does not (really) \u0027knows\u0027 about the instances. \n\nThe classmethod decorator have the method to operate on the class instead of the instance.\n\nhttps://docs.python.org/2/library/functions.html#classmethod\n\nI do not think it really solves your issue.","commit_id":"d3e73510419e10ac3fea1b70331c7d6f50a4bf0e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9b7c6bc0132a2a5393fc7c7db37c05496c318858","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class BaseBaremetalTest(test.BaseTestCase):"},{"line_number":49,"context_line":"    \"\"\"Base class for Baremetal API tests.\"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def __init__(self):"},{"line_number":52,"context_line":"        self.client \u003d None"},{"line_number":53,"context_line":"        self.created_objects \u003d {}"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_908b7767","line":51,"in_reply_to":"1abeadc6_af4dc074","updated":"2014-08-27 14:49:30.000000000","message":"I\u0027m not too familiar with what tempest is doing with classmethods and class variables... but I don\u0027t understand why these would not be declared as instance variables.","commit_id":"d3e73510419e10ac3fea1b70331c7d6f50a4bf0e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"3b7ce47ad57e353ce33d141e9e2ffac01ed562f0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\"Ensure that all created objects get destroyed.\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            if cls.client is not None:"},{"line_number":83,"context_line":"                for resource, uuids in cls.created_objects.iteritems():"},{"line_number":84,"context_line":"                    delete_method \u003d getattr(cls.client, \u0027delete_%s\u0027 % resource)"},{"line_number":85,"context_line":"                    for u in uuids:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_3a78f0f1","line":82,"updated":"2014-08-19 11:07:39.000000000","message":"__init__ for per object, and it is class method.\n\nJust use hasattr for both attributes in the if.","commit_id":"d3e73510419e10ac3fea1b70331c7d6f50a4bf0e"}]}