)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"79c92acfd08acbe3ac3f1de5bcd968ff93f15f41","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            self.diff_list \u003d [n for n in new_nic_list if n not in old_nic_list]"},{"line_number":242,"context_line":"            return len(self.diff_list) \u003d\u003d 1"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        test.call_until_true(check_new_nic, 60, 1)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        num, new_nic \u003d self.diff_list[0]"},{"line_number":247,"context_line":"        ssh_client.assign_static_ip(nic\u003dnew_nic,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_f5269015","line":244,"updated":"2014-08-19 09:27:21.000000000","message":"60 seconds is ok, but I would consider using one of our configurable timeouts or add a new configurable timeout.","commit_id":"888ff203eccf24b4339f888c43dcaa694ecdac30"},{"author":{"_account_id":6683,"name":"Pavel Sedlák","email":"psedlak@redhat.com","username":"psedlak"},"change_message_id":"487f9a7d5175deaeadd661611d6308af12edb80c","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            self.diff_list \u003d [n for n in new_nic_list if n not in old_nic_list]"},{"line_number":242,"context_line":"            return len(self.diff_list) \u003d\u003d 1"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        test.call_until_true(check_new_nic, 60, 1)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        num, new_nic \u003d self.diff_list[0]"},{"line_number":247,"context_line":"        ssh_client.assign_static_ip(nic\u003dnew_nic,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_75c8c022","line":244,"range":{"start_line":244,"start_character":13,"end_line":244,"end_character":28},"updated":"2014-08-19 09:28:32.000000000","message":"i think better to assert return value of call_until_true or even better len of diff_list here,\ninstead of fail on index error on line below","commit_id":"888ff203eccf24b4339f888c43dcaa694ecdac30"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0a58fbde48d60ffe20b1fdf8ba1bdc8e6e97549b","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                         if port !\u003d old_port]"},{"line_number":228,"context_line":"            return len(port_list) \u003d\u003d 1"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        test.call_until_true(check_ports, CONF.network.build_timeout,"},{"line_number":231,"context_line":"                             CONF.network.build_interval)"},{"line_number":232,"context_line":"        new_port_list \u003d [p for p in"},{"line_number":233,"context_line":"                         self._list_ports(device_id\u003dserver.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_761c3778","line":230,"updated":"2014-08-19 15:59:20.000000000","message":"So looking at: http://git.openstack.org/cgit/openstack/tempest/tree/tempest/test.py#n622\n\ncall_until_true doesn\u0027t raise an exception on timeout, just returns false. I think you should if block this so we raise a timeout exception and fail here instead of trying to move on. I see where it catches it with the assert below but that is kind of unclear why it fails, I think being explicit that the new port failed to show up before the timeout here would be better.","commit_id":"2ef5d58900ccd376abc022f737d844c479b3fc0f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0a58fbde48d60ffe20b1fdf8ba1bdc8e6e97549b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        def check_new_nic():"},{"line_number":241,"context_line":"            new_nic_list \u003d self._get_server_nics(ssh_client)"},{"line_number":242,"context_line":"            self.diff_list \u003d [n for n in new_nic_list if n not in old_nic_list]"},{"line_number":243,"context_line":"            return len(self.diff_list) \u003d\u003d 1"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        test.call_until_true(check_new_nic, CONF.network.build_timeout,"},{"line_number":246,"context_line":"                             CONF.network.build_interval)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_7978a88f","line":243,"updated":"2014-08-19 15:59:20.000000000","message":"I\u0027m wondering if this should be \u003e\u003d1? My concern is if the diff list exceeds 1 we\u0027ll cause a timeout because it\u0027ll never be true. It\u0027s probably not a likely case, so I\u0027m not -1 because of it.","commit_id":"2ef5d58900ccd376abc022f737d844c479b3fc0f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0a58fbde48d60ffe20b1fdf8ba1bdc8e6e97549b","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            self.diff_list \u003d [n for n in new_nic_list if n not in old_nic_list]"},{"line_number":243,"context_line":"            return len(self.diff_list) \u003d\u003d 1"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        test.call_until_true(check_new_nic, CONF.network.build_timeout,"},{"line_number":246,"context_line":"                             CONF.network.build_interval)"},{"line_number":247,"context_line":"        self.assertEqual(1, len(self.diff_list),"},{"line_number":248,"context_line":"                         \"Interface not visable on the guest after %s sec\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_96139365","line":245,"updated":"2014-08-19 15:59:20.000000000","message":"same here","commit_id":"2ef5d58900ccd376abc022f737d844c479b3fc0f"}]}