)]}'
{"tempest/api/telemetry/test_telemetry_alarming_api.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"32d66a29fe0aad869e32b9333be009b5bb403e54","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":33,"context_line":"    def test_alarm_list(self):"},{"line_number":34,"context_line":"        # List alarms"},{"line_number":35,"context_line":"        _, alarm_list \u003d self.telemetry_client.list_alarms()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Verify created alarm in the list"},{"line_number":38,"context_line":"        fetched_ids \u003d [a[\u0027alarm_id\u0027] for a in alarm_list]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_f1ec1192","line":35,"updated":"2014-08-25 15:20:13.000000000","message":"maybe make this double underscore instead \u0027__\u0027","commit_id":"204d9f42cb28ed021c4301daf3374229a8cd6eca"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0c86cc591cbe2faaea12ad4ed688e75ce674165d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":33,"context_line":"    def test_alarm_list(self):"},{"line_number":34,"context_line":"        # List alarms"},{"line_number":35,"context_line":"        _, alarm_list \u003d self.telemetry_client.list_alarms()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Verify created alarm in the list"},{"line_number":38,"context_line":"        fetched_ids \u003d [a[\u0027alarm_id\u0027] for a in alarm_list]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_d8a3b24d","line":35,"in_reply_to":"1abeadc6_4776e707","updated":"2014-08-25 17:09:44.000000000","message":"ah cool cool. good to know","commit_id":"204d9f42cb28ed021c4301daf3374229a8cd6eca"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"b952c42359613e80f7811424909dc767bdaca8e2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":33,"context_line":"    def test_alarm_list(self):"},{"line_number":34,"context_line":"        # List alarms"},{"line_number":35,"context_line":"        _, alarm_list \u003d self.telemetry_client.list_alarms()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Verify created alarm in the list"},{"line_number":38,"context_line":"        fetched_ids \u003d [a[\u0027alarm_id\u0027] for a in alarm_list]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_4776e707","line":35,"in_reply_to":"1abeadc6_f1ec1192","updated":"2014-08-25 16:00:44.000000000","message":"Single underscore to denote unreferenced variables is standard in the tempest code base.","commit_id":"204d9f42cb28ed021c4301daf3374229a8cd6eca"}],"tempest/services/telemetry/telemetry_client_base.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"b3299292e3f03a31ab5143525e02208c1f5ebaf7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        body \u003d self.serialize(body)"},{"line_number":66,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":67,"context_line":"        body \u003d self.deserialize(body)"},{"line_number":68,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":69,"context_line":"        return resp, body"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def get_request(self, uri):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_f5a88b22","line":68,"updated":"2014-08-25 08:24:11.000000000","message":"So at the moment all posts may return 201, all puts 200, all gets 200 on success etc. But surely that won\u0027t be true in the future? Doesn\u0027t it really need to be resource specific for the future?","commit_id":"204d9f42cb28ed021c4301daf3374229a8cd6eca"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"b952c42359613e80f7811424909dc767bdaca8e2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        body \u003d self.serialize(body)"},{"line_number":66,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":67,"context_line":"        body \u003d self.deserialize(body)"},{"line_number":68,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":69,"context_line":"        return resp, body"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def get_request(self, uri):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_a7997b21","line":68,"in_reply_to":"1abeadc6_f5a88b22","updated":"2014-08-25 16:00:44.000000000","message":"I agree. In the future we also would like to do a schema check here. So the validation info should be passed in from the resource-specific call.","commit_id":"204d9f42cb28ed021c4301daf3374229a8cd6eca"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ec283107ab7052cf32563588541bcd07ae5304ed","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        uri \u003d \"%s/alarms/%s/state\" % (self.uri_prefix, alarm_id)"},{"line_number":140,"context_line":"        body \u003d self.serialize(state)"},{"line_number":141,"context_line":"        resp, body \u003d self.put(uri, body)"},{"line_number":142,"context_line":"        body \u003d self.deserialize(body)"},{"line_number":143,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":144,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_c928a035","line":142,"updated":"2014-10-16 14:58:15.000000000","message":"\u0027Update alarm state\u0027 operation does not return the response body.\nSo I think we should check the response body like \u0027delete_alerm()\u0027.","commit_id":"57d844d93b5112be4e10dbcb37981c02a68d79e9"}]}