)]}'
{"tempest/api/network/test_fwaas_extensions.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"15b605675d81fd1c469eb78b2b2fcb122b42a469","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not test.call_until_true(_wait, CONF.network.build_timeout,"},{"line_number":85,"context_line":"                                    CONF.network.build_interval):"},{"line_number":86,"context_line":"            m \u003d (\"Timed out waiting for firewall %s to reach %s state(s) %s\" %"},{"line_number":87,"context_line":"                 (fw_id, target_states))"},{"line_number":88,"context_line":"            raise exceptions.TimeoutException(m)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_1b4aba54","line":86,"updated":"2014-08-22 22:29:35.000000000","message":"I count three occurrences of \u0027%s\u0027 here and two values provided in the tuple below.\n\n  \u003e\u003e\u003e target_states \u003d (\u0027ACTIVE\u0027, \u0027CREATED\u0027)\n  \u003e\u003e\u003e fw_id \u003d \u0027xyz\u0027\n  \u003e\u003e\u003e m \u003d (\"Timed out waiting for firewall %s to reach %s state(s) %s\" %\n  ...     (fw_id, target_states))\n  Traceback (most recent call last):\n    File \"\u003cstdin\u003e\", line 2, in \u003cmodule\u003e\n  TypeError: not enough arguments for format string\n\nI\u0027m wondering how Jenkins gave +1, seems it probably didn\u0027t run this code.","commit_id":"595628bedb522265c36eb787d226c1d641c0fa80"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"10452f0a887b38b2d93d4b354ea3064a99bf6f0c","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not test.call_until_true(_wait, CONF.network.build_timeout,"},{"line_number":85,"context_line":"                                    CONF.network.build_interval):"},{"line_number":86,"context_line":"            m \u003d (\"Timed out waiting for firewall %s to reach %s state(s) %s\" %"},{"line_number":87,"context_line":"                 (fw_id, target_states))"},{"line_number":88,"context_line":"            raise exceptions.TimeoutException(m)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_c785c5cf","line":86,"in_reply_to":"1abeadc6_1b4aba54","updated":"2014-08-23 02:44:47.000000000","message":"indeed the code is run during failures! Good catch!","commit_id":"595628bedb522265c36eb787d226c1d641c0fa80"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1bbea822e085a5409a9d0b70021f89b5c6695906","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not test.call_until_true(_wait, CONF.network.build_timeout,"},{"line_number":85,"context_line":"                                    CONF.network.build_interval):"},{"line_number":86,"context_line":"            m \u003d (\"Timed out waiting for firewall %s to reach %s state(s) %s\" %"},{"line_number":87,"context_line":"                 (fw_id, target_states))"},{"line_number":88,"context_line":"            raise exceptions.TimeoutException(m)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_b7dc441a","line":86,"in_reply_to":"1abeadc6_979bc871","updated":"2014-08-25 17:54:55.000000000","message":"Of course, I realize that this code is itself a test and so unit testing may not make sense.  I was just explaining why I look for this sort of thing in reviews.  Now I\u0027m just rambling.","commit_id":"595628bedb522265c36eb787d226c1d641c0fa80"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"351c3622a76946ba2219b671aa753846024ad327","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not test.call_until_true(_wait, CONF.network.build_timeout,"},{"line_number":85,"context_line":"                                    CONF.network.build_interval):"},{"line_number":86,"context_line":"            m \u003d (\"Timed out waiting for firewall %s to reach %s state(s) %s\" %"},{"line_number":87,"context_line":"                 (fw_id, target_states))"},{"line_number":88,"context_line":"            raise exceptions.TimeoutException(m)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_979bc871","line":86,"in_reply_to":"1abeadc6_c785c5cf","updated":"2014-08-25 17:53:04.000000000","message":"I\u0027ve hit this sort of thing enough that I watch out for it now.  Our UTs just don\u0027t cover these failure scenarios enough.  We\u0027ve had agents die with log messages in production.  ;(\n\nThis is one of the best arguments for UT coverage in an lazily interpreted language.","commit_id":"595628bedb522265c36eb787d226c1d641c0fa80"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"6dd7cd3ed06b50a9ad3d574ad75ef01e883ead87","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not test.call_until_true(_wait, CONF.network.build_timeout,"},{"line_number":85,"context_line":"                                    CONF.network.build_interval):"},{"line_number":86,"context_line":"            m \u003d (\"Timed out waiting for firewall %s to reach %s state(s)\" %"},{"line_number":87,"context_line":"                 (fw_id, target_states))"},{"line_number":88,"context_line":"            raise exceptions.TimeoutException(m)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_c520f19d","line":86,"updated":"2014-09-09 14:51:40.000000000","message":"(Suggestion only)\n\nreach %s state(s) -\u003e reach one of the following states: %s","commit_id":"c9e9bf6f5f7c311e942a6b9154f37ace19df8d95"}]}