)]}'
{"tempest/api/network/base.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d173a736e64af6fcdfae23cb17cd52964060a539","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            elif not gateway:"},{"line_number":171,"context_line":"                gateway_ip \u003d str(netaddr.IPAddress(subnet_cidr) + 1)"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                gateway_ip \u003d gateway"},{"line_number":174,"context_line":"            try:"},{"line_number":175,"context_line":"                resp, body \u003d cls.client.create_subnet("},{"line_number":176,"context_line":"                    network_id\u003dnetwork[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_3e451017","line":173,"updated":"2014-09-25 15:54:33.000000000","message":"If a specific gateway is specified, then ideally we don\u0027t want to enter this loop searching for a free cidr.","commit_id":"3a49416a8f6ec547fd6d2f96fecc1cfbb6d0e309"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3620176acf16e491ec1273c5c191986a5bf0ca09","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            elif not gateway:"},{"line_number":171,"context_line":"                gateway_ip \u003d str(netaddr.IPAddress(subnet_cidr) + 1)"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                gateway_ip \u003d gateway"},{"line_number":174,"context_line":"            try:"},{"line_number":175,"context_line":"                resp, body \u003d cls.client.create_subnet("},{"line_number":176,"context_line":"                    network_id\u003dnetwork[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_998fc374","line":173,"in_reply_to":"da9df570_3e451017","updated":"2014-09-29 13:56:15.000000000","message":"if gateway and cidr(!) are specified, than it will exit on first cycle. Treating it as separate case will complicate and duplicate the code. \n\nIf cidr is not specified we anyway should cycle over subnets. For example, ipv6 subnet could set gateway as link local address not within subnet range - i.e. gateway fe80::ff for subnet 2003::/64 is legal case according to current neutron code.","commit_id":"3a49416a8f6ec547fd6d2f96fecc1cfbb6d0e309"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"da12eecfdc60c27049c6e91534cd2ebbefb8c311","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            elif not gateway:"},{"line_number":171,"context_line":"                gateway_ip \u003d str(netaddr.IPAddress(subnet_cidr) + 1)"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                gateway_ip \u003d gateway"},{"line_number":174,"context_line":"            try:"},{"line_number":175,"context_line":"                resp, body \u003d cls.client.create_subnet("},{"line_number":176,"context_line":"                    network_id\u003dnetwork[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c25d84eb","line":173,"in_reply_to":"da9df570_998fc374","updated":"2014-09-29 15:19:16.000000000","message":"Agreed. Thanks.","commit_id":"3a49416a8f6ec547fd6d2f96fecc1cfbb6d0e309"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d173a736e64af6fcdfae23cb17cd52964060a539","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            except exceptions.BadRequest as e:"},{"line_number":183,"context_line":"                is_overlapping_cidr \u003d \u0027overlaps with another subnet\u0027 in str(e)"},{"line_number":184,"context_line":"                # Unset gateway value if there is an overlapping subnet"},{"line_number":185,"context_line":"                gateway \u003d None"},{"line_number":186,"context_line":"                if not is_overlapping_cidr:"},{"line_number":187,"context_line":"                    raise"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_be9ae06b","line":185,"updated":"2014-09-25 15:54:33.000000000","message":"This now breaks the free cidr search.","commit_id":"3a49416a8f6ec547fd6d2f96fecc1cfbb6d0e309"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3620176acf16e491ec1273c5c191986a5bf0ca09","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            except exceptions.BadRequest as e:"},{"line_number":183,"context_line":"                is_overlapping_cidr \u003d \u0027overlaps with another subnet\u0027 in str(e)"},{"line_number":184,"context_line":"                # Unset gateway value if there is an overlapping subnet"},{"line_number":185,"context_line":"                gateway \u003d None"},{"line_number":186,"context_line":"                if not is_overlapping_cidr:"},{"line_number":187,"context_line":"                    raise"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_462c4b4b","line":185,"in_reply_to":"da9df570_be9ae06b","updated":"2014-09-29 13:56:15.000000000","message":"removed this","commit_id":"3a49416a8f6ec547fd6d2f96fecc1cfbb6d0e309"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1e11698bfe980dbbb38d8aa6dbdc6989d4ab4ec9","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            cidr \u003d ("},{"line_number":164,"context_line":"                cidr or netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr))"},{"line_number":165,"context_line":"            mask_bits \u003d mask_bits or CONF.network.tenant_network_v6_mask_bits"},{"line_number":166,"context_line":"        # Find a cidr that is not in use yet and create a subnet with it"},{"line_number":167,"context_line":"        for subnet_cidr in cidr.subnet(mask_bits):"},{"line_number":168,"context_line":"            if gateway is None:"},{"line_number":169,"context_line":"                gateway_ip \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_c203c471","line":166,"updated":"2014-09-29 15:19:22.000000000","message":"I think we need to keep track of how the gateway was specified by the caller.\n\n  gateway_ip_from_cidr \u003d True if gateway \u003d\u003d \u0027\u0027 else False","commit_id":"9ad921f65df520ecdf6fa8ffec5a0e2abd20d165"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"73972b522f820e1ebf4a931ffc572d0a40b136f7","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            cidr \u003d ("},{"line_number":164,"context_line":"                cidr or netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr))"},{"line_number":165,"context_line":"            mask_bits \u003d mask_bits or CONF.network.tenant_network_v6_mask_bits"},{"line_number":166,"context_line":"        # Find a cidr that is not in use yet and create a subnet with it"},{"line_number":167,"context_line":"        for subnet_cidr in cidr.subnet(mask_bits):"},{"line_number":168,"context_line":"            if gateway is None:"},{"line_number":169,"context_line":"                gateway_ip \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_d8cab6a0","line":166,"in_reply_to":"baa201ad_a2e8807d","updated":"2014-09-30 14:56:21.000000000","message":"I did it a bit different but with same result","commit_id":"9ad921f65df520ecdf6fa8ffec5a0e2abd20d165"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0e7f8a18bbd9a0963e28a6901e67ed22c3a6a2b4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            cidr \u003d ("},{"line_number":164,"context_line":"                cidr or netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr))"},{"line_number":165,"context_line":"            mask_bits \u003d mask_bits or CONF.network.tenant_network_v6_mask_bits"},{"line_number":166,"context_line":"        # Find a cidr that is not in use yet and create a subnet with it"},{"line_number":167,"context_line":"        for subnet_cidr in cidr.subnet(mask_bits):"},{"line_number":168,"context_line":"            if gateway is None:"},{"line_number":169,"context_line":"                gateway_ip \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_a2e8807d","line":166,"in_reply_to":"baa201ad_c203c471","updated":"2014-09-29 15:21:58.000000000","message":"Or you could write:\n\n  gateway_ip_from_cidr \u003d gateway \u003d\u003d \u0027\u0027\n\nAlthough I think it is a bit cryptic.","commit_id":"9ad921f65df520ecdf6fa8ffec5a0e2abd20d165"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1e11698bfe980dbbb38d8aa6dbdc6989d4ab4ec9","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        for subnet_cidr in cidr.subnet(mask_bits):"},{"line_number":168,"context_line":"            if gateway is None:"},{"line_number":169,"context_line":"                gateway_ip \u003d None"},{"line_number":170,"context_line":"            elif not gateway:"},{"line_number":171,"context_line":"                gateway_ip \u003d str(netaddr.IPAddress(subnet_cidr) + 1)"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                gateway_ip \u003d gateway"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_22f2d09a","line":170,"updated":"2014-09-29 15:19:22.000000000","message":"elif gateway_ip_from_cidr:","commit_id":"9ad921f65df520ecdf6fa8ffec5a0e2abd20d165"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1e11698bfe980dbbb38d8aa6dbdc6989d4ab4ec9","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                break"},{"line_number":182,"context_line":"            except exceptions.BadRequest as e:"},{"line_number":183,"context_line":"                is_overlapping_cidr \u003d \u0027overlaps with another subnet\u0027 in str(e)"},{"line_number":184,"context_line":"                # Unset gateway value if there is an overlapping subnet"},{"line_number":185,"context_line":"                if not is_overlapping_cidr:"},{"line_number":186,"context_line":"                    raise"},{"line_number":187,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_82e29cd3","line":184,"updated":"2014-09-29 15:19:22.000000000","message":"Remove this comment.","commit_id":"9ad921f65df520ecdf6fa8ffec5a0e2abd20d165"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"73972b522f820e1ebf4a931ffc572d0a40b136f7","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                break"},{"line_number":182,"context_line":"            except exceptions.BadRequest as e:"},{"line_number":183,"context_line":"                is_overlapping_cidr \u003d \u0027overlaps with another subnet\u0027 in str(e)"},{"line_number":184,"context_line":"                # Unset gateway value if there is an overlapping subnet"},{"line_number":185,"context_line":"                if not is_overlapping_cidr:"},{"line_number":186,"context_line":"                    raise"},{"line_number":187,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_265d6e22","line":184,"in_reply_to":"baa201ad_82e29cd3","updated":"2014-09-30 14:56:21.000000000","message":"Done","commit_id":"9ad921f65df520ecdf6fa8ffec5a0e2abd20d165"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"9a51267da4ea9c14b5443df0a1a7d8b143575fcd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \"\"\"Wrapper utility that returns a test subnet.\"\"\""},{"line_number":158,"context_line":"        # The cidr and mask_bits depend on the ip version."},{"line_number":159,"context_line":"        ip_version \u003d ip_version if ip_version is not None else cls._ip_version"},{"line_number":160,"context_line":"        gateway_not_set \u003d gateway \u003d\u003d \u0027\u0027"},{"line_number":161,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":162,"context_line":"            cidr \u003d cidr or netaddr.IPNetwork(CONF.network.tenant_network_cidr)"},{"line_number":163,"context_line":"            mask_bits \u003d mask_bits or CONF.network.tenant_network_mask_bits"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_43e22a04","line":160,"updated":"2014-10-22 10:29:05.000000000","message":"nit: this isn\u0027t really needed. you could just check later for gw\u003d\u003d\u0027\u0027.","commit_id":"058f02e092a783adf14c957a8906936f93369f19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df42773e61ee4faaaee06e09cd5c1150c632cbc3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \"\"\"Wrapper utility that returns a test subnet.\"\"\""},{"line_number":158,"context_line":"        # The cidr and mask_bits depend on the ip version."},{"line_number":159,"context_line":"        ip_version \u003d ip_version if ip_version is not None else cls._ip_version"},{"line_number":160,"context_line":"        gateway_not_set \u003d gateway \u003d\u003d \u0027\u0027"},{"line_number":161,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":162,"context_line":"            cidr \u003d cidr or netaddr.IPNetwork(CONF.network.tenant_network_cidr)"},{"line_number":163,"context_line":"            mask_bits \u003d mask_bits or CONF.network.tenant_network_mask_bits"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_636e4e31","line":160,"in_reply_to":"9aa7fdbe_43e22a04","updated":"2014-10-22 12:33:57.000000000","message":"I consciously set it as variable, because gw as \"\" is kinda hack and not so readable and clear.","commit_id":"058f02e092a783adf14c957a8906936f93369f19"}],"tempest/api/network/test_networks.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1282fef40fa74bc76bc9f0b20bcf9722d27dd2a4","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":347,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":348,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":349,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":350,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dNone)"},{"line_number":351,"context_line":"        # Verifies Subnet GW is None in IPv4"},{"line_number":352,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_a622694f","line":349,"updated":"2014-10-09 06:35:03.000000000","message":"Please add cleanup also to avoid any resource leakage.\nself.addCleanup(self._try_delete_network, net_id)","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bdc04e6ca0c06c182983fcbc82c201fefe8caaf5","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":347,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":348,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":349,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":350,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dNone)"},{"line_number":351,"context_line":"        # Verifies Subnet GW is None in IPv4"},{"line_number":352,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_c6e59b0b","line":349,"in_reply_to":"baa201ad_a622694f","updated":"2014-10-09 18:32:42.000000000","message":"Done","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1282fef40fa74bc76bc9f0b20bcf9722d27dd2a4","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":360,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":361,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":362,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":363,"context_line":"        subnet1 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d6)"},{"line_number":364,"context_line":"        subnet2 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d4)"},{"line_number":365,"context_line":"        # Verifies Subnet GW is None in IPv6"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_6334f349","line":362,"updated":"2014-10-09 06:35:03.000000000","message":"ditto","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c605765604e4ef0acccf0a8a73c701aeb8cf40f0","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":360,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":361,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":362,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":363,"context_line":"        subnet1 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d6)"},{"line_number":364,"context_line":"        subnet2 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d4)"},{"line_number":365,"context_line":"        # Verifies Subnet GW is None in IPv6"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_dc11e354","line":362,"in_reply_to":"baa201ad_46b9abeb","updated":"2014-10-10 02:04:15.000000000","message":"Sorry for confusion :). I meant to add cleanup which you did. Thanks","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bdc04e6ca0c06c182983fcbc82c201fefe8caaf5","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":360,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":361,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":362,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":363,"context_line":"        subnet1 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d6)"},{"line_number":364,"context_line":"        subnet2 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d4)"},{"line_number":365,"context_line":"        # Verifies Subnet GW is None in IPv6"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_46b9abeb","line":362,"in_reply_to":"baa201ad_6334f349","updated":"2014-10-09 18:32:42.000000000","message":"can you explain please?\nIf this about 3 lines above, I\u0027d like to leave them for readability as it\u0027s done in previous tests in this file.","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1282fef40fa74bc76bc9f0b20bcf9722d27dd2a4","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":361,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":362,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":363,"context_line":"        subnet1 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d6)"},{"line_number":364,"context_line":"        subnet2 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d4)"},{"line_number":365,"context_line":"        # Verifies Subnet GW is None in IPv6"},{"line_number":366,"context_line":"        self.assertEqual(subnet1[\u0027gateway_ip\u0027], None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_2650390a","line":363,"updated":"2014-10-09 06:35:03.000000000","message":"Do not we need ipv6 feature enabled for ipv6 tests?\n\nwe can do like-\nsubnet1 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003dself._ip_version)","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bdc04e6ca0c06c182983fcbc82c201fefe8caaf5","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":361,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":362,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":363,"context_line":"        subnet1 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d6)"},{"line_number":364,"context_line":"        subnet2 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d4)"},{"line_number":365,"context_line":"        # Verifies Subnet GW is None in IPv6"},{"line_number":366,"context_line":"        self.assertEqual(subnet1[\u0027gateway_ip\u0027], None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_66beafd6","line":363,"in_reply_to":"baa201ad_2650390a","updated":"2014-10-09 18:32:42.000000000","message":"Added check for ipv6. In this test the main idea is to set explicitly two subnets with different IP versions, not depending on source IP version of class.","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1282fef40fa74bc76bc9f0b20bcf9722d27dd2a4","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        # Verifies Subnet GW is None in IPv6"},{"line_number":366,"context_line":"        self.assertEqual(subnet1[\u0027gateway_ip\u0027], None)"},{"line_number":367,"context_line":"        # Verifies Subnet GW is None in IPv4"},{"line_number":368,"context_line":"        self.assertEqual(subnet2[\u0027gateway_ip\u0027], None)"},{"line_number":369,"context_line":"        # Delete network and subnets"},{"line_number":370,"context_line":"        self.client.delete_network(net_id)"},{"line_number":371,"context_line":"        self.subnets.pop()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_86df2539","line":368,"updated":"2014-10-09 06:35:03.000000000","message":"it will be good if we add cidr check also here to confirm it is created with ipv4 or ipv6","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bdc04e6ca0c06c182983fcbc82c201fefe8caaf5","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        # Verifies Subnet GW is None in IPv6"},{"line_number":366,"context_line":"        self.assertEqual(subnet1[\u0027gateway_ip\u0027], None)"},{"line_number":367,"context_line":"        # Verifies Subnet GW is None in IPv4"},{"line_number":368,"context_line":"        self.assertEqual(subnet2[\u0027gateway_ip\u0027], None)"},{"line_number":369,"context_line":"        # Delete network and subnets"},{"line_number":370,"context_line":"        self.client.delete_network(net_id)"},{"line_number":371,"context_line":"        self.subnets.pop()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_66f22f71","line":368,"in_reply_to":"baa201ad_86df2539","updated":"2014-10-09 18:32:42.000000000","message":"Done","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1282fef40fa74bc76bc9f0b20bcf9722d27dd2a4","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        # Verifies Subnet GW in IPv6"},{"line_number":522,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], gateway)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":525,"context_line":"    def test_create_delete_subnet_without_gw(self):"},{"line_number":526,"context_line":"        net \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":527,"context_line":"        gateway_ip \u003d str(netaddr.IPAddress(net.first + 1))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_83463779","line":524,"updated":"2014-10-09 06:35:03.000000000","message":"Please rename this tests as it will be confusing with newly added one\n\nsomething - test_create_delete_subnet_with_default_gw(self)","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bdc04e6ca0c06c182983fcbc82c201fefe8caaf5","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        # Verifies Subnet GW in IPv6"},{"line_number":522,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], gateway)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":525,"context_line":"    def test_create_delete_subnet_without_gw(self):"},{"line_number":526,"context_line":"        net \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":527,"context_line":"        gateway_ip \u003d str(netaddr.IPAddress(net.first + 1))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_86e713ac","line":524,"in_reply_to":"baa201ad_83463779","updated":"2014-10-09 18:32:42.000000000","message":"Done","commit_id":"c97bdb39cb4ae8526752bfa5bbcea01cc4107c3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81899160ead572ecde356a62da731d3e8d5b4aec","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    @testtools.skipIf(not CONF.network_feature_enabled.ipv6,"},{"line_number":359,"context_line":"                      \u0027IPv6 Tests are disabled.\u0027)"},{"line_number":360,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":361,"context_line":"    def test_create_delete_subnet_with_no_gw64(self):"},{"line_number":362,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":363,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":364,"context_line":"        network \u003d body[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_1c336bf7","line":361,"updated":"2014-10-10 02:04:08.000000000","message":"Got it. In this case this can be moved to class NetworksIpV6TestJSON(NetworksTestJSON): for more clear classification of tests.","commit_id":"e4047b627b3603619d85d166ef9f0bcdf60523b2"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7a2b1e561372ff460da187e3c0c127b72f068c97","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    @testtools.skipIf(not CONF.network_feature_enabled.ipv6,"},{"line_number":359,"context_line":"                      \u0027IPv6 Tests are disabled.\u0027)"},{"line_number":360,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":361,"context_line":"    def test_create_delete_subnet_with_no_gw64(self):"},{"line_number":362,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":363,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":364,"context_line":"        network \u003d body[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_4980d48b","line":361,"in_reply_to":"baa201ad_1c336bf7","updated":"2014-10-10 06:11:58.000000000","message":"Done","commit_id":"e4047b627b3603619d85d166ef9f0bcdf60523b2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"94e8567a7417a3f11ced8d1a6bc5078cf0552833","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":345,"context_line":"    def test_create_delete_subnet_with_no_gw(self):"},{"line_number":346,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":347,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":348,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":349,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":350,"context_line":"        self.addCleanup(self._try_delete_network, net_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_7519de21","line":347,"updated":"2014-10-10 13:17:28.000000000","message":"I suggest you use the conventional tempest way of creating a network:\n\n  network \u003d self.create_network(network_name\u003dname)\n\nThis will then automatically get deleted when the test case ends.","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"666b838e20c1ae78535b4189f7870be764383060","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":345,"context_line":"    def test_create_delete_subnet_with_no_gw(self):"},{"line_number":346,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":347,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":348,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":349,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":350,"context_line":"        self.addCleanup(self._try_delete_network, net_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_96dc851a","line":347,"in_reply_to":"baa201ad_7519de21","updated":"2014-10-14 17:54:50.000000000","message":"you\u0027re right","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"94e8567a7417a3f11ced8d1a6bc5078cf0552833","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":348,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":349,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":350,"context_line":"        self.addCleanup(self._try_delete_network, net_id)"},{"line_number":351,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dNone)"},{"line_number":352,"context_line":"        # Verifies Subnet GW is None in IPv4"},{"line_number":353,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], None)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_b5b986ee","line":350,"updated":"2014-10-10 13:17:28.000000000","message":"Above three lines not needed.","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"666b838e20c1ae78535b4189f7870be764383060","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":348,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":349,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":350,"context_line":"        self.addCleanup(self._try_delete_network, net_id)"},{"line_number":351,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dNone)"},{"line_number":352,"context_line":"        # Verifies Subnet GW is None in IPv4"},{"line_number":353,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], None)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_eccdb2b8","line":350,"in_reply_to":"baa201ad_b5b986ee","updated":"2014-10-14 17:54:50.000000000","message":"Done","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"94e8567a7417a3f11ced8d1a6bc5078cf0552833","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], None)"},{"line_number":354,"context_line":"        # Delete network and subnet"},{"line_number":355,"context_line":"        self.client.delete_network(net_id)"},{"line_number":356,"context_line":"        self.subnets.pop()"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"class NetworksTestXML(NetworksTestJSON):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_55ca1a6f","line":356,"updated":"2014-10-10 13:17:28.000000000","message":"Above three lines not needed.","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"666b838e20c1ae78535b4189f7870be764383060","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], None)"},{"line_number":354,"context_line":"        # Delete network and subnet"},{"line_number":355,"context_line":"        self.client.delete_network(net_id)"},{"line_number":356,"context_line":"        self.subnets.pop()"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"class NetworksTestXML(NetworksTestJSON):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_cccaaea0","line":356,"in_reply_to":"baa201ad_55ca1a6f","updated":"2014-10-14 17:54:50.000000000","message":"Done","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"94e8567a7417a3f11ced8d1a6bc5078cf0552833","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":519,"context_line":"    def test_create_delete_subnet_with_no_gw64(self):"},{"line_number":520,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":521,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":522,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":523,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":524,"context_line":"        self.addCleanup(self._try_delete_network, net_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_d5a52ab6","line":521,"updated":"2014-10-10 13:17:28.000000000","message":"Use:\n\n   network \u003d self.create_network(network_name\u003dname)","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"666b838e20c1ae78535b4189f7870be764383060","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":519,"context_line":"    def test_create_delete_subnet_with_no_gw64(self):"},{"line_number":520,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":521,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":522,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":523,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":524,"context_line":"        self.addCleanup(self._try_delete_network, net_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_6cb9c214","line":521,"in_reply_to":"baa201ad_d5a52ab6","updated":"2014-10-14 17:54:50.000000000","message":"Done","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"94e8567a7417a3f11ced8d1a6bc5078cf0552833","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":522,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":523,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":524,"context_line":"        self.addCleanup(self._try_delete_network, net_id)"},{"line_number":525,"context_line":"        subnet1 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d6)"},{"line_number":526,"context_line":"        self.assertEqual(netaddr.IPNetwork(subnet1[\u0027cidr\u0027]).version, 6,"},{"line_number":527,"context_line":"                         \u0027The created subnet is not IPv6\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_d5936a4d","line":524,"updated":"2014-10-10 13:17:28.000000000","message":"Above three lines not needed.","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"666b838e20c1ae78535b4189f7870be764383060","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        _, body \u003d self.client.create_network(name\u003dname)"},{"line_number":522,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":523,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":524,"context_line":"        self.addCleanup(self._try_delete_network, net_id)"},{"line_number":525,"context_line":"        subnet1 \u003d self.create_subnet(network, gateway\u003dNone, ip_version\u003d6)"},{"line_number":526,"context_line":"        self.assertEqual(netaddr.IPNetwork(subnet1[\u0027cidr\u0027]).version, 6,"},{"line_number":527,"context_line":"                         \u0027The created subnet is not IPv6\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_8c37c6af","line":524,"in_reply_to":"baa201ad_d5936a4d","updated":"2014-10-14 17:54:50.000000000","message":"Done","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"94e8567a7417a3f11ced8d1a6bc5078cf0552833","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        # Delete network and subnets"},{"line_number":536,"context_line":"        self.client.delete_network(net_id)"},{"line_number":537,"context_line":"        self.subnets.pop()"},{"line_number":538,"context_line":"        self.subnets.pop()"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    @testtools.skipUnless(CONF.network_feature_enabled.ipv6_subnet_attributes,"},{"line_number":541,"context_line":"                          \"IPv6 extended attributes for subnets not \""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_95a9e27d","line":538,"updated":"2014-10-10 13:17:28.000000000","message":"Above four lines not needed.","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"666b838e20c1ae78535b4189f7870be764383060","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        # Delete network and subnets"},{"line_number":536,"context_line":"        self.client.delete_network(net_id)"},{"line_number":537,"context_line":"        self.subnets.pop()"},{"line_number":538,"context_line":"        self.subnets.pop()"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    @testtools.skipUnless(CONF.network_feature_enabled.ipv6_subnet_attributes,"},{"line_number":541,"context_line":"                          \"IPv6 extended attributes for subnets not \""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_ac3aca95","line":538,"in_reply_to":"baa201ad_95a9e27d","updated":"2014-10-14 17:54:50.000000000","message":"Done","commit_id":"40ace893fd742a7c51b3faa27d11cd7f54891a42"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"de235296d01e3fe6847dbe55514b69e185327a37","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            **self.subnet_dict([\u0027gateway\u0027, \u0027host_routes\u0027, \u0027dns_nameservers\u0027]))"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":345,"context_line":"    def test_create_delete_subnet_with_no_gw(self):"},{"line_number":346,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":347,"context_line":"        network \u003d self.create_network(name)"},{"line_number":348,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dNone)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa201ad_ca38c4a2","line":345,"updated":"2014-10-15 03:12:49.000000000","message":"Isn\u0027t this a subset of test_create_delete_subnet_with_no_gw64? Do we really need it?","commit_id":"022c773d363e636e2bdfe033750613c56da4ccf4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d7142ed853df9f846f425f45dbbe7da07ca27320","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            **self.subnet_dict([\u0027gateway\u0027, \u0027host_routes\u0027, \u0027dns_nameservers\u0027]))"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":345,"context_line":"    def test_create_delete_subnet_with_no_gw(self):"},{"line_number":346,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":347,"context_line":"        network \u003d self.create_network(name)"},{"line_number":348,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dNone)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa201ad_2ce088f9","line":345,"in_reply_to":"baa201ad_ca38c4a2","updated":"2014-10-15 08:39:51.000000000","message":"It really is. However the 64 test is executed when IPv6 is enabled/available ONLY. If not - we won\u0027t check it. This test target is gateway, although 64 test checks 6+4 subnets together. I\u0027d leave both of them because they test actually different fields.","commit_id":"022c773d363e636e2bdfe033750613c56da4ccf4"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"9a51267da4ea9c14b5443df0a1a7d8b143575fcd","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":511,"context_line":"        network \u003d self.create_network(name)"},{"line_number":512,"context_line":"        subnet1 \u003d self.create_subnet(network,"},{"line_number":513,"context_line":"                                     gateway\u003d\"fe80::1234\","},{"line_number":514,"context_line":"                                     ip_version\u003d6)"},{"line_number":515,"context_line":"        self.assertEqual(netaddr.IPNetwork(subnet1[\u0027cidr\u0027]).version, 6,"},{"line_number":516,"context_line":"                         \u0027The created subnet is not IPv6\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_a3ae7683","line":513,"updated":"2014-10-22 10:29:05.000000000","message":"there\u0027s a dict at the top of the module that helps avoid hard-coded constants. please use it","commit_id":"058f02e092a783adf14c957a8906936f93369f19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df42773e61ee4faaaee06e09cd5c1150c632cbc3","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":511,"context_line":"        network \u003d self.create_network(name)"},{"line_number":512,"context_line":"        subnet1 \u003d self.create_subnet(network,"},{"line_number":513,"context_line":"                                     gateway\u003d\"fe80::1234\","},{"line_number":514,"context_line":"                                     ip_version\u003d6)"},{"line_number":515,"context_line":"        self.assertEqual(netaddr.IPNetwork(subnet1[\u0027cidr\u0027]).version, 6,"},{"line_number":516,"context_line":"                         \u0027The created subnet is not IPv6\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_6cf9db7f","line":513,"in_reply_to":"9aa7fdbe_a3ae7683","updated":"2014-10-22 12:33:57.000000000","message":"Done","commit_id":"058f02e092a783adf14c957a8906936f93369f19"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"9a51267da4ea9c14b5443df0a1a7d8b143575fcd","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        self.assertEqual(netaddr.IPNetwork(subnet2[\u0027cidr\u0027]).version, 4,"},{"line_number":521,"context_line":"                         \u0027The created subnet is not IPv4\u0027)"},{"line_number":522,"context_line":"        # Verifies Subnet GW is fe80::1234 in IPv6"},{"line_number":523,"context_line":"        self.assertEqual(subnet1[\u0027gateway_ip\u0027], \"fe80::1234\")"},{"line_number":524,"context_line":"        # Verifies Subnet GW is None in IPv4"},{"line_number":525,"context_line":"        self.assertEqual(subnet2[\u0027gateway_ip\u0027], None)"},{"line_number":526,"context_line":"        # Verifies all 2 subnets in the same network"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_e3b79ed6","line":523,"updated":"2014-10-22 10:29:05.000000000","message":"ditto","commit_id":"058f02e092a783adf14c957a8906936f93369f19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df42773e61ee4faaaee06e09cd5c1150c632cbc3","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        self.assertEqual(netaddr.IPNetwork(subnet2[\u0027cidr\u0027]).version, 4,"},{"line_number":521,"context_line":"                         \u0027The created subnet is not IPv4\u0027)"},{"line_number":522,"context_line":"        # Verifies Subnet GW is fe80::1234 in IPv6"},{"line_number":523,"context_line":"        self.assertEqual(subnet1[\u0027gateway_ip\u0027], \"fe80::1234\")"},{"line_number":524,"context_line":"        # Verifies Subnet GW is None in IPv4"},{"line_number":525,"context_line":"        self.assertEqual(subnet2[\u0027gateway_ip\u0027], None)"},{"line_number":526,"context_line":"        # Verifies all 2 subnets in the same network"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_8cf43f88","line":523,"in_reply_to":"9aa7fdbe_e3b79ed6","updated":"2014-10-22 12:33:57.000000000","message":"Done","commit_id":"058f02e092a783adf14c957a8906936f93369f19"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ea018efcb4c4a6bbd3132aa5c3565f723b546817","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], gateway_ip)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":509,"context_line":"    def test_create_delete_subnet_with_no_gw64(self):"},{"line_number":510,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":511,"context_line":"        network \u003d self.create_network(name)"},{"line_number":512,"context_line":"        ipv6_gateway \u003d self.subnet_dict([\u0027gateway\u0027])[\u0027gateway\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aa7fdbe_08dca0e3","line":509,"updated":"2014-10-23 07:50:05.000000000","message":"Seems that the name of the test is outdated. There is no delete action. test_create_list_subnet_with_no_gw64_one_network may be.","commit_id":"a954ab8d0bbe4ef0dc2bd09138a9a04f03a161cf"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"25ee3123e007fc985a6d6b30714dcbb0d8b57f1f","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        self.assertEqual(subnet[\u0027gateway_ip\u0027], gateway_ip)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":509,"context_line":"    def test_create_delete_subnet_with_no_gw64(self):"},{"line_number":510,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":511,"context_line":"        network \u003d self.create_network(name)"},{"line_number":512,"context_line":"        ipv6_gateway \u003d self.subnet_dict([\u0027gateway\u0027])[\u0027gateway\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aa7fdbe_a8f0ef67","line":509,"in_reply_to":"9aa7fdbe_08dca0e3","updated":"2014-10-23 10:58:01.000000000","message":"Done","commit_id":"a954ab8d0bbe4ef0dc2bd09138a9a04f03a161cf"}]}