)]}'
{"tempest/api/baremetal/admin/test_nodes.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"adcd1dfba9239ba65e2bbe92afaacf8cc1ee62bb","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":101,"context_line":"    def test_node_port_list(self):"},{"line_number":102,"context_line":"        _, self.port \u003d self.create_port(self.node[\u0027uuid\u0027],"},{"line_number":103,"context_line":"                                        data_utils.rand_mac_address())"},{"line_number":104,"context_line":"        _, body \u003d self.client.list_node_ports(self.node[\u0027uuid\u0027])"},{"line_number":105,"context_line":"        self.assertIn(self.port[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_2b6eb92f","line":102,"updated":"2014-09-11 04:09:57.000000000","message":"It is not necessary to store self.port because self.port is used in this test method only.","commit_id":"906489d12ce4b28e188cd070a39b1f7b7de81dfb"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8b67dd59d099925627cdfe65c3a41c8c1632cea8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Ensure nodes instance association is removed on cleanup, if"},{"line_number":33,"context_line":"        # it exists."},{"line_number":34,"context_line":"        try:"},{"line_number":35,"context_line":"            self.client.update_node(self.node[\u0027uuid\u0027],"},{"line_number":36,"context_line":"                                    instance_uuid\u003dNone)"},{"line_number":37,"context_line":"        except Exception:"},{"line_number":38,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_e75b3220","line":35,"updated":"2014-09-18 21:34:54.000000000","message":"This should be done with an addCleanup instead.","commit_id":"10a970fa1f047741e49b242b873a9405c5e29b74"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8b67dd59d099925627cdfe65c3a41c8c1632cea8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.assertNotIn(self.node[\u0027uuid\u0027],"},{"line_number":90,"context_line":"                         [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._associate_node_with_instance()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        _, body \u003d self.client.list_nodes(associated\u003dTrue)"},{"line_number":95,"context_line":"        self.assertIn(self.node[\u0027uuid\u0027], [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_47a4fe07","line":92,"updated":"2014-09-18 21:34:54.000000000","message":"addCleanup here?","commit_id":"10a970fa1f047741e49b242b873a9405c5e29b74"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8b67dd59d099925627cdfe65c3a41c8c1632cea8","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":174,"context_line":"    def test_get_node_by_instance_uuid(self):"},{"line_number":175,"context_line":"        instance_uuid \u003d self._associate_node_with_instance()"},{"line_number":176,"context_line":"        _, body \u003d self.client.show_node_by_instance_uuid(instance_uuid)"},{"line_number":177,"context_line":"        self.assertEqual(len(body[\u0027nodes\u0027]), 1)"},{"line_number":178,"context_line":"        self.assertIn(self.node[\u0027uuid\u0027], [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_07cf56b4","line":175,"updated":"2014-09-18 21:34:54.000000000","message":"addCleanup here","commit_id":"10a970fa1f047741e49b242b873a9405c5e29b74"}],"tempest/common/waiters.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"adcd1dfba9239ba65e2bbe92afaacf8cc1ee62bb","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    The client should have a show_node(node_uuid) method to get the node."},{"line_number":140,"context_line":"    \"\"\""},{"line_number":141,"context_line":"    resp, node \u003d client.show_node(node_id)"},{"line_number":142,"context_line":"    start \u003d int(time.time())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    while node[attr] !\u003d status:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_ebe591a4","line":141,"updated":"2014-09-11 04:09:57.000000000","message":"resp is not used. it is nice to change here to\n\n _, node \u003d client.show_node(node_id)\n\nlike the other places in this patch.","commit_id":"906489d12ce4b28e188cd070a39b1f7b7de81dfb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"adcd1dfba9239ba65e2bbe92afaacf8cc1ee62bb","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    while node[attr] !\u003d status:"},{"line_number":145,"context_line":"        time.sleep(client.build_interval)"},{"line_number":146,"context_line":"        resp, node \u003d client.show_node(node_id)"},{"line_number":147,"context_line":"        if node[attr] \u003d\u003d status:"},{"line_number":148,"context_line":"            return"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_0bebb578","line":146,"updated":"2014-09-11 04:09:57.000000000","message":"ditto","commit_id":"906489d12ce4b28e188cd070a39b1f7b7de81dfb"}]}