)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4619382db9ef5c314ab59fc7155c45346f28c9be","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                                            CONF.compute.ping_timeout,"},{"line_number":740,"context_line":"                                            1)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def _create_security_group(self, tenant_id\u003dNone, client\u003dNone,"},{"line_number":743,"context_line":"                               namestart\u003d\u0027secgroup-smoke\u0027):"},{"line_number":744,"context_line":"        if client is None:"},{"line_number":745,"context_line":"            client \u003d self.network_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_c372d0af","line":742,"updated":"2014-09-17 14:09:49.000000000","message":"unrelated change...","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"168d868ddd2e0194fc9301636ff9069572b22128","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                                            CONF.compute.ping_timeout,"},{"line_number":740,"context_line":"                                            1)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def _create_security_group(self, tenant_id\u003dNone, client\u003dNone,"},{"line_number":743,"context_line":"                               namestart\u003d\u0027secgroup-smoke\u0027):"},{"line_number":744,"context_line":"        if client is None:"},{"line_number":745,"context_line":"            client \u003d self.network_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_08569e06","line":742,"in_reply_to":"fa98f980_c372d0af","updated":"2014-09-18 08:01:58.000000000","message":"Done","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"f751fa1d61e2795781cec9864d12515d92374754","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                debug.log_net_debug()"},{"line_number":520,"context_line":"            raise"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def _create_floating_ip(self, thing, pool_name\u003dNone):"},{"line_number":523,"context_line":"        \"\"\"Creates a floating IP and associates to a server using"},{"line_number":524,"context_line":"        Nova clients"},{"line_number":525,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_45735e4d","line":522,"updated":"2014-09-29 15:45:01.000000000","message":"As fresh eyes looking at this patch, I think it is a little confusing to have methods with the same name and different args in the parent and child class.  Maybe you could change it to _create_nova_floating_ip and the other to _create_neutron_floating_ip?  Unless there\u0027s a clever reason that I\u0027m not seeing for the same name. Please let me know your thoughts.","commit_id":"c9f4006802d1e942eede740fb342ba2ec5156d75"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a2d7688e11ef39d082fc58478d197851e456644a","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                debug.log_net_debug()"},{"line_number":520,"context_line":"            raise"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def _create_floating_ip(self, thing, pool_name\u003dNone):"},{"line_number":523,"context_line":"        \"\"\"Creates a floating IP and associates to a server using"},{"line_number":524,"context_line":"        Nova clients"},{"line_number":525,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_dbd55b44","line":522,"in_reply_to":"baa201ad_45735e4d","updated":"2014-09-30 09:09:32.000000000","message":"I think with diff name we need another if else in large ops tests.\n\nApart from that I think name should include \u0027associate\u0027  also (for ex _create_associate_floating_ip) as it do associate the FIP too.","commit_id":"c9f4006802d1e942eede740fb342ba2ec5156d75"}],"tempest/scenario/test_large_ops.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4619382db9ef5c314ab59fc7155c45346f28c9be","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        cls.set_network_resources()"},{"line_number":43,"context_line":"        super(TestLargeOpsScenario, cls).setUpClass()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(TestLargeOpsScenario, self).setUp()"},{"line_number":47,"context_line":"        self.servers_count \u003d 0"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_e3d3545d","line":45,"updated":"2014-09-17 14:09:49.000000000","message":"Is this really needed? server count is initialized in _wait_for_servers_status anyways, which handles the whole list of servers any time it\u0027s invoked.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"dfb73b55475fbeb469879967d35bf1f210849d56","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        cls.set_network_resources()"},{"line_number":43,"context_line":"        super(TestLargeOpsScenario, cls).setUpClass()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(TestLargeOpsScenario, self).setUp()"},{"line_number":47,"context_line":"        self.servers_count \u003d 0"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_68f3aa9f","line":45,"in_reply_to":"fa98f980_6d849cb1","updated":"2014-09-18 08:25:44.000000000","message":"Please remove it then, it\u0027s not needed here.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"211d72c6b7599fac66c9fef50fd0d6da27a30473","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        cls.set_network_resources()"},{"line_number":43,"context_line":"        super(TestLargeOpsScenario, cls).setUpClass()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(TestLargeOpsScenario, self).setUp()"},{"line_number":47,"context_line":"        self.servers_count \u003d 0"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_c829f6f3","line":45,"in_reply_to":"fa98f980_6d849cb1","updated":"2014-09-18 09:49:29.000000000","message":"Yes, setUp is not needed.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"168d868ddd2e0194fc9301636ff9069572b22128","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        cls.set_network_resources()"},{"line_number":43,"context_line":"        super(TestLargeOpsScenario, cls).setUpClass()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(TestLargeOpsScenario, self).setUp()"},{"line_number":47,"context_line":"        self.servers_count \u003d 0"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_6d849cb1","line":45,"in_reply_to":"fa98f980_e3d3545d","updated":"2014-09-18 08:01:58.000000000","message":"Thought this should be declared somewhere. it really doesn\u0027t do anything special","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4619382db9ef5c314ab59fc7155c45346f28c9be","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                                           status)"},{"line_number":55,"context_line":"                self.servers_count +\u003d 1"},{"line_number":56,"context_line":"            except Exception as E:"},{"line_number":57,"context_line":"                LOG.exception(\"Verified status of %d out of %d servers\" %"},{"line_number":58,"context_line":"                              (self.servers_count, len(self.servers)))"},{"line_number":59,"context_line":"                raise"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_23e1dcfe","line":57,"updated":"2014-09-17 14:09:49.000000000","message":"I\u0027m not sure about this. If the 2nd server fails it will tell us that it could verify two servers, but we still have no idea about what was the status of the remaining 98 (or how many we spawn...).\nWe fail early on this test, which makes sense in the gate. But this just tells us how early we failed, it doesn\u0027t seem to be that much useful info.\n\nYou should not use LOG.exception and then raise the exception, it will be logged twice. \n\nBesides it looks like an unrelated change here.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"168d868ddd2e0194fc9301636ff9069572b22128","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                                           status)"},{"line_number":55,"context_line":"                self.servers_count +\u003d 1"},{"line_number":56,"context_line":"            except Exception as E:"},{"line_number":57,"context_line":"                LOG.exception(\"Verified status of %d out of %d servers\" %"},{"line_number":58,"context_line":"                              (self.servers_count, len(self.servers)))"},{"line_number":59,"context_line":"                raise"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_ed66cc28","line":57,"in_reply_to":"fa98f980_23e1dcfe","updated":"2014-09-18 08:01:58.000000000","message":"Done","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"211d72c6b7599fac66c9fef50fd0d6da27a30473","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027)"},{"line_number":106,"context_line":"    def test_large_ops_scenario_3(self):"},{"line_number":107,"context_line":"        self._large_ops_scenario()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_8db53d80","line":108,"updated":"2014-09-18 09:49:29.000000000","message":"Thanks Fried for this. If you want to run this large ops with connectivity check for neutron only then please check my comments below. If for nova-network also then we need do little bit more structural changes in scenario tests base class where switching can done whether to go for nova or neutron for example to create floating IPs etc.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0916af6638de744d1b097d60a06d8264ec2e4635","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027)"},{"line_number":106,"context_line":"    def test_large_ops_scenario_3(self):"},{"line_number":107,"context_line":"        self._large_ops_scenario()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_87dfd10b","line":108,"in_reply_to":"fa98f980_8db53d80","updated":"2014-09-18 15:17:18.000000000","message":"I am less interested in nova-network ATM. Also, all of the network helpers are Neutron-specific, and also - I don\u0027t like to proxy stuff when we already have too much stress on the neutron-nova relationship here","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"211d72c6b7599fac66c9fef50fd0d6da27a30473","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self._large_ops_scenario()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_4d035576","line":110,"updated":"2014-09-18 09:49:29.000000000","message":"Also 1 point to note, if we want to run this large ops tests  for neutron ( large VM boot with connectivity check) then, we need to disable the TestLargeOpsScenario  for gate-tempest-dsvm-neutron-large-ops otherwise it will be duplicate kind of tests running twice.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0916af6638de744d1b097d60a06d8264ec2e4635","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self._large_ops_scenario()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_6703cd76","line":110,"in_reply_to":"fa98f980_4d035576","updated":"2014-09-18 15:17:18.000000000","message":"One is without network and with a lot more VMs. the other is with network.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4619382db9ef5c314ab59fc7155c45346f28c9be","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def check_preconditions(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_982af62d","line":111,"updated":"2014-09-17 14:09:49.000000000","message":"This isn\u0027t a problem in principle, the inheritance structure is probably plain enough so it should be possible to calculate the MRO, but it may lead to confusion.\n\nFor instance in L114 you define check_preconditions, expecting it to be invoked by the setUpClass in NeutronScenarioTest. However setUpClass will resolve instead to that of TestLargeOpsScenario (it goes ~left to right).\n\nSo I would prefer you didn\u0027t do this.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"97e5126cb94db0a1a4c00c61e5a1f22e21c3da64","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def check_preconditions(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_207d21b2","line":111,"in_reply_to":"fa98f980_2748e5cb","updated":"2014-09-24 01:57:17.000000000","message":"Creation can be done for multiple server but yes, clean up part is not so generic in manager.create_server.\n\nBut still this can be derived for TestLargeOpsScenario only by using its nova_boot() function (same way you are doing).\nand have create floating ips in manager.ScenarioTest or calling client directly.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0916af6638de744d1b097d60a06d8264ec2e4635","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def check_preconditions(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_2748e5cb","line":111,"in_reply_to":"fa98f980_2d29b19b","updated":"2014-09-18 15:17:18.000000000","message":"No. TestLargeOpsScenario has it\u0027s own boot function in order to do multiple VMs at once. manager.create_server is used for a single VM and handling it\u0027s cleanUp","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"211d72c6b7599fac66c9fef50fd0d6da27a30473","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def check_preconditions(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_cdcca58d","line":111,"in_reply_to":"fa98f980_982af62d","updated":"2014-09-18 09:49:29.000000000","message":"Yes, I think reason to derived it from TestLargeOpsScenario to use the nova_boot().\n\nIMO we should derive this only from NeutronScenarioTest as it is for neutron only and let\u0027s use the create_server() function of base class where server will be created with network id and cleanup/waiting part will be handled there.\n\nI think TestLargeOpsScenario has its own boot function because it do want to boot VM with network.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e2ae3dafca6917f26a49c6ff2259a7873b0c713","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class TestLargeScaleNetwork(TestLargeOpsScenario,"},{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def check_preconditions(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_2d29b19b","line":111,"in_reply_to":"fa98f980_cdcca58d","updated":"2014-09-18 09:53:17.000000000","message":"correction -\u003e I think TestLargeOpsScenario has its own boot function because it do **not** want to boot VM with network.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"211d72c6b7599fac66c9fef50fd0d6da27a30473","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def check_preconditions(cls):"},{"line_number":115,"context_line":"        if CONF.scenario.large_ops_number \u003c 1:"},{"line_number":116,"context_line":"            raise cls.skipException()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_6d281986","line":114,"updated":"2014-09-18 09:49:29.000000000","message":"we need to call super\u0027s check_preconditions() also to check neutron availability.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0916af6638de744d1b097d60a06d8264ec2e4635","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                            manager.NeutronScenarioTest):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def check_preconditions(cls):"},{"line_number":115,"context_line":"        if CONF.scenario.large_ops_number \u003c 1:"},{"line_number":116,"context_line":"            raise cls.skipException()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_474329af","line":114,"in_reply_to":"fa98f980_6d281986","updated":"2014-09-18 15:17:18.000000000","message":"Done","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4619382db9ef5c314ab59fc7155c45346f28c9be","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            raise cls.skipException()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _large_ops_scenario(self):"},{"line_number":119,"context_line":"        # Neutron is unable to handle such large amount of VMs at once"},{"line_number":120,"context_line":"        num_instances \u003d CONF.scenario.large_ops_number / 2"},{"line_number":121,"context_line":"        self.create_networks()"},{"line_number":122,"context_line":"        self.keypair \u003d self.create_keypair()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_b8d6da25","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":70},"updated":"2014-09-17 14:09:49.000000000","message":"Well, I hope it\u0027s not quite like that. I think the limitation is in the size of the cloud we setup for testing in the gate.","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"dfb73b55475fbeb469879967d35bf1f210849d56","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            raise cls.skipException()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _large_ops_scenario(self):"},{"line_number":119,"context_line":"        # Neutron is unable to handle such large amount of VMs at once"},{"line_number":120,"context_line":"        num_instances \u003d CONF.scenario.large_ops_number / 2"},{"line_number":121,"context_line":"        self.create_networks()"},{"line_number":122,"context_line":"        self.keypair \u003d self.create_keypair()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_c8773607","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":70},"in_reply_to":"fa98f980_0d43106d","updated":"2014-09-18 08:25:44.000000000","message":"In our public cloud I tested on a regular basis spawning 100 VMs at once and ssh-ing into each of them. In fact it goes beyond 100 as well. In which kind of environment are you getting this limit of 63VMs?","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"168d868ddd2e0194fc9301636ff9069572b22128","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            raise cls.skipException()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _large_ops_scenario(self):"},{"line_number":119,"context_line":"        # Neutron is unable to handle such large amount of VMs at once"},{"line_number":120,"context_line":"        num_instances \u003d CONF.scenario.large_ops_number / 2"},{"line_number":121,"context_line":"        self.create_networks()"},{"line_number":122,"context_line":"        self.keypair \u003d self.create_keypair()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_0d43106d","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":70},"in_reply_to":"fa98f980_b8d6da25","updated":"2014-09-18 08:01:58.000000000","message":"well, actually, we\u0027ve seen here that with neutorn-nova notification on, we are unable to boot more than 63 VMs in a single command. I want to get this thing working so I can create a good bug report for that","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"123265420e55c305eb6f777983bd07df9d665677","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            raise cls.skipException()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _large_ops_scenario(self):"},{"line_number":119,"context_line":"        # Neutron is unable to handle such large amount of VMs at once"},{"line_number":120,"context_line":"        num_instances \u003d CONF.scenario.large_ops_number / 2"},{"line_number":121,"context_line":"        self.create_networks()"},{"line_number":122,"context_line":"        self.keypair \u003d self.create_keypair()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_909e3406","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":70},"in_reply_to":"fa98f980_c8773607","updated":"2014-09-18 10:32:45.000000000","message":"I\u0027m testing on a physical a single machine (not a VM) with Icehouse, with neutron-nova port notification enables. we\u0027ve seen this problem also with multiple compute nodes.\nHow is your public cloud configured?","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"211d72c6b7599fac66c9fef50fd0d6da27a30473","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.create_networks()"},{"line_number":122,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":123,"context_line":"        self.glance_image_create()"},{"line_number":124,"context_line":"        self.nova_boot(key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":125,"context_line":"                       min_count\u003dnum_instances)"},{"line_number":126,"context_line":"        self.create_and_associate_floating_ips()"},{"line_number":127,"context_line":"        self.servers_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_cd702576","line":124,"updated":"2014-09-18 09:49:29.000000000","message":"do not we need to boot with network id?","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8b2189204fcd3ec2e58514d755e407dc601cde84","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.create_networks()"},{"line_number":122,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":123,"context_line":"        self.glance_image_create()"},{"line_number":124,"context_line":"        self.nova_boot(key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":125,"context_line":"                       min_count\u003dnum_instances)"},{"line_number":126,"context_line":"        self.create_and_associate_floating_ips()"},{"line_number":127,"context_line":"        self.servers_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_b046d879","line":124,"in_reply_to":"fa98f980_10e404ab","updated":"2014-09-18 10:46:54.000000000","message":"With neutron, you cannot be sure only one network is visible to the tenant, even if the tenant only owns one network).","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0916af6638de744d1b097d60a06d8264ec2e4635","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.create_networks()"},{"line_number":122,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":123,"context_line":"        self.glance_image_create()"},{"line_number":124,"context_line":"        self.nova_boot(key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":125,"context_line":"                       min_count\u003dnum_instances)"},{"line_number":126,"context_line":"        self.create_and_associate_floating_ips()"},{"line_number":127,"context_line":"        self.servers_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_274d45c5","line":124,"in_reply_to":"fa98f980_b046d879","updated":"2014-09-18 15:17:18.000000000","message":"Done","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"123265420e55c305eb6f777983bd07df9d665677","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.create_networks()"},{"line_number":122,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":123,"context_line":"        self.glance_image_create()"},{"line_number":124,"context_line":"        self.nova_boot(key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":125,"context_line":"                       min_count\u003dnum_instances)"},{"line_number":126,"context_line":"        self.create_and_associate_floating_ips()"},{"line_number":127,"context_line":"        self.servers_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_10e404ab","line":124,"in_reply_to":"fa98f980_cd702576","updated":"2014-09-18 10:32:45.000000000","message":"Not if we only have 1 network in the tenant","commit_id":"68b08e3f0008a16f0a9789f721dc0973c5747460"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"4be5e67d12ecec779cf591aa00f83f1b8c406644","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        for server in self.servers:"},{"line_number":147,"context_line":"            floating_ip \u003d self.floating_ips[server[\u0027id\u0027]]"},{"line_number":148,"context_line":"            ip_address \u003d floating_ip.floating_ip_address"},{"line_number":149,"context_line":"            super(TestLargeOpsWithNetwork,"},{"line_number":150,"context_line":"                  self)._check_public_network_connectivity("},{"line_number":151,"context_line":"                      ip_address, ssh_login, private_key, should_connect\u003dTrue,"},{"line_number":152,"context_line":"                      msg\u003d\u0027Failed to connect to Server: {server} \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"da9df570_f91e0f6f","line":149,"updated":"2014-09-28 14:18:43.000000000","message":"This is a single statement that spans over 8 lines...\n\nCan you split this?","commit_id":"d9c994d646221afd031f426bedeaba53404d45c6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a2d7688e11ef39d082fc58478d197851e456644a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        _, update_server \u003d self.servers_client.get_server(server[\u0027id\u0027])"},{"line_number":104,"context_line":"        server.update(update_server)"},{"line_number":105,"context_line":"        floating_ip \u003d self._create_floating_ip(server)"},{"line_number":106,"context_line":"        self.floating_ips[server[\u0027id\u0027]] \u003d floating_ip"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _check_public_network_connectivity(self):"},{"line_number":109,"context_line":"        ssh_login \u003d CONF.compute.image_ssh_user"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_2682ce4f","line":106,"updated":"2014-09-30 09:09:32.000000000","message":"1 way is to fetch the FIP here depend on CONF.service_available.neutron","commit_id":"c9f4006802d1e942eede740fb342ba2ec5156d75"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"f751fa1d61e2795781cec9864d12515d92374754","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        private_key \u003d self.keypair[\u0027private_key\u0027]"},{"line_number":111,"context_line":"        for server in self.servers:"},{"line_number":112,"context_line":"            floating_ip \u003d self.floating_ips[server[\u0027id\u0027]]"},{"line_number":113,"context_line":"            ip_address \u003d floating_ip.floating_ip_address"},{"line_number":114,"context_line":"            super_method \u003d super(TestLargeOpsScenario,"},{"line_number":115,"context_line":"                                 self)._check_public_network_connectivity"},{"line_number":116,"context_line":"            super_method(ip_address, ssh_login, private_key,"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_a56dea06","line":113,"updated":"2014-09-29 15:45:01.000000000","message":"Looks like there\u0027s a failure here in the Jenkins tests.  Where does \"floating_ip_address\" get set?","commit_id":"c9f4006802d1e942eede740fb342ba2ec5156d75"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a2d7688e11ef39d082fc58478d197851e456644a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        private_key \u003d self.keypair[\u0027private_key\u0027]"},{"line_number":111,"context_line":"        for server in self.servers:"},{"line_number":112,"context_line":"            floating_ip \u003d self.floating_ips[server[\u0027id\u0027]]"},{"line_number":113,"context_line":"            ip_address \u003d floating_ip.floating_ip_address"},{"line_number":114,"context_line":"            super_method \u003d super(TestLargeOpsScenario,"},{"line_number":115,"context_line":"                                 self)._check_public_network_connectivity"},{"line_number":116,"context_line":"            super_method(ip_address, ssh_login, private_key,"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_a6e4fe3b","line":113,"in_reply_to":"baa201ad_a56dea06","updated":"2014-09-30 09:09:32.000000000","message":"Yes for nova it is not set, it is in floating_ip[\u0027ip\u0027]. just thinking any other way to avoid if else here or in create_and_associate_floating_ips().\n\nWe could change the _create_floating_ip(server) function to return ip directly but that need change sin many files.","commit_id":"c9f4006802d1e942eede740fb342ba2ec5156d75"}]}