)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0b24137e2ead111c28c5d42699135877b881a14e","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        if wait_on_delete:"},{"line_number":268,"context_line":"            self.addCleanup(self.volumes_client.wait_for_resource_deletion,"},{"line_number":269,"context_line":"                            volume[\u0027id\u0027])"},{"line_number":270,"context_line":"        self.addCleanup(self.delete_wrapper, self.volumes_client.delete_volume,"},{"line_number":271,"context_line":"                        volume[\u0027id\u0027])"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.assertEqual(name, volume[\u0027display_name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_690377b8","line":270,"updated":"2014-09-10 19:19:00.000000000","message":"So if wait_on_delete\u003dFalse we will never verify that the volume is deleted, it\u0027ll just issue an async delete call and hope the volume gets removed successfully but never check that. I don\u0027t think that\u0027s an option we really want to expose.\n\nI think it would be preferable to do one of 2 things:\n\n1. remove the wait_on_delete flag and always do a sync delete with volumes.\n\n2. Scope this addCleanup call under if wait_on_delete and add an\n\n    else: \n        addCleanup_with_wait(...)\n\nThat way if you decide to do a sync delete there\u0027s only 1 wait. But if doing the volume delete synchronously isn\u0027t important and wait_on_delete\u003dFalse we will wait for the volume deletion at the very end.","commit_id":"a572a94a2cb39bbb349700913638c9cfa1d701f0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bdd71d3d668f05e7232eadc8e4552633bb7d84bb","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        if wait_on_delete:"},{"line_number":268,"context_line":"            self.addCleanup(self.volumes_client.wait_for_resource_deletion,"},{"line_number":269,"context_line":"                            volume[\u0027id\u0027])"},{"line_number":270,"context_line":"        self.addCleanup(self.delete_wrapper, self.volumes_client.delete_volume,"},{"line_number":271,"context_line":"                        volume[\u0027id\u0027])"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.assertEqual(name, volume[\u0027display_name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_e98207ff","line":270,"in_reply_to":"fa98f980_690377b8","updated":"2014-09-10 19:21:59.000000000","message":"OK, yeah I was thinking about (1) and removing the wait_on_delete kwarg since it\u0027s not set to False anywhere that\u0027s using this, but I\u0027ll go with (2).","commit_id":"a572a94a2cb39bbb349700913638c9cfa1d701f0"}]}