)]}'
{"tempest/api/volume/admin/test_multi_backend.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42cde2fcf4e0c3f96350e1e96ffc7bec8d9ed4f1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            extra_specs \u003d {spec_key_with_prefix: backend_name_key}"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            extra_specs \u003d {spec_key_without_prefix: backend_name_key}"},{"line_number":64,"context_line":"        _, self.type \u003d self.client.create_volume_type("},{"line_number":65,"context_line":"            type_name, extra_specs\u003dextra_specs)"},{"line_number":66,"context_line":"        self.volume_type_id_list.append(self.type[\u0027id\u0027])"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_1b455142","line":64,"updated":"2014-10-09 02:07:55.000000000","message":"Things little bit messed in base class with volume_types_client.\n\nPlease use cls.volume_types_client instead of self.client. then only it will make V2 request when it runs for V2 tests.\n\ncls.client is also volume_types_client which should be cleaned up but in different patch.","commit_id":"61c5d014bacfaae51f008960739b65897a70d5fd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42cde2fcf4e0c3f96350e1e96ffc7bec8d9ed4f1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # volume types deletion"},{"line_number":93,"context_line":"        volume_type_id_list \u003d getattr(cls, \u0027volume_type_id_list\u0027, [])"},{"line_number":94,"context_line":"        for volume_type_id in volume_type_id_list:"},{"line_number":95,"context_line":"            cls.client.delete_volume_type(volume_type_id)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        super(VolumeMultiBackendV2Test, cls).resource_cleanup()"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_7b6d7dcb","line":95,"updated":"2014-10-09 02:07:55.000000000","message":"Please use cls.volume_types_client instead of cls.client.","commit_id":"61c5d014bacfaae51f008960739b65897a70d5fd"}],"tempest/api/volume/base.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"47de52095227163382f0bc5decbad35d3c0fc13d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        cls.adm_user \u003d CONF.identity.admin_username"},{"line_number":158,"context_line":"        cls.adm_pass \u003d CONF.identity.admin_password"},{"line_number":159,"context_line":"        cls.adm_tenant \u003d CONF.identity.admin_tenant_name"},{"line_number":160,"context_line":"        if not all((cls.adm_user, cls.adm_pass, cls.adm_tenant)):"},{"line_number":161,"context_line":"            msg \u003d (\"Missing Volume Admin API credentials \""},{"line_number":162,"context_line":"                   \"in configuration.\")"},{"line_number":163,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_a13e77d8","side":"PARENT","line":160,"updated":"2014-10-13 18:53:54.000000000","message":"Why is this skip check pushed into the non-isolated-tenant case? I think this will cause the isolated-tenant case to fail rather than skip if there are no admin credentials.","commit_id":"41d6aa233bf9c76734d443e023bb88a448f6ed59"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d10e3c1ee78030b2c03297d545a2bf08c0263182","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        cls.adm_user \u003d CONF.identity.admin_username"},{"line_number":158,"context_line":"        cls.adm_pass \u003d CONF.identity.admin_password"},{"line_number":159,"context_line":"        cls.adm_tenant \u003d CONF.identity.admin_tenant_name"},{"line_number":160,"context_line":"        if not all((cls.adm_user, cls.adm_pass, cls.adm_tenant)):"},{"line_number":161,"context_line":"            msg \u003d (\"Missing Volume Admin API credentials \""},{"line_number":162,"context_line":"                   \"in configuration.\")"},{"line_number":163,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_5ee119fd","side":"PARENT","line":160,"in_reply_to":"baa201ad_a13e77d8","updated":"2014-10-14 05:52:35.000000000","message":"David, i think for isloated-tenant (currently with allow_tenant_isolation), admin cred will be created on fly. So i did not get why it should fail for isloated tenant.\n\nFor our new pre-provisioned accounts, it is being handled in https://review.openstack.org/#/c/107685/  \n\nBut IMO, as per this patch scope we should leave those as it is. Those are anyways going to be modified/fixed in https://review.openstack.org/#/c/107685/","commit_id":"41d6aa233bf9c76734d443e023bb88a448f6ed59"}],"tempest/clients.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b91deeb2512605799ea01202b2f1c9dc97e11586","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            self.volume_types_client \u003d VolumeTypesClientJSON("},{"line_number":336,"context_line":"                self.auth_provider)"},{"line_number":337,"context_line":"            self.volume_types_v2_client \u003d VolumeTypesV2ClientJSON("},{"line_number":338,"context_line":"                self.auth_provider)"},{"line_number":339,"context_line":"            self.identity_client \u003d IdentityClientJSON(self.auth_provider)"},{"line_number":340,"context_line":"            self.identity_v3_client \u003d IdentityV3ClientJSON("},{"line_number":341,"context_line":"                self.auth_provider)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_c08bd8c0","line":338,"updated":"2014-10-09 01:49:02.000000000","message":"Not sure why not xml tests for volume type. But that is out of scope for this patch.\n\nSo defining/implementing Volume type V2 client only for Json in patch looks fine for me.","commit_id":"61c5d014bacfaae51f008960739b65897a70d5fd"}],"tempest/services/volume/v2/json/admin/volume_types_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d0a3e8b803f7f3fa8bb627c57db6806c1dcc2805","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa201ad_0ea1ce93","line":1,"updated":"2014-10-16 14:40:18.000000000","message":"I\u0027m not sure \"2012\" is correct or not. But this is a nit, I don\u0027t care.","commit_id":"449e4c07a687ded2629dd67e7f7d641d1bc3f8b2"}],"tempest/services/volume/v2/json/volume_types_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b91deeb2512605799ea01202b2f1c9dc97e11586","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.services.volume.json.admin import volume_types_client"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_004de0c3","line":15,"updated":"2014-10-09 01:49:02.000000000","message":"Looks like it is admin only client then it should go in admin directory same as for V1. \n\ntempest/services/volume/v2/json/admin/volume_types_client.py","commit_id":"61c5d014bacfaae51f008960739b65897a70d5fd"}]}