)]}'
{"tempest/api/compute/admin/test_flavors_extra_specs_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4ef23801be67f26a7420b455861bd27289279cd5","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def resource_cleanup(cls):"},{"line_number":56,"context_line":"        resp, body \u003d cls.client.delete_flavor(cls.flavor[\u0027id\u0027])"},{"line_number":57,"context_line":"        cls.client.wait_for_resource_deletion(cls.flavor[\u0027id\u0027])"},{"line_number":58,"context_line":"        super(FlavorsExtraSpecsNegativeTestJSON, cls).resource_cleanup()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_db7006df","line":56,"updated":"2014-09-17 05:53:55.000000000","message":"So these cleanup should be fixed as this cleanup function will be called in case resource_setup() fail which will cause failure in resource_cleanup().\n\nIMO we should fix tearDownClass cleanup also in this patch.","commit_id":"81467b89cb7604b2470b3025b56ef8bb69f95ae7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e12b0fb61c3245c6e03244dc03133ee48e80136a","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def resource_cleanup(cls):"},{"line_number":56,"context_line":"        resp, body \u003d cls.client.delete_flavor(cls.flavor[\u0027id\u0027])"},{"line_number":57,"context_line":"        cls.client.wait_for_resource_deletion(cls.flavor[\u0027id\u0027])"},{"line_number":58,"context_line":"        super(FlavorsExtraSpecsNegativeTestJSON, cls).resource_cleanup()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_d498d01d","line":56,"in_reply_to":"fa98f980_74f00492","updated":"2014-09-17 09:36:56.000000000","message":"Thanks Andrea, I understand.\n\nMay be this place it is fine but its issue where resource_cleanup() clean up more resources. \nBut I agree about the scope of this patch. I will remove my -1 and let\u0027s wait for other opinion.","commit_id":"81467b89cb7604b2470b3025b56ef8bb69f95ae7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"c8664eed79e5779d9898c0b2269f4532a1cbedbf","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def resource_cleanup(cls):"},{"line_number":56,"context_line":"        resp, body \u003d cls.client.delete_flavor(cls.flavor[\u0027id\u0027])"},{"line_number":57,"context_line":"        cls.client.wait_for_resource_deletion(cls.flavor[\u0027id\u0027])"},{"line_number":58,"context_line":"        super(FlavorsExtraSpecsNegativeTestJSON, cls).resource_cleanup()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_74f00492","line":56,"in_reply_to":"fa98f980_db7006df","updated":"2014-09-17 09:30:09.000000000","message":"In case there is a failure here it\u0027s because there\u0027s nothing to be cleaned-up. The failure will be caught in tearDownClass and credentials will be cleaned up, so this is behaving fine I think.\nI wanted to limit these patches as much as possible to only migrate to the new framework, so unless I get other votes on reworking this, I\u0027d like to keep it as it is for now.","commit_id":"81467b89cb7604b2470b3025b56ef8bb69f95ae7"}],"tempest/api/compute/base.py":[{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"bece0b72ce0f69df7e1f104c8e2c62a20008cb72","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        cls.clear_images()"},{"line_number":216,"context_line":"        cls.clear_servers()"},{"line_number":217,"context_line":"        cls.clear_security_groups()"},{"line_number":218,"context_line":"        cls.clear_isolated_creds()"},{"line_number":219,"context_line":"        cls.clear_server_groups()"},{"line_number":220,"context_line":"        super(BaseComputeTest, cls).tearDownClass()"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_711e56bd","side":"PARENT","line":218,"updated":"2014-09-17 08:52:19.000000000","message":"Is the removing of this line related your work on credentials?","commit_id":"45f223cad90c03233f91b0bf60af3db2d3b3e387"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"c8664eed79e5779d9898c0b2269f4532a1cbedbf","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        cls.clear_images()"},{"line_number":216,"context_line":"        cls.clear_servers()"},{"line_number":217,"context_line":"        cls.clear_security_groups()"},{"line_number":218,"context_line":"        cls.clear_isolated_creds()"},{"line_number":219,"context_line":"        cls.clear_server_groups()"},{"line_number":220,"context_line":"        super(BaseComputeTest, cls).tearDownClass()"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_343d9c2d","side":"PARENT","line":218,"in_reply_to":"fa98f980_711e56bd","updated":"2014-09-17 09:30:09.000000000","message":"It\u0027s related to the migration to the new fixtures. \nCredentials are cleaned up now in the tearDownClass of the base class.","commit_id":"45f223cad90c03233f91b0bf60af3db2d3b3e387"}],"tempest/api/compute/floating_ips/test_list_floating_ips.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4ef23801be67f26a7420b455861bd27289279cd5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def resource_cleanup(cls):"},{"line_number":35,"context_line":"        for i in range(3):"},{"line_number":36,"context_line":"            cls.client.delete_floating_ip(cls.floating_ip_id[i])"},{"line_number":37,"context_line":"        super(FloatingIPDetailsTestJSON, cls).resource_cleanup()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_3b56722b","line":36,"updated":"2014-09-17 05:53:55.000000000","message":"ditto","commit_id":"81467b89cb7604b2470b3025b56ef8bb69f95ae7"}]}