)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"28c04f617e42becaefdceed6112600d0b2f82860","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":368,"context_line":"        self.servers_client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        self.wait_for(self._get_output)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.console_output,"},{"line_number":373,"context_line":"                          \u0027Console output not supported.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_681baa1c","line":370,"updated":"2014-09-18 08:11:13.000000000","message":"The existing tests use wait_for, maybe this API is unstable for getting console-log and we need to re-try it. So new test should be re-tried before merging into the master for confirming stable test.","commit_id":"cc37d6ed354656a5cdd05311a098ad9290a859df"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"7f452ec6f0472fb053ab2c46a526a9fe08ac4d30","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            # NOTE: This test tries to get full length console log, and the"},{"line_number":385,"context_line":"            # length should be bigger than the one of test_get_console_output."},{"line_number":386,"context_line":"            self.assertTrue(lines \u003e 10, \"Cannot get enough console log length\")"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        self.wait_for(_check_full_length_console_log)"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_a4dc1a76","line":386,"updated":"2014-09-29 07:14:20.000000000","message":"Please include numbers into the assert message, or consider using assertGreater.","commit_id":"4bbe5e0f138a6af209d07aa20ae6f3b08e620d88"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"55d99828791fc4930580977ec3be66bf03a6fd1b","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            # NOTE: This test tries to get full length console log, and the"},{"line_number":385,"context_line":"            # length should be bigger than the one of test_get_console_output."},{"line_number":386,"context_line":"            self.assertTrue(lines \u003e 10, \"Cannot get enough console log length\")"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        self.wait_for(_check_full_length_console_log)"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_1755131d","line":386,"in_reply_to":"baa201ad_a4dc1a76","updated":"2014-09-29 11:17:16.000000000","message":"@afazekas\n\nThat is a nice idea, thanks.\nI will add the line number into the message.","commit_id":"4bbe5e0f138a6af209d07aa20ae6f3b08e620d88"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"87d288ea29778de45e51718cb521a50fd36ab7d8","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.console_output,"},{"line_number":373,"context_line":"                          \u0027Console output not supported.\u0027)"},{"line_number":374,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":375,"context_line":"    def test_get_console_output_with_unlimit_size(self):"},{"line_number":376,"context_line":"        _, server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        def _check_full_length_console_log():"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_e7819dfc","line":375,"updated":"2014-10-10 18:38:29.000000000","message":"Should be test_get_console_output_with_unlimited_size","commit_id":"a4f8e634b63a174f0d0f36601849a8074548a359"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"248b5bcc85f6730a0e774e29fef582384af5bb13","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    def test_get_console_output_with_unlimit_size(self):"},{"line_number":376,"context_line":"        _, server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        def _check_full_length_console_log():"},{"line_number":379,"context_line":"            _, output \u003d self.servers_client.get_console_output(server[\u0027id\u0027],"},{"line_number":380,"context_line":"                                                               None)"},{"line_number":381,"context_line":"            self.assertTrue(output, \"Console output was empty.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_faad8489","line":378,"updated":"2014-10-02 04:29:57.000000000","message":"Probably, we can conbine this function to _get_output(). But I think it\u0027s another topic.","commit_id":"a4f8e634b63a174f0d0f36601849a8074548a359"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"248b5bcc85f6730a0e774e29fef582384af5bb13","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        def _check_full_length_console_log():"},{"line_number":379,"context_line":"            _, output \u003d self.servers_client.get_console_output(server[\u0027id\u0027],"},{"line_number":380,"context_line":"                                                               None)"},{"line_number":381,"context_line":"            self.assertTrue(output, \"Console output was empty.\")"},{"line_number":382,"context_line":"            lines \u003d len(output.split(\u0027\\n\u0027))"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_3ab70cda","line":380,"updated":"2014-10-02 04:29:57.000000000","message":"Yeah, we don\u0027t need to check the response code here like _get_output().\n\n self.assertEqual(200, resp.status)","commit_id":"a4f8e634b63a174f0d0f36601849a8074548a359"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"248b5bcc85f6730a0e774e29fef582384af5bb13","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            # NOTE: This test tries to get full length console log, and the"},{"line_number":385,"context_line":"            # length should be bigger than the one of test_get_console_output."},{"line_number":386,"context_line":"            self.assertTrue(lines \u003e 10, \"Cannot get enough console log length.\""},{"line_number":387,"context_line":"                                        \" (lines: %s)\" % lines)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        self.wait_for(_check_full_length_console_log)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_baca1c4d","line":386,"updated":"2014-10-02 04:29:57.000000000","message":"I think using assertGreater is suitable here. But it\u0027s not a strong opinion.","commit_id":"a4f8e634b63a174f0d0f36601849a8074548a359"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a92fee2ecdcdb41ceada5916b24ede19db16b180","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            # NOTE: This test tries to get full length console log, and the"},{"line_number":385,"context_line":"            # length should be bigger than the one of test_get_console_output."},{"line_number":386,"context_line":"            self.assertTrue(lines \u003e 10, \"Cannot get enough console log length.\""},{"line_number":387,"context_line":"                                        \" (lines: %s)\" % lines)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        self.wait_for(_check_full_length_console_log)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_9a02b86d","line":386,"in_reply_to":"baa201ad_baca1c4d","updated":"2014-10-02 04:36:46.000000000","message":"To be honest, I don\u0027t prefer assertGreater because I faced a problem that py26 didn\u0027t support assertGreater. Now the problem has been solved already and we can use it. but I\u0027d like to avoid using it after that.","commit_id":"a4f8e634b63a174f0d0f36601849a8074548a359"}]}