)]}'
{"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5cf8d8e781931a6bec5b952ba3ced95b237d1f2d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        resp, test_server \u003d self.client.create_server("},{"line_number":88,"context_line":"            name, image_id, flavor)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":90,"context_line":"        self.addCleanup(self.client.delete_server, test_server[\u0027id\u0027])"},{"line_number":91,"context_line":"        self.client.wait_for_server_status(test_server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":92,"context_line":"        resp, server \u003d self.client.get_server(test_server[\u0027id\u0027])"},{"line_number":93,"context_line":"        self.assertEqual(server[\u0027status\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_f2c79210","side":"PARENT","line":90,"updated":"2014-09-30 18:17:39.000000000","message":"Couldn\u0027t we just call create_test_server and eliminate lines 89 to 95?","commit_id":"8d6f4c3df89986c9056099d18455fd76d6956d53"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"a9b027c5a0dc044f950eff02b841486dc93042a7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        resp, test_server \u003d self.client.create_server("},{"line_number":88,"context_line":"            name, image_id, flavor)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":90,"context_line":"        self.addCleanup(self.client.delete_server, test_server[\u0027id\u0027])"},{"line_number":91,"context_line":"        self.client.wait_for_server_status(test_server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":92,"context_line":"        resp, server \u003d self.client.get_server(test_server[\u0027id\u0027])"},{"line_number":93,"context_line":"        self.assertEqual(server[\u0027status\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c54e0a96","side":"PARENT","line":90,"in_reply_to":"baa201ad_f2c79210","updated":"2014-10-03 01:48:39.000000000","message":"yes","commit_id":"8d6f4c3df89986c9056099d18455fd76d6956d53"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"116919dbc0038534992a5d4502287bf15e276809","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        name \u003d data_utils.rand_name(\u0027server\u0027)"},{"line_number":85,"context_line":"        flavor \u003d self.flavor_ref"},{"line_number":86,"context_line":"        image_id \u003d self.image_ref"},{"line_number":87,"context_line":"        resp, server \u003d cls.create_test_server(name\u003dname,"},{"line_number":88,"context_line":"                                              image_id\u003dimage_id,"},{"line_number":89,"context_line":"                                              flavor\u003dflavor,"},{"line_number":90,"context_line":"                                              wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_7793b04f","line":87,"updated":"2014-10-10 04:38:58.000000000","message":"Need to use self.create_test_server","commit_id":"098060e439b955235a077564c17aa459f3d8a106"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12d77f3a413b84aa93cde37139b0baf5eab8bfa2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        resp, test_server \u003d self.create_test_server(name\u003dname,"},{"line_number":88,"context_line":"                                              image_id\u003dimage_id,"},{"line_number":89,"context_line":"                                              flavor\u003dflavor,"},{"line_number":90,"context_line":"                                              wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":91,"context_line":"        resp, server \u003d self.client.get_server(test_server[\u0027id\u0027])"},{"line_number":92,"context_line":"        hostname \u003d server[self._host_key]"},{"line_number":93,"context_line":"        params \u003d {\u0027host\u0027: hostname}"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_0e147942","line":90,"updated":"2014-10-16 07:08:00.000000000","message":"If we are going to use create_test_server() which going to create server on non-admin tenant then why not to use already created servers in resource_setup (self.s1_id) as this tests is just to check \u0027host\u0027 filter.","commit_id":"5f4ee130877a2aee9eda20de8c5e25e6d7083285"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12d77f3a413b84aa93cde37139b0baf5eab8bfa2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                              wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":91,"context_line":"        resp, server \u003d self.client.get_server(test_server[\u0027id\u0027])"},{"line_number":92,"context_line":"        hostname \u003d server[self._host_key]"},{"line_number":93,"context_line":"        params \u003d {\u0027host\u0027: hostname}"},{"line_number":94,"context_line":"        resp, body \u003d self.client.list_servers(params)"},{"line_number":95,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":96,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_e8456cb4","line":93,"updated":"2014-10-16 07:08:00.000000000","message":"self.create_test_server creates server for non-admin tenant \u0026 L94 list servers with admin tenant which will be empty be default.\nYou need to use \u0027all_tenants\u0027 filter  along with \u0027host\u0027 to get right list of servers with admin cred.","commit_id":"5f4ee130877a2aee9eda20de8c5e25e6d7083285"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12d77f3a413b84aa93cde37139b0baf5eab8bfa2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        resp, body \u003d self.client.list_servers(params)"},{"line_number":95,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":96,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":97,"context_line":"        nonexistent_params \u003d {\u0027host\u0027: \u0027nonexistent_host\u0027}"},{"line_number":98,"context_line":"        resp, nonexistent_body \u003d self.client.list_servers("},{"line_number":99,"context_line":"            nonexistent_params)"},{"line_number":100,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_c8234803","line":97,"updated":"2014-10-16 07:08:00.000000000","message":"ditto to get the right empty list for \u0027nonexistent_host\u0027","commit_id":"5f4ee130877a2aee9eda20de8c5e25e6d7083285"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12d77f3a413b84aa93cde37139b0baf5eab8bfa2","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            nonexistent_params)"},{"line_number":100,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":101,"context_line":"        nonexistent_servers \u003d nonexistent_body[\u0027servers\u0027]"},{"line_number":102,"context_line":"        self.assertIn(test_server[\u0027id\u0027], map(lambda x: x[\u0027id\u0027], servers))"},{"line_number":103,"context_line":"        self.assertNotIn(test_server[\u0027id\u0027],"},{"line_number":104,"context_line":"                         map(lambda x: x[\u0027id\u0027], nonexistent_servers))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_4e3121ec","line":102,"updated":"2014-10-16 07:08:00.000000000","message":"use self.s1_id instead of test_server[\u0027id\u0027] to avoid another server to create","commit_id":"5f4ee130877a2aee9eda20de8c5e25e6d7083285"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"64325f90fc21e8c67f9899c1672cfa3bc2f31d82","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.client \u003d cls.os_adm.servers_client"},{"line_number":32,"context_line":"        cls.non_admin_client \u003d cls.servers_client"},{"line_number":33,"context_line":"        cls.flavors_client \u003d cls.os_adm.flavors_client"},{"line_number":34,"context_line":"        cls.servers_client \u003d cls.os_adm.servers_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        cls.s1_name \u003d data_utils.rand_name(\u0027server\u0027)"},{"line_number":37,"context_line":"        resp, server \u003d cls.create_test_server(name\u003dcls.s1_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_422b57eb","line":34,"updated":"2014-10-20 04:11:11.000000000","message":"this is going to break other tests like test_list_servers_by_admin.\n\nWe should not override cls.servers_client.","commit_id":"61ec10ce489c00b60ff5fb9f4243861606821868"}],"tempest/api/compute/floating_ips/test_floating_ips_actions.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5cf8d8e781931a6bec5b952ba3ced95b237d1f2d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.floating_ip,"},{"line_number":123,"context_line":"            self.new_server_id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.addCleanup(self.servers_client.delete_server, self.new_server_id)"},{"line_number":126,"context_line":"        if (resp[\u0027status\u0027] is not None):"},{"line_number":127,"context_line":"            self.addCleanup(self.client.disassociate_floating_ip_from_server,"},{"line_number":128,"context_line":"                            self.floating_ip,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_f295d2e4","side":"PARENT","line":125,"updated":"2014-09-30 18:17:39.000000000","message":"SInce the server is created with create_test_server I don\u0027t think the addCleanUp is needed at all. It is also in the wrong place since there are other calls that might fail between the create and the addCleanUp.","commit_id":"8d6f4c3df89986c9056099d18455fd76d6956d53"}],"tempest/api/compute/images/test_images.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5cf8d8e781931a6bec5b952ba3ced95b237d1f2d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def test_delete_saving_image(self):"},{"line_number":42,"context_line":"        snapshot_name \u003d data_utils.rand_name(\u0027test-snap-\u0027)"},{"line_number":43,"context_line":"        resp, server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":45,"context_line":"        resp, image \u003d self.create_image_from_server(server[\u0027id\u0027],"},{"line_number":46,"context_line":"                                                    name\u003dsnapshot_name,"},{"line_number":47,"context_line":"                                                    wait_until\u003d\u0027SAVING\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_d290ceee","side":"PARENT","line":44,"updated":"2014-09-30 18:17:39.000000000","message":"addCleanUps not needed because create_test_server does it.","commit_id":"8d6f4c3df89986c9056099d18455fd76d6956d53"}],"tempest/api/compute/images/test_images_negative.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5cf8d8e781931a6bec5b952ba3ced95b237d1f2d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.servers_client.stop(server[\u0027id\u0027])"},{"line_number":71,"context_line":"        self.servers_client.wait_for_server_status(server[\u0027id\u0027],"},{"line_number":72,"context_line":"                                                   \u0027SHUTOFF\u0027)"},{"line_number":73,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"},{"line_number":74,"context_line":"        snapshot_name \u003d data_utils.rand_name(\u0027test-snap-\u0027)"},{"line_number":75,"context_line":"        resp, image \u003d self.create_image_from_server(server[\u0027id\u0027],"},{"line_number":76,"context_line":"                                                    name\u003dsnapshot_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_12c256e9","side":"PARENT","line":73,"updated":"2014-09-30 18:17:39.000000000","message":"Ditto.","commit_id":"8d6f4c3df89986c9056099d18455fd76d6956d53"}]}