)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"574940d4d13642998d140dd6eb4589f72c31b472","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In test_security_group_rules, most created security group rules are"},{"line_number":10,"context_line":"the same. This patch adds shared values and makes these tests use"},{"line_number":11,"context_line":"them for cleanup."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie86c33217fc6b065844e31f9b6e37be93322f2cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baa201ad_7fe2bb04","line":11,"updated":"2014-09-29 08:36:30.000000000","message":"The setUp method is used in this way every test cases will create it own copy of this values.\nThey would be shared if they were decelerated on the class.\n\nI do not see where these values will be used in cleanup at the first loop. Did you mean this change is made for code cleanup ?","commit_id":"8685f13fa5bd501e27ca0d1c0c0ebd3b9f774d76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2dd966260681cb8bc7ea1b13995d316d6d857dbb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In test_security_group_rules, most created security group rules are"},{"line_number":10,"context_line":"the same. This patch adds shared values and makes these tests use"},{"line_number":11,"context_line":"them for cleanup."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie86c33217fc6b065844e31f9b6e37be93322f2cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baa201ad_3ad03e53","line":11,"in_reply_to":"baa201ad_7fe2bb04","updated":"2014-09-29 11:32:20.000000000","message":"You are right. This should be implemented with setUpClass method.\n\nThis patch\u0027s reason is that I will add the expected response body checks into each test in https://review.openstack.org/#/c/124005/ and the most part of bodies are based on the same values which are shared on this patch. Then I\u0027d like to clarify that each test use the same value on this patch.","commit_id":"8685f13fa5bd501e27ca0d1c0c0ebd3b9f774d76"}]}
