)]}'
{"tempest/api/compute/security_groups/test_security_group_rules.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a489106de6299e0635ce5d308de7d50dfba80797","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                                   self.from_port,"},{"line_number":71,"context_line":"                                                   self.to_port,"},{"line_number":72,"context_line":"                                                   cidr\u003dcidr)"},{"line_number":73,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":76,"context_line":"    @test.services(\u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_95ed04ba","line":73,"updated":"2014-09-25 11:47:52.000000000","message":"I think this check is already done in services/compute/json/security_groups_client.py:: create_security_group_rule","commit_id":"808324aa0a4b8db63a2b2bb5ff2b2f975b39a36f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b9b05b8d6f8b6ae08486829fde2310265cfb1a28","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                                   self.from_port,"},{"line_number":71,"context_line":"                                                   self.to_port,"},{"line_number":72,"context_line":"                                                   cidr\u003dcidr)"},{"line_number":73,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":76,"context_line":"    @test.services(\u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_f5b49083","line":73,"in_reply_to":"da9df570_95ed04ba","updated":"2014-09-25 11:52:44.000000000","message":"Yes, you are right.\nand that also is removed on the next patch Iab4ce492c060b8a2b79a3b3d9a6d30a359f6f312 because of the scope.","commit_id":"808324aa0a4b8db63a2b2bb5ff2b2f975b39a36f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d2661c72b3efbd118a5568717375849ddbf105b1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                                   self.from_port,"},{"line_number":72,"context_line":"                                                   self.to_port,"},{"line_number":73,"context_line":"                                                   cidr\u003dcidr)"},{"line_number":74,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":77,"context_line":"    @test.services(\u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_cb77143a","line":74,"updated":"2014-10-02 08:28:03.000000000","message":"For new tests we can avoid checking resp code as it is done in schema","commit_id":"57be76b4a829fb13a8c05da5c29cb7a8268700eb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d9cefaa6d167cad60d82903e9b3fc46515bc8051","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                                   self.from_port,"},{"line_number":72,"context_line":"                                                   self.to_port,"},{"line_number":73,"context_line":"                                                   cidr\u003dcidr)"},{"line_number":74,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":77,"context_line":"    @test.services(\u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_c45e2212","line":74,"in_reply_to":"baa201ad_cb77143a","updated":"2014-10-02 09:46:22.000000000","message":"I got the same point from Jordan on https://review.openstack.org/#/c/124003/2/tempest/api/compute/security_groups/test_security_group_rules.py , and I said I will remove it in the next patch.\n\nHowever, I got the same point from two developers so my current patch is wrong for reviewing. I will remove it in the next patch.\n\nThanks Ghanshyam, Jordan","commit_id":"57be76b4a829fb13a8c05da5c29cb7a8268700eb"}]}