)]}'
{"tempest/api/baremetal/admin/test_nodestates.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e5ad1512aa355071f28ae6541330f6b62cf98f05","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":61,"context_line":"    def test_get_console(self):"},{"line_number":62,"context_line":"        _, body \u003d self.client.get_console(self.node[\u0027uuid\u0027])"},{"line_number":63,"context_line":"        con_info \u003d [\u0027console_enabled\u0027, \u0027console_info\u0027]"},{"line_number":64,"context_line":"        for key in con_info:"},{"line_number":65,"context_line":"            self.assertIn(key, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_c342563d","line":62,"updated":"2014-09-26 08:36:56.000000000","message":"Sorry, maybe I misunderstand something.\nbut the destination file name contains \"states\" and all tests are for states now.\n\nIf applying this patch, that seems inconsistent for me.\nIt would be nice to rename the method name \"get_console\" also to \"get_state_console\" or something.","commit_id":"9689002b0e5f41945ba3335825eef0fab065ec4b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"acabb2132c3287513646057c984d3b29bb2e4fbe","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":61,"context_line":"    def test_get_console(self):"},{"line_number":62,"context_line":"        _, body \u003d self.client.get_console(self.node[\u0027uuid\u0027])"},{"line_number":63,"context_line":"        con_info \u003d [\u0027console_enabled\u0027, \u0027console_info\u0027]"},{"line_number":64,"context_line":"        for key in con_info:"},{"line_number":65,"context_line":"            self.assertIn(key, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_6f48142e","line":62,"in_reply_to":"baa201ad_567c0473","updated":"2014-10-01 04:31:54.000000000","message":"Yes, I know and that is a point from me.\n\nI guess this patch\u0027s reason is that API URL includes \"states\" then this patch moves these tests to this file including \"states\". However that is really right thing?\nThis file does not represent \"this file should contain API tests for \"/v1/nodes/(node_uuid)/states\" now. So I feel it is a little difficult to decide whether this move is right or not.\n\nIf applying this *current* patch, the tests don\u0027t contain \"states\" at all. When other people see this file in the future, it would be difficult to understand the reason.","commit_id":"9689002b0e5f41945ba3335825eef0fab065ec4b"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"64e305fb673110b95bd8a4e9447423d9811de8da","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":61,"context_line":"    def test_get_console(self):"},{"line_number":62,"context_line":"        _, body \u003d self.client.get_console(self.node[\u0027uuid\u0027])"},{"line_number":63,"context_line":"        con_info \u003d [\u0027console_enabled\u0027, \u0027console_info\u0027]"},{"line_number":64,"context_line":"        for key in con_info:"},{"line_number":65,"context_line":"            self.assertIn(key, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_567c0473","line":62,"in_reply_to":"da9df570_c342563d","updated":"2014-09-29 03:50:36.000000000","message":"This API doesn\u0027t have state information, so I can not rename this method name to include \"state\", but all of these APIs written in this file have \"states\" in their URLs. please check http://docs.openstack.org/developer/ironic/webapi/v1.html#nodestates","commit_id":"9689002b0e5f41945ba3335825eef0fab065ec4b"}]}