)]}'
{"tempest/api/baremetal/admin/test_drivers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f00c70b17e6f0940c5365b772e8522df174d4d44","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def test_show_driver_properties(self):"},{"line_number":42,"context_line":"        _, driver_properties \u003d self.client.show_driver_properties("},{"line_number":43,"context_line":"            self.driver_name)"},{"line_number":44,"context_line":"        self.assertEqual(True, isinstance(driver_properties, dict))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_95e736ac","line":44,"updated":"2014-11-19 05:56:57.000000000","message":"This check seems less.\nmaybe driver_properties would depend on the driver and it seems difficult to check specific value.\n\nNow the default value \"driver\" of tempest.conf is fake, so how about adding a new option \"driver_properties\" and setting one of fake\u0027s driver_properties as the default?","commit_id":"08b433c6f50e4f28d347e567a3979885efb55a3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c79ea4ad4ac6075db3a669ced2a3891b2a798c8b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def test_show_driver_properties(self):"},{"line_number":42,"context_line":"        _, driver_properties \u003d self.client.show_driver_properties("},{"line_number":43,"context_line":"            self.driver_name)"},{"line_number":44,"context_line":"        self.assertEqual(True, isinstance(driver_properties, dict))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_d07aac24","line":44,"in_reply_to":"5a890539_95e736ac","updated":"2014-11-19 06:46:14.000000000","message":"It\u0027s nice, I\u0027ll do so.","commit_id":"08b433c6f50e4f28d347e567a3979885efb55a3f"}],"tempest/services/baremetal/v1/base_v1.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"bc0ba67d813ff8f4b39f122065118d1af6f3c583","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :return: dictionary with \u003cproperty name\u003e:\u003cproperty description\u003e"},{"line_number":132,"context_line":"         entries."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        return self._list_request(\u0027drivers/%s/properties\u0027 % driver_name)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @base.handle_errors"},{"line_number":137,"context_line":"    def create_node(self, chassis_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_4a9229a0","line":134,"updated":"2014-10-02 23:48:32.000000000","message":"I\u0027m not very familiar with the ironic API, but the commit message and the documentation (http://docs.openstack.org/developer/ironic/webapi/v1.html) show the properties API call as not having the driver_name in the URI.\n\nShould this line be changed something like this?\n\nreturn self._list_request(\u0027drivers/properties\u0027, driver_name)","commit_id":"105bd77eba3cc1d23d6535a3ae11c48e0a0c33e0"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"9c5d868f34fba004e6cdae7674d99a725c9140ae","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :return: dictionary with \u003cproperty name\u003e:\u003cproperty description\u003e"},{"line_number":132,"context_line":"         entries."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        return self._list_request(\u0027drivers/%s/properties\u0027 % driver_name)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @base.handle_errors"},{"line_number":137,"context_line":"    def create_node(self, chassis_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_55f7168b","line":134,"updated":"2014-10-03 16:32:54.000000000","message":"Thanks for your response.  The call looks good to me in that case.  I\u0027d suggest updating the commit message, since it uses the incorrect format from the documentation.","commit_id":"105bd77eba3cc1d23d6535a3ae11c48e0a0c33e0"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"a30b30efcb19b096ed673eb2ee37a541b1e50725","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :return: dictionary with \u003cproperty name\u003e:\u003cproperty description\u003e"},{"line_number":132,"context_line":"         entries."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        return self._list_request(\u0027drivers/%s/properties\u0027 % driver_name)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @base.handle_errors"},{"line_number":137,"context_line":"    def create_node(self, chassis_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_053ad235","line":134,"in_reply_to":"baa201ad_4a9229a0","updated":"2014-10-03 01:20:01.000000000","message":"Thank you for your comments! Actual URL includes driver_name. URL written in above documentation  looks wrong, and I tried to update doc, but this doc is created automatically, so I couldn\u0027t. Please try to run \"ironic --debug driver-properties fake\" command, then you can see that the URL is \"http://xxx.xxx.xxx.xxx:6385/v1/drivers/fake/properties\"","commit_id":"105bd77eba3cc1d23d6535a3ae11c48e0a0c33e0"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1bc2362054a9d9020c59f8c2b49168e76424193c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :return: dictionary with \u003cproperty name\u003e:\u003cproperty description\u003e"},{"line_number":132,"context_line":"         entries."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        return self._list_request(\u0027drivers/%s/properties\u0027 % driver_name)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @base.handle_errors"},{"line_number":137,"context_line":"    def create_node(self, chassis_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8f415cab","line":134,"in_reply_to":"baa201ad_55f7168b","updated":"2014-10-06 04:06:44.000000000","message":"That\u0027s right, thank you. I\u0027ll fix the commit message.","commit_id":"105bd77eba3cc1d23d6535a3ae11c48e0a0c33e0"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"b6ee56e1370b9d42dac04ce9d8de98557189690b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        return self._show_request(\u0027drivers\u0027, driver_name)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def show_driver_properties(self, driver_name):"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        Gets a specific driver\u0027s property information."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_d2fd0f3d","line":126,"updated":"2014-11-12 18:36:35.000000000","message":"Somehow using \"show\" in method name looks incorrect, I would suggest - list_driver_properties or get_driver_properties would be more appropriate.","commit_id":"08b433c6f50e4f28d347e567a3979885efb55a3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"dc96df1ae782a3d788b926246733b61898252a56","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        return self._show_request(\u0027drivers\u0027, driver_name)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def show_driver_properties(self, driver_name):"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        Gets a specific driver\u0027s property information."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_90aae483","line":126,"in_reply_to":"5a890539_d2fd0f3d","updated":"2014-11-19 06:40:43.000000000","message":"That\u0027s right. I\u0027ll change this method name to \"list_driver_properties\".","commit_id":"08b433c6f50e4f28d347e567a3979885efb55a3f"}]}