)]}'
{"tempest/api/compute/servers/test_server_rescue.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"abfdc97bd621375347b04a3bbd4de9d9ff59680b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def resource_cleanup(cls):"},{"line_number":65,"context_line":"        # Deleting the floating IP which is created in this method"},{"line_number":66,"context_line":"        cls.floating_ips_client.delete_floating_ip(cls.floating_ip_id)"},{"line_number":67,"context_line":"        if cls.volume:"},{"line_number":68,"context_line":"            cls.delete_volume(cls.volume[\u0027id\u0027])"},{"line_number":69,"context_line":"        resp, cls.sg \u003d cls.security_groups_client.delete_security_group("},{"line_number":70,"context_line":"            cls.sg_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_aceb7f76","line":67,"updated":"2014-09-26 11:11:56.000000000","message":"I think that won\u0027t help as volume attribute would not be defined at all.\n\nif hasattribute(cls, volume) \n\nor if you really want to check for the None case as well, you could do:\n\nif getattr(cls, volume, None) is not None:","commit_id":"65d35f929941eabdbacb39e918a43d1ed28f3134"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"269dcafa6078114070170cd75f01184bbded5ae1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def resource_cleanup(cls):"},{"line_number":65,"context_line":"        # Deleting the floating IP which is created in this method"},{"line_number":66,"context_line":"        cls.floating_ips_client.delete_floating_ip(cls.floating_ip_id)"},{"line_number":67,"context_line":"        if cls.volume:"},{"line_number":68,"context_line":"            cls.delete_volume(cls.volume[\u0027id\u0027])"},{"line_number":69,"context_line":"        resp, cls.sg \u003d cls.security_groups_client.delete_security_group("},{"line_number":70,"context_line":"            cls.sg_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_97332861","line":67,"in_reply_to":"da9df570_aceb7f76","updated":"2014-09-26 11:38:16.000000000","message":"agree, this will fail.\nwill replace to \"if getattr(cls, \u0027volume\u0027, None):\"","commit_id":"65d35f929941eabdbacb39e918a43d1ed28f3134"}]}