)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"18fd21790af2a704225914f6a0f6566e25dd839e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                                      new_password)"},{"line_number":76,"context_line":"            linux_client.validate_authentication()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _test_reboot_server(self, reboot_type, skip_first_ssh_check\u003dTrue):"},{"line_number":79,"context_line":"        if self.run_ssh and skip_first_ssh_check:"},{"line_number":80,"context_line":"            # Get the time the server was last rebooted,"},{"line_number":81,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_9a48f888","line":78,"updated":"2014-10-02 05:39:34.000000000","message":"I\u0027m confusing this flag. If skip_first_ssh_check is True, we should skip the first checking. But the code is checking it when it\u0027s True.\nDo I misunderstand something?","commit_id":"0de38605925a49b470b7c9bb8f602c135d0c2220"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4474080ff21d9048048c6d71b8d1098ed643c833","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                                      new_password)"},{"line_number":76,"context_line":"            linux_client.validate_authentication()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _test_reboot_server(self, reboot_type, skip_first_ssh_check\u003dTrue):"},{"line_number":79,"context_line":"        if self.run_ssh and skip_first_ssh_check:"},{"line_number":80,"context_line":"            # Get the time the server was last rebooted,"},{"line_number":81,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_24dfee3c","line":78,"in_reply_to":"baa201ad_9a48f888","updated":"2014-10-02 09:59:52.000000000","message":"oh, nice catch. The default value should be False and the check code should be:\n\n if self.run_ssh and not skip_first_ssh_check:","commit_id":"0de38605925a49b470b7c9bb8f602c135d0c2220"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ae4933a70fe1c88a5f781b3f649cd4731e9febe8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            linux_client.validate_authentication()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _test_reboot_server(self, reboot_type, skip_first_ssh_check\u003dFalse):"},{"line_number":79,"context_line":"        if self.run_ssh and not skip_first_ssh_check:"},{"line_number":80,"context_line":"            # Get the time the server was last rebooted,"},{"line_number":81,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":82,"context_line":"            linux_client \u003d remote_client.RemoteClient(server, self.ssh_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_4b5a2b51","line":79,"updated":"2014-10-03 05:12:55.000000000","message":"hmm, I feel this is a little complicated to me... How about changing the name to \u0027check_first_ssh\u0027 or \u0027ssh_before_rebooting\u0027 or something and setting the default value to True?","commit_id":"f09791572e9fa9ef41757a57cca591d97f66ae6c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d40a86297cfbfcb5701fbf9c3006607b3bd37453","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            linux_client.validate_authentication()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _test_reboot_server(self, reboot_type, skip_first_ssh_check\u003dFalse):"},{"line_number":79,"context_line":"        if self.run_ssh and not skip_first_ssh_check:"},{"line_number":80,"context_line":"            # Get the time the server was last rebooted,"},{"line_number":81,"context_line":"            resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":82,"context_line":"            linux_client \u003d remote_client.RemoteClient(server, self.ssh_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_9d75369a","line":79,"in_reply_to":"baa201ad_4b5a2b51","updated":"2014-10-03 05:15:07.000000000","message":"thanks again, check_first_ssh seems simple :-)\n\nI will change here to the above.","commit_id":"f09791572e9fa9ef41757a57cca591d97f66ae6c"}]}