)]}'
{"tempest/api/network/admin/test_shared_network_extension.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16d53880fc000da72f01183936c7d74eda4fb1b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8d7ec417","line":1,"updated":"2014-10-06 07:58:02.000000000","message":"Please update year too","commit_id":"50ee919c2383bf3f419539cb586ed30dd5618fe0"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"f2a966f6a4db2ccd1e81f6423fdd320e54f5986e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_528be967","line":1,"in_reply_to":"baa201ad_8d7ec417","updated":"2014-10-13 09:59:56.000000000","message":"i have changed to 2014","commit_id":"50ee919c2383bf3f419539cb586ed30dd5618fe0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16d53880fc000da72f01183936c7d74eda4fb1b1","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    @test.safe_setup"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(SharedNetworksTestJSON, cls).setUpClass()"},{"line_number":31,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8de964e8","line":29,"updated":"2014-10-06 07:58:02.000000000","message":"please rebase and change the setUpClass to resource_setup - https://blueprints.launchpad.net/tempest/+spec/resource-cleanup","commit_id":"50ee919c2383bf3f419539cb586ed30dd5618fe0"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"f2a966f6a4db2ccd1e81f6423fdd320e54f5986e","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    @test.safe_setup"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(SharedNetworksTestJSON, cls).setUpClass()"},{"line_number":31,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_92ec712b","line":29,"in_reply_to":"baa201ad_8de964e8","updated":"2014-10-13 09:59:56.000000000","message":"changed to resource_setup","commit_id":"50ee919c2383bf3f419539cb586ed30dd5618fe0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16d53880fc000da72f01183936c7d74eda4fb1b1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @test.safe_setup"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(SharedNetworksTestJSON, cls).setUpClass()"},{"line_number":31,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _create_shared_network(self, shared\u003dTrue):"},{"line_number":34,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ade62813","line":31,"updated":"2014-10-06 07:58:02.000000000","message":"why you need to create this network?","commit_id":"50ee919c2383bf3f419539cb586ed30dd5618fe0"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"f2a966f6a4db2ccd1e81f6423fdd320e54f5986e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @test.safe_setup"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(SharedNetworksTestJSON, cls).setUpClass()"},{"line_number":31,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _create_shared_network(self, shared\u003dTrue):"},{"line_number":34,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_52b92914","line":31,"in_reply_to":"baa201ad_ade62813","updated":"2014-10-13 09:59:56.000000000","message":"in order to create a shared network","commit_id":"50ee919c2383bf3f419539cb586ed30dd5618fe0"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"81257b1f2331f3b06de91021a6c3562e7f239fbb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertFalse(updated_net[\u0027admin_state_up\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_create_bulk_shared_network(self):"},{"line_number":69,"context_line":"        # Creates 2 networks in one request\\"},{"line_number":70,"context_line":"        net_nm \u003d [data_utils.rand_name(\u0027network-\u0027),"},{"line_number":71,"context_line":"                  data_utils.rand_name(\u0027network-\u0027)]"},{"line_number":72,"context_line":"        shared \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_e74f2f90","line":69,"updated":"2014-10-17 14:46:25.000000000","message":"extra \u0027\\\u0027","commit_id":"9c25d8dffc0a3dd1de4e06ef1a65df96a89740b7"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"bcff1488c5aa101c6761c6adb5805b68954e8075","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # verify the tenant id of admin network and non admin port"},{"line_number":56,"context_line":"        self.assertNotEqual(shared_net[\u0027tenant_id\u0027], port[\u0027tenant_id\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_create_update_admin_state_up(self):"},{"line_number":59,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027)}"},{"line_number":60,"context_line":"        post_body[\u0027shared\u0027] \u003d True"},{"line_number":61,"context_line":"        _, body \u003d self.admin_client.create_network(**post_body)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aa7fdbe_276bee1e","line":58,"updated":"2014-10-28 07:01:22.000000000","message":"What about testcase that will update shared parameter of network?","commit_id":"23cec32beba12f09b0aa0068bd52986891a916e2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"dc1b0ed972c2b9cfe927b4c533eb1792c1120cf2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(SharedNetworksTestJSON, cls).resource_setup()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _create_shared_network(self, shared\u003dTrue):"},{"line_number":32,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027)}"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_986699ed","line":29,"updated":"2014-10-29 01:04:12.000000000","message":"There are not special method calls or settings, so we can remove the above 3 lines(def resource_setup()).","commit_id":"b019559c796a0b6c3b83e55c22ae888d786d4471"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"dc1b0ed972c2b9cfe927b4c533eb1792c1120cf2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(SharedNetworksTestJSON, cls).resource_setup()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _create_shared_network(self, shared\u003dTrue):"},{"line_number":32,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027)}"},{"line_number":33,"context_line":"        if shared:"},{"line_number":34,"context_line":"            post_body[\u0027shared\u0027] \u003d shared"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_38868d66","line":31,"updated":"2014-10-29 01:04:12.000000000","message":"This test class is for testing shared network and all callers of this method are not specifying \"shared\" argument. So how about removing \"shared\" argument and :\n\n - if shared:\n -     post_body[\u0027shared\u0027] \u003d shared\n + post_body[\u0027shared\u0027] \u003d True\n\n?\nThat seems to fit to the method name.","commit_id":"b019559c796a0b6c3b83e55c22ae888d786d4471"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"bdddabbccaebb95c6535c6df4f1a5a3420e72140","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _create_shared_network(self):"},{"line_number":28,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027)}"},{"line_number":29,"context_line":"        post_body[\u0027shared\u0027] \u003d True"},{"line_number":30,"context_line":"        _, body \u003d self.admin_client.create_network(**post_body)"},{"line_number":31,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":32,"context_line":"        self.addCleanup(self.admin_client.delete_network, network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_b1529366","line":29,"updated":"2014-10-29 10:13:57.000000000","message":"Seems that it will be  better to set once:\n\n    post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027)\n                 \u0027shared\u0027: True}","commit_id":"72159eb4971d6b509126474bf7c9526c547f23d6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"bdddabbccaebb95c6535c6df4f1a5a3420e72140","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def test_create_update_admin_state_up_and_shared_attribute(self):"},{"line_number":54,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027)}"},{"line_number":55,"context_line":"        post_body[\u0027shared\u0027] \u003d True"},{"line_number":56,"context_line":"        _, body \u003d self.admin_client.create_network(**post_body)"},{"line_number":57,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":58,"context_line":"        netid \u003d network[\u0027id\u0027]"},{"line_number":59,"context_line":"        self.addCleanup(self.admin_client.delete_network, netid)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_11e19f9a","line":56,"updated":"2014-10-29 10:13:57.000000000","message":"Why no use _create_shared_network here as well?","commit_id":"72159eb4971d6b509126474bf7c9526c547f23d6"},{"author":{"_account_id":11671,"name":"Ashish Kumar Gupta","email":"guptaas@vmware.com","username":"ashish-kumar-gupta"},"change_message_id":"cbeeb6b971853d2e39a677e4aa047832a5273b69","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                self.assertTrue(net[\u0027shared\u0027])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_show_shared_networks_attribute(self):"},{"line_number":94,"context_line":"        # Create external_net"},{"line_number":95,"context_line":"        shared_network \u003d self._create_shared_network()"},{"line_number":96,"context_line":"        # Show an shared network and confirm the"},{"line_number":97,"context_line":"        # shared network extension attribute is returned."}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8c0949_4587850f","line":94,"updated":"2014-11-06 14:02:11.000000000","message":"Isn\u0027t external network ? its shared network i think.","commit_id":"0b15076c6f3ccccab95af86c9ce428b9d19fe958"},{"author":{"_account_id":11670,"name":"Alok Kumar Maurya","email":"alok.maurya88@gmail.com","username":"alokmaurya"},"change_message_id":"12756280a0580149fe282fa9752e0276e6d51f30","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                self.assertTrue(net[\u0027shared\u0027])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_show_shared_networks_attribute_as_a_non_admin(self):"},{"line_number":118,"context_line":"        # Create external_net"},{"line_number":119,"context_line":"        shared_network \u003d self._create_shared_network()"},{"line_number":120,"context_line":"        # Show an shared network and confirm the"},{"line_number":121,"context_line":"        # shared network extension attribute is returned."}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_af53086b","line":118,"updated":"2014-11-10 05:47:52.000000000","message":"Ditto : it  should be  shared_net","commit_id":"0b15076c6f3ccccab95af86c9ce428b9d19fe958"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"064c922840088ea27889b4f1e75ce675f56ed5ad","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_create_port_shared_network_as_non_admin_tenant(self):"},{"line_number":44,"context_line":"        # create a shared network"},{"line_number":45,"context_line":"        shared_net \u003d self._create_shared_network()"},{"line_number":46,"context_line":"        # create a port as non admin"},{"line_number":47,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dshared_net[\u0027id\u0027])"},{"line_number":48,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a890539_a1dc9d13","line":45,"updated":"2014-11-13 10:30:23.000000000","message":"You create shared network almost in each test, what about create one in resource_setup like it done in other tests( in test_networks for example https://github.com/openstack/tempest/blob/master/tempest/api/network/test_networks.py#L65)  and use it where creation is not tested action ?","commit_id":"079a0a6ca878e6e08c564d363339362172092285"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"fdc2ea0e9438890891770e43e22feb6892bca728","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_create_shared_network(self):"},{"line_number":33,"context_line":"        # Create a network as an admin user specifying the"},{"line_number":34,"context_line":"        # shared network extension"},{"line_number":35,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":36,"context_line":"        self.assertIsNotNone(shared_network[\u0027id\u0027])"},{"line_number":37,"context_line":"        # Verifies shared parameter"},{"line_number":38,"context_line":"        self.assertTrue(shared_network[\u0027shared\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_560b38d5","line":35,"updated":"2014-11-18 12:53:16.000000000","message":"I\u0027m not sure, but I think Ann meant in previous comment that you don\u0027t need now to create network each test. Just create one in resource_setup and use it everywhere.","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_create_shared_network(self):"},{"line_number":33,"context_line":"        # Create a network as an admin user specifying the"},{"line_number":34,"context_line":"        # shared network extension"},{"line_number":35,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":36,"context_line":"        self.assertIsNotNone(shared_network[\u0027id\u0027])"},{"line_number":37,"context_line":"        # Verifies shared parameter"},{"line_number":38,"context_line":"        self.assertTrue(shared_network[\u0027shared\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_a2291f8b","line":35,"in_reply_to":"5a890539_36630c43","updated":"2014-11-20 14:11:24.000000000","message":"yes , i made changes and uploaded a new patch 17","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_create_shared_network(self):"},{"line_number":33,"context_line":"        # Create a network as an admin user specifying the"},{"line_number":34,"context_line":"        # shared network extension"},{"line_number":35,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":36,"context_line":"        self.assertIsNotNone(shared_network[\u0027id\u0027])"},{"line_number":37,"context_line":"        # Verifies shared parameter"},{"line_number":38,"context_line":"        self.assertTrue(shared_network[\u0027shared\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_a22e7ff8","line":35,"in_reply_to":"5a890539_560b38d5","updated":"2014-11-20 14:11:24.000000000","message":"Yes, i made changes and uploaded patch 17","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_create_shared_network(self):"},{"line_number":33,"context_line":"        # Create a network as an admin user specifying the"},{"line_number":34,"context_line":"        # shared network extension"},{"line_number":35,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":36,"context_line":"        self.assertIsNotNone(shared_network[\u0027id\u0027])"},{"line_number":37,"context_line":"        # Verifies shared parameter"},{"line_number":38,"context_line":"        self.assertTrue(shared_network[\u0027shared\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_8226e3b8","line":35,"in_reply_to":"5a890539_560b38d5","updated":"2014-11-20 14:11:24.000000000","message":"yes , i made changes and uploaded a new patch 17","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9f3b668113af3c94093fb9840da57d119faa6eba","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_create_shared_network(self):"},{"line_number":33,"context_line":"        # Create a network as an admin user specifying the"},{"line_number":34,"context_line":"        # shared network extension"},{"line_number":35,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":36,"context_line":"        self.assertIsNotNone(shared_network[\u0027id\u0027])"},{"line_number":37,"context_line":"        # Verifies shared parameter"},{"line_number":38,"context_line":"        self.assertTrue(shared_network[\u0027shared\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_36630c43","line":35,"in_reply_to":"5a890539_560b38d5","updated":"2014-11-18 13:02:13.000000000","message":"yes, I mean this. Everywhere except this test.","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9f3b668113af3c94093fb9840da57d119faa6eba","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_create_port_shared_network_as_non_admin_tenant(self):"},{"line_number":41,"context_line":"        # create a shared network"},{"line_number":42,"context_line":"        shared_net \u003d self.create_shared_network()"},{"line_number":43,"context_line":"        # create a port as non admin"},{"line_number":44,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dshared_net[\u0027id\u0027])"},{"line_number":45,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_965cc07e","line":42,"updated":"2014-11-18 13:02:13.000000000","message":"Use self.shared_network, not create new one","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_create_port_shared_network_as_non_admin_tenant(self):"},{"line_number":41,"context_line":"        # create a shared network"},{"line_number":42,"context_line":"        shared_net \u003d self.create_shared_network()"},{"line_number":43,"context_line":"        # create a port as non admin"},{"line_number":44,"context_line":"        _, body \u003d self.client.create_port(network_id\u003dshared_net[\u0027id\u0027])"},{"line_number":45,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_9863b440","line":42,"in_reply_to":"5a890539_965cc07e","updated":"2014-11-20 14:11:24.000000000","message":"Done","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9f3b668113af3c94093fb9840da57d119faa6eba","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertNotEqual(shared_net[\u0027tenant_id\u0027], port[\u0027tenant_id\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_create_update_admin_state_up_and_shared_attribute(self):"},{"line_number":51,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":52,"context_line":"        netid \u003d shared_network[\u0027id\u0027]"},{"line_number":53,"context_line":"        _, body \u003d self.admin_client.update_network(netid, admin_state_up\u003dFalse,"},{"line_number":54,"context_line":"                                                   shared\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_1648d0b1","line":51,"updated":"2014-11-18 13:02:13.000000000","message":"the same","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertNotEqual(shared_net[\u0027tenant_id\u0027], port[\u0027tenant_id\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_create_update_admin_state_up_and_shared_attribute(self):"},{"line_number":51,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":52,"context_line":"        netid \u003d shared_network[\u0027id\u0027]"},{"line_number":53,"context_line":"        _, body \u003d self.admin_client.update_network(netid, admin_state_up\u003dFalse,"},{"line_number":54,"context_line":"                                                   shared\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_22352fdb","line":51,"in_reply_to":"5a890539_1648d0b1","updated":"2014-11-20 14:11:24.000000000","message":"yes , i made changes","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9f3b668113af3c94093fb9840da57d119faa6eba","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_list_shared_networks(self):"},{"line_number":78,"context_line":"        # Create shared_net"},{"line_number":79,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":80,"context_line":"        # List the shared networks and confirm the"},{"line_number":81,"context_line":"        # shared network extension attribute is returned for those networks"},{"line_number":82,"context_line":"        # that are created as shared"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_b6dd3ce2","line":79,"updated":"2014-11-18 13:02:13.000000000","message":"the same","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_list_shared_networks(self):"},{"line_number":78,"context_line":"        # Create shared_net"},{"line_number":79,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":80,"context_line":"        # List the shared networks and confirm the"},{"line_number":81,"context_line":"        # shared network extension attribute is returned for those networks"},{"line_number":82,"context_line":"        # that are created as shared"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_622f3789","line":79,"in_reply_to":"5a890539_b6dd3ce2","updated":"2014-11-20 14:11:24.000000000","message":"yes , i made changes","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9f3b668113af3c94093fb9840da57d119faa6eba","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_show_shared_networks_attribute(self):"},{"line_number":91,"context_line":"        # Create shared_net"},{"line_number":92,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":93,"context_line":"        # Show an shared network and confirm the"},{"line_number":94,"context_line":"        # shared network extension attribute is returned."},{"line_number":95,"context_line":"        _, body \u003d self.admin_client.show_network(shared_network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_d6d808f1","line":92,"updated":"2014-11-18 13:02:13.000000000","message":"the same","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_show_shared_networks_attribute(self):"},{"line_number":91,"context_line":"        # Create shared_net"},{"line_number":92,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":93,"context_line":"        # Show an shared network and confirm the"},{"line_number":94,"context_line":"        # shared network extension attribute is returned."},{"line_number":95,"context_line":"        _, body \u003d self.admin_client.show_network(shared_network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_a2503f0b","line":92,"in_reply_to":"5a890539_d6d808f1","updated":"2014-11-20 14:11:24.000000000","message":"yes , i made changes","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9f3b668113af3c94093fb9840da57d119faa6eba","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_list_shared_networks_as_a_non_admin(self):"},{"line_number":102,"context_line":"        # Create shared_net"},{"line_number":103,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":104,"context_line":"        # List the shared networks and confirm the"},{"line_number":105,"context_line":"        # shared network extension attribute is returned for those networks"},{"line_number":106,"context_line":"        # that are created as shared"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_16dff0d6","line":103,"updated":"2014-11-18 13:02:13.000000000","message":"the same","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_list_shared_networks_as_a_non_admin(self):"},{"line_number":102,"context_line":"        # Create shared_net"},{"line_number":103,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":104,"context_line":"        # List the shared networks and confirm the"},{"line_number":105,"context_line":"        # shared network extension attribute is returned for those networks"},{"line_number":106,"context_line":"        # that are created as shared"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_02411339","line":103,"in_reply_to":"5a890539_16dff0d6","updated":"2014-11-20 14:11:24.000000000","message":"yes , i made changes","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9f3b668113af3c94093fb9840da57d119faa6eba","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_show_shared_networks_attribute_as_a_non_admin(self):"},{"line_number":115,"context_line":"        # Create shared_net"},{"line_number":116,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":117,"context_line":"        # Show an shared network and confirm the"},{"line_number":118,"context_line":"        # shared network extension attribute is returned."},{"line_number":119,"context_line":"        _, body \u003d self.client.show_network(shared_network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_d6ff2832","line":116,"updated":"2014-11-18 13:02:13.000000000","message":"the same","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9479f7c8ca167430dc6a32b17cdd75ee195ae4f2","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_show_shared_networks_attribute_as_a_non_admin(self):"},{"line_number":115,"context_line":"        # Create shared_net"},{"line_number":116,"context_line":"        shared_network \u003d self.create_shared_network()"},{"line_number":117,"context_line":"        # Show an shared network and confirm the"},{"line_number":118,"context_line":"        # shared network extension attribute is returned."},{"line_number":119,"context_line":"        _, body \u003d self.client.show_network(shared_network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_424b1b59","line":116,"in_reply_to":"5a890539_d6ff2832","updated":"2014-11-20 14:11:24.000000000","message":"yes , i made changes","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6f4c4bf54110c1c8a10e5d3ecb3614ee00fd8e89","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        net_nm \u003d [data_utils.rand_name(\u0027network-\u0027),"},{"line_number":60,"context_line":"                  data_utils.rand_name(\u0027network-\u0027)]"},{"line_number":61,"context_line":"        shared \u003d True"},{"line_number":62,"context_line":"        _, body \u003d self.admin_client.create_bulk_network(net_nm, shared)"},{"line_number":63,"context_line":"        created_networks \u003d body[\u0027networks\u0027]"},{"line_number":64,"context_line":"        network1 \u003d created_networks[0]"},{"line_number":65,"context_line":"        network2 \u003d created_networks[1]"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_64eff01e","line":62,"updated":"2014-11-24 09:20:38.000000000","message":"I think it is better\n\n     self.admin_client.create_bulk_network(net_nm, shared\u003dTrue)","commit_id":"958f80551cbf95b0c1615b1d98941f7be066de24"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"915d95f672d61dba08b7ad2341500d79e4bbbc81","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        net_nm \u003d [data_utils.rand_name(\u0027network-\u0027),"},{"line_number":60,"context_line":"                  data_utils.rand_name(\u0027network-\u0027)]"},{"line_number":61,"context_line":"        shared \u003d True"},{"line_number":62,"context_line":"        _, body \u003d self.admin_client.create_bulk_network(net_nm, shared)"},{"line_number":63,"context_line":"        created_networks \u003d body[\u0027networks\u0027]"},{"line_number":64,"context_line":"        network1 \u003d created_networks[0]"},{"line_number":65,"context_line":"        network2 \u003d created_networks[1]"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_545c3d7d","line":62,"in_reply_to":"5a890539_64eff01e","updated":"2014-11-25 11:14:38.000000000","message":"Yes, i did changes","commit_id":"958f80551cbf95b0c1615b1d98941f7be066de24"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6f4c4bf54110c1c8a10e5d3ecb3614ee00fd8e89","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        show_shared_net \u003d body[\u0027network\u0027]"},{"line_number":111,"context_line":"        self.assertEqual(self.shared_network[\u0027name\u0027], show_shared_net[\u0027name\u0027])"},{"line_number":112,"context_line":"        self.assertEqual(self.shared_network[\u0027id\u0027], show_shared_net[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertTrue(show_shared_net[\u0027shared\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class SharedNetworksTestXML(SharedNetworksTestJSON):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_0448ec5a","line":113,"updated":"2014-11-24 09:20:38.000000000","message":"Tests test_list_shared_networks, test_list_shared_networks_as_a_non_admin and test_show_shared_networks_attribute, test_show_shared_networks_attribute_as_a_non_admin differ only in client that is used. What about create for this cases create help methods and then use like\n\n     test_list_shared_networks(self):\n          self._list_shared_networks(\u0027admin_client\u0027)\n\n      test_list_shared_networks_as_a_non_admin(self):\n            self._list_shared_networks(\u0027client\u0027)","commit_id":"958f80551cbf95b0c1615b1d98941f7be066de24"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"915d95f672d61dba08b7ad2341500d79e4bbbc81","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        show_shared_net \u003d body[\u0027network\u0027]"},{"line_number":111,"context_line":"        self.assertEqual(self.shared_network[\u0027name\u0027], show_shared_net[\u0027name\u0027])"},{"line_number":112,"context_line":"        self.assertEqual(self.shared_network[\u0027id\u0027], show_shared_net[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertTrue(show_shared_net[\u0027shared\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class SharedNetworksTestXML(SharedNetworksTestJSON):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_14663551","line":113,"in_reply_to":"5a890539_0448ec5a","updated":"2014-11-25 11:14:38.000000000","message":"yes, in doing that code is reduced\ni made changes and uploaded a new patch","commit_id":"958f80551cbf95b0c1615b1d98941f7be066de24"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c896fa2bb3daa214dea1c0c1d3fb3209fc79423b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_e56f87c3","line":2,"updated":"2015-01-23 15:55:16.000000000","message":"Should update the year","commit_id":"eac2e9735dc000e5f216457434c99751cf6e5558"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"b927e95962ff16d45155b15679f5a869e06eecb5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_ef4f0832","line":2,"in_reply_to":"1a930d6b_e56f87c3","updated":"2015-02-05 15:18:40.000000000","message":"yes i made changes","commit_id":"eac2e9735dc000e5f216457434c99751cf6e5558"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c896fa2bb3daa214dea1c0c1d3fb3209fc79423b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.assertTrue(self.shared_network[\u0027shared\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_list_shared_networks(self):"},{"line_number":81,"context_line":"        # List the shared networks and confirm the"},{"line_number":82,"context_line":"        # shared network extension attribute is returned for those networks"},{"line_number":83,"context_line":"        # that are created as shared"},{"line_number":84,"context_line":"        self._list_shared_networks(self.admin_client)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_052573aa","line":81,"updated":"2015-01-23 15:55:16.000000000","message":"the shared networks -\u003e  shared networks\n\nthe -\u003e that","commit_id":"eac2e9735dc000e5f216457434c99751cf6e5558"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"b927e95962ff16d45155b15679f5a869e06eecb5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.assertTrue(self.shared_network[\u0027shared\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_list_shared_networks(self):"},{"line_number":81,"context_line":"        # List the shared networks and confirm the"},{"line_number":82,"context_line":"        # shared network extension attribute is returned for those networks"},{"line_number":83,"context_line":"        # that are created as shared"},{"line_number":84,"context_line":"        self._list_shared_networks(self.admin_client)"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_8f75ac65","line":81,"in_reply_to":"1a930d6b_052573aa","updated":"2015-02-05 15:18:40.000000000","message":"yes i made changes","commit_id":"eac2e9735dc000e5f216457434c99751cf6e5558"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c896fa2bb3daa214dea1c0c1d3fb3209fc79423b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertTrue(show_shared_net[\u0027shared\u0027])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_show_shared_networks_attribute(self):"},{"line_number":95,"context_line":"        # Show an shared network and confirm the"},{"line_number":96,"context_line":"        # shared network extension attribute is returned."},{"line_number":97,"context_line":"        self._show_shared_network(self.admin_client)"},{"line_number":98,"context_line":"        self._show_shared_network(self.client)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_c24e0196","line":95,"updated":"2015-01-23 15:55:16.000000000","message":"an -\u003e a\n\nthe -\u003e that","commit_id":"eac2e9735dc000e5f216457434c99751cf6e5558"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"b927e95962ff16d45155b15679f5a869e06eecb5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertTrue(show_shared_net[\u0027shared\u0027])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_show_shared_networks_attribute(self):"},{"line_number":95,"context_line":"        # Show an shared network and confirm the"},{"line_number":96,"context_line":"        # shared network extension attribute is returned."},{"line_number":97,"context_line":"        self._show_shared_network(self.admin_client)"},{"line_number":98,"context_line":"        self._show_shared_network(self.client)"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_cf6b2483","line":95,"in_reply_to":"1a930d6b_c24e0196","updated":"2015-02-05 15:18:40.000000000","message":"yes i made changes","commit_id":"eac2e9735dc000e5f216457434c99751cf6e5558"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c896fa2bb3daa214dea1c0c1d3fb3209fc79423b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self._show_shared_network(self.client)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class SharedNetworksTestXML(SharedNetworksTestJSON):"},{"line_number":102,"context_line":"    _interface \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_e2b77d84","line":101,"updated":"2015-01-23 15:55:16.000000000","message":"Tests for XML shouldn\u0027t be added AFAIK","commit_id":"eac2e9735dc000e5f216457434c99751cf6e5558"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"b927e95962ff16d45155b15679f5a869e06eecb5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self._show_shared_network(self.client)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class SharedNetworksTestXML(SharedNetworksTestJSON):"},{"line_number":102,"context_line":"    _interface \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_ef6628ba","line":101,"in_reply_to":"1a930d6b_e2b77d84","updated":"2015-02-05 15:18:40.000000000","message":"yes i made changes","commit_id":"eac2e9735dc000e5f216457434c99751cf6e5558"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0b345bee1562f15664103025c853252acbdf2d59","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(SharedNetworksTestJSON, cls).resource_setup()"},{"line_number":30,"context_line":"        cls.shared_network \u003d cls.create_shared_network()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_create_update_shared_network(self):"},{"line_number":33,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_a0343efc","line":30,"updated":"2015-03-09 18:44:20.000000000","message":"what is this for?","commit_id":"048a64126eb45d63f9eebea93cce4ec481c301fe"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"77e8efcf9feb612cf86ff65ed6e7f9f91756e70f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(SharedNetworksTestJSON, cls).resource_setup()"},{"line_number":30,"context_line":"        cls.shared_network \u003d cls.create_shared_network()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_create_update_shared_network(self):"},{"line_number":33,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_f648a02e","line":30,"in_reply_to":"9a80dd14_a0343efc","updated":"2015-03-10 09:56:10.000000000","message":"Create shared network function is place in base.py and here i am using it","commit_id":"048a64126eb45d63f9eebea93cce4ec481c301fe"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0b345bee1562f15664103025c853252acbdf2d59","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        net_id \u003d shared_network[\u0027id\u0027]"},{"line_number":36,"context_line":"        self.assertEqual(\u0027ACTIVE\u0027, shared_network[\u0027status\u0027])"},{"line_number":37,"context_line":"        self.assertIsNotNone(shared_network[\u0027id\u0027])"},{"line_number":38,"context_line":"        self.assertTrue(self.shared_network[\u0027shared\u0027])"},{"line_number":39,"context_line":"        new_name \u003d \"New_shared_network\""},{"line_number":40,"context_line":"        body \u003d self.admin_client.update_network(net_id, name\u003dnew_name,"},{"line_number":41,"context_line":"                                                admin_state_up\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_80f65a5b","line":38,"updated":"2015-03-09 18:44:20.000000000","message":"maybe use assertEqual(self.shared_network[\u0027shared\u0027], True) to ensure it actually is True and not some random value that bool(value) \u003d\u003d True\n\nsame for below","commit_id":"048a64126eb45d63f9eebea93cce4ec481c301fe"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"77e8efcf9feb612cf86ff65ed6e7f9f91756e70f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        net_id \u003d shared_network[\u0027id\u0027]"},{"line_number":36,"context_line":"        self.assertEqual(\u0027ACTIVE\u0027, shared_network[\u0027status\u0027])"},{"line_number":37,"context_line":"        self.assertIsNotNone(shared_network[\u0027id\u0027])"},{"line_number":38,"context_line":"        self.assertTrue(self.shared_network[\u0027shared\u0027])"},{"line_number":39,"context_line":"        new_name \u003d \"New_shared_network\""},{"line_number":40,"context_line":"        body \u003d self.admin_client.update_network(net_id, name\u003dnew_name,"},{"line_number":41,"context_line":"                                                admin_state_up\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_7632f0a7","line":38,"in_reply_to":"9a80dd14_80f65a5b","updated":"2015-03-10 09:56:10.000000000","message":"yes i made changes","commit_id":"048a64126eb45d63f9eebea93cce4ec481c301fe"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0b345bee1562f15664103025c853252acbdf2d59","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # create a port as non admin"},{"line_number":50,"context_line":"        body \u003d self.client.create_port(network_id\u003dself.shared_network[\u0027id\u0027])"},{"line_number":51,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(self.admin_client.delete_port, port[\u0027id\u0027])"},{"line_number":53,"context_line":"        # verify the tenant id of admin network and non admin port"},{"line_number":54,"context_line":"        self.assertNotEqual(self.shared_network[\u0027tenant_id\u0027],"},{"line_number":55,"context_line":"                            port[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_0b71aba7","line":52,"updated":"2015-03-09 18:44:20.000000000","message":"i believe this is a side effect of create_port already","commit_id":"048a64126eb45d63f9eebea93cce4ec481c301fe"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"77e8efcf9feb612cf86ff65ed6e7f9f91756e70f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # create a port as non admin"},{"line_number":50,"context_line":"        body \u003d self.client.create_port(network_id\u003dself.shared_network[\u0027id\u0027])"},{"line_number":51,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(self.admin_client.delete_port, port[\u0027id\u0027])"},{"line_number":53,"context_line":"        # verify the tenant id of admin network and non admin port"},{"line_number":54,"context_line":"        self.assertNotEqual(self.shared_network[\u0027tenant_id\u0027],"},{"line_number":55,"context_line":"                            port[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_160294b3","line":52,"in_reply_to":"9a80dd14_0b71aba7","updated":"2015-03-10 09:56:10.000000000","message":"how it is a side effect?","commit_id":"048a64126eb45d63f9eebea93cce4ec481c301fe"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0b345bee1562f15664103025c853252acbdf2d59","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                  data_utils.rand_name(\u0027network-\u0027)]"},{"line_number":61,"context_line":"        body \u003d self.admin_client.create_bulk_network(net_nm, shared\u003dTrue)"},{"line_number":62,"context_line":"        created_networks \u003d body[\u0027networks\u0027]"},{"line_number":63,"context_line":"        network1 \u003d created_networks[0]"},{"line_number":64,"context_line":"        network2 \u003d created_networks[1]"},{"line_number":65,"context_line":"        self.addCleanup(self.admin_client.delete_network, network1[\u0027id\u0027])"},{"line_number":66,"context_line":"        self.addCleanup(self.admin_client.delete_network, network2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_eb08d729","line":63,"updated":"2015-03-09 18:44:20.000000000","message":"could probably be a loop","commit_id":"048a64126eb45d63f9eebea93cce4ec481c301fe"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"77e8efcf9feb612cf86ff65ed6e7f9f91756e70f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                  data_utils.rand_name(\u0027network-\u0027)]"},{"line_number":61,"context_line":"        body \u003d self.admin_client.create_bulk_network(net_nm, shared\u003dTrue)"},{"line_number":62,"context_line":"        created_networks \u003d body[\u0027networks\u0027]"},{"line_number":63,"context_line":"        network1 \u003d created_networks[0]"},{"line_number":64,"context_line":"        network2 \u003d created_networks[1]"},{"line_number":65,"context_line":"        self.addCleanup(self.admin_client.delete_network, network1[\u0027id\u0027])"},{"line_number":66,"context_line":"        self.addCleanup(self.admin_client.delete_network, network2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_f6f6e0d5","line":63,"in_reply_to":"9a80dd14_eb08d729","updated":"2015-03-10 09:56:10.000000000","message":"yes i made changes","commit_id":"048a64126eb45d63f9eebea93cce4ec481c301fe"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cfb38f9f485ec1e944014bc2a8d7a26200429a3b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(SharedNetworksTestJSON, cls).resource_setup()"},{"line_number":30,"context_line":"        cls.shared_network \u003d cls.create_shared_network()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_create_update_shared_network(self):"},{"line_number":33,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_d7fef104","line":30,"updated":"2015-03-11 14:54:24.000000000","message":"i was sort of wondering why we need the variable if it\u0027s never referenced. i guess it\u0027s standard practice in tempest?","commit_id":"52c58c22b6fe8f4764e7247ada3f263038163ad0"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"3b860ac4a5824f7e2bdf0fe280278bebc69fa5c6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(SharedNetworksTestJSON, cls).resource_setup()"},{"line_number":30,"context_line":"        cls.shared_network \u003d cls.create_shared_network()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_create_update_shared_network(self):"},{"line_number":33,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_ff180386","line":30,"in_reply_to":"9a80dd14_d7fef104","updated":"2015-03-12 09:37:00.000000000","message":"i am using self.shared_network to create a port and to show the shared network details.\ni.e in \n1) test_create_port_shared_network_as_non_admin_tenant\n2)_show_shared_network","commit_id":"52c58c22b6fe8f4764e7247ada3f263038163ad0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cfb38f9f485ec1e944014bc2a8d7a26200429a3b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # create a port as non admin"},{"line_number":50,"context_line":"        body \u003d self.client.create_port(network_id\u003dself.shared_network[\u0027id\u0027])"},{"line_number":51,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(self.admin_client.delete_port, port[\u0027id\u0027])"},{"line_number":53,"context_line":"        # verify the tenant id of admin network and non admin port"},{"line_number":54,"context_line":"        self.assertNotEqual(self.shared_network[\u0027tenant_id\u0027],"},{"line_number":55,"context_line":"                            port[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_57a2019b","line":52,"updated":"2015-03-11 14:54:24.000000000","message":"as i undertstand it, you can use https://github.com/openstack/tempest/blob/master/tempest/api/network/base.py#L238-L244\n\nand it will clean here: https://github.com/openstack/tempest/blob/master/tempest/api/network/base.py#L149-L151\n\nalthough i could be wrong.","commit_id":"52c58c22b6fe8f4764e7247ada3f263038163ad0"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"3b860ac4a5824f7e2bdf0fe280278bebc69fa5c6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # create a port as non admin"},{"line_number":50,"context_line":"        body \u003d self.client.create_port(network_id\u003dself.shared_network[\u0027id\u0027])"},{"line_number":51,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":52,"context_line":"        self.addCleanup(self.admin_client.delete_port, port[\u0027id\u0027])"},{"line_number":53,"context_line":"        # verify the tenant id of admin network and non admin port"},{"line_number":54,"context_line":"        self.assertNotEqual(self.shared_network[\u0027tenant_id\u0027],"},{"line_number":55,"context_line":"                            port[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_bf812b91","line":52,"in_reply_to":"9a80dd14_57a2019b","updated":"2015-03-12 09:37:00.000000000","message":"in https://github.com/openstack/tempest/blob/master/tempest/api/network/base.py#L238-L244 create_port takes 2 arguments i.e create_port(cls, network, **kwargs). . \nso while creating a port we are passing only one argument i.e , self.client.create_port(network_id\u003dself.shared_network[\u0027id\u0027])\nso i used self.addCleanup(self.admin_client.delete_port, port[\u0027id\u0027]) to delete the port.","commit_id":"52c58c22b6fe8f4764e7247ada3f263038163ad0"}],"tempest/api/network/base.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3de59277a9e6d5e156feb6cbf4e61f476dc06889","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return network"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @classmethod"},{"line_number":161,"context_line":"    def create_shared_network(cls):"},{"line_number":162,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027),"},{"line_number":163,"context_line":"                     \u0027shared\u0027: True}"},{"line_number":164,"context_line":"        _, body \u003d cls.admin_client.create_network(**post_body)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_164370af","line":161,"updated":"2014-11-18 13:00:03.000000000","message":"Do we need all this separate stuff? Maybe it\u0027s better to check in create_network if network is shared, and the same in cleanup? It\u0027s just an attribute of network.","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"49978d953b83fa108f4f6367a196f8c1b42b4f55","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return network"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @classmethod"},{"line_number":161,"context_line":"    def create_shared_network(cls):"},{"line_number":162,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027sharednetwork-\u0027),"},{"line_number":163,"context_line":"                     \u0027shared\u0027: True}"},{"line_number":164,"context_line":"        _, body \u003d cls.admin_client.create_network(**post_body)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a890539_a65593c7","line":161,"in_reply_to":"5a890539_164370af","updated":"2014-11-21 04:36:32.000000000","message":"YES, we are creating shared network by admin, and it is deleted by admin .\nSo  thought to make a different function.","commit_id":"74c5ac32c488b10616472efdf0c89ba8c334ac09"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"b7235c59e0042cbbc3706a38ad7e7c8c886882a9","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            for network in cls.networks:"},{"line_number":159,"context_line":"                cls._try_delete_resource(cls.client.delete_network,"},{"line_number":160,"context_line":"                                         network[\u0027id\u0027])"},{"line_number":161,"context_line":"            #clean up shared networks"},{"line_number":162,"context_line":"            for network in cls.shared_networks:"},{"line_number":163,"context_line":"                cls._try_delete_resource(cls.admin_client.delete_network,"},{"line_number":164,"context_line":"                                         network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_151f1c6d","line":161,"updated":"2015-02-05 11:18:15.000000000","message":"# Clean up shared networks","commit_id":"3f8b4b5bb5432c8e949d4ccf3229d9b5019fdb1c"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"1b50b2d4ee36598f4d0fe28fde9c6080c1df831e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            for network in cls.networks:"},{"line_number":159,"context_line":"                cls._try_delete_resource(cls.client.delete_network,"},{"line_number":160,"context_line":"                                         network[\u0027id\u0027])"},{"line_number":161,"context_line":"            #clean up shared networks"},{"line_number":162,"context_line":"            for network in cls.shared_networks:"},{"line_number":163,"context_line":"                cls._try_delete_resource(cls.admin_client.delete_network,"},{"line_number":164,"context_line":"                                         network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_2f0cc0ec","line":161,"in_reply_to":"da86d52c_151f1c6d","updated":"2015-02-05 15:18:23.000000000","message":"yes i made changes","commit_id":"3f8b4b5bb5432c8e949d4ccf3229d9b5019fdb1c"}],"tempest/services/network/network_client_base.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2c099688383d44688af0ecce3436728395d5f290","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.rest_client.expected_success(201, resp.status)"},{"line_number":192,"context_line":"        return resp, body"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def create_bulk_shared_network(self, names, shared):"},{"line_number":195,"context_line":"        sh_att \u003d shared"},{"line_number":196,"context_line":"        network_list \u003d [{\u0027name\u0027: name, \u0027shared\u0027: sh_att} for name in names]"},{"line_number":197,"context_line":"        post_data \u003d {\u0027networks\u0027: network_list}"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_deb2fb04","line":194,"updated":"2014-10-17 10:35:36.000000000","message":"The difference is one line only. Maybe it\u0027s better to add (shared\u003dFalse) to create_bulk_network function?","commit_id":"9c25d8dffc0a3dd1de4e06ef1a65df96a89740b7"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"81257b1f2331f3b06de91021a6c3562e7f239fbb","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.rest_client.expected_success(201, resp.status)"},{"line_number":192,"context_line":"        return resp, body"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def create_bulk_shared_network(self, names, shared):"},{"line_number":195,"context_line":"        sh_att \u003d shared"},{"line_number":196,"context_line":"        network_list \u003d [{\u0027name\u0027: name, \u0027shared\u0027: sh_att} for name in names]"},{"line_number":197,"context_line":"        post_data \u003d {\u0027networks\u0027: network_list}"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_47b2bb94","line":194,"in_reply_to":"baa201ad_deb2fb04","updated":"2014-10-17 14:46:25.000000000","message":"+1","commit_id":"9c25d8dffc0a3dd1de4e06ef1a65df96a89740b7"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"82fad120edb7256d3b3676831cd9c6162d7296d0","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    # Common methods that are hard to automate"},{"line_number":184,"context_line":"    def create_bulk_network(self, names, shared\u003dFalse):"},{"line_number":185,"context_line":"        sh_att \u003d shared"},{"line_number":186,"context_line":"        network_list \u003d [{\u0027name\u0027: name, \u0027shared\u0027: sh_att} for name in names]"},{"line_number":187,"context_line":"        post_data \u003d {\u0027networks\u0027: network_list}"},{"line_number":188,"context_line":"        body \u003d self.serialize_list(post_data, \"networks\", \"network\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_8318d785","line":185,"updated":"2014-10-20 14:00:06.000000000","message":"Does it mean something? I think you can use directly \"shared\" without another variable. { .... \u0027shared\u0027: shared}","commit_id":"85470f7bedd4064a9a416ee28ad43d3c3188e2e9"}]}