)]}'
{"tempest/api/messaging/test_queues.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"93c1572437b6b9dc92b05a280ebab619bef4203f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":57,"context_line":"    def test_delete_queue(self):"},{"line_number":58,"context_line":"        # Delete Queue"},{"line_number":59,"context_line":"        queue_name \u003d self.queues.pop()"},{"line_number":60,"context_line":"        resp, body \u003d self.delete_queue(queue_name)"},{"line_number":61,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":62,"context_line":"        self.assertEqual(\u0027\u0027, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_e7f27d05","side":"PARENT","line":59,"updated":"2014-10-10 18:26:33.000000000","message":"Individual tests should not be side-effecting mutable class variables that are used by other tests. It would be better to put the test for delete in the first class and change test_create_queue to test_create_delete_queue.","commit_id":"2844bf9729a409dc96a14e8a9757117c6251e446"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ceeee259d2c089e0ec76db4c564e3fa460e78354","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":57,"context_line":"    def test_delete_queue(self):"},{"line_number":58,"context_line":"        # Delete Queue"},{"line_number":59,"context_line":"        queue_name \u003d self.queues.pop()"},{"line_number":60,"context_line":"        resp, body \u003d self.delete_queue(queue_name)"},{"line_number":61,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":62,"context_line":"        self.assertEqual(\u0027\u0027, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ea884f24","side":"PARENT","line":59,"in_reply_to":"baa201ad_e7f27d05","updated":"2014-10-14 01:24:44.000000000","message":"Yes, that makes sense. Thanks","commit_id":"2844bf9729a409dc96a14e8a9757117c6251e446"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"fcaf68fc13942d306ecbd9b7cfb34348ec8350b0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.addCleanup(self.client.delete_queue, queue_name)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":40,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class TestManageQueue(base.BaseMessagingTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_6048e25c","side":"PARENT","line":40,"updated":"2014-10-14 19:10:30.000000000","message":"It would be good to check that the queue was actually deleted.","commit_id":"afb3e83f3d29b40524084437c3f3aa7a026272b2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f0a3adbe0667ac12df29c6ae7b920aa645e7c24","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.addCleanup(self.client.delete_queue, queue_name)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":40,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class TestManageQueue(base.BaseMessagingTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_9b7e0cae","side":"PARENT","line":40,"in_reply_to":"baa201ad_6048e25c","updated":"2014-10-15 06:50:29.000000000","message":"Done.","commit_id":"afb3e83f3d29b40524084437c3f3aa7a026272b2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"d4f691294808349f0be22be23a5956c13c9a72a0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        _, body \u003d self.delete_queue(queue_name)"},{"line_number":43,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":44,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":45,"context_line":"                          self.client.get_queue,"},{"line_number":46,"context_line":"                          queue_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_37f46586","line":43,"updated":"2014-10-23 04:05:48.000000000","message":"I guess this is all over the code everywhere else in this file, but it seems weird to check a 204 doesn\u0027t have a body like this. We already check it in the rest client:\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/common/rest_client.py#n371\n\nIt\u0027s probably worth a followup cleanup.","commit_id":"e0befa487d99da7e7b79b0488ffac6a86e055ac0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7f1d4b2825620878185ae07b490aedff6c0bd36c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        _, body \u003d self.delete_queue(queue_name)"},{"line_number":43,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":44,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":45,"context_line":"                          self.client.get_queue,"},{"line_number":46,"context_line":"                          queue_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_d2832702","line":43,"in_reply_to":"9aa7fdbe_37f46586","updated":"2014-10-23 05:37:04.000000000","message":"Agree. Thanks Matthew for catching this, i will do it in next cleanup","commit_id":"e0befa487d99da7e7b79b0488ffac6a86e055ac0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"d4f691294808349f0be22be23a5956c13c9a72a0","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        _, body \u003d self.delete_queue(queue_name)"},{"line_number":43,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":44,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":45,"context_line":"                          self.client.get_queue,"},{"line_number":46,"context_line":"                          queue_name)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_17f92180","line":44,"updated":"2014-10-23 04:05:48.000000000","message":"Not being familiar with the marconi/zaqar api my only concern is whether queue deletion is sync or async. If it\u0027s async there is a bug here.","commit_id":"e0befa487d99da7e7b79b0488ffac6a86e055ac0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7f1d4b2825620878185ae07b490aedff6c0bd36c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        _, body \u003d self.delete_queue(queue_name)"},{"line_number":43,"context_line":"        self.assertEqual(\u0027\u0027, body)"},{"line_number":44,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":45,"context_line":"                          self.client.get_queue,"},{"line_number":46,"context_line":"                          queue_name)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_3278f32a","line":44,"in_reply_to":"9aa7fdbe_17f92180","updated":"2014-10-23 05:37:04.000000000","message":"Confirmed this with jeffrey4l on zaqar IRC today. This is sync operation.","commit_id":"e0befa487d99da7e7b79b0488ffac6a86e055ac0"}]}